Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210982
-------
On Nov. 29, 2018, 1:58 p.m., Brian Towles wrote:
,
Brian Towles
,
Brian Towles
availability for future UI development.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210939
------
line1>
> >
> > Brian,
> >
> > What does this bootstrap java script do?
>
> Brian Towles wrote:
> This is paert of the standard Bootstrap distribution
> (https://getbootstrap.com/docs/3.3/javascript/). It provides support for
> Bootstrap specific UI interfa
/static/materialdesign/fonts/materialdesignicons-webfont.woff2
PRE-CREATION
Diff: https://reviews.apache.org/r/69351/diff/5/
Changes: https://reviews.apache.org/r/69351/diff/4-5/
Testing
---
Running with web and unit tests
Thanks,
Brian Towles
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69351/#review210878
-------
On Nov. 26, 2018, 9:32 p.m., Brian Towles wrote:
>
> --
gt;
> >
> > it returns the same result as /admi/roles. Should we remove this line?
No this is for backwards compatability
- Brian
---
This is an automatically generated e-mail. To reply, visit:
http
do we have 2 different copyrights? Is this file under the MIT
> > license?
>
> Brian Towles wrote:
> This is a direct copy of the file. It how they copyrighted it.
>
> Steve Moist wrote:
> Even the apache 2 license on the top?
Belive that was a different file I
Thanks,
Brian Towles
t;https://reviews.apache.org/r/69351/diff/3/?file=2108356#file2108356line92>
> >
> > Why is there another one here?
This is a direct copy of the file. It how they copyrighted it.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.o
--
On Nov. 19, 2018, 10:32 a.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69285/
>
Thanks,
Brian Towles
sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2
PRE-CREATION
Diff: https://reviews.apache.org/r/69351/diff/3/
Changes: https://reviews.apache.org/r/69351/diff/2-3/
Testing
---
Running with web and unit tests
Thanks,
Brian
,
Brian Towles
/fonts/materialdesignicons-webfont.woff
PRE-CREATION
sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2
PRE-CREATION
Diff: https://reviews.apache.org/r/69351/diff/1/
Testing
---
Running with web and unit tests
Thanks,
Brian
/main/java/org/apache/sentry/core/common/utils/SigUtils.java
d621c74c2cdf44c1eedbec36f5cd8a32cace20ff
Diff: https://reviews.apache.org/r/69285/diff/1/
Testing
---
Build and Unit tests
Thanks,
Brian Towles
, add in the annotation and remove the existing logger. 2)
> > > Create an epic in Jira, create tasks under it for each maven module,
> then
> > > go through all the classes in each module and convert to it.
> > >
> > > I don’t think this is cr
> On Aug. 27, 2018, 3:32 p.m., Steve Moist wrote:
> > pom.xml
> > Lines 410 (patched)
> > <https://reviews.apache.org/r/68488/diff/2/?file=2076863#file2076863line410>
> >
> > Why is this provided?
>
> Brian Towles wrote:
> Lombok only hook
iew208112
---
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> -
PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi
PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/3/
Changes: https://reviews.apache.org/r/68488/diff/2-3/
Testing
---
Unit tests.
Thanks,
Brian Towles
fb9950d0feca18f7f49531c6c38bb7357b565e5b
Diff: https://reviews.apache.org/r/68585/diff/1/
Testing
---
Build and Unit tests.
Thanks,
Brian Towles
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review208112
-------
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
>
----
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68488/
> ---
commands to transfer object ownership.
> >
> > Hive had a shims interface for Hadoop to support Hadoop 1.x and Hadoop
> 2.x
> > in the past. Should we use a similar thing?
> >
> > Any other ideas?
> >
> > - Sergio
> >
>
--
*Brian Towles* | Sof
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207847
---
On Aug. 23, 2018, 8:15 p.m., Brian Towles wrot
/org.apache.sentry.spi.SomeTestProviderFactory
PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi
PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/2/
Testing
---
Unit tests.
Thanks,
Brian Towles
://reviews.apache.org/r/68488/diff/1-2/
Testing
---
Unit tests.
Thanks,
Brian Towles
le?
Nope didnt mean to, will pull from patch
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68488/#review207825
---
On Aug. 2
/resources/META-INF/services/org.apache.sentry.spi.SomeTestProviderFactory
PRE-CREATION
sentry-spi/src/test/resources/META-INF/services/org.apache.sentry.spi.Spi
PRE-CREATION
Diff: https://reviews.apache.org/r/68488/diff/1/
Testing
---
Unit tests.
Thanks,
Brian Towles
/
Testing
---
Tested with unit tests and manual testing
Thanks,
Brian Towles
ly, visit:
https://reviews.apache.org/r/68264/#review206992
-------
On Aug. 7, 2018, 4 p.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail.
/apache/sentry/core/common/utils/SigUtils.java
1f16e1435dde850d651b9b9f5ad8e6253269d106
Diff: https://reviews.apache.org/r/68264/diff/1/
Testing
---
Tested with unit tests and manual testing
Thanks,
Brian Towles
my pleasure to introduce a new Apache Sentry committer who is
> > very
> > > > familiar to people on this list - Arjun Mishra! Welcome Arjun!
> > > >
> > > > - Alex
> > >
> >
>
--
*Brian Towles* | Software Engineer
t. (512) 415- 8105 e. bto
ian,
>
> This seems interesting. How does it interplay with IntelliJ/Eclipse
> ability to find all usages of the method - will we still be able to find
> all references to constructors/getters/setters e.t.c. ?
>
> > On May 24, 2018, at 12:54 PM, Brian Towles wrote:
> >
> >
t; >> [image: Cloudera] <https://www.cloudera.com/>
> >>
> >> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
> >> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image:
> Cloudera
> >> on LinkedIn] <ht
Builders,
and Synchronized.
What do you guys think about using this in Sentry?
-=Brian
--
*Brian Towles* | Software Engineer
t. (512) 415- <00>8105 e. btow...@cloudera.com
cloudera.com <http://www.cloudera.com/>
[image: Cloudera] <http://www.cloudera.com/>
[image: C
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66146/#review199474
---
Ship it!
Ship It!
- Brian Towles
On March 19, 2018, 1:43
: https://reviews.apache.org/r/65192/diff/1/
Testing
---
Full unit test passing and builds
Thanks,
Brian Towles
ts/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/TestUtils.java
>
> sentry-tests/sentry-tests-solr/pom.xml
> 5ef7a2b1de67a2f35510ad41c0150ad1bc957118
> sentry-tests/sentry-tests-sqoop/pom.xml
> eed8269d4e1b67fd622d539741e50d9984ae90c8
> sentry-tools/pom.xml 45cfdb562f8cb9955d14165240ca0f7b33028551
>
>
> Diff: https://reviews.apache.org/r/65192/diff/1/
>
>
> Testing
> ---
>
> Full unit test passing and builds
>
>
> Thanks,
>
> Brian Towles
>
>
s://reviews.apache.org/r/65244/diff/1/
Testing
---
Full unit test passing and builds
Thanks,
Brian Towles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65224/#review195740
---
Ship it!
Ship It!
- Brian Towles
On Jan. 18, 2018, 12:18
passing and builds
Thanks,
Brian Towles
eed8269d4e1b67fd622d539741e50d9984ae90c8
sentry-tools/pom.xml 45cfdb562f8cb9955d14165240ca0f7b33028551
Diff: https://reviews.apache.org/r/65192/diff/1/
Testing
---
Full unit test passing and builds
Thanks,
Brian Towles
@Moist
It can be found here
https://github.com/apache/hbase/blob/master/hbase-shaded/hbase-shaded-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
On Wed, Nov 15, 2017 at 3:38 PM Brian Towles wrote:
> HBase does have a ensure-jars-have-correct-contents.sh check that t
d ones?
>
>
> > On Nov 15, 2017, at 3:02 PM, Brian Towles wrote:
> >
> > I can see that. I can look into that as well. It would make sense for
> the
> > "Sentry as a Library" you talked about as well
> >
> > On Wed, Nov 15, 2017 at 2:56 PM Alexand
which run server, HDFS, Hive all in the same JVM.
>
> On Wed, Nov 15, 2017 at 12:47 PM, Brian Towles
> wrote:
>
> > So there would be two different levels of shading.
> >
> > The first would be the known issues shared repackaged dependencies like
> > Guava. This woul
trying to make Sentry work with DataNucleus 4 - the problem was
> >>> that e2e tests combine Sentry with Hive in the same JVM and this
> created
> >> a
> >>> conflict on the DataNucleus libraries and test failures.
> >>>
> >>> Looking at
potentially be something that is more of an overall Sentry standard
practice and larger scale implementation.
-=Brian
--
*Brian Towles* | Software Engineer
t. (512) 415- <00>8105 e. btow...@cloudera.com
cloudera.com <http://www.cloudera.com/>
[image: Cloudera] <http://w
Congrats Sergio!
On Tue, Oct 17, 2017 at 12:05 AM Alexander Kolbasov
wrote:
> It is my pleasure to announce a new Apache Sentry PMC member Sergio Pena
> who is well known to this mailing list.
>
> Thanks for all your contributions Sergio!
>
> - Alex Kolbasov
--
*Brian
/thrift/TestSentryStateBank.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62107/diff/10/
Changes: https://reviews.apache.org/r/62107/diff/9-10/
Testing
---
Unit Tests
Thanks,
Brian Towles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62192/#review185013
---
Ship it!
Ship It!
- Brian Towles
On Sept. 8, 2017, 2:23 p.m
/TestSentryStateBank.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62107/diff/9/
Changes: https://reviews.apache.org/r/62107/diff/8-9/
Testing
---
Unit Tests
Thanks,
Brian Towles
ps://reviews.apache.org/r/62107/#review185004
-------
On Sept. 8, 2017, 2:58 p.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail.
/TestSentryStateBank.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62107/diff/8/
Changes: https://reviews.apache.org/r/62107/diff/7-8/
Testing
---
Unit Tests
Thanks,
Brian Towles
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62107/#review184945
-------
On Sept. 8, 2017, 11:29 a.m., Brian Towles wrote:
>
> --
gt; Previous log messages have INFO level. I think we should set this as
> > INFO as well so that users know that a snapshot is requested but the client
> > will be delayed.
>
> Brian Towles wrote:
> Becasue this message can occur every .5 seconds if an update is
>
reply, visit:
https://reviews.apache.org/r/62107/#review184996
---
On Sept. 8, 2017, 11:29 a.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail. To re
/service/thrift/TestSentryStateBank.java
PRE-CREATION
Diff: https://reviews.apache.org/r/62107/diff/7/
Changes: https://reviews.apache.org/r/62107/diff/6-7/
Testing
---
Unit Tests
Thanks,
Brian Towles
://reviews.apache.org/r/62107/diff/5-6/
Testing
---
Unit Tests
Thanks,
Brian Towles
>
> >
> > What would prevent the execution from reaching this step and a full
> > snapshot from HMS kicked off at the same time?
> >
> > Do you think we should have the block on both the sides?
>
> Brian Towles wrote:
> Once it hits this p
I was going to leave this for SENTRY-1921 but since we have a lot of questions
about it I have just converted the SentryService itself to be a singleton and
control the config. This will remove the SentryServiceFactory and allow it to
be all compartmentalized in the Se
with the changes
to the SentryService. It is now a singleton and is only configured and has one
thread with one instance running at a time.
- Brian Towles
On Sept. 6, 2017, 6:33 p.m., Brian Towles wrote:
>
> ---
> This is an auto
80f158a1fd626cdddeae9e2ee264f361d78bc2a7
Diff: https://reviews.apache.org/r/62107/diff/5/
Changes: https://reviews.apache.org/r/62107/diff/4-5/
Testing
---
Unit Tests
Thanks,
Brian Towles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62107/#review184691
---
I added an additional unit test for a missed case
- Brian Towles
,
Brian Towles
---
Unit Tests
Thanks,
Brian Towles
Thanks,
Brian Towles
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62107/#review184628
-------
On Sept. 5, 2017, 9:25 p.m., Brian Towles wrote:
>
> ---
&g
-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java
1685702c6dbc9715c8885a29a80bc68509550f0b
Diff: https://reviews.apache.org/r/62107/diff/2/
Testing
---
Unit Tests
Thanks,
Brian Towles
--------
On Sept. 5, 2017, 7:42 p.m., Brian Towles wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62107/
> --
-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java
1685702c6dbc9715c8885a29a80bc68509550f0b
Diff: https://reviews.apache.org/r/62107/diff/2/
Changes: https://reviews.apache.org/r/62107/diff/1-2/
Testing
---
Unit Tests
Thanks,
Brian Towles
ther implementation that evolves to have
what ever implementation it needs, but the check to remain the same.
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/621
/src/main/java/org/apache/sentry/service/thrift/SentryServiceFactory.java
1685702c6dbc9715c8885a29a80bc68509550f0b
Diff: https://reviews.apache.org/r/62107/diff/1/
Testing
---
Unit Tests
Thanks,
Brian Towles
1685702c6dbc9715c8885a29a80bc68509550f0b
Diff: https://reviews.apache.org/r/62107/diff/1/
Testing
---
Unit Tests
Thanks,
Brian Towles
1685702c6dbc9715c8885a29a80bc68509550f0b
Diff: https://reviews.apache.org/r/62107/diff/1/
Testing
---
Unit Tests
Thanks,
Brian Towles
/62006/diff/1/
Testing
---
Unit tests run.
Thanks,
Brian Towles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/#review182908
---
Ship it!
Ship It!
- Brian Towles
On Aug. 14, 2017, 1:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61537/#review182701
---
Ship it!
Ship It!
- Brian Towles
On Aug. 10, 2017, 7:28 p.m
> On Aug. 10, 2017, 10:32 a.m., Brian Towles wrote:
> >
Other then this LGTM... ship it!
- Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61537/#rev
/sentry/service/thrift/SentryHMSClient.java
Lines 204-205 (patched)
<https://reviews.apache.org/r/61537/#comment258563>
Empty catch... do we want to log or something?
- Brian Towles
On Aug. 10, 2017, 1:43 a.m., Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61113/#review181382
---
Ship it!
Ship It!
- Brian Towles
On July 25, 2017, 11:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60865/#review180860
---
Ship it!
Ship It!
- Brian Towles
On July 17, 2017, 7:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60860/#review180858
---
Ship it!
Ship It!
- Brian Towles
On July 14, 2017, 6:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60869/#review180857
---
Ship it!
with Na Li's change ship it
- Brian Towles
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60926/#review180850
---
Ship it!
Other then LiNas stuff ship it
- Brian Towles
On
> On July 17, 2017, 11:51 a.m., Brian Towles wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HmsFollower.java
> > Line 214 (original), 225 (patched)
> > <https://reviews.apache.org/r/60883/diff/1/?file=1777189#file1777189lin
rc/main/java/org/apache/sentry/service/thrift/HmsFollower.java
Line 214 (original), 225 (patched)
<https://reviews.apache.org/r/60883/#comment255918>
Needed for public function? or should this be a public function?
- Brian Towle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60843/#review180537
---
Ship it!
Looks good to me.
- Brian Towles
On July 13, 2017
d just use Thrift as a transport mechanism.
>
> Im not sure why we would break protocol compatibility with something
custom. I feel we can work around this. Im not convinced we can, but i
think this should be a last resort.
> - Sasha
>
--
*Brian Towles* | Software Engineer
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60273/#review178502
---
On June 21, 2017, 10:28 a.m., Brian Towles wrote:
>
> ---
/pom.xml
14ad6a29f7f814ccc13482d78ccafd171568acc6
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ConfServlet.java
9e7fca83e79e23c71559221ba9e5a97f79ec75eb
Diff: https://reviews.apache.org/r/60273/diff/1/
Testing
---
Thanks,
Brian Towles
ec938da1fb02bd0e58554336b671d14e7c6fc621
Diff: https://reviews.apache.org/r/60091/diff/1/
Testing
---
Unit test runs and visual insepction of thread names when sentry is running.
Thanks,
Brian Towles
93 matches
Mail list logo
