---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62261/#review185349
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 13, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62221/#review185342
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 13, 2017, 8
> On Sept. 13, 2017, 6:50 p.m., Vamsee Yarlagadda wrote:
> > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
> > Line 74 (original), 78 (patched)
> > <https://reviews.apache.org/r/62221/diff/8/?file=1821068#file1821068line78
t result = new HashSet<>();
for (MSentryGroup sentryGroup : sentryGroups) {
for (MSentryRole role : sentryGroup.getRoles()) {
result.add(role.getRoleName());
}
}
return result;
}
```
- Vamsee Yarlagadda
On Sept. 13, 2017, 3:49 a.
/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
Line 74 (original), 78 (patched)
<https://reviews.apache.org/r/62221/#comment261632>
Can remove String.format and make it via simple {}?
- Vamsee Yarlagadda
On Sept. 13, 2017, 6:42 p.m., Arjun Mishra
I would expect a log message to tell me everything went well so far
without any issues.
Makes sense?
- Vamsee Yarlagadda
On Sept. 12, 2017, 2:36 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail.
e number: 0
```
We should ideally print this log message just before we get the snapshot
but not before we do the SentryStateStore check. It is giving wrong notion that
we are getting too many full snapshots which is not the case really.
- Vamsee Yarlagadda
On Sept. 11, 2017, 8:54 p.m., A
snapshots
at the same time
Diffs
-
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
2866ab348390e092d0c1732c6ab8a8bea0529a4b
Diff: https://reviews.apache.org/r/62231/diff/1/
Testing
---
In progress
Thanks,
Vamsee Yarlagadda
://reviews.apache.org/r/62231/diff/1/
Testing
---
In progress
Thanks,
Vamsee Yarlagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62229/#review185120
---
Ship it!
LGTM.
- Vamsee Yarlagadda
On Sept. 11, 2017, 9:35
> On Sept. 11, 2017, 7:03 p.m., Vamsee Yarlagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
> > Line 326 (original), 328 (patched)
> > <https://reviews.apache.org/r/62221/diff/2/?file=1819594#file181959
like this printed when it is the first time HMSFollower
ran through the entire operation after the clean restart of server.
- Vamsee Yarlagadda
On Sept. 11, 2017, 6:56 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically
-09-08 21:05:29,480 INFO org.apache.sentry.hdfs.DBUpdateForwarder: Newer
delta updates are found up to sequence number: 2717
```
Thanks,
Vamsee Yarlagadda
/apache/sentry/service/thrift/HMSFollower.java
b600487dcf60b34f95d3eec7bf834b9a884db834
Diff: https://reviews.apache.org/r/62202/diff/1/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62177/#review184914
---
Ship it!
Verified this on actual cluster.
- Vamsee Yarlagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184885
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 7, 2017, 8
/main/java/org/apache/sentry/service/thrift/CounterWait.java
Lines 138 (patched)
<https://reviews.apache.org/r/62146/#comment260994>
What about pending waiters on the higher notification ID's?
- Vamsee Yarlagadda
On Sept. 7, 2017, 7:06 a.m., Alexander Kol
> On Sept. 7, 2017, 2:20 a.m., Vamsee Yarlagadda wrote:
> > IMPORTANT:
> > http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312
> > We should handle the case
-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312
We should handle the case when the HDFSSync is also not enabled. Currently we
only purge when the sync is present but ideally this should be done in both the
cases.
- Vamsee Yarlagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62136/#review184770
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 7, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62146/#review184769
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 7, 2017, 1
/sentry/service/thrift/HMSFollower.java
Lines 188-202 (original), 188-196 (patched)
<https://reviews.apache.org/r/62136/#comment260971>
Just collapse to a single catch?
- Vamsee Yarlagadda
On Sept. 7, 2017, 1:24 a.m., Sergio Pena
.java
Lines 186 (patched)
<https://reviews.apache.org/r/62136/#comment260965>
Same here.
- Vamsee Yarlagadda
On Sept. 6, 2017, 10:50 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62131/#review184718
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 6, 2017, 7
> On Sept. 6, 2017, 2:02 a.m., Vamsee Yarlagadda wrote:
> > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java
> > Line 115 (original), 122 (patched)
> > <https://reviews.apache.org/r/62107/diff/1/?file=1816055#file1816055line127
th the sides?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
Lines 321-323 (patched)
<https://reviews.apache.org/r/62107/#comment260796>
Should this be in finally block otherwise it will leave the state in true
if there was any error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62101/#review184614
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Sept. 6, 2017, 12
> On Sept. 5, 2017, 9:44 p.m., Vamsee Yarlagadda wrote:
> > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java
> > Lines 103 (patched)
> > <https://reviews.apache.org/r/62096/diff/1/?file=1815913#file1815913line103>
&g
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62096/
> ---
>
> (Updated Sept. 5, 2017, 10:41 p.m.)
>
>
> Review request for sentry, Alexa
<https://reviews.apache.org/r/62096/#comment260754>
Same comment as above.
- Vamsee Yarlagadda
On Sept. 5, 2017, 9:11 p.m., Sergio Pena wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
05eb7513375a110852a5038c2244fd75a8521f5f
Diff: https://reviews.apache.org/r/62044/diff/1/
Testing
---
Pre-commit tests in progress.
Thanks,
Vamsee Yarlagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62007/#review184369
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Aug. 31, 2017, 4
e5939
Diff: https://reviews.apache.org/r/61983/diff/2/
Changes: https://reviews.apache.org/r/61983/diff/1-2/
Testing
---
Sentry unit test run in progress.
Thanks,
Vamsee Yarlagadda
ruptedException here?
Good point. I will set the interrupt again.
- Vamsee
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61983/#review184173
-------
progress.
Thanks,
Vamsee Yarlagadda
/sentry/provider/db/service/model/package.jdo
Line 135 (original), 126 (patched)
<https://reviews.apache.org/r/61793/#comment259998>
Is this something that we are matching with the size on Hive side?
Otherwise this could lead into lot of problems.
- Vamsee Yarlagadda
On Aug. 25, 2017, 7:
/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 1821 (patched)
<https://reviews.apache.org/r/61863/#comment259818>
typo -> sentryGroup?
- Vamsee Yarlagadda
On Aug. 23, 2017, 9:24 p.m., Arjun Mis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61858/#review183702
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Aug. 23, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61862/#review183698
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Aug. 23, 2017, 9
very
DB or should we explore some datanuclues specific syntax for handlings joins?
- Vamsee Yarlagadda
On Aug. 22, 2017, 9:58 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
P_NAME IN ('A, 'B'...)
That way we save on computing the same joins over and over?
- Vamsee Yarlagadda
On Aug. 22, 2017, 9:58 p.m., Arjun Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To r
> On Aug. 22, 2017, 8:31 p.m., Alexander Kolbasov wrote:
> > Would it make sense to still handle the old config if it is present and the
> > new one isn't?
>
> Vamsee Yarlagadda wrote:
> For the fact that we are releasing a new major version of Sentry, I think
/61821/#review183518
---
On Aug. 22, 2017, 6:57 p.m., Vamsee Yarlagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
c19ccbd12fde3567496b6847cf2b67b3c49cd655
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
e62c54a5c0a932617a88492944a6d9fb76571903
Diff: https://reviews.apache.org/r/61821/diff/1/
Testing
---
Will make sure all the unit tests work.
Thanks,
Vamsee
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61724/#review183216
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Aug. 18, 2017, 12
Sentry accepting the duplicate
elements from Hive. There is a followup effort that handles the consistency
that we are not skipping any hive events on sentry side. That being said, I am
good with the current implementation.
- Vamsee Yarlagadda
On Aug. 16, 2017, 7:41 p.m., Sergio Pena wrote
ine 23 (original)
<https://reviews.apache.org/r/61696/#comment259049>
To make these changes show up cleanly, should we create SENTRY-1803
specific sql files?
- Vamsee Yarlagadda
On Aug. 16, 2017, 7:41 p.m., Sergio Pena wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61626/#review182917
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Aug. 14, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/#review182903
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On Aug. 14, 2017, 6
/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java
Lines 174 (patched)
<https://reviews.apache.org/r/61537/#comment258433>
nit. typo - Reconciling
- Vamsee Yarlagadda
On Aug. 9, 2017, 7:37 p.m., Alexander Kolbasov
Great work! Thanks Sergio for leading the effort.
- Vamsee
On Mon, Aug 7, 2017 at 2:35 PM, Rams Venkatesh wrote:
> Great effort.
>
> -Rams
>
> > On 7 Aug 2017, at 22:26, Sergio Pena wrote:
> >
> > The Apache Sentry team is happy to announce the release of version 1.8.0.
> > Apache Sentry is a
+1 looks good. Thanks Sergio.
On Thu, Aug 3, 2017 at 10:10 AM, Na Li wrote:
> +1
>
> Lina
>
> On Thu, Aug 3, 2017 at 11:12 AM, Alexander Kolbasov
> wrote:
>
> > +1
> >
> > Alex
> >
> > > On Aug 3, 2017, at 12:16, Colm O hEigeartaigh
> > wrote:
> > >
> > > +1.
> > >
> > > Colm.
> > >
> > > On W
-mail. To reply, visit:
> https://reviews.apache.org/r/61192/
> ---
>
> (Updated July 28, 2017, 7:26 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar
> kalvagadda, Sergio Pena, and Vamsee Yarlagadda.
>
>
ervice/persistent/SentryStore.java
Lines 4028-4038 (original), 4093-4106 (patched)
<https://reviews.apache.org/r/61192/#comment257372>
I know you were trying to a simple revert but we added some helpful
comments. Let's preserve them.
- Vamsee Yarlagadda
On July 28, 2017, 7:26
Thanks Sasha.
On Fri, Jul 28, 2017 at 10:09 AM, Alexander Kolbasov
wrote:
> Hello everyone.
>
> The sentry master is now merged with sentry-ha-redesign branch. The merge
> replaced all the conflicts with the version of sentry-ha-redesign.
>
> Please stop using sentry-ha-redesign branch and conti
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61144/#review181592
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 26, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61187/#review181591
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 27, 2017, 5
-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Line 4097 (original), 4098 (patched)
<https://reviews.apache.org/r/61047/#comment257131>
We removed the null check. This will only be null during "No HDFS sync"
cases only?
- Vamsee
+1
Thanks,
Vamsee
On Wed, Jul 26, 2017 at 2:11 PM, Na Li wrote:
> Sergio,
>
> I agree we should do it soon. Can you send out a notice right before it? So
> we will submit the changes to master instead of sentry-ha-redesign for 2.0
>
> Thanks,
>
> Lina
>
> On Wed, Jul 26, 2017 at 3:57 PM, Sergio
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61141/#review181471
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 26, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61138/#review181470
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 26, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60812/#review180345
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 12, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60806/#review180313
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 12, 2017, 3
method.
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
Lines 83 (patched)
<https://reviews.apache.org/r/60779/#comment255405>
I see there is only one thread being started for this. What is the need to
use %d then?
- Vamsee Yarlagad
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60777/#review180232
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 11, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60775/#review180211
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On July 11, 2017, 3
omatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60273/
> ---
>
> (Updated June 21, 2017, 3:28 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, kalyan kumar
> kalvagadda, Na Li,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60273/#review179816
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 21, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60490/#review179226
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 29, 2017, 12
> On June 29, 2017, 12:56 a.m., Vamsee Yarlagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java
> > Lines 295 (patched)
> > <https://reviews.apache.org/r/60490/diff/2/?file=1766739#file1766739l
> On June 29, 2017, 12:56 a.m., Vamsee Yarlagadda wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java
> > Lines 295 (patched)
> > <https://reviews.apache.org/r/60490/diff/2/?file=1766739#file1766739l
/sentry/provider/db/service/thrift/SentryMetrics.java
Lines 295 (patched)
<https://reviews.apache.org/r/60490/#comment253830>
Does it keep overwriting the existing /tmp/sentry-metrics.json file or keep
appending data to this single file?
- Vamsee Yarlagadda
On June 29, 2017, 12:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60505/#review179143
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 28, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60469/#review179047
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 27, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60168/#review178438
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 20, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60096/#review177950
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 14, 2017, 6
>
> > Would it make sense to take care of the empty input array inline?
>
> Vamsee Yarlagadda wrote:
> Shouldn't make a big difference between passing an array vs list right?
> Just that having array will just make the function more generic. But as long
ges: https://reviews.apache.org/r/59869/diff/9-10/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
tion definition, it should be ok.
- Vamsee
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177680
-------
On June
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59963/#review177536
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 10, 2017, 1
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177446
-------
On June 9, 2017, 11:22 p.m., Vamsee Yarlagadda wrote:
>
> ---
> This is an automatically gen
er-db/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java
PRE-CREATION
Diff: https://reviews.apache.org/r/59869/diff/9/
Changes: https://reviews.apache.org/r/59869/diff/8-9/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
Long values and just call it here.
Moved it to a new class SentryUtils under core-common
- Vamsee
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177446
-------
iff: https://reviews.apache.org/r/59869/diff/8/
Changes: https://reviews.apache.org/r/59869/diff/7-8/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
t makes things less readable.
> >
> > Is this == or != ? Seems like you inverted the condition.
The review already has been updated with !=
- Vamsee
---
This is an automatically generated e-mail. To reply, visit:
http
org/r/59869/diff/7/
Changes: https://reviews.apache.org/r/59869/diff/6-7/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
generated e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177277
-----------
On June 9, 2017, 1:01 a.m., Vamsee Yarlagadda wrote:
>
> ---
> This is an automatically
iff: https://reviews.apache.org/r/59869/diff/6/
Changes: https://reviews.apache.org/r/59869/diff/5-6/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177277
---
On June 8, 2017, 1:05 a.m., Vamsee Yarlagadda wrote:
>
> ---
> This is an automatically gener
;
> (Updated June 8, 2017, 5:42 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, kalyan kumar kalvagadda, and
> Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1782
> https://issues.apache.org/jira/browse/SENTRY-1782
>
>
> Repository: sentry
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59720/#review177386
---
LGTM. I will let Sasha give final sign off.
- Vamsee Yarlagadda
gress.
Thanks,
Vamsee Yarlagadda
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
37eb0b25e10ef69057599277aa5941ca05d52290
Diff: https://reviews.apache.org/r/59869/diff/4/
Changes: https://reviews.apache.org/r/59869/diff/3-4/
Testing
---
In progress.
Thank
- Vamsee
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177229
---
On June 7, 2017, 10:21 p.m., Vamsee Yarlagadda wrote
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59869/#review177229
-------
On June 7, 2017, 10:21 p.m., Vamsee Yarlagadda wrote:
>
> ---
> This is
ache.org/r/59897/diff/1/
Testing
---
Trivial fix
Thanks,
Vamsee Yarlagadda
ca05d52290
Diff: https://reviews.apache.org/r/59869/diff/3/
Testing
---
In progress.
Thanks,
Vamsee Yarlagadda
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59887/#review177232
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 7, 2017, 5:17
/sentry/provider/db/service/persistent/SentryStore.java
Line 56 (original), 57 (patched)
<https://reviews.apache.org/r/59720/#comment250737>
Better to avoid wild card imports.
- Vamsee Yarlagadda
On June 7, 2017, 9:24 p.m., Sergio Pena
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59810/#review177153
---
Ship it!
Ship It!
- Vamsee Yarlagadda
On June 7, 2017, 12
1 - 100 of 245 matches
Mail list logo
