/r/56481/diff/
Testing
---
Thanks,
Alexander Kolbasov
---
I re-generated all Thrift files to verify that there are no actual changes in
the generated code.
Thanks,
Alexander Kolbasov
/sentry/provider/db/service/persistent/SentryStore.java
(line 428)
<https://reviews.apache.org/r/56720/#comment238138>
I mean the two statements doing the purge should stay unless you thing
there is a reason not to.
- Alexander Kolbasov
On Feb. 21, 2017, 9:47 p.m., Lei Xu
l but
if you make another round of changes may be you can put a comment about it here.
- Alexander Kolbasov
On Feb. 21, 2017, 11:30 p.m., Lei Xu wrote:
>
> ---
> This is an automatically generated e-mail. To rep
close() generates exception, we don't sent client to null and don't
clean kerberos context.
Can this be refactored so that we always set client to null and kerberos
context to null even if we get exception? We may I don't want to have closed
client or kereros context lying around
ill make testing trickier since I
test for keys and values and it is difficult to guarantee specific generated
names.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56481/#review166
someone need
it?
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56481/#review166218
---
On Feb. 20, 2017, 5:46 a.m., Alexander Kol
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56481/#review166270
-------
On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote:
>
> ---
ps://reviews.apache.org/r/56481/#review166228
-------
On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail.
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56481/#review166225
---
On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote:
>
> -
ache.org/r/56481/#review166208
---
On Feb. 20, 2017, 5:46 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
(valueToken, fieldValue);
> >
> > Or am I missing something? If there is a reason not to support the same
> > field appearing in the query more than once, it needs to be documented and
> > an exception should be thrown when someone tries to override an existing
> &g
mmend QueryParamBuilder to subclass QueryPart and be a
> > container for a single List to include both simple query parts
> > and nested queries, so they're kept in the order of their addition.
>
> Alexander Kolbasov wrote:
> Why would you think that the original
(valueToken, fieldValue);
> >
> > Or am I missing something? If there is a reason not to support the same
> > field appearing in the query more than once, it needs to be documented and
> > an exception should be thrown when someone tries to override an existing
> &g
(valueToken, fieldValue);
> >
> > Or am I missing something? If there is a reason not to support the same
> > field appearing in the query more than once, it needs to be documented and
> > an exception should be thrown when someone tries to override an existing
> &g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56931/#review166369
---
Ship it!
Ship It!
- Alexander Kolbasov
On Feb. 22, 2017, 4
-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
17a4a937221891a72ee44db92976cfa5cab40bc4
Diff: https://reviews.apache.org/r/56481/diff/
Testing
---
Thanks,
Alexander Kolbasov
-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
17a4a937221891a72ee44db92976cfa5cab40bc4
Diff: https://reviews.apache.org/r/56481/diff/
Testing
---
Thanks,
Alexander Kolbasov
SentryService itself. That's where we start
other things like HMSFollower.
I think this will make things quite simple and minimize the number of files
that are touched by this change.
- Alexander Kolbasov
On Feb. 22, 2017, 9:20 p.m., Lei Xu
/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
4075e3a049773795ecbd40a0293505bb4cc3b317
Diff: https://reviews.apache.org/r/57065/diff/
Testing
---
Thanks,
Alexander Kolbasov
/common/transport/SentryPolicyClientTransportConfig.java
(line 30)
<https://reviews.apache.org/r/56954/#comment238923>
See comments from the similar HDFS class.
- Alexander Kolbasov
On Feb. 22, 2017, 9:53 p.m., kalyan kumar kalvagadda wrote:
>
>
As we are making good progress with Sentry HA we need to start thinking about
merging the Sentry HA into Sentry 1.8 code base. It seems that there are not
that many commits (about a dozen) that never made it to Sentry HA branch, but
some of these were refactoring changes which will complicate th
> On Feb. 27, 2017, 12:52 a.m., Alexander Kolbasov wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/transport/SentryClientTransportConfigInterface.java,
> > line 26
> > <https://reviews.apache.org/r/56954/diff/1/?file=1
ne 190)
<https://reviews.apache.org/r/56952/#comment239119>
Please add comment explaining what's going on here.
- Alexander Kolbasov
On Feb. 24, 2017, 10:47 p.m., Lei Xu wrote:
>
> ---
> This is an automatically generat
e 2567)
<https://reviews.apache.org/r/54798/#comment239122>
Extra "+" - it was in the original for no reason
- Alexander Kolbasov
On Feb. 27, 2017, 11:59 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an aut
e/sentry/provider/db/generic/service/persistent/TestSentryRole.java
(line 348)
<https://reviews.apache.org/r/54947/#comment239161>
Comment formatting
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
(line 517
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56952/#review167177
---
Ship it!
Ship It!
- Alexander Kolbasov
On Feb. 28, 2017, 7
CounterWait class has a unit test. End to end functionality will be
tested once HMS part is implemented.
Thanks,
Alexander Kolbasov
-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo
Lines 269 (patched)
<https://reviews.apache.org/r/57220/#comment239488>
Do we need to index by this column or enforce uniqueness?
- Alexander Kolbasov
On March 1, 2017, 9:49 p.m., Lei Xu
va
Line 295 (original), 302 (patched)
<https://reviews.apache.org/r/55904/#comment239497>
Incomplete fraze?
retrieve full HMS snapshot from ... ?
- Alexander Kolbasov
On March 1, 2017, 8:20 p.m., Hao Hao wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57220/#review167595
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 1, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55904/#review167619
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 2, 2017, 12
sit:
> https://reviews.apache.org/r/54454/
> ---
>
> (Updated Feb. 28, 2017, 2:21 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda,
> and Vadim Spector.
>
>
> Bugs: SENTRY-1548
> https://issues.apache.org/jira/browse/SENTRY-1
are
unique.
So you get something along the lines of:
roles = getAllRoles
for(role: roles) {
retval.put(role.getRoleName()) = roleGroups(role)
}
where roleFroups returns names of groups belonging to a role.
- Alexander Kolbasov
On Feb. 3, 2017, 7:53 a.m., H
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/#review167624
---
Ship it!
Ship It!
- Alexander Kolbasov
On Feb. 28, 2017, 5
will move if this makes
things easier.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57219/#review167618
---
On March 1, 201
functionality will be
tested once HMS part is implemented.
Thanks,
Alexander Kolbasov
/TestCounterWait.java
PRE-CREATION
Diff: https://reviews.apache.org/r/57219/diff/3/
Changes: https://reviews.apache.org/r/57219/diff/2-3/
Testing
---
The new CounterWait class has a unit test. End to end functionality will be
tested once HMS part is implemented.
Thanks,
Alexander Kolbasov
/thrift/TestCounterWait.java
PRE-CREATION
Diff: https://reviews.apache.org/r/57219/diff/4/
Changes: https://reviews.apache.org/r/57219/diff/3-4/
Testing
---
The new CounterWait class has a unit test. End to end functionality will be
tested once HMS part is implemented.
Thanks,
Alexander
validator here - the abstraction doesn't buy you anything here.
- Alexander Kolbasov
On Feb. 28, 2017, 2:21 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
ution.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57219/#review167766
---
On March 2, 2017, 5:26 a.m., Alex
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/57219/#review167778
---
On March 2, 2017, 5:26 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automat
iters.remove(eid). Since ValueEvent.equals() is based on
> > the value, not object identity, it may remove the wrong ValueEvent object
> > added by thread 1.
> >
> > 5. Update thread calls wakeup() but the ValueEvent object of thread 1
> > is not in the queue.
/4-5/
Testing
---
The new CounterWait class has a unit test. End to end functionality will be
tested once HMS part is implemented.
Thanks,
Alexander Kolbasov
r/RevokePrivilegeRequestValidator.java
Lines 35 (patched)
<https://reviews.apache.org/r/54454/#comment239786>
See comments for the GrantPrivilegeRequestValidator - most of them apply
here.
- Alexander Kolbasov
On March 2, 2017, 2:44 p.m., kalyan kumar
6181d8b9aeca3397b6d1c35006deb2d7a7371c35
Diff: https://reviews.apache.org/r/57266/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
in/java/org/apache/sentry/provider/db/service/thrift/validator/GrantPrivilegeRequestValidator.java
Lines 70 (patched)
<https://reviews.apache.org/r/54454/#comment239818>
replace ',' with ':'
- Alexander Kolbasov
On March 3, 2017, 4:41 p.m., kalyan kumar kalvagadda
thrift/TestCounterWait.java
Lines 49 (patched)
<https://reviews.apache.org/r/57219/#comment239836>
right, will update the comment
- Alexander Kolbasov
On March 3, 2017, 3:08 a.m., Alexander Kolbasov wrote:
>
> ---
> Thi
)
<https://reviews.apache.org/r/57308/#comment239881>
Do you need to check that HIVE_CONF_DIR is set?
Something like
[[ -n $HIVE_CONF_DIR ]] && HADOOP_CLASSPATH+=":${HIVE_CONF_DIR}"
- Alexander Kolbasov
On March 3, 2017, 10:41 p.m.,
But we can, in fact, wait untill we have enough waiters.
I'll change the test to do that.
- Alexander Kolbasov
On March 3, 2017, 3:08 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automatically gener
,
Alexander Kolbasov
ould allow it, but I don't see a use case for it.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57219/#review167867
-------
So we have this interactive Sentry shell that is lying around in a branch
(akolb-ha-cli). I think that it would be useful to make it generally
available in master - are there any opinions about that?
On Wed, Dec 14, 2016 at 9:42 PM Alexander Kolbasov
wrote:
> On Dec 14, 2016, at 8:46 PM, Le
t/SentryPolicyClientTransportConfig.java
Lines 39 (patched)
<https://reviews.apache.org/r/56954/#comment240195>
You don't need this to be a singleton
- Alexander Kolbasov
On Feb. 28, 2017, 1:24 a.m., kalyan kumar kalvagadda wrote
/sentry/provider/db/service/persistent/SentryStore.java
Lines 2369 (patched)
<https://reviews.apache.org/r/55706/#comment240201>
query.execute() will not return in this context. It only returns null when
a single object is returned. Otherwise it returns an empty collection.
- Alexander Ko
vider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Line 2319 (original), 2367 (patched)
<https://reviews.apache.org/r/55706/#comment240462>
Here Iterable can be used instead of List
- Alexander Kolbasov
On March 2, 2017, 9:43 p
/hdfs/ImageRetriever.java
Lines 36 (patched)
<https://reviews.apache.org/r/55706/#comment240463>
What is seqNum?
- Alexander Kolbasov
On March 2, 2017, 9:43 p.m., Hao Hao wrote:
>
> ---
> This is an automatically gener
then concrete
types are a recommendation - it is Ok to leave as is. I actually tried
converting to interfaces and it turned out to be pretty small change.
- Alexander Kolbasov
On March 2, 2017, 9:43 p.m., Hao Hao wrote:
>
> ---
> T
e/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
Lines 89 (patched)
<https://reviews.apache.org/r/56954/#comment240619>
This can be a local variable in constructors, but you may need wrapUgi as a
class-level var
sentry-provider/sentry-provider-db/src/main/j
ther before {
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Line 619 (original), 607 (patched)
<https://reviews.apache.org/r/54947/#comment240794>
space after if and before {
- Alexander Kolbasov
On March 4, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55706/#review168556
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 9, 2017, 11
block
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java
Lines 189 (patched)
<https://reviews.apache.org/r/56954/#comment240967>
Same comment about IOE
tions.emptyList()
Can we recover from this condition?
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 3424 (patched)
<https://reviews.apache.org/r/57232/#comment241135>
Same comments as in getMSentryPathChanges(
--
On March 13, 2017, 11:47 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56954/
> ---
>
> (Updated March 13, 2017, 11:47 p.m
e comment regarding Exception
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/RetryClientInvocationHandler.java
Lines 97 (patched)
<https://reviews.apache.org/r/56954/#comment241147>
What is the point of catching exception and immediately re-throwing
he persistent storage."
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 982 (patched)
<https://reviews.apache.org/r/54947/#comment241152>
null
- Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169046
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 15, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57657/#review169047
---
Ship it!
Please fix the commit message
- Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57654/#review169048
---
Ship it!
Please fix the commit message
- Alexander Kolbasov
> On March 15, 2017, 7:07 p.m., Alexander Kolbasov wrote:
> > Please fix the commit message
>
> Jan Hentschel wrote:
> What is wrong with the commit message?
The commit message should be
SENTRY-1658: Null pointer derefeence in SentryShell
/sentry/binding/hive/HiveAuthzBindingHook.java
Lines 253 (patched)
<https://reviews.apache.org/r/57375/#comment241401>
You use ast.getChild(0)getCHild(0) several times - would it make sense to
assign it to a variable with a meaningful name?
- Alexander Kolbasov
On March 7, 2017, 1:
Hello,
I would like to start the discussion on merging sentry-ha-redesign branch
with master.
As of now most of the changes from master are merged into
sentry-ha-redesign. The major missing part is SENTRY-1205 (Refactor the
code for sentry-provider-db and create sentry-service module) and
associa
che/sentry/provider/db/service/persistent/SentryStore.java
Lines 3435 (patched)
<https://reviews.apache.org/r/57232/#comment242489>
return Collections.emptyList()
- Alexander Kolbasov
On March 22, 2017, 11:08 p.m., Hao Hao wrote:
>
> ---
SENTRY-1675?
- Alexander Kolbasov
On March 22, 2017, 11:05 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56954/#review169909
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 23, 2017, 1
am bringing this up,
otherwise it would be a clear deal.
- Sasha
>
> On Wed, Mar 22, 2017 at 3:43 PM, Alexander Kolbasov <mailto:ak...@cloudera.com>> wrote:
> Hello,
>
> I would like to start the discussion on merging sentry-ha-redesign branch
> with master.
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57232/#review169982
---
Ship it!
Ship It!
- Alexander Kolbasov
On March 24, 2017, 1
)
<https://reviews.apache.org/r/57570/#comment242853>
Why do you need subList() here?
- Alexander Kolbasov
On March 22, 2017, 9:27 p.m., Lei Xu wrote:
>
> ---
> This is an automatically gene
bbfa713262c5b4d5cecccd95c823a78c9149752c
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java
6ed2c781b4ac8819f6d17a249c33e32f0116e15a
Diff: https://reviews.apache.org/r/58069/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/FullUpdateInitializer.java
146cea2b9467ce82b69bbf402933b1aa350bcd46
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
6c14f5e46aad4223347d8d057188d31efbb68ed8
Diff: https://reviews.apache.org/r/58087/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
: https://reviews.apache.org/r/58087/diff/2/
Changes: https://reviews.apache.org/r/58087/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
ather then client_object
- Alexander Kolbasov
On March 29, 2017, 11:32 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/FullUpdateInitializer.java
146cea2b9467ce82b69bbf402933b1aa350bcd46
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
6c14f5e46aad4223347d8d057188d31efbb68ed8
Diff: https://reviews.apache.org/r/58093/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/MetastoreCacheInitializer.java
f9664f02d076f03a6481adbac24cefd72e90e152
Diff: https://reviews.apache.org/r/58094/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
able, this shouldn't be here since it changes the
interface (throwing out exception)
- Alexander Kolbasov
On Feb. 10, 2017, 9:44 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generate
3562>
This is wrong - you are redefining close() from the parent while changing
exceptions thrown - you should just remove this line
- Alexander Kolbasov
On March 29, 2017, 11:32 p.m., kalyan kumar kalvagadda wrote:
>
> ---
Added, you should be good to go.
- Sasha
On Fri, Mar 31, 2017 at 9:00 AM Sergio Pena
wrote:
> Hi folks,
>
> I would like to assign some JIRAs to contribute to Sentry.
> Can someone add me as a contributor to Sentry to start assigning them
> myself?
>
> My Apache account is: spena
>
> - Sergio
>
28bf20edb63b08a92b6ec060bc76934dea82f746
Diff: https://reviews.apache.org/r/58121/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
/
Testing
---
Thanks,
Alexander Kolbasov
/FullUpdateInitializer.java
146cea2b9467ce82b69bbf402933b1aa350bcd46
Diff: https://reviews.apache.org/r/58130/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
.java
00eec4eab066829ae1226d0ba3485eab7bd9eeb2
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java
1d79bd1f722505e56941dfd131d782e518515dc4
Diff: https://reviews.apache.org/r/58166/diff/1/
Testing
---
Thanks,
Alexander Kolbasov
dated)
---
I tested this manually by running the server with namespace provided in the
config.
Thanks,
Alexander Kolbasov
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58166/#review170957
-------
On April 4, 2017, 5:03 a.m., Alexander Kolbasov wrote:
>
> -
ail. To reply, visit:
https://reviews.apache.org/r/58069/#review170958
-------
On March 30, 2017, 5:25 a.m., Alexander Kolbasov wrote:
>
> ---
> This is an automa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58131/#review170998
---
Ship it!
Ship It!
- Alexander Kolbasov
On April 4, 2017, 11
x27;t we just update
the initial creation scripts rather then add new scripts to fix the tables?
- Alexander Kolbasov
On April 4, 2017, 5:05 p.m., kalyan kumar kalvagadda wrote:
>
> ---
> This is an automatically generated e-mail. T
before it reaches here?
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
Lines 339 (patched)
<https://reviews.apache.org/r/57570/#comment243851>
should it be private?
The return value is never used - is it intended?
- Alexander Kolbasov
On March 28
/apache/sentry/provider/db/service/thrift/SentryMetrics.java
6ed2c781b4ac8819f6d17a249c33e32f0116e15a
Diff: https://reviews.apache.org/r/58069/diff/2/
Changes: https://reviews.apache.org/r/58069/diff/1-2/
Testing
---
Thanks,
Alexander Kolbasov
6ed2c781b4ac8819f6d17a249c33e32f0116e15a
Diff: https://reviews.apache.org/r/58069/diff/3/
Changes: https://reviews.apache.org/r/58069/diff/2-3/
Testing
---
Thanks,
Alexander Kolbasov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57570/#review171052
---
Ship it!
Ship It!
- Alexander Kolbasov
On April 4, 2017, 8
501 - 600 of 950 matches
Mail list logo
