SHINDIG-1809 and Uri encoding/decoding

2012-06-25 Thread Stanton Sievers
Hi everyone, I was looking at SHINDIG-1809 [1] and why DefaultJsUriManager.processExternJsUri(Uri) is not decoding %3A, i.e. ':', when parsing the libs from the Uri's path. After digging a bit I noticed that neither Uri nor UriBuilder in Shindig seem to do any decoding. In fact,

Re: Review Request: Enhance AuthenticationServletFilter to be more easily overrideable

2012-06-25 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5539/#review8542 --- Ship it! Ship It! - Dan Dumont On June 23, 2012, 8:02 p.m.,

Re: Review Request: Per latest OAuth2 spec, handle 400 from refresh_token response

2012-06-25 Thread Dan Dumont
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5330/#review8543 --- Ship it! Ship It! - Dan Dumont On June 1, 2012, 1:56 p.m., Adam

Horoscope gadget and the common container

2012-06-25 Thread daviesd
I noticed that the horoscope gadget is not working in the common container anymore. I see the following error in the javascript console. NetworkError: 400 Invalid url parameter - http://localhost:8080/gadgets/makeRequest?url=http%3A%2F%2Fapi.tarot.com%2Fa

Re: Horoscope gadget and the common container

2012-06-25 Thread Henry Saputra
Looks like the st= param is not being set when sending the makeRequest request - Henry On Mon, Jun 25, 2012 at 11:35 AM, daviesd davi...@oclc.org wrote: I noticed that the horoscope gadget is not working in the common container anymore.  I see the following error in the javascript console.

Re: Horoscope gadget and the common container

2012-06-25 Thread Dan Dumont
Are you able to set a debug point in the makeRequest servlet to see where the exception is being thrown? Do you get any server stack traces? From: daviesd davi...@oclc.org To: shindig dev@shindig.apache.org, Date: 06/25/2012 02:37 PM Subject:Horoscope gadget and the common

Re: Horoscope gadget and the common container

2012-06-25 Thread daviesd
Ya, it's complaining about the %up_uid% parameter. http://feeds.tarot.com/f/ws/dh/igoogledh/locale/en/timezone/-4/uid/%up_uid%? partner=igooglekey=a9a51c94bbb165f9type=xmltime=1340651940753 Is common container have an implementation of userprefs? Perhaps this never worked. Doug On 6/25/12

Re: Horoscope gadget and the common container

2012-06-25 Thread daviesd
Ya, I went back and tested on beta1 and it doesn't work there either, so perhaps I won't worry about it. On 6/25/12 3:23 PM, daviesd davi...@oclc.org wrote: Ya, it's complaining about the %up_uid% parameter. http://feeds.tarot.com/f/ws/dh/igoogledh/locale/en/timezone/-4/uid/%up_uid%?pa

Re: Horoscope gadget and the common container

2012-06-25 Thread Ryan J Baxter
Doug add shindig.urlgen.use-templates-default=false to your shindig.properties file and try again. -Ryan From: daviesd davi...@oclc.org To: dev@shindig.apache.org, Date: 06/25/2012 03:36 PM Subject:Re: Horoscope gadget and the common container Ya, I went back and tested

Re: Horoscope gadget and the common container

2012-06-25 Thread daviesd
Ok, I will retest with your patch in the morning. Ryan... You're not even gonna like my next question but we are releasing our stuff in 2 weeks and really need to be on a stable beta. If we can't get another beta (or recut beta2) then I'll probably need to figure out how to apply this fix to our

Re: Review Request: X-Shindig-St behaves differently when the security token is null between Firefox and WebKit browsers

2012-06-25 Thread Brian Lillie
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5568/#review8572 --- LGTM - Brian Lillie On June 25, 2012, 10:07 p.m., Stanton Sievers

svn commit: r703 - /release/shindig/2.5.0-beta2/

2012-06-25 Thread rbaxter85
Author: rbaxter85 Date: Tue Jun 26 00:29:45 2012 New Revision: 703 Log: 2.5.0-beta2 release Added: release/shindig/2.5.0-beta2/

svn commit: r704 - /release/shindig/2.5.0-beta2/

2012-06-25 Thread rbaxter85
Author: rbaxter85 Date: Tue Jun 26 01:38:20 2012 New Revision: 704 Log: 2.5.0-beta2 release artifacts Added: release/shindig/2.5.0-beta2/shindig-2.5.0-beta2-java.tar.bz2 (with props) release/shindig/2.5.0-beta2/shindig-2.5.0-beta2-java.tar.bz2.asc

svn commit: r705 - /release/shindig/KEYS

2012-06-25 Thread rbaxter85
Author: rbaxter85 Date: Tue Jun 26 01:41:01 2012 New Revision: 705 Log: 2.5.0-beta2 KEYS file Modified: release/shindig/KEYS Modified: release/shindig/KEYS == --- release/shindig/KEYS (original) +++

svn commit: r706 - /release/shindig/2.5.0-beta1/

2012-06-25 Thread rbaxter85
Author: rbaxter85 Date: Tue Jun 26 01:42:11 2012 New Revision: 706 Log: 2.5.0-beta1 is no longer the current release Removed: release/shindig/2.5.0-beta1/