---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21060/#review42689
---
Ship it!
Ship It!
- Dan Dumont
On May 12, 2014, 7:42 a.m., Yun
GET request?
- Dan Dumont
On May 5, 2014, 12:44 p.m., Yun Zhi Lin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
.apache.org/r/17228/#comment62607>
It doesn't look like the if check and throw need to be part of the sync
block
- Dan Dumont
On Jan. 28, 2014, 2:10 a.m., ChunYan Zhang wrote:
>
> ---
> This is an automatically genera
Again, this is there so that gadgets take ownership of the dom size they
are given to render in.
You likely have a margin/padding that is unintentionally pushing the
content of the html/body outside of the bounds of what is available for
your gadget, otherwise the html/body inside the iframe would
Shindig takes the approach of shifting render space management of the
gadget contents to the gadget. The container may or may not support
increasing or decreasing available gadget space through apis like
dynamic-height and dynamic-width. It also may choose to ignore the amount
of space requested
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13802/#review25550
---
Ship it!
Ship It!
- Dan Dumont
On Aug. 26, 2013, 5:18 a.m., Zhi
/java/org/apache/shindig/common/crypto/BasicBlobCrypter.java
<https://reviews.apache.org/r/11299/#comment48844>
This method is plural even though the config is currently meant to hold 1
value.
- Dan Dumont
On July 18, 2013, 11:04 a.m., Zhi Hong Yang
> On Aug. 7, 2013, 2:17 a.m., Dan Dumont wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/crypto/BasicBlobCrypter.java,
> > line 81
> > <https://reviews.apache.org/r/11299/diff/5/?file=323040#file323040line81&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11584/#review21404
---
Ship it!
Ship It!
- Dan Dumont
On June 3, 2013, 8:29 p.m
t this to work on lists (which it really doesn't at
the moment.)
You should still probably trim the Strings in the List.
- Dan Dumont
On May 29, 2013, 7:27 a.m., Zhi Hong Yang wrote:
>
> ---
> This is an automatica
-
>
> (Updated May 29, 2013, 7:27 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and
> Rich Thompson.
>
>
> Description
> ---
>
>
> the following setting are added to support different algorithms:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11584/#review21269
---
Ship it!
I agree with this approach.
- Dan Dumont
On May 31
+1
On Sat, May 18, 2013 at 10:32 AM, Stanton Sievers wrote:
> FWIW, I'll give this a +1 as well. I'd ask that we discuss what value
> samples gives us today and see if we can't move some of that into the
> wiki. Without samples I'm afraid we may lose some good examples for
> component replacem
/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java
<https://reviews.apache.org/r/11024/#comment42072>
Can you please make sure that you're using the eclipse style config files
so that your editor doesn't do this kind of cleanup?
- Dan Dumont
On M
RB seems to support git just fine:
http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/#git
On Mon, May 6, 2013 at 12:45 PM, Stanton Sievers wrote:
> Conditional +1...
>
> ...as long as review board still works.
> On May 6, 2013 12:38 PM, "Dan Dumont&quo
Would anyone else be interested in seeing this change?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9891/#review18152
---
Ship it!
nice :)
- Dan Dumont
On March 13, 2013, 1:44 a.m., Paul
ache.shindig.gadgets.oauth2.persistence.sample.JSONOAuth2Persister.
> > I don't see anything that would handle this for the redirect and callback
> > URIs.
>
> Dan Dumont wrote:
> On second glance, Stanton brings up a good point. Also, the scheme
> should probably include the colon(:).
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17335
---
Ship it!
Ship It!
- Dan Dumont
On March 2, 2013, 2:50 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9668/#review17209
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 28, 2013, 2:42 a.m., Ryan
ache.shindig.gadgets.oauth2.persistence.sample.JSONOAuth2Persister.
> > I don't see anything that would handle this for the redirect and callback
> > URIs.
>
> Dan Dumont wrote:
> On second glance, Stanton brings up a good point. Also, the scheme
> should probably include the colon(:).
Cou
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9324/
> ---
>
> (Updated Feb. 6, 2013, 5:51 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, St
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9574/#review17099
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 25, 2013, 2:53 p.m., Ryan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9603/#review17097
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 26, 2013, 6:09 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9584/#review17037
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 25, 2013, 7:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9513/#review16938
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 22, 2013, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9177/#review16856
---
Ship it!
Looks good to me, thanks for working on this!
- Dan
/features/src/test/javascript/features/container/gadget_site_test.js
1446640
Diff: https://reviews.apache.org/r/9470/diff/
Testing
---
Thanks,
Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9335/#review16580
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 6, 2013, 8:34 p.m., Erin
Shindig should be able to take valid container tokens and mint new gadget
tokens as-is.
Container tokens will need to be minted by you somehow. You'll want to use
the same crypter/codec and key that shindig will use to decode them.
On Wed, Feb 13, 2013 at 9:20 AM, Doug Davies wrote:
> I was rea
Sure, I'll take a look.
On Mon, Feb 11, 2013 at 11:17 AM, Noe-Payne, Erin A. wrote:
> Hi All,
>
> I have submitted a review request at https://reviews.apache.org/r/9335/to
> fire ON_PRELOADED lifecycle events after container.preloadCaches(). This
> is needed to support the open social actions fe
/javascript/features/container.site.gadget/gadget_site.js
<https://reviews.apache.org/r/9369/#comment34817>
This generic listener name won't interfere with any others we might use?
- Dan Dumont
On Feb. 8, 2013, 12:07 a.m., Ryan B
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9324/#review16184
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 6, 2013, 5:51 a.m., Zhi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9309/#review16117
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 5, 2013, 5:13 p.m., Ryan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9308/#review16111
---
Ship it!
Ship It!
- Dan Dumont
On Feb. 5, 2013, 7:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8951/#review16026
---
Ship it!
Ship It!
- Dan Dumont
On Jan. 28, 2013, 4:51 a.m
.
- Dan Dumont
On Jan. 7, 2013, 9:20 p.m., Martin Höller wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
al/opensocial/spi/FriendService.java
<https://reviews.apache.org/r/9177/#comment34231>
Please provide a default implementation for this interface.
- Dan Dumont
On Jan. 31, 2013, 12:57 p.m., René Peinl wrote:
>
> ---
> This is an au
jira name
"SHINDIG-".
- Dan Dumont
On Jan. 31, 2013, 12:57 p.m., René Peinl wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
the diff to the JIRA
- Dan Dumont
On Jan. 21, 2013, 2:01 a.m., Marshall Shi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
> (Updated Jan. 24, 2013, 2:38 p.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and
> Rich Thompson.
>
>
> Description
> ---
>
> moduleID is defined as int and long respectively. Propose to unify them to
> long.
t;
> (Updated Jan. 20, 2013, 8:44 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and
> Rich Thompson.
>
>
> Description
> ---
>
> In EhCacheCacheProvider.java, it is creating a new CacheManager instance.
> Prefer to use
ig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java
1437127
Diff: https://reviews.apache.org/r/9099/diff/
Testing
---
Thanks,
Dan Dumont
diff/
Testing
---
Thanks,
Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9017/#review15537
---
Ship it!
Ship It!
- Dan Dumont
On Jan. 21, 2013, 7:15 a.m., Zhi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8952/#review15536
---
Ship it!
Ship It!
- Dan Dumont
On Jan. 20, 2013, 8:44 a.m
submitted?
- Dan Dumont
On Jan. 18, 2013, 8:38 a.m., Zhi Hong Yang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
the patch in the Jira is up to date.
- Dan Dumont
On Jan. 15, 2013, 2:22 a.m., Marshall Shi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8766/#review15507
---
Ship it!
Ship It!
- Dan Dumont
On Jan. 15, 2013, 2:22 a.m
/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
<https://reviews.apache.org/r/9017/#comment33434>
Looks like you lost the break statement after the catch.
- Dan Dumont
On Jan. 18, 2013, 8:55 a.m., Zhi Hong Yang
Not much is going on in that one.
On Thu, Jan 10, 2013 at 9:46 PM, Ryan Baxter wrote:
> Dan don't we need the same change on the DefaultJsCompiler?
>
>
> On Thu, Jan 10, 2013 at 4:51 PM, wrote:
>
> > Author: ddumont
> > Date: Thu Jan 10 21:51:33 2013
> > New Revision: 1431679
> >
> > URL: http:
> On Jan. 9, 2013, 2:59 p.m., Dan Dumont wrote:
> > Ship It!
Committed r1430900. Please close this review.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8222/#re
> On Jan. 9, 2013, 3:11 p.m., Dan Dumont wrote:
> > Ship It!
Committed r1430886. Please close this review.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8244/#re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8244/#review15186
---
Ship it!
Ship It!
- Dan Dumont
On Dec. 18, 2012, 7:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8222/#review15185
---
Ship it!
Ship It!
- Dan Dumont
On Dec. 27, 2012, 2:32 a.m
the search for target frames a bit more resilient.
Diffs
-
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
1430457
Diff: https://reviews.apache.org/r/8894/diff/
Testing
---
Thanks,
Dan Dumont
https://issues.apache.org/jira/browse/SHINDIG-1816
Since this patch, it appears that gadget-to-gadget communication is no
longer possible. I believe that it's because of this change:
- return window.top.frames[siblingId.id];
+ return window.frames[siblingId.id];
When the gadgets go look up the
> On Dec. 12, 2012, 7:20 p.m., Dan Dumont wrote:
> > Looking this over again, I'm not sure what to do here. This looks like a
> > library that we've gotten from the project
> > http://code.google.com/p/swfobject/
> > They wouldn't have code to ou
t;
> (Updated Dec. 7, 2012, 1:08 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and
> Rich Thompson.
>
>
> Description
> ---
>
> Copied from https://reviews.apache.org/r/6695/
>
> The OpenSocial 2.0 specification now
> On Dec. 12, 2012, 7:20 p.m., Dan Dumont wrote:
> > Looking this over again, I'm not sure what to do here. This looks like a
> > library that we've gotten from the project
> > http://code.google.com/p/swfobject/
> > They wouldn't have code to ou
mized file as a .opt file so
that our compiler can skip that step... it might be optimized better than the
basic optimization we perform during build.
Can someone else comment on what we should do here?
Paul?
- Dan Dumont
On Dec. 4, 2012, 2:53 a.m.
://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java
<https://reviews.apache.org/r/8184/#comment30145>
Hehe, sorry to keep pushing back but there are whitespaces at the end of
the lines here.
- Dan Dumont
On Dec. 6
/7878/diff/
Testing
---
Thanks,
Dan Dumont
o reply, visit:
https://reviews.apache.org/r/7878/#review13165
-------
On Nov. 6, 2012, 7:43 p.m., Dan Dumont wrote:
>
> ---
> This is an automatically generated e-
/server/target/maven-archiver/pom.properties
PRE-CREATION
Diff: https://reviews.apache.org/r/7878/diff/
Testing
---
Thanks,
Dan Dumont
* api and point the impl to the official spec
namespace.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7878/#review13094
---------
something you want to do, I had
implemented it here in the attached patch:
https://issues.apache.org/jira/browse/SHINDIG-1864
This patch hasn't made it in.
- Dan Dumont
On Nov. 4, 2012, 3:40 p.m., Stanton Sievers wrote:
>
> ---
&
: https://reviews.apache.org/r/7878/diff/
Testing
---
Thanks,
Dan Dumont
---
Thanks,
Dan Dumont
As I understand it, in java this should be represented by a
List> construct.
A PluralField would look like:
interface PluralField {
public T getValue();
public String getType(); // or maybe Class
public boolean isPrimary();
public String getLabel();
}
On Tue, Oct 16, 2012 at 9:34 AM, Ry
There's also a property in shindig.properties that lists the core features
everything must have (which is currently core and rpc)
On Tue, Sep 25, 2012 at 2:46 PM, Henry Saputra wrote:
> HI Christian,
>
> You can either have custom DefaultGadgetSpecFactory.parse() and
> decorate the ModulePrefs el
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7166/#review11839
---
Ship it!
Committed r1389503
Please close this review.
- Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436/#review11838
---
Ship it!
Committed r1389495
Please close this review.
- Dan
tra wrote:
> >> > Dan, could you tell a bit more details what the issue looks like with
> >>3-legged OAuth 1.0a dance? It will help review the change.
> >> >
> >> > This needs to be fixed ASAP bc the oauthpopup change is part of beta4
> >>
ig/gadgets/uri/DefaultOAuthUriManagerTest.java
1387677
Diff: https://reviews.apache.org/r/7186/diff/
Testing
---
Updated tests.
Removed obsolete tests.
Thanks,
Dan Dumont
ig/gadgets/uri/DefaultOAuthUriManagerTest.java
1387677
Diff: https://reviews.apache.org/r/7186/diff/
Testing
---
Updated tests.
Removed obsolete tests.
Thanks,
Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7166/#review11747
---
Ship it!
Ship It!
- Dan Dumont
On Sept. 20, 2012, 8:04 a.m
ta4
> > release and if its broken we need to come up with beta5 quickly.
>
> Dan Dumont wrote:
> Hey, thanks for helping with the review :)
>
> Let me start by describing what I saw before any of these changes or the
> oauthpopup changes with locked domain
Now on the unlocked domain, window.opener would now match domains.
- Dan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7186/#review11730
-------
org/r/7186/diff/
Testing
---
Updated tests.
Removed obsolete tests.
Thanks,
Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7149/#review11701
---
Ship it!
Ship It!
- Dan Dumont
On Sept. 18, 2012, 11:02 p.m
> On Sept. 19, 2012, 4:34 p.m., Dan Dumont wrote:
> > Committed r1387677
> > Please close this review.
> >
Marshall, could you please attach the patch here to the JIRA?
- Dan
---
This is an automatically gener
;
> (Updated Sept. 19, 2012, 8:04 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and
> Rich Thompson.
>
>
> Description
> ---
>
> The AllJsIframeVersioner causes a massive memory allocation executing the
> following:
use the fragment as a
blob, or enhance the shindig.uri js class to encode multiple params in the
fragment like the java side does?
- Dan Dumont
On Sept. 19, 2012, 1:36 p.m., Matt Jones wrote:
>
> ---
> This is an automatically ge
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7122/#review11612
---
Ship it!
Ship It!
- Dan Dumont
On Sept. 15, 2012, 4:58 p.m
-----------
>
> (Updated Sept. 15, 2012, 4:58 p.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Description
> ---
>
> Disable thread in the closure compiler code since Shindig manage the thread
> in
arns you of the javacore... that's not
it's job. Anyways, the OOM core being generated here is for a caught
expected exception I would think that other uncaught unexpected cores
would halt the build with less misleading information.
On Wed, Sep 12, 2012 at 11:06 PM, Dan Dumont wrot
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6945/#review11543
---
Ship it!
Committed r1384822
Please close this review.
- Dan Dumont
://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuthCallbackServlet.java
1384338
Diff: https://reviews.apache.org/r/7089/diff/
Testing
---
All tests pass. Tested an oauth 1.0a gadget in the sample container.
Thanks,
Dan Dumont
attach the latest patch to the JIRA and
grant license (if it still gives you that option)
- Dan Dumont
On Sept. 11, 2012, 2:55 a.m., Marshall Shi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Stanton, would this help?
http://maven.apache.org/plugins/maven-surefire-plugin/examples/system-properties.html
Special VM properties
Some system properties must be set on the command line of the forked VM,
and cannot be set after the VM has been started. These properties must be
added to the arg
Yes I was planning on doing that today when I got in.
On Tue, Sep 11, 2012 at 8:29 AM, Ryan Baxter wrote:
> Dan could you fix the missing license header in
> features/src/test/javascript/features/container/mixin_test.js?
> Thanks.
>
> -- Forwarded message --
> From: Apache Jenkin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6201/#review11325
---
Ship it!
Ship It!
- Dan Dumont
On Sept. 11, 2012, 2:55 a.m
Yes I was planning on doing that today when I got in.
On Tue, Sep 11, 2012 at 8:29 AM, Ryan Baxter wrote:
> Dan could you fix the missing license header in
> features/src/test/javascript/features/container/mixin_test.js?
> Thanks.
>
> -- Forwarded message --
> From: Apache Jenkin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6436/#review11250
---
Ship it!
Ship It!
- Dan Dumont
On Sept. 7, 2012, 4:07 p.m., Adam
apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/views/views-init-test.js
1380656
Diff: https://reviews.apache.org/r/6947/diff/
Testing
---
Removed a test that is no longer applicable.
Thanks,
Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6947/#review6
-----------
On Sept. 6, 2012, 6:03 p.m., Dan Dumont wrote:
>
> ---
ntainer_test.js
1380656
Diff: https://reviews.apache.org/r/6947/diff/
Testing
---
Removed a test that is no longer applicable.
Thanks,
Dan Dumont
ache.org/r/6947/diff/
Testing
---
Removed a test that is no longer applicable.
Thanks,
Dan Dumont
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6906/#review11030
---
Ship it!
Ship It!
- Dan Dumont
On Sept. 4, 2012, 6:46 p.m
1 - 100 of 574 matches
Mail list logo
