Re: Sling 12 themes

2018-10-30 Thread Jason E Bailey
Since this is a public record, I'm going to clarify myself. I don't dislike it. I resent it. And the way it felt like it was forced on me for no good reason. However, in it's own right, it's a decent solution. - Jason On Tue, Oct 23, 2018, at 12:42 PM, Jason E Bailey wrote: > 1. I don't use

[jira] [Comment Edited] (SLING-7790) Allow for synchronous installation of bundles and configurations via install hook

2018-10-30 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645570#comment-16645570 ] Georg Henzler edited comment on SLING-7790 at 10/30/18 8:07 PM: ---

Re: Sling 12 themes

2018-10-30 Thread Oliver Lietz
On Monday 29 October 2018 11:37:47 Robert Munteanu wrote: > On Wed, 2018-10-24 at 07:19 +0200, Carsten Ziegeler wrote: > > In addition to that, it seems to me wrong to write a script which > > creates an output (being that html or json or whatever) and then you > > need an additional mechanism to m

[jira] [Commented] (SLING-8060) Sling Testing Mocks: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669103#comment-16669103 ] Konrad Windszus commented on SLING-8060: I provided a PR for Testing Sling Mock i

[GitHub] kwin opened a new pull request #2: [SLING-8060] declare OSGi dependencies with scope "compile"

2018-10-30 Thread GitBox
kwin opened a new pull request #2: [SLING-8060] declare OSGi dependencies with scope "compile" URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/2 They are actually needed at test execution time and using "provided" scope may lead to the fact that they are not

Re: Sling 12 themes

2018-10-30 Thread Jason E Bailey
- Jason On Tue, Oct 30, 2018, at 5:50 AM, Robert Munteanu wrote: > Hi Jason, > > On Tue, 2018-10-23 at 12:00 -0400, Jason E Bailey wrote: > > 1. Creating a resource provider to use as the default resource > > provider for the starter installation > > 2. Define a Resource > > 3. Define a Resou

Re: Sling 12 themes

2018-10-30 Thread Jason E Bailey
On Tue, Oct 30, 2018, at 5:50 AM, Robert Munteanu wrote: > Hi Jason, > > On Tue, 2018-10-23 at 12:00 -0400, Jason E Bailey wrote: > > 1. Creating a resource provider to use as the default resource > > provider for the starter installation > > 2. Define a Resource > > 3. Define a Resource Type h

Re: Sling 12 themes

2018-10-30 Thread Jason E Bailey
On Tue, Oct 30, 2018, at 5:50 AM, Robert Munteanu wrote: > Hi Jason, > > On Tue, 2018-10-23 at 12:00 -0400, Jason E Bailey wrote: > > 1. Creating a resource provider to use as the default resource > > provider for the starter installation > > 2. Define a Resource > > 3. Define a Resource Type

[jira] [Updated] (SLING-8060) Sling Testing Mocks: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8060: --- Summary: Sling Testing Mocks: Transitive dependencies necessary at test execution time should

[jira] [Updated] (SLING-8060) Sling Testing Mocks: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8060: --- Description: Currently Testing OSGi Mock and Testing Sling Mock have a class execution time

[jira] [Updated] (SLING-8060) Sling Testing OSGi: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8060: --- Description: Currently Testing OSGi Mock and Testing Sling Mock has a runtime dependency to

[jira] [Updated] (SLING-8060) Sling Testing OSGi: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8060: --- Affects Version/s: Testing Sling Mock 2.3.4 > Sling Testing OSGi: Transitive dependencies nec

[jira] [Created] (SLING-8060) Sling Testing OSGi: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-8060: -- Summary: Sling Testing OSGi: Transitive dependencies necessary at test execution time should be defined with scope "compile" Key: SLING-8060 URL: https://issues.apache.org/jir

[jira] [Updated] (SLING-8060) Sling Testing OSGi: Transitive dependencies necessary at test execution time should be defined with scope "compile"

2018-10-30 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-8060: --- Issue Type: Bug (was: Improvement) > Sling Testing OSGi: Transitive dependencies necessary a

[jira] [Comment Edited] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-10-30 Thread Philip Mundt (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668614#comment-16668614 ] Philip Mundt edited comment on SLING-8047 at 10/30/18 4:04 PM:

[jira] [Commented] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread David Bosschaert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668885#comment-16668885 ] David Bosschaert commented on SLING-8028: - The Launcher also needs to be updated

[jira] [Commented] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread David Bosschaert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668869#comment-16668869 ] David Bosschaert commented on SLING-8028: - Initial code changes committed. Now s

[jira] [Commented] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668809#comment-16668809 ] ASF GitHub Bot commented on SLING-8028: --- bosschaert closed pull request #7: SLING-8

[GitHub] bosschaert closed pull request #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread GitBox
bosschaert closed pull request #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostProcessor URL: https://github.com/apache/sling-org-apache-sling-feature/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed be

[jira] [Commented] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668795#comment-16668795 ] ASF GitHub Bot commented on SLING-8028: --- karlpauls commented on issue #7: SLING-802

[GitHub] karlpauls commented on issue #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread GitBox
karlpauls commented on issue #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostProcessor URL: https://github.com/apache/sling-org-apache-sling-feature/pull/7#issuecomment-434326929 +1 This is an automate

[jira] [Commented] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668784#comment-16668784 ] ASF GitHub Bot commented on SLING-8028: --- cziegeler commented on issue #7: SLING-802

[GitHub] cziegeler commented on issue #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread GitBox
cziegeler commented on issue #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostProcessor URL: https://github.com/apache/sling-org-apache-sling-feature/pull/7#issuecomment-434321795 Interfaces look good to me, +1

[jira] [Commented] (SLING-8028) Split FeatureExtensionHandler into MergeHandler and PostProcessor

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668764#comment-16668764 ] ASF GitHub Bot commented on SLING-8028: --- bosschaert opened a new pull request #7: S

[GitHub] bosschaert opened a new pull request #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostPr…

2018-10-30 Thread GitBox
bosschaert opened a new pull request #7: SLING-8028 Split FeatureExtensionHandler into MergeHandler and PostPr… URL: https://github.com/apache/sling-org-apache-sling-feature/pull/7 … This is an automated message from the Apac

[jira] [Commented] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-10-30 Thread Philip Mundt (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668614#comment-16668614 ] Philip Mundt commented on SLING-8047: - [~jsedding] that's what I'm wondering too. I w

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Stefan Egli
On 30.10.18 10:22, Bertrand Delacretaz wrote: Hi, I agree, and we might use the following trick to avoid that with minimal disruption: -Consider the current interface "Legacy" that needs half of its methods deprecated -Move the non-deprecated methods to a new "Modern" interface -Legacy inherits

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Stefan Egli
On 30.10.18 10:08, Robert Munteanu wrote: On Mon, 2018-10-29 at 17:42 +0100, Stefan Egli wrote: (btw: I went even further in restricting the API, as I think retryJobById and getJobById are potentially expensive as well, thus lean towards deprecating those too - not sure about getScheduledJobs...

Re: Sling 12 themes

2018-10-30 Thread Robert Munteanu
On Mon, 2018-10-29 at 12:03 +0100, Radu Cotescu wrote: > Hi Robert, > > > On 29 Oct 2018, at 11:37, Robert Munteanu > > wrote: > > > > Wild idea: would it be possible to provide an optional extension > > point > > for scripting engines where they could signal that a link is > > output? > > Then

[jira] [Comment Edited] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-10-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668381#comment-16668381 ] Julian Sedding edited comment on SLING-8047 at 10/30/18 9:51 AM: --

Re: Sling 12 themes

2018-10-30 Thread Robert Munteanu
On Tue, 2018-10-23 at 21:17 +0200, Jörg Hoh wrote: > Am Di., 23. Okt. 2018 um 16:29 Uhr schrieb Robert Munteanu < > romb...@apache.org>: > > > I think it would be an interesting and worthwhile exercise to see > > what > > various contributors would like to see as the major themes of Sling > > 12.

Re: Sling 12 themes

2018-10-30 Thread Robert Munteanu
Hi Jason, On Tue, 2018-10-23 at 12:00 -0400, Jason E Bailey wrote: > 1. Creating a resource provider to use as the default resource > provider for the starter installation > 2. Define a Resource > 3. Define a Resource Type hierarchy > 4. Convert all generated HTML to HTML5 standards > 5. Fix the

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Robert Munteanu
On Tue, 2018-10-30 at 10:22 +0100, Bertrand Delacretaz wrote: > Hi, > > On Tue, Oct 30, 2018 at 10:08 AM Robert Munteanu > wrote: > > ...My personal opinion is that an interface with half of its > > methods > > deprecated is confusing and should not be used > > I agree, and we might use the

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Bertrand Delacretaz
Hi, On Tue, Oct 30, 2018 at 10:08 AM Robert Munteanu wrote: >...My personal opinion is that an interface with half of its methods > deprecated is confusing and should not be used I agree, and we might use the following trick to avoid that with minimal disruption: -Consider the current inter

[jira] [Commented] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-10-30 Thread Julian Sedding (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668402#comment-16668402 ] Julian Sedding commented on SLING-8047: --- Thanks [~mundt] for the feedback. That's i

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Robert Munteanu
On Mon, 2018-10-29 at 17:42 +0100, Stefan Egli wrote: > Right, Sling Jobs can help in defining the deprecation, which is > exactly > what I've use it for now. (btw: I went even further in restricting > the > API, as I think retryJobById and getJobById are potentially expensive > as > well, thus

[jira] [Commented] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-10-30 Thread Philip Mundt (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668381#comment-16668381 ] Philip Mundt commented on SLING-8047: - Hey [~jsedding] thanks for chiming in and prov

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Timothee Maret
Hi, Le lun. 29 oct. 2018 à 17:42, Stefan Egli a écrit : > Right, Sling Jobs can help in defining the deprecation, which is exactly > what I've use it for now. (btw: I went even further in restricting the > API, as I think retryJobById and getJobById are potentially expensive as > well, thus lean

Re: [DISCUSS] Deprecate query part of Sling Event API

2018-10-30 Thread Robert Munteanu
On Mon, 2018-10-29 at 17:17 +0100, Carsten Ziegeler wrote: > Eventually we should move to some ootb solution for job processing > and > not reinvent the wheel another time. (We should have never started > with > our own job processing API, but that went out of the window already). > So > depreca

[jira] [Commented] (SLING-7752) Deserializing and serializing a feature model file suffles the configurations

2018-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668261#comment-16668261 ] ASF GitHub Bot commented on SLING-7752: --- andreituicu closed pull request #8: SLING-

[GitHub] andreituicu closed pull request #8: SLING-7752 - Deserializing and serializing a feature model file shuffles the configurations

2018-10-30 Thread GitBox
andreituicu closed pull request #8: SLING-7752 - Deserializing and serializing a feature model file shuffles the configurations URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge,

[jira] [Commented] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-10-30 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668258#comment-16668258 ] Carsten Ziegeler commented on SLING-8058: - And the AnalyserMojo > Make configura