[PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

reschke opened a new pull request, #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109 (needed for subsequent use of query paging) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

sonarcloud[bot] commented on PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#issuecomment-1864879736 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality G

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

enapps-enorman commented on code in PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433092042 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java: ## @@ -105,7 +105,7 @@ public Itera

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

reschke merged PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

reschke commented on code in PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433692557 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1154,7 +1152,7 @@ private Map>> loadAliases(fina

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

enapps-enorman commented on code in PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1433717742 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1154,7 +1152,7 @@ private Map>> loadAlias

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

rombert commented on code in PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1434028256 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1154,7 +1152,7 @@ private Map>> loadAliases(fina

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

enapps-enorman commented on code in PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#discussion_r1434736024 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1154,7 +1152,7 @@ private Map>> loadAlias

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

reschke commented on PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#issuecomment-1903541030 FWIW, I chose not to act on the feedback above because it's not specific to *this* PR. I'm ok with having a discussion unsing javax.jcr in the source, but w

Re: [PR] SLING-12205: ResourceResolver: switch sling:alias query to JCR-SQL2 [sling-org-apache-sling-resourceresolver]

enapps-enorman commented on PR #109: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/109#issuecomment-1922007973 > it's not specific to _this_ PR @reschke I'm not sure that is true. You specifically changed the code to use a new query language. For me,