[VOTE] Release Apache Sling Repoinit Parser version 1.9.0, Repoinit JCR 1.1.44 and Repoinit FileVault Validator 1.0.0

2023-01-25 Thread Konrad Windszus
Hi, We solved some issues in these releases: Repoinit Parser 1.9.0: https://issues.apache.org/jira/projects/SLING/versions/12352326 Repoinit JCR 1.1.44: https://issues.apache.org/jira/projects/SLING/versions/12352325 Repoinit FileVault Validator 1.0.0: https://issues.apache.org/jira/project

Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2

2023-01-26 Thread Konrad Windszus
Hi Radu, Quite some time passed, you gathered enough votes, still this is not released (the staging repo is still there in https://repository.apache.org/#stagingRepositories ) Anything blocking here? Thanks, Konrad > On 9. Dec 2022, at 11:15,

Re: [VOTE] Release Apache Sling Repoinit Parser version 1.9.0, Repoinit JCR 1.1.44 and Repoinit FileVault Validator 1.0.0

2023-01-26 Thread Konrad Windszus
Would you mind creating a JIRA for that so that we can track? I will try to enable Windows builds for the affected module then to reproduce with Jenkins. Thanks, Konrad > On 26. Jan 2023, at 14:36, Stefan Seifert > wrote: > > +1 > > please note i'm unable to run the integration tests on windo

[RESULT] [VOTE] Release Apache Sling Repoinit Parser version 1.9.0, Repoinit JCR 1.1.44 and Repoinit FileVault Validator 1.0.0

2023-01-30 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Angela, Stefan and Dan. I will copy these releases to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 25. Jan 2023, at 20:47, Konrad Windszus wrote: >

Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others

2023-02-07 Thread Konrad Windszus
Probably https://issues.apache.org/jira/browse/SLING-11750 would be easy to integrate. Also as long as the new statements are only parsed but not generated this is also 100% backwards compatible. Won’t have time to look into this this week, tho

Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others

2023-02-08 Thread Konrad Windszus
scripts are parsed and rewritten by cp2fm because I don’t know the details there. Konrad > On 8. Feb 2023, at 10:53, Robert Munteanu wrote: > > Hi Konrad, > > On Tue, 2023-02-07 at 11:09 +0100, Konrad Windszus wrote: >> Probably >> https://issues.apache.org/jira/br

Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others

2023-02-08 Thread Konrad Windszus
at 12:15 +0100, Konrad Windszus wrote: >> IIUC then using the new repoinit statements will make the cpconverter >> throw an exception. >> That makes it pretty critical for me. >> Otherwise we should clearly indicate the non-compatibility with newer >> versions of r

Re: [VOTE] Release Apache Sling Commons Permissions 1.0.0

2023-03-09 Thread Konrad Windszus
IIRC Commons is used as name infix for all bundles not having a dependency on other Sling bundles (i.e. are not really Sling-specific) As long as the only implementation is not fulfilling that requirement (due to https://github.com/apache/sling-org-apache-sling-commons-permissions-sling/blob/a316

Re: SLING-11709 - Set up Jira autolinks to all Sling Github projects

2023-03-23 Thread Konrad Windszus
I think one week passed :-) Are you still planning to work on this? This is a very useful feature. Thanks, Konrad > On 15. Dec 2022, at 13:11, Konrad Windszus wrote: > > Sounds good to me. Could we at the same reestablish auto-linking of GitHub > PRs with > https://c

Re: PGP Keys Issue

2023-03-29 Thread Konrad Windszus
Yes, the steps are outlined in https://sling.apache.org/documentation/development/release-management.html#appendix-a-creating-and-registering-your-pgp-key as mentioned by Julian. You have to manually update the KEYS file in SVN! Konrad > On 29. Mar 2023, at 16:52, Andreas Schaefer wrote: > >

Re: [RT] Migrating the feature model tooling to Jakarta JSON

2023-04-19 Thread Konrad Windszus
To me it seems that Johnson isn’t really well maintained any longer (see https://issues.apache.org/jira/browse/JOHNZON-389 and https://issues.apache.org/jira/browse/JOHNZON-388) and isn’t adopting new spec versions. So we should definitely consider moving to https://github.com/eclipse-ee4j/pars

Re: [RT] Migrating the feature model tooling to Jakarta JSON

2023-04-19 Thread Konrad Windszus
At some point in the future we hopefully have https://openjdk.org/jeps/198 integrated in the JDK (but this is not even planned yet for JDK21) > On 19. Apr 2023, at 16:07, Konrad Windszus wrote: > > To me it seems that Johnson isn’t really well maintained any longer (see

Re: Dropping Java 8 support for the Sling Starter (was: [RT] Migrating the feature model tooling to Jakarta JSON)

2023-04-21 Thread Konrad Windszus
There was a similar discussion already at https://lists.apache.org/thread/6p86tqpldjj83zw3288ooht869yt99dr and back then we already kind of reached consensus that it is time to require Java 11 also for bundles nowadays. Konrad > On 21. Apr 2023, at 12:02, Stefan Seifert > wrote: > > makes

Re: Dropping Java 8 support for the Sling Starter (was: [RT] Migrating the feature model tooling to Jakarta JSON)

2023-04-21 Thread Konrad Windszus
I created some follow up tickets for that https://issues.apache.org/jira/browse/SLING-11843 https://issues.apache.org/jira/browse/SLING-11842 https://issues.apache.org/jira/browse/SLING-11841 Please comment directly on those. Thanks, Konrad > On 21. Apr 2023, at 12:02, Stefan Seifert > wrot

Re: [VOTE] Release Apache Sling Event API version 1.0.2 and Event 4.3.10

2023-05-04 Thread Konrad Windszus
> On 4. May 2023, at 09:53, Stefan Seifert > wrote: > > i've two remarks on this release: > > a) on both modules org.jetbrains:annotations was added with compile scope - > should be provided. although not a problem for the bundle in OSGi runtime, it > should be fixed. i would propose making

Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.2

2023-05-05 Thread Konrad Windszus
+1 (although having https://issues.apache.org/jira/browse/SLING-11750 integrated would have been nice, but for sure no blocker of this release) Konrad > On 4. May 2023, at 18:59, Robert Munteanu wrote: > > Hi, > > We solved 7 issues in this release: > https://issues.apache.org/jira/browse/SLIN

Re: SLING-11865 - Conversion fails when initial content document does not include namespace declaration

2023-05-08 Thread Konrad Windszus
Hi, From a Sling perspective having initial content without explicit namespace declaration is totally fine. Therefore I wouldn’t call it ill-formed Sling initial content files. But the converted DocView file is ill-formed (violating the spec) but still imported fine. Having said this, FileVault

Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-05-12 Thread Konrad Windszus
Hi, Currently we still build by default all our modules with Java 8 on Linux only [1]. In SLING-11843 I proposed to change the default to Java 11 and 17 with Linux and Windows. The default build (i.e. the one which deploys the Snapshot) would be Java 11 on Linux. As there were some concerns ra

[VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

2023-05-15 Thread Konrad Windszus
Hi, We solved 1 issues in these releases: https://issues.apache.org/jira/browse/SLING-11864 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2747/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/re

Re: Test failures with Java 17 - Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

2023-05-15 Thread Konrad Windszus
, Konrad > On 15. May 2023, at 14:37, Robert Munteanu wrote: > > On Mon, 2023-05-15 at 13:02 +0200, Konrad Windszus wrote: >> Usage: sh check_staged_release.sh 2747 /tmp/sling-staging > > For the record, the tests fail for me on Java 17 > > [ERROR] Tests run: 1, Failure

Re: Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-05-15 Thread Konrad Windszus
> Is a Jenkins rebuild > going to happen once the > https://github.com/apache/sling-tooling-jenkins/pull/16 is merged or > will the potential failures be exposed once a new CI job runs? > No, not automatically. But either through a dedicated build (due to some commits in the affected module re

Re: Sling Engine release 2.15.0?

2023-05-18 Thread Konrad Windszus
Hi, same from my side. No plans for a release. Konrad > On 19. May 2023, at 07:07, Carsten Ziegeler wrote: > > Hi, > > no plans for a release from my side; I'm also not aware of any outstanding > work. > > Thanks > Carsten > > On 18.05.2023 10:53, Jörg Hoh wrote: >> Hi, >> I would like to p

Re: [VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

2023-05-18 Thread Konrad Windszus
+1 Konrad > On 15. May 2023, at 13:02, Konrad Windszus wrote: > > Hi, > > We solved 1 issues in these releases: > https://issues.apache.org/jira/browse/SLING-11864 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-274

[RESULT] [VOTE] Release Apache Sling OSGi Installer Configuration Factory 1.4.4 and OSGi Installer Console 1.1.2

2023-05-18 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Stefan, Robert and myself +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 15. May 2023, at 13:02, Kon

OSGi Installer Factory Configuration dependency on javax.servlet

2023-05-19 Thread Konrad Windszus
With https://issues.apache.org/jira/browse/SLING-11864 we moved one Web Console plugin to the Installer Factory Configuration Bundle. That now has a dependency on javax.servlet. In Sling Starter we load that bundle with start order 1, but servlet is only exposed in start order 5. That leads to v

[VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.10

2023-05-23 Thread Konrad Windszus
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12350261 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2752/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apa

Re: OSGi Installer Factory Configuration dependency on javax.servlet

2023-05-26 Thread Konrad Windszus
Hi Robert, Good point, tracked and fixed in the context of https://issues.apache.org/jira/browse/SLING-11889. Konrad > On 26. May 2023, at 10:50, Robert Munteanu wrote: > > Hi Konrad, > > On Fri, 2023-05-19 at 16:13 +0200, Konrad Windszus wrote: >> With https://issues.a

Re: Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-05-26 Thread Konrad Windszus
11843. Hopefully that allows us to improve compatibility with Windows and Java 11/17. Thanks, Konrad > On 12. May 2023, at 14:24, Konrad Windszus wrote: > > Hi, > Currently we still build by default all our modules with Java 8 on Linux only > [1]. > In SLING-11843 I proposed to ch

Re: Synthethic requests and Sling Models

2023-05-26 Thread Konrad Windszus
I think this can be implemented with the HttpServiceRuntime.getRuntimeDRO[1] which should return all registered event listeners [2] through its ServletContextDTO (also the ServletRequestListener registered by ModelAdapterFactory). The question is though when to call the according events, as the

Re: Synthethic requests and Sling Models

2023-05-26 Thread Konrad Windszus
I added a draft in https://github.com/apache/sling-org-apache-sling-engine/pull/35/files#. Feel free to have a look and take over if you deem that useful. Haven’t tested it yet… Konrad > On 26. May 2023, at 17:32, Konrad Windszus wrote: > > I think this can be implemented

Re: Automatically build on ASF Jenkins with Java 11/17 on Linux/Windows

2023-06-05 Thread Konrad Windszus
Thanks, but I would rename the page. The failures are not specific to Jenkins or CI but rather generic Maven build with Java 17 issues. Konrad > Am 02.06.2023 um 13:40 schrieb Robert Munteanu : > > Hi, > >> On Fri, 2023-05-12 at 14:24 +0200, Konrad Windszus wrote: &g

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.10

2023-06-11 Thread Konrad Windszus
Here is my +1 Konrad > On 23. May 2023, at 16:31, Konrad Windszus wrote: > > Hi, > We solved 2 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12350261 > > Staging repository: > https://repository.apache.org/content/repositories/or

[RESULT] [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.1.10

2023-06-11 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Robert, David and myself +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 23. May 2023, at 16:31, Kon

JIRA Release notes link in vote email template

2023-06-11 Thread Konrad Windszus
Hi, The link towards a specific component version in JIRA is unfortunately only accessible to logged in users (e.g. https://issues.apache.org/jira/projects/SLING/versions/12350261) But the release notes from JIRA (e.g. https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350261&style

Re: JIRA Release notes link in vote email template

2023-06-11 Thread Konrad Windszus
FTR: Here is the vote email template used in Apache Maven: https://maven.apache.org/developers/release/maven-project-release-procedure.html#call-the-vote which is using that format. > On 11. Jun 2023, at 11:30, Konrad Windszus wrote: > > Hi, > The link towards a specific componen

Re: Proposal: enforcing CI checks for pull requests

2023-06-12 Thread Konrad Windszus
Hi Robert, What issue are we trying to solve here? Is this only about preventing someone to press the merge button in the GitHub UI too soon? Did that happen in the past? Too me this right now sounds a bit like over engineering, as the proposed mandatory checks are not always easy to pass (some

Sling Models Constructor Injection

2023-06-27 Thread Konrad Windszus
Hi, Currently our documentation at [1] only outlines using the annotations on method level for constructor injection: @Inject public MyModel(@Named("propertyName") String propertyName) { // constructor code } However as we recommend using injector-specific annotation now, I am wondering if

Re: Sling Models Constructor Injection

2023-06-27 Thread Konrad Windszus
Some things magically work even without ITs. And no, by someone I really meant some committer. > On 27. Jun 2023, at 11:36, Bertrand Delacretaz wrote: > > On Tue, Jun 27, 2023 at 9:05 AM Konrad Windszus wrote: >> ...If someone can confirm that both levels are supported

[VOTE] Release Apache Sling Maven Enforcer Rules 1.2.0

2023-07-05 Thread Konrad Windszus
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12353398&styleName=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2760/ You can use this UNIX script to download the release and v

[VOTE] Release Apache Sling Parent and Bundle Parent version 50

2023-07-05 Thread Konrad Windszus
Hi, We solved 9 issues in these releases: Parent: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12352188&styleName=Text Bundle Parent: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12352189&styleName=Text Staging repo

Sling Models Integration Tests broken

2023-07-07 Thread Konrad Windszus
HI, The ITs at https://github.com/apache/sling-org-apache-sling-models-integration-tests built through https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-integration-tests/activity are failing since quite some time and also reference pretty o

[RESULT] [VOTE] Release Apache Sling Parent and Bundle Parent version 50

2023-07-08 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Robert, Stefan, Oli I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad

Re: [VOTE] Release Apache Sling Maven Enforcer Rules 1.2.0

2023-07-08 Thread Konrad Windszus
+1 Konrad > On 5. Jul 2023, at 12:11, Konrad Windszus wrote: > > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12353398&styleName=Text > > Staging repository: > https://reposit

[RESULT] [VOTE] Release Apache Sling Maven Enforcer Rules 1.2.0

2023-07-08 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Robert, Stefan, myself I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad

Re: [VOTE] Release Apache Sling Parent and Bundle Parent 51

2023-07-10 Thread Konrad Windszus
+1 Thanks for finding and fixing, Konrad > On 9. Jul 2023, at 22:22, Oliver Lietz wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12310710&version=12353168&styleName=Text > > Staging repository: > https://repository.a

Re: Sling Models Integration Tests broken

2023-07-10 Thread Konrad Windszus
; >> but that's a good deal of work to get this running. i'm lacking the >> knowledge in the feature model tooling to get a good start on this. > > I found [1], in case anyone wants to give the conversion a shot. > > Thanks, > Robert > > [1]: > ht

[VOTE] Apache Sling Parent & Bundle Parent 52

2023-07-18 Thread Konrad Windszus
Hi, We solved 2 issues in these releases: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710&version=12353412&styleName=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2769/ You can use this UNIX script to download the release

Re: More Sling GraphQL Core Jenkins Wows

2023-07-19 Thread Konrad Windszus
Please check out https://issues.apache.org/jira/browse/INFRA-24767. > On 19. Jul 2023, at 14:58, Andreas Schaefer wrote: > > Hi > > After limiting the Jenkins build to JDK 11 to release a fix required for the > last release the build is still failing with a pretty weird issue: > > https://c

SLING-11974: Spec Compliance vs. Backward compatibility

2023-07-20 Thread Konrad Windszus
Hi, Carsten just reverted the fix from https://issues.apache.org/jira/browse/SLING-11825 in https://issues.apache.org/jira/browse/SLING-11974. The fix is correct according to the Servlet Spec, but it seems some customer rely on Sling behaving not spec compliant here. The question is what weighs

Re: SLING-11974: Spec Compliance vs. Backward compatibility

2023-07-20 Thread Konrad Windszus
ught during tests (although I agree it should be). I stumbled upon this and it costed me some time to figure this out. Also this will be reported otherwise again (for good reasons) But I see, that you are opting for 2) in this case :-) Konrad > > Regards > Carsten > > On 20.07.202

Re: Integration problem Eclipse <> Sling 12

2023-07-20 Thread Konrad Windszus
Hi Juerg, It would help, if you can try testing the latest SNAPSHOT as outlined in https://sling.apache.org/documentation/development/ide-tooling.html#update-site-installation (there is a p2 update site at https://nightlies.apache.org/sling/eclipse/) The upcoming version has lots of issues fixed

[RESULT] [VOTE] Apache Sling Parent & Bundle Parent 52

2023-07-21 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Stefan, Robert, Dan I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 18. Jul 2023, at 14:27, Konrad Windszus wrote: > >

Re: Sling IDE Tooling 2.0 prerelease?

2023-08-30 Thread Konrad Windszus
Hi Robert, This plan sounds good to me. Let me know in case of questions related to signing: https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+-+Signing We should definitely switch to GPG signing in the midterm as that is built into Tycho (https://issues.apache.org/jira/browse/S

ASM library to parse class files?

2023-09-18 Thread Konrad Windszus
Hi, In the context of https://issues.apache.org/jira/browse/SLING-12026 I would need to parse Java class files to inspect them (on a high level only, i.e. check for implemented interfaces). I would like to use ASM for that: https://asm.ow2.io/. Its license is BSD which is compatible with ASF poli

Sling Feature Analyser: CLI

2023-09-18 Thread Konrad Windszus
Hi, Despite the fact that a CLI is mentioned in https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/master/readme.md#running-the-analyser-from-the-command-line I couldn’t find the mentioned Main class anywhere in the Git repository https://github.com/apache/sling-org-apache-sl

Re: ASM library to parse class files?

2023-10-09 Thread Konrad Windszus
ent packages). > So maybe we can add such an analyser in a separate module or at least make > the dependencies optional? > > I think it would be great to have the content package dependencies optional > as well. But that's of course a different issue. > > Regards > C

Re: jenkins builds: include javadoc:javadoc goal

2023-10-11 Thread Konrad Windszus
Hi, Makes sense to me. Can you create a PR? That should only be done though with the main OS/JDK. No need to build javadoc with every OS/JDK combination. Konrad > Am 11.10.2023 um 11:11 schrieb Stefan Seifert > : > > if often happens that releases fail due to small javadoc errors, which get >

Description in Jenkins for Sling Jobs

2023-10-17 Thread Konrad Windszus
According to https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup we leverage the https://github.com/jenkinsci/github-branch-source-plugin for automatically creating Jobs for new repos. I noticed though that new Jobs have the generic description “Apache sling” though in https:/

Re: Description in Jenkins for Sling Jobs

2023-10-17 Thread Konrad Windszus
ures#Git.asf.yamlfeatures-Repositorymetadata) I am gonna enrich our wiki page a bit to clarify that. Konrad > On 17. Oct 2023, at 16:44, Konrad Windszus wrote: > > According to > https://cwiki.apache.org/confluence/display/SLING/Sling+Jenkins+Setup we > leverage the https://github.com/jenk

Re: Please welcome Henry Kuijpers as new Sling committer

2023-10-23 Thread Konrad Windszus
Welcome Henry, Great to have you onboard. Konrad > On 20. Oct 2023, at 11:46, Stefan Seifert > wrote: > > Hi Sling community, > > Based on his ongoing and valuable contributions to the project, the > Sling PMC has elected Henry Kuijpers as a Sling committer, and he > has accepted the invitati

Re: Please welcome Roy Teeuwen as new Sling committer

2023-10-23 Thread Konrad Windszus
Welcome Roy, Great to have you onboard! Konrad > On 20. Oct 2023, at 22:19, Roy Teeuwen wrote: > > Hey all, > > The honor is all mine, thanks for welcoming me to the fold :). > > As a short intro, I can tell you that I started as an AEM developer around 10 > years ago and immediatly became

Enhanced run mode support for OSGi providers

2020-06-29 Thread Konrad Windszus
Hi, In the context of https://issues.apache.org/jira/browse/SLING-9031 and https://issues.apache.org/jira/browse/SLING-8548 I proposed a new way how artifacts/configurations can be provided run mode specific by providers (file and jcr): https://github.com/apache/sling-org-apache-sling-installer-

Re: Enhanced run mode support for OSGi providers

2020-06-29 Thread Konrad Windszus
rg-apache-sling-installer-core/pull/7/files#diff-ac0cacf223d10bbf8c8eb4204053ae92>) is exported, others may leverage the same logic. Konrad > On 29. Jun 2020, at 16:06, Robert Munteanu wrote: > > Hi Konrad, > > On Mon, 2020-06-29 at 12:46 +0200, Konrad Windszus wrote:

OSGi property "service.vendor"

2020-07-07 Thread Konrad Windszus
Hi, I am wondering if we should set the OSGi service property "service.vendor" at all for our services (https://docs.osgi.org/specification/osgi.core/7.0.0/framework.service.html#framework.service.serviceproperties

Re: OSGi property "service.vendor"

2020-07-15 Thread Konrad Windszus
Given the lack of response I would like to propose to no longer define service.vendor in our bundles. IMHO just unnecessary overhead. Please raise you voice if you don't agree Thanks, Konrad > On 7. Jul 2020, at 15:46, Konrad Windszus wrote: > > Hi, > I am wondering if we sh

Re: [VOTE] Release Apache Sling JCR Jackrabbit User Manager version 2.2.10

2020-07-27 Thread Konrad Windszus
+1 Konrad > On 26. Jul 2020, at 23:39, Eric Norman wrote: > > Hi, > > We solved 3 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12344081 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2304/ > > You can use this

Re: [VOTE] Release Apache Sling JCR Jackrabbit Access Manager version 3.0.6

2020-07-27 Thread Konrad Windszus
+1 Konrad > On 27. Jul 2020, at 00:55, Eric Norman wrote: > > Hi, > > We solved 7 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12344670 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2305/ > > You can use this

Why does Sling overwrite "org.osgi.framework.system.packages"

2020-07-27 Thread Konrad Windszus
Hi, Currently in https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26 the default property "org.osgi.framework.system.packages" from https://github.com/apache/felix-dev/blob/master/framework/src/main/resour

[VOTE] Release Apache Jackrabbit FileVault 3.4.6 & Apache Jackrabbit FileVault - Package Maven Plugin 1.1.4

2020-07-28 Thread Konrad Windszus
Hi, A candidate for the Jackrabbit FileVault 3.4.6 release is available at: https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.6/ The release candidate is a zip archive of the sources in: https://github.com/apache/jackrabbit-filevault/tree/jackrabbit-filevault-3.4.6 The SHA1 checksu

Re: Why does Sling overwrite "org.osgi.framework.system.packages"

2020-07-28 Thread Konrad Windszus
s anymore. The framework is calculating the packages > based on the available modules for Java 9+. I don't know the details though :) > > Regards > Carsten > > Am 28.07.2020 um 07:10 schrieb Konrad Windszus: >> Hi, >> Currently in >> https://github.com/apa

Re: [VOTE] Release Apache Jackrabbit FileVault 3.4.6 & Apache Jackrabbit FileVault - Package Maven Plugin 1.1.4

2020-07-28 Thread Konrad Windszus
Please ignore, wrong mailing list :-) > On 28. Jul 2020, at 11:13, Konrad Windszus wrote: > > Hi, > > A candidate for the Jackrabbit FileVault 3.4.6 release is available at: > https://dist.apache.org/repos/dist/dev/jackrabbit/filevault/3.4.6/ > > The release candidate

[VOTE] Release Apache Sling Settings 1.4.0, File Installer 1.3.0 and JCR Installer 3.3.0

2020-07-30 Thread Konrad Windszus
Hi, We solved some issues in these releases: Settings: https://issues.apache.org/jira/projects/SLING/versions/12344046 Installer JCR Provider: https://issues.apache.org/jira/projects/SLING/versions/12348454 Installer File Provider: https://issues.apache.org/jira/projects/SLING/versions/12348453

Re: [VOTE] Release Apache Sling Feature Model 1.2.6, Analysers 1.3.6 and Slingfeature Maven Plugin 1.3.14

2020-07-30 Thread Konrad Windszus
+1 Konrad > On 30. Jul 2020, at 07:55, Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in the feature model > https://issues.apache.org/jira/projects/SLING/versions/12348589 > > Two issues in the analysers > https://issues.apache.org/jira/projects/SLING/versions/12348614 > > and three

Bootstrapping of new Jenkins Multibranch Jobs

2020-07-30 Thread Konrad Windszus
Hi, In the context of https://issues.apache.org/jira/browse/SLING-9594 I am currently trying to figure out how new multibranch build jobs are created for new repos. Unfortunately I fail to see it in https://cwiki.apache.org/confluence/display/S

[RESULT] [VOTE] Release Apache Sling Settings 1.4.0, File Installer 1.3.0 and JCR Installer 3.3.0

2020-08-02 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Carsten, Nicolas, Dan +1 (non binding): Andy I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks, Konrad

Sling Settings 1.4.0 not resolvable against Felix SCR 2.1.20

2020-08-03 Thread Konrad Windszus
Hi, When trying to start Sling Starter 12 with Sling Settings 1.4.0 the following error is logged 03.08.2020 09:59:27.402 *ERROR* [FelixStartLevel] ERROR: Bundle '6' Error starting slinginstall:org.apache.sling.settings-1.4.0.jar (org.osgi.framework.BundleException: Unable to resolve org.apach

Re: Sling Settings 1.4.0 not resolvable against Felix SCR 2.1.20

2020-08-03 Thread Konrad Windszus
Nevermind, this is just a start level issue. We must start SCR first now after https://issues.apache.org/jira/browse/SLING-9561 <https://issues.apache.org/jira/browse/SLING-9561> > On 3. Aug 2020, at 10:17, Konrad Windszus wrote: > > Hi, > When trying to start Sling Sta

Re: Bootstrapping of new Jenkins Multibranch Jobs

2020-08-03 Thread Konrad Windszus
4, Robert Munteanu wrote: > > Hi Konrad, > > On Thu, 2020-07-30 at 15:33 +0200, Konrad Windszus wrote: >> Hi, >> In the context of https://issues.apache.org/jira/browse/SLING-9594 < >> https://issues.apache.org/jira/browse/SLING-9594> I am currently >> tryi

Re: Sling Starter switched to the Feature Model

2020-08-05 Thread Konrad Windszus
Thanks a lot Robert, looks great at first glance. Konrad > On 5. Aug 2020, at 19:35, Robert Munteanu wrote: > > Hi, > > With the merge of the two PRs for the Sling Starter [1] and Launchpad- > Testing [2] the Sling starter is now switched to the feature model. > > This completes Phase 2, as de

Re: New committer setup

2020-08-13 Thread Konrad Windszus
Looks good, should we link from https://sling.apache.org/documentation/development.html or even move that to the site? > On 13. Aug 2020, at 09:18, Robert Munteanu wrote: > > Hi, > > I wrote down a couple of items hopefully useful for

Re: New committer setup

2020-08-17 Thread Konrad Windszus
ite/commit/144fa82c012006525cbf769a86f629ccc527a167>. That is IMHO enough. Sorry for the noise. Konrad > On 17. Aug 2020, at 10:22, Robert Munteanu wrote: > > On Thu, 2020-08-13 at 17:19 +0200, Konrad Windszus wrote: >> Looks good, should we link from >> https://sli

Re: [DISCUSS] Automatic Mapping of URIs in HTL

2020-09-11 Thread Konrad Windszus
+1 for a dedicated option. Not sure about the naming though. Konrad > Am 11.09.2020 um 14:07 schrieb Radu Cotescu : > > Hi Georg, > >> On 11 Sep 2020, at 01:09, Georg Henzler wrote: >> >> Hi all, >> >> as briefly mentioned in the thread about the resource >> mapping SPI [1], it would be real

Re: Jira version names vs Maven module names

2020-09-22 Thread Konrad Windszus
I would also personally prefer artifact id instead of name in JIRA. But the majority of version names in JIRA is right now named after the artifact name (https://issues.apache.org/jira/projects/SLING?selectedItem=com.atlassian.jira.jira-projects-plugin%3Arelease-page&status=released). Also our r

Re: Jira version names vs Maven module names

2020-09-22 Thread Konrad Windszus
't have any problem with this for years, and I don't understand >> why a new tool developed by ourselves should force us now to change >> things. Why can't the tool simply look for both, id and name - and we're >> done with this? >> >> Regards >>

Re: [VOTE] Release Apache Sling API 2.23.0

2020-09-24 Thread Konrad Windszus
+1 Konrad > On 23. Sep 2020, at 20:58, Georg Henzler wrote: > > Hi all, > > We solved 6 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12346965 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2338 > > You can use t

Re: Jira version names vs Maven module names

2020-09-24 Thread Konrad Windszus
On 24. Sep 2020, at 11:58, Robert Munteanu wrote: > > We created Jira versions in the form of 'Artifact Name' 'Version' for > quite some time, only one of them stands out by being different. Just a > note, not something bad by itself. I would very much appreciate consistency in the naming. This

New git repositories: sling-org-apache-sling-adapter-annotations and sling-org-apache-sling-adapter-annotations-it

2020-09-28 Thread Konrad Windszus
Hi, in the context of https://issues.apache.org/jira/browse/SLING-2938 Henry Kuijpers is contributing code in two new repositories: - for adapter annotations (based on OSGi property type annotations) - for ITs for those I propose to create the

Re: How to 'spin a release'

2020-10-19 Thread Konrad Windszus
-0400, Cris Rockwell wrote: >> Regarding >> >> >> Konrad Windszus commented on SLING-9648: >> >> Someone would need to spin a release. [~cris_rockwell] Do you want to >> give it a try? >> >> >&g

Re: How to 'spin a release'

2020-10-19 Thread Konrad Windszus
ct that by > indicating the role of the person in charge of step #4 > > Thanks > Cris > > >> On Oct 19, 2020, at 3:33 AM, Konrad Windszus wrote: >> >> Hi Cris and Robert, >> >> after doing those steps you still need to manually add your key to th

Re: [roundtable] Code coverage

2020-10-24 Thread Konrad Windszus
Hi Radu, I am wondering why we need to still generate reports for both unit and integration test separately in https://github.com/apache/sling-parent/blob/3e7b3edb7411440b6a5dcd4836da2c45f4cc7166/sling-parent/pom.xml#L509

Re: [VOTE] Release Apache Sling Content Package Archetype 1.0.0

2020-11-06 Thread Konrad Windszus
Sorry I haven't checked the code up till now. Some questions/remarks: 1. Why filevault-package-maven-plugin 1.1.2 and not the latest version 1.1.4? 2. It is using a mixed package (mutable/potentially immutable content), why do we propose that instead of a clear separation with three different mod

Re: [VOTE] Release Apache Sling Settings 1.4.2

2020-11-09 Thread Konrad Windszus
+1 Konrad > On 7. Nov 2020, at 13:04, Oliver Lietz wrote: > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12348652 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2370 > > You can use this

Re: Two "adapter annotations" module, deprecate the old one?

2020-11-10 Thread Konrad Windszus
These annotations serve different purposes for details refer to https://issues.apache.org/jira/browse/SLING-2938?focusedCommentId=17196213&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17196213

Re: [VOTE] Release Sling Adapter Annotations 2.0.0

2020-11-11 Thread Konrad Windszus
+1 Konrad > On 10. Nov 2020, at 19:11, Bertrand Delacretaz wrote: > > Hi, > > This is a new module, at > https://github.com/apache/sling-org-apache-sling-adapter-annotations > > ...not to be confused with the older > https://github.com/apache/sling-adapter-annotations module, which I > have re

Re: [Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #52 is BROKEN

2020-11-11 Thread Konrad Windszus
This is again the issue described in https://github.com/bndtools/bnd/issues/4125#issuecomment-691707488 . The metadata of staxex is again corrupt on Maven Central. I opened https://issues.sonatype.org/browse/MVNCENTRAL-6303

Feedback on SLING-9883

2020-11-13 Thread Konrad Windszus
Hi everyone, I would like to gather some feedback on https://issues.apache.org/jira/browse/SLING-9883 . I already provided a draft PR (lacking tests for now) in https://github.com/apache/sling-slingfeature-maven-plugin/pull/59

[VOTE] Release Apache Sling JCR WebConsole Bundle 1.1.0

2020-12-01 Thread Konrad Windszus
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12328688 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2384/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apach

[RESULT] [VOTE] Release Apache Sling JCR WebConsole Bundle 1.1.0

2020-12-08 Thread Konrad Windszus
Hi, The vote has passed with the following result : +1 (binding): Stefan, Carsten, Nicolas, Dan I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Konrad > On 1. Dec 2020, at 14:10, Konrad Windszus wrote: > > Hi, >

Re: Error in test execution for org-apache-sling-jcr-resource

2020-12-18 Thread Konrad Windszus
Please try to update to sling-bundle-parent 40 in https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/pom.xml . That should allow to build with Java 11. > On 18. Dec 2020, at 09:52, Miroslav

Re: Ianal Maven Plugin?

2020-12-27 Thread Konrad Windszus
+0200, Bertrand Delacretaz wrote: >> On Tue, May 5, 2020 at 6:21 PM Konrad Windszus >> wrote: >>> ...interesting finding but unfortunately last updated in 2008 >>> ( >>> https://search.maven.org/artifact/org.apache.geronimo.genesis.plugins/tools-maven-plug

<    1   2   3   4   5   6   7   8   9   10   >