Re: Solr 9.1.1 bugfix release

2023-01-12 Thread Gus Heck
Ok false alarm I think missed updating the separate solr-test-framework line in my build (need to parameterize that version or something), I have other problems with the upgrade now such as import org.apache.lucene.util.QuickPatchThreadsFilter going away, but the class def problem disappeared On

Re: Solr 9.1.1 bugfix release

2023-01-12 Thread Gus Heck
I might be finding something. I just tried upgrading JesterJ to 9.1 from 9.0 and got org/apache/lucene/codecs/lucene90/Lucene90Codec java.lang.NoClassDefFoundError: org/apache/lucene/codecs/lucene90/Lucene90Codec at org.apache.lucene.util.LuceneTestCase.(LuceneTestCase.java:663) at

Re: Solr 9.1.1 bugfix release

2023-01-10 Thread Ishan Chattopadhyaya
You're good to go, Michael. Wish you all the best! On Wed, Jan 11, 2023 at 1:28 AM Michael Gibney wrote: > > Great, thanks Alessandro! Once I get the go-ahead from Ishan that he's > done wrapping up the loose ends from the 9.1.0 release, I'll build an > RC based on

Re: Solr 9.1.1 bugfix release

2023-01-10 Thread Michael Gibney
Great, thanks Alessandro! Once I get the go-ahead from Ishan that he's done wrapping up the loose ends from the 9.1.0 release, I'll build an RC based on 2c669fe43777342758a0042b821efb6aa3ec15b6. Michael On Tue, Jan 10, 2023 at 12:47 PM Alessandro Benedetti wrote: > > From my side I merged

Re: Solr 9.1.1 bugfix release

2023-01-10 Thread Alessandro Benedetti
>From my side I merged everything and I am monitoring Jenkins! On Mon, 9 Jan 2023, 10:08 Alessandro Benedetti, wrote: > Hi Michael, yes! Doing it right now! > > Cheers > -- > *Alessandro Benedetti* > Director @ Sease Ltd. > *Apache Lucene/Solr Committer* > *Apache Solr

Re: Solr 9.1.1 bugfix release

2023-01-09 Thread Alessandro Benedetti
Hi Michael, yes! Doing it right now! Cheers -- *Alessandro Benedetti* Director @ Sease Ltd. *Apache Lucene/Solr Committer* *Apache Solr PMC Member* e-mail: a.benede...@sease.io *Sease* - Information Retrieval Applied Consulting | Training | Open Source Website:

Re: Solr 9.1.1 bugfix release

2023-01-06 Thread Michael Gibney
Alessandro, are you still looking to include the SOLR-16588 bugfix? Ishan, any updates on the handful of tasks that you had mentioned were still outstanding from the 9.1.0 release? Aside from these two open questions, it looks like branch_9_1 has settled down with all of the changes we had

Re: Solr 9.1.1 bugfix release

2023-01-05 Thread Alessandro Benedetti
discussing on the PR, once clarified a bit around Lucene94 (and a backport to Lucene 9.3 ad hoc for 9.1.1) we should be ready to merge and cherry pick! -- *Alessandro Benedetti* Director @ Sease Ltd. *Apache Lucene/Solr Committer* *Apache Solr PMC Member* e-mail:

Re: Solr 9.1.1 bugfix release

2023-01-04 Thread Michael Gibney
This seems fine to me, assuming no objections from others. On Wed, Jan 4, 2023 at 4:30 PM Alessandro Benedetti wrote: > > What about including this as well in 9.1.1 : > https://github.com/apache/solr/pull/1255 ? > It's an annoying neural search bug, and it's pretty much done, just waiting > for

Re: Solr 9.1.1 bugfix release

2023-01-04 Thread Alessandro Benedetti
What about including this as well in 9.1.1 : https://github.com/apache/solr/pull/1255 ? It's an annoying neural search bug, and it's pretty much done, just waiting for a few checks and then I'll merge it with the changes! -- *Alessandro Benedetti* Director @ Sease Ltd.

Re: Solr 9.1.1 bugfix release

2023-01-03 Thread Shawn Heisey
On 1/3/23 08:05, Michael Gibney wrote: and possibly upgrade to Lucene 9.4 https://issues.apache.org/jira/browse/SOLR-16442 particularly considering: https://github.com/apache/lucene/pull/11718 It seems like a bad idea to upgrade a critical component to a new major or minor version in a bugfix

Re: Solr 9.1.1 bugfix release

2023-01-03 Thread Michael Gibney
Thanks! Agreed wrt 9.2 soon w/ Lucene upgrade; but to be explicit: the SlotAcc deadlock in particular can be addressed in 9.1.1 (by backporting SOLR-16165). The analyzer SPI deadlock (requires Lucene 9.4) is separate. On Tue, Jan 3, 2023 at 11:02 AM Ishan Chattopadhyaya wrote: > > The slot

Re: Solr 9.1.1 bugfix release

2023-01-03 Thread Ishan Chattopadhyaya
The slot accumulator deadlocks make a good case for doing a 9.2 soon (with the Lucene upgrade). On Tue, Jan 3, 2023 at 9:30 PM Ishan Chattopadhyaya wrote: > > +1 to SOLR-16165. > Let's not do a Lucene upgrade in a bugfix release. > > I have some pending steps from the post release of 9.1, I'll

Re: Solr 9.1.1 bugfix release

2023-01-03 Thread Ishan Chattopadhyaya
+1 to SOLR-16165. Let's not do a Lucene upgrade in a bugfix release. I have some pending steps from the post release of 9.1, I'll complete them in another 48-72 hours. Sorry about the delay. On Tue, Jan 3, 2023 at 9:16 PM David Smiley wrote: > > +1. Don't add a Lucene upgrade though :-) > > ~

Re: Solr 9.1.1 bugfix release

2023-01-03 Thread David Smiley
+1. Don't add a Lucene upgrade though :-) ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Tue, Jan 3, 2023 at 10:05 AM Michael Gibney wrote: > Wondering what folks think of backporting some classloading > deadlock-related fixes: >

Re: Solr 9.1.1 bugfix release

2023-01-03 Thread Michael Gibney
Wondering what folks think of backporting some classloading deadlock-related fixes: https://issues.apache.org/jira/browse/SOLR-16165 and possibly upgrade to Lucene 9.4 https://issues.apache.org/jira/browse/SOLR-16442 particularly considering: https://github.com/apache/lucene/pull/11718 The main

Re: Solr 9.1.1 bugfix release

2022-12-30 Thread David Smiley
Still looking for a PR approval for the protobuf upgrade: https://github.com/apache/solr/pull/1252

Re: Solr 9.1.1 bugfix release

2022-12-29 Thread Alessandro Benedetti
There's this one I would like to include: https://github.com/apache/solr/pull/1245 It's almost ready! -- *Alessandro Benedetti* Director @ Sease Ltd. *Apache Lucene/Solr Committer* *Apache Solr PMC Member* e-mail: a.benede...@sease.io *Sease* - Information Retrieval

Re: Solr 9.1.1 bugfix release

2022-12-26 Thread David Smiley
More specifically: SOLR-16443: Upgrade Jackson bom to 2.13.4.20221013 (#1106) SOLR-16568: Update FasterXML Woodstox to 6.4.0 (#1209) I will push those cherry-picks tonight after my local build succeeds. And I created a new JIRA issue for Protobuf: https://issues.apache.org/jira/browse/SOLR-16598

Re: Solr 9.1.1 bugfix release

2022-12-23 Thread David Smiley
Thanks for volunteering! I'd like to propose that the upgrades to dependencies due to CVEs be back-ported to 9.1.1. I can help with this. One example I see is woodstox-core. ~ David Smiley Apache Lucene/Solr Search Developer http://www.linkedin.com/in/davidwsmiley On Thu, Dec 22, 2022 at

Re: Solr 9.1.1 bugfix release

2022-12-22 Thread Ishan Chattopadhyaya
Thanks for volunteering, Michael. On Thu, 22 Dec, 2022, 8:14 pm Michael Gibney, wrote: > I'd like to get the ball rolling on a 9.1.1 bugfix release, and > volunteer to be release manager. There aren't very many bugfixes > accumulated since 9.1.0 on `branch_9_1`, but SOLR-16585 in particular >

Solr 9.1.1 bugfix release

2022-12-22 Thread Michael Gibney
I'd like to get the ball rolling on a 9.1.1 bugfix release, and volunteer to be release manager. There aren't very many bugfixes accumulated since 9.1.0 on `branch_9_1`, but SOLR-16585 in particular (NPE on MatchAllDocs pagination) should be fixed asap. I'm thinking to build a release candidate