Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/461#issuecomment-78291337
+1, but since some of the code came from me another committer is going to
need to give a +1 too.
---
If your project is set up for it, you can reply to this email and
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/458#discussion_r26232936
--- Diff: external/storm-jdbc/README.md ---
@@ -38,34 +63,30 @@ hikariConfigMap.put(dataSource.password,password);
String tableName =
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/458#discussion_r26232904
--- Diff: external/storm-jdbc/README.md ---
@@ -13,14 +13,39 @@ public interface JdbcMapper extends Serializable {
}
```
-The
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/414#discussion_r26230152
--- Diff: storm-core/src/jvm/backtype/storm/serialization/Test.java ---
@@ -0,0 +1,17 @@
+package backtype.storm.serialization;
--- End diff --
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/414#discussion_r26230947
--- Diff: storm-core/src/storm.thrift ---
@@ -193,6 +193,7 @@ struct ExecutorStats {
1: required mapstring, mapstring, i64 emitted;
2: required
[
https://issues.apache.org/jira/browse/STORM-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357222#comment-14357222
]
ASF GitHub Bot commented on STORM-699:
--
Github user Parth-Brahmbhatt commented on a
[
https://issues.apache.org/jira/browse/STORM-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357224#comment-14357224
]
ASF GitHub Bot commented on STORM-699:
--
Github user Parth-Brahmbhatt commented on a
[
https://issues.apache.org/jira/browse/STORM-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357074#comment-14357074
]
ASF GitHub Bot commented on STORM-689:
--
Github user harshach commented on the pull
[
https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357159#comment-14357159
]
ASF GitHub Bot commented on STORM-634:
--
Github user revans2 commented on a diff in the
[
https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357183#comment-14357183
]
ASF GitHub Bot commented on STORM-634:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/444#issuecomment-78366813
The change looks fine to me +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357578#comment-14357578
]
ASF GitHub Bot commented on STORM-669:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriharsha Chintalapani resolved STORM-539.
--
Resolution: Fixed
Storm hive bolt and trident state
Sorry for the late reply. I am +1 on releasing 0.9.4 . For 0.10.0 I would like
to include this https://issues.apache.org/jira/browse/STORM-617
Thanks,
Harsha
On March 11, 2015 at 1:52:02 PM, P. Taylor Goetz (ptgo...@gmail.com) wrote:
Sorry for the late reply. I am +1 on releasing 0.9.4 . For
[
https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-657.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~caofangkun],
I merged this
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357580#comment-14357580
]
ASF GitHub Bot commented on STORM-669:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rick Kellogg closed STORM-693.
--
Resolution: Fixed
Fix Version/s: 0.9.4
Confirmed change is within master branch.
KafkaBolt
[
https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357505#comment-14357505
]
ASF GitHub Bot commented on STORM-634:
--
Github user Parth-Brahmbhatt commented on a
[
https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357511#comment-14357511
]
ASF GitHub Bot commented on STORM-634:
--
Github user Parth-Brahmbhatt commented on a
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/414#discussion_r26250794
--- Diff: storm-core/src/storm.thrift ---
@@ -243,6 +244,55 @@ struct SubmitOptions {
2: optional Credentials creds;
}
+struct
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/424#issuecomment-78363934
+1 looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-669.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks again [~lewuathe],
I merged
[
https://issues.apache.org/jira/browse/STORM-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357654#comment-14357654
]
ASF GitHub Bot commented on STORM-670:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/431#issuecomment-78377210
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/STORM-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357658#comment-14357658
]
ASF GitHub Bot commented on STORM-670:
--
Github user asfgit closed the pull request at:
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/414#discussion_r26250717
--- Diff: storm-core/src/jvm/backtype/storm/serialization/Test.java ---
@@ -0,0 +1,17 @@
+package backtype.storm.serialization;
--- End diff
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/425#issuecomment-78368904
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357499#comment-14357499
]
ASF GitHub Bot commented on STORM-657:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357494#comment-14357494
]
ASF GitHub Bot commented on STORM-657:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-663.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~lewuathe],
I merged this into
[
https://issues.apache.org/jira/browse/STORM-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357530#comment-14357530
]
ASF GitHub Bot commented on STORM-663:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357531#comment-14357531
]
ASF GitHub Bot commented on STORM-663:
--
Github user revans2 commented on the pull
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357257#comment-14357257
]
ASF GitHub Bot commented on STORM-681:
--
Github user revans2 commented on a diff in the
[
https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-469.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~rekhajoshm],
I merged your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/296#issuecomment-78341357
For the most part it seems fine. My manual attempts to kill workers all
are foiled very quickly, but I would like to not have the supervisor be so
noisy with the ps
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357570#comment-14357570
]
ASF GitHub Bot commented on STORM-690:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357563#comment-14357563
]
ASF GitHub Bot commented on STORM-690:
--
Github user revans2 commented on the pull
Thanks for the feedback Richard, Parth, and Jungtaek. I’ve made a note of your
suggestions for the releases.
Does anyone else have any thoughts (esp. committers)? Should we move forward
with releasing?
-Taylor
On Mar 5, 2015, at 5:00 PM, 임정택 kabh...@gmail.com wrote:
storm-redis (scheduled
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/396#issuecomment-78343992
I'm not convinced having the PID on the UI is really that helpful, but it
does provide more information for possible automation or monitoring, so I am OK
with it.
---
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/363#issuecomment-78316822
This is technically a non-backwards compatible change, but I think it is
OK. I am +1.
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357342#comment-14357342
]
ASF GitHub Bot commented on STORM-532:
--
Github user revans2 commented on a diff in the
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357381#comment-14357381
]
ASF GitHub Bot commented on STORM-638:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357254#comment-14357254
]
ASF GitHub Bot commented on STORM-634:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/436#issuecomment-78316257
I just had the one comment. As for the date in the generated files I see
two options.
1) We remove it with a sed script. It is optional, and thrift is not
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/388#issuecomment-78327431
+1 I think the change is a good start to this problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r26240829
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -392,6 +392,15 @@
(.addArgument command a))
(.execute (DefaultExecutor.)
[
https://issues.apache.org/jira/browse/STORM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357273#comment-14357273
]
ASF GitHub Bot commented on STORM-596:
--
Github user revans2 commented on the pull
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/396#discussion_r26242669
--- Diff: storm-core/src/storm.thrift ---
@@ -205,7 +205,8 @@ struct ExecutorSummary {
2: required string component_id;
3: required string host;
[
https://issues.apache.org/jira/browse/STORM-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357268#comment-14357268
]
ASF GitHub Bot commented on STORM-681:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357311#comment-14357311
]
ASF GitHub Bot commented on STORM-469:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357375#comment-14357375
]
ASF GitHub Bot commented on STORM-638:
--
Github user revans2 commented on a diff in the
[
https://issues.apache.org/jira/browse/STORM-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357442#comment-14357442
]
ASF GitHub Bot commented on STORM-638:
--
Github user harshach commented on the pull
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/414#discussion_r26234849
--- Diff:
storm-core/src/jvm/backtype/storm/serialization/DefaultSerializationDelegate.java
---
@@ -17,11 +17,7 @@
*/
package
[
https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357360#comment-14357360
]
ASF GitHub Bot commented on STORM-532:
--
Github user revans2 commented on the pull
[
https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans updated STORM-656:
--
Assignee: P. Taylor Goetz
Document external modules and Committer Sponsors
[
https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357483#comment-14357483
]
ASF GitHub Bot commented on STORM-656:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-656.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~ptgoetz],
I merged this into
[
https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357778#comment-14357778
]
ASF GitHub Bot commented on STORM-691:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/451#issuecomment-78393165
The code looks fine to me. My only comment is that it would be nice to
have a default in most of the case statements, mostly as defensive programming
so if something
[
https://issues.apache.org/jira/browse/STORM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357788#comment-14357788
]
ASF GitHub Bot commented on STORM-696:
--
Github user revans2 commented on the pull
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/450#issuecomment-78394408
Sweet!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/450
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/STORM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Joseph Evans resolved STORM-696.
---
Resolution: Fixed
Fix Version/s: 0.10.0
Thanks [~knusbaum]
Single Namespace
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/445#discussion_r26266419
--- Diff:
storm-core/src/jvm/backtype/storm/security/auth/authorizer/SimpleACLAuthorizer.java
---
@@ -96,7 +101,10 @@ public boolean permit(ReqContext
[
https://issues.apache.org/jira/browse/STORM-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357827#comment-14357827
]
ASF GitHub Bot commented on STORM-695:
--
Github user HeartSaVioR commented on the pull
Github user dkatten commented on the pull request:
https://github.com/apache/storm/pull/462#issuecomment-78397688
I'll file it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/456#issuecomment-78397516
IMHO I agree @revans2, parsing stdout by regular expression would become
easily broken by later commits.
---
If your project is set up for it, you can reply to this
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-78386437
Done, I've added the ticket number to the title. Here is the ticket:
https://issues.apache.org/jira/browse/STORM-702
---
If your project is set up for it, you can reply
[
https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357723#comment-14357723
]
ASF GitHub Bot commented on STORM-702:
--
Github user atdixon commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/463#issuecomment-78388285
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/460#issuecomment-78388527
@krichter722 thanks for the pull request, if you could remove the changes
you made to the generated thrift code the rest seems fine.
---
If your project is set up for
[
https://issues.apache.org/jira/browse/STORM-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357798#comment-14357798
]
ASF GitHub Bot commented on STORM-689:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/457#discussion_r26263810
--- Diff: bin/storm ---
@@ -82,6 +82,8 @@ CONFFILE =
JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))
JAVA_HOME =
[
https://issues.apache.org/jira/browse/STORM-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357745#comment-14357745
]
ASF GitHub Bot commented on STORM-477:
--
Github user revans2 commented on a diff in the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/445#issuecomment-78395668
Sorry it took so long for the review. It looks good, and I agree having
groups of allowed users would be a good step.
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/STORM-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357817#comment-14357817
]
ASF GitHub Bot commented on STORM-691:
--
Github user HeartSaVioR commented on the pull
Aaron Dixon created STORM-702:
-
Summary: Apache Exhibitor support
Key: STORM-702
URL: https://issues.apache.org/jira/browse/STORM-702
Project: Apache Storm
Issue Type: Improvement
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/450#issuecomment-78394267
Its a bit hacky, but it works! +++1. I'll check this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/STORM-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357837#comment-14357837
]
ASF GitHub Bot commented on STORM-703:
--
Github user dkatten commented on the pull
Github user dkatten commented on the pull request:
https://github.com/apache/storm/pull/462#issuecomment-78398611
STORM-703
https://issues.apache.org/jira/browse/STORM-703
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Dave Katten created STORM-703:
-
Summary: RedisMapState with hash key can cause network overload
Key: STORM-703
URL: https://issues.apache.org/jira/browse/STORM-703
Project: Apache Storm
Issue
caofangkun created STORM-701:
Summary: provide eclipse plugin for monitoring/debugging user
topology
Key: STORM-701
URL: https://issues.apache.org/jira/browse/STORM-701
Project: Apache Storm
[
https://issues.apache.org/jira/browse/STORM-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356723#comment-14356723
]
ASF GitHub Bot commented on STORM-695:
--
Github user miguno commented on the pull
GitHub user miguno opened a pull request:
https://github.com/apache/storm/pull/463
Client (Netty): improving logging to help troubleshooting connection woes
These logging statements are not on a hot path, and `INFO` is the default
log level of Storm. These logging are filling a
[
https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356730#comment-14356730
]
ASF GitHub Bot commented on STORM-329:
--
GitHub user miguno opened a pull request:
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/463#issuecomment-78255547
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/462#issuecomment-78390669
The change looks good to me. I am +1 for the change. @dkatten if you want
to file a JIRA under STORM at issues.apache.org that would be great. If you
would rather I can
[
https://issues.apache.org/jira/browse/STORM-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357767#comment-14357767
]
ASF GitHub Bot commented on STORM-695:
--
Github user revans2 commented on the pull
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/456#issuecomment-78392307
Why do we want to distinguish between different errors in the exit code?
I would rather see the commands themselves handle this instead of the
python code, the
[
https://issues.apache.org/jira/browse/STORM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357793#comment-14357793
]
ASF GitHub Bot commented on STORM-696:
--
Github user asfgit closed the pull request at:
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/451#issuecomment-78396550
@revans2 Thanks for reviewing! It's updated. Could you please check again?
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358034#comment-14358034
]
Aaron Dixon edited comment on STORM-702 at 3/12/15 3:02 AM:
A
Github user atdixon commented on the pull request:
https://github.com/apache/storm/pull/432#issuecomment-78415948
Note: I've added a short bit on design options and why I recommend this
implementation in a comment attached to the JIRA ticket.
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14358034#comment-14358034
]
Aaron Dixon commented on STORM-702:
---
A couple of notes on some of the code/design
1 - 100 of 102 matches
Mail list logo
