[jira] [Commented] (STORM-1081) Import json11 and gmock into the storm-sql project

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939063#comment-14939063 ] ASF GitHub Bot commented on STORM-1081: --- GitHub user haohui opened a pull request:

[GitHub] storm pull request: STORM-1081. Import json11 and gmock into the s...

2015-09-30 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/storm/pull/774 STORM-1081. Import json11 and gmock into the storm-sql project. This PR includes json11 and gmock into the storm-sql project. These two third-party libraries are going to be used in the later jiras.

[jira] [Commented] (STORM-1081) Import json11 and gmock into the storm-sql project

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939061#comment-14939061 ] ASF GitHub Bot commented on STORM-1081: --- Github user haohui closed the pull request

[GitHub] storm pull request: STORM-1081. Import json11 and gmock into the s...

2015-09-30 Thread haohui
Github user haohui closed the pull request at: https://github.com/apache/storm/pull/773 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-1081) Import json11 and gmock into the storm-sql project

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939032#comment-14939032 ] ASF GitHub Bot commented on STORM-1081: --- GitHub user haohui opened a pull request:

[GitHub] storm pull request: STORM-1081. Import json11 and gmock into the s...

2015-09-30 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/storm/pull/773 STORM-1081. Import json11 and gmock into the storm-sql project. This PR includes json11 and gmock into the storm-sql project. These two third-party libraries are going to be used in the later jiras.

[jira] [Created] (STORM-1081) Import json11 and gmock into the storm-sql project

2015-09-30 Thread Haohui Mai (JIRA)
Haohui Mai created STORM-1081: - Summary: Import json11 and gmock into the storm-sql project Key: STORM-1081 URL: https://issues.apache.org/jira/browse/STORM-1081 Project: Apache Storm Issue Type:

[jira] [Updated] (STORM-1080) Create a compiler to compile expressions down to LLVM bytecodes

2015-09-30 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated STORM-1080: -- Description: This jira tracks the effort of creating a expression compiler to compile SQL expressions d

[jira] [Created] (STORM-1080) Create a compiler to compile expressions down to LLVM bytecodes

2015-09-30 Thread Haohui Mai (JIRA)
Haohui Mai created STORM-1080: - Summary: Create a compiler to compile expressions down to LLVM bytecodes Key: STORM-1080 URL: https://issues.apache.org/jira/browse/STORM-1080 Project: Apache Storm

[jira] [Closed] (STORM-1060) Serialize Calcite plans into JSON format

2015-09-30 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai closed STORM-1060. - Resolution: Fixed Thanks [~sriharsha] for reviews and commits. > Serialize Calcite plans into JSON format

[jira] [Commented] (STORM-1079) Batch Puts to HBase

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938988#comment-14938988 ] ASF GitHub Bot commented on STORM-1079: --- Github user Parth-Brahmbhatt commented on t

[GitHub] storm pull request: STORM-1079. Batch Puts to HBase.

2015-09-30 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/772#issuecomment-144565292 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[jira] [Commented] (STORM-1033) TLP site's download link should be updated to refer closer.lua instead of closer.cgi

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938943#comment-14938943 ] ASF GitHub Bot commented on STORM-1033: --- Github user harshach commented on the pull

[GitHub] storm pull request: STORM-1033 replace closer.cgi to closer.lua

2015-09-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/771#issuecomment-144553323 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Updated] (STORM-1079) Batch Puts to HBase

2015-09-30 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated STORM-1079: -- Summary: Batch Puts to HBase (was: batch Puts to hbase table.) > Batch Puts to

[jira] [Commented] (STORM-1079) Batch Puts to HBase

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938931#comment-14938931 ] ASF GitHub Bot commented on STORM-1079: --- GitHub user harshach opened a pull request:

[GitHub] storm pull request: STORM-1079. Batch Puts to HBase.

2015-09-30 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/772 STORM-1079. Batch Puts to HBase. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-1079 Alternatively you can revi

[GitHub] storm pull request: STORM-1033 replace closer.cgi to closer.lua

2015-09-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/771#issuecomment-144550315 @revans2 It's another version of #725. Please check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[jira] [Commented] (STORM-1033) TLP site's download link should be updated to refer closer.lua instead of closer.cgi

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938927#comment-14938927 ] ASF GitHub Bot commented on STORM-1033: --- Github user HeartSaVioR commented on the pu

[jira] [Created] (STORM-1079) batch Puts to hbase table.

2015-09-30 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created STORM-1079: - Summary: batch Puts to hbase table. Key: STORM-1079 URL: https://issues.apache.org/jira/browse/STORM-1079 Project: Apache Storm Issue Type:

[jira] [Commented] (STORM-1033) TLP site's download link should be updated to refer closer.lua instead of closer.cgi

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938916#comment-14938916 ] ASF GitHub Bot commented on STORM-1033: --- GitHub user HeartSaVioR opened a pull reque

[GitHub] storm pull request: STORM-1033 replace closer.cgi to closer.lua

2015-09-30 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/storm/pull/771 STORM-1033 replace closer.cgi to closer.lua It's another version of #725, only difference is base branch. It is asf-site now. Please refer STORM-1033 or #725 to more details. You can merge t

[jira] [Commented] (STORM-1033) TLP site's download link should be updated to refer closer.lua instead of closer.cgi

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938910#comment-14938910 ] ASF GitHub Bot commented on STORM-1033: --- Github user HeartSaVioR commented on the pu

[jira] [Commented] (STORM-1033) TLP site's download link should be updated to refer closer.lua instead of closer.cgi

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938911#comment-14938911 ] ASF GitHub Bot commented on STORM-1033: --- Github user HeartSaVioR closed the pull req

[GitHub] storm pull request: STORM-1033 replace closer.cgi to closer.lua

2015-09-30 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/725#issuecomment-144547247 @revans2 No, I'm not. Since it's merged to another branch (asf-site), I'll close this PR and re-work. Thanks for reviewing. :) --- If your project is set up

[GitHub] storm pull request: STORM-1033 replace closer.cgi to closer.lua

2015-09-30 Thread HeartSaVioR
Github user HeartSaVioR closed the pull request at: https://github.com/apache/storm/pull/725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1033) TLP site's download link should be updated to refer closer.lua instead of closer.cgi

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938890#comment-14938890 ] ASF GitHub Bot commented on STORM-1033: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: STORM-1033 replace closer.cgi to closer.lua

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/725#issuecomment-144545013 +1 looks good to me. @HeartSaVioR have you ever pushed a new version of the web site out? --- If your project is set up for it, you can reply to this email and h

[jira] [Resolved] (STORM-1053) Correct storm-kafka readme file because of using new kafka-producer api

2015-09-30 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1053. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~vesense], I merged this int

[jira] [Commented] (STORM-1053) Correct storm-kafka readme file because of using new kafka-producer api

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938885#comment-14938885 ] ASF GitHub Bot commented on STORM-1053: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Updated] (STORM-1053) Correct storm-kafka readme file because of using new kafka-producer api

2015-09-30 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-1053: Summary: Correct storm-kafka readme file because of using new kafka-producer api (was: Correct storm-kafka

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/744#issuecomment-144543208 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1053) Correct storm-kafka readme file because of using new kafka-clients api

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938882#comment-14938882 ] ASF GitHub Bot commented on STORM-1053: --- Github user revans2 commented on the pull r

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938881#comment-14938881 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-144543081 Actually I thought about this a bit more and I am not sure what value this adds over dividing the emitted counts that we already have by the time window that they are for

[jira] [Commented] (STORM-1053) Correct storm-kafka readme file because of using new kafka-clients api

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938878#comment-14938878 ] ASF GitHub Bot commented on STORM-1053: --- Github user zhuoliu commented on the pull r

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-30 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/744#issuecomment-144542259 Looks good to me. The only nit is the title of this JIRA: new Kafka Producer API rather than kafka-client. the new Kafka Clients API is still in the process in STORM-

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938864#comment-14938864 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40850849 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/strategies/IStrategy.java --- @@ -0,0 +1,33 @@ +/** + * Licensed to the Apache Softwa

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938854#comment-14938854 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938850#comment-14938850 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40850542 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java --- @@ -0,0 +1,117 @@ +package backtype.storm.scheduler.resource; +

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40850487 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceUtils.java --- @@ -0,0 +1,117 @@ +package backtype.storm.scheduler.resource; -

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/753#issuecomment-144539829 @wangli1426 I am done with my first pass through the code. There may be other things in here too that I missed on the first pass. --- If your project is set up for it,

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938847#comment-14938847 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40850307 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache Sof

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938848#comment-14938848 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40850076 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -570,7 +575,11 @@ (tasks-fn

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938846#comment-14938846 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938840#comment-14938840 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40849566 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache Sof

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938837#comment-14938837 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938835#comment-14938835 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938833#comment-14938833 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40849297 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -79,11 +95,302 @@ public StormTopology getTopology() {

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938834#comment-14938834 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40849422 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -79,11 +95,302 @@ public StormTopology getTopology() {

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938836#comment-14938836 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938831#comment-14938831 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40849301 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -79,11 +95,302 @@ public StormTopology getTopology() {

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40849279 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/TopologyDetails.java --- @@ -79,11 +95,302 @@ public StormTopology getTopology() {

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40849246 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -570,7 +575,11 @@ (tasks-fn

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40849130 --- Diff: storm-core/src/jvm/backtype/storm/networktopography/AbstractDNSToSwitchMapping.java --- @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache S

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938829#comment-14938829 ] ASF GitHub Bot commented on STORM-893: -- Github user jerrypeng commented on a diff in t

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/746#discussion_r40848979 --- Diff: storm-core/src/jvm/backtype/storm/StormSubmitter.java --- @@ -442,4 +446,35 @@ public static String submitJar(Map conf, String localJar, ProgressLi

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938823#comment-14938823 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40848297 --- Diff: storm-core/src/clj/backtype/storm/stats.clj --- @@ -218,11 +220,17 @@ [stats stream amt] (update-executor-stat! stats [:common :transfer

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938817#comment-14938817 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40848077 --- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java --- @@ -72,7 +80,7 @@ public RateTracker(int validTimeWindowInMils, int numOfSlides, boolean

[jira] [Created] (STORM-1078) RateTracker.java is not thread safe

2015-09-30 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-1078: -- Summary: RateTracker.java is not thread safe Key: STORM-1078 URL: https://issues.apache.org/jira/browse/STORM-1078 Project: Apache Storm Issue Ty

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938807#comment-14938807 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40847090 --- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java --- @@ -72,7 +80,7 @@ public RateTracker(int validTimeWindowInMils, int numOfSlides, boolean

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938800#comment-14938800 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40846514 --- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java --- @@ -60,6 +65,9 @@ public RateTracker(int validTimeWindowInMils, int numOfSlides, boolean

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938798#comment-14938798 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40846293 --- Diff: storm-core/src/jvm/backtype/storm/utils/RateTracker.java --- @@ -87,7 +95,7 @@ public final float reportRate() { sum += _histograms[i

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938796#comment-14938796 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40846081 --- Diff: storm-core/src/ui/public/js/visualization.js --- @@ -127,13 +127,13 @@ function renderGraph(elem) { }

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40846010 --- Diff: storm-core/src/storm.thrift --- @@ -204,6 +203,7 @@ struct ExecutorStats { 2: required map> transferred; 3: required ExecutorSpecificSta

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938793#comment-14938793 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938786#comment-14938786 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40845541 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -663,8 +673,9 @@ (reset! last-active true)

[GitHub] storm pull request: [STORM-1057] Add throughput metrics to spouts/...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/753#discussion_r40845429 --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj --- @@ -550,14 +553,16 @@ has-ackers? (has-ackers? storm-conf) has-eve

[jira] [Commented] (STORM-1057) Add throughput metric to spout/bolt and display them on web ui

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938784#comment-14938784 ] ASF GitHub Bot commented on STORM-1057: --- Github user revans2 commented on a diff in

[jira] [Resolved] (STORM-1058) create CLI kill_workers to kill workers on a supervisor node

2015-09-30 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1058. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~zhuoliu], I merged this int

[jira] [Commented] (STORM-1058) create CLI kill_workers to kill workers on a supervisor node

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938778#comment-14938778 ] ASF GitHub Bot commented on STORM-1058: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...

2015-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/756 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-1058) create CLI kill_workers to kill workers on a supervisor node

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938761#comment-14938761 ] ASF GitHub Bot commented on STORM-1058: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1058] create CLI kill_workers to kill w...

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/756#issuecomment-144522660 +1 looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: advance kafka offset when deserializer yields ...

2015-09-30 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/758#discussion_r40843072 --- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java --- @@ -136,15 +136,15 @@ public EmitState next(SpoutOutputCollector collector) {

[jira] [Resolved] (STORM-1063) Workers cannot find log4j configuration files since default value of storm.log4j2.conf.dir is relative

2015-09-30 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1063. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~zhuoliu], I merged this int

[jira] [Commented] (STORM-1063) Workers cannot find log4j configuration files since default value of storm.log4j2.conf.dir is relative

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938748#comment-14938748 ] ASF GitHub Bot commented on STORM-1063: --- Github user asfgit closed the pull request

[GitHub] storm pull request: [STORM-1063] support relative log4j conf dir f...

2015-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/760 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-1066) Specify current directory when supervisor launches a worker

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938340#comment-14938340 ] ASF GitHub Bot commented on STORM-1066: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1066] add current directory for worker ...

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/769#issuecomment-144515204 +1 looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] storm pull request: Modified .ignore file

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/770#issuecomment-144514881 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938332#comment-14938332 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-893] Resource Aware Scheduling

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/746#issuecomment-144514012 @jerrypeng for the most part the code looks really good. I would mostly just like to see a lot of the debug logging turned into LOG.debug instead of LOG.info statements.

[jira] [Commented] (STORM-893) Resource Aware Scheduling

2015-09-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938320#comment-14938320 ] ASF GitHub Bot commented on STORM-893: -- Github user revans2 commented on a diff in the

  1   2   >