Re: [VOTE] Release Apache Storm 1.0.4 (rc1)

+1 (binding) > source - verify file (signature, MD5, SHA) -- source, tar.gz : OK -- source, zip : OK - extract file -- source, tar.gz : OK -- source, zip : OK - diff-ing extracted files between tar.gz and zip : OK - build source with JDK 7 -- source, tar.gz : OK - build source

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2241 @HeartSaVioR I don't mind breaking this into multiple PRs if it helps reviewing and merging in. Its up to @roshannaik . --- If your project is set up for it, you can reply to this email and have

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 @harshach As I commented multiple times, this patch is mixed up of replacing queue, changing message subsystem, and micro-optimization. Three committers already had a look at the first pass

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2241 @HeartSaVioR lets keep this discussion to reviews. This is not forum to discuss what one should tweet or not that's up to individuals. Nobody is trying to promote something that's not feasible lets

[GitHub] storm issue #2240: [STORM-2657] Update SECURITY.MD

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2240 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129736861 --- Diff: storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java --- @@ -43,43 +45,59 @@ private static final Logger

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129736631 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129736497 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -635,14 +594,13 @@ public static boolean

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129736199 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -269,11 +263,9 @@ public WorkerState(Map conf,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129736039 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -155,134 +150,141 @@ public void start() throws Exception {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129735181 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java --- @@ -122,28 +130,33 @@ public Task(Executor executor, Integer taskId) throws

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129734715 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -574,13 +536,21 @@ public static final String

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129734383 --- Diff: storm-client/pom.xml --- @@ -106,10 +106,11 @@ commons-collections - +

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129734343 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/bolt/KafkaBoltTest.java --- @@ -293,7 +293,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129734072 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/PartitionManagerTest.java --- @@ -238,6 +238,10 @@ public void emitDirect(int taskId,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129733902 --- Diff: external/storm-hive/src/test/java/org/apache/storm/hive/bolt/TestHiveBolt.java --- @@ -451,7 +451,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129733914 --- Diff: external/storm-hive/src/test/java/org/apache/storm/hive/common/TestHiveWriter.java --- @@ -168,7 +168,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129733748 --- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestSequenceFileBolt.java --- @@ -165,7 +165,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129733708 --- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestHdfsBolt.java --- @@ -247,7 +247,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129733449 --- Diff: external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java --- @@ -69,7 +69,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129733454 --- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java --- @@ -224,7 +224,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129732524 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer"

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129732345 --- Diff: examples/storm-perf/pom.xml --- @@ -81,7 +81,7 @@ maven-checkstyle-plugin -

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129731553 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer"

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129730577 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129730510 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129730321 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129729875 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129729641 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129729086 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129728553 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer"

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129728132 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129727744 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer"

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129726539 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer"

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129726126 --- Diff: conf/defaults.yaml --- @@ -49,6 +49,9 @@ storm.nimbus.retry.times: 5 storm.nimbus.retry.interval.millis: 2000

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129725525 --- Diff: conf/defaults.yaml --- @@ -231,16 +228,13 @@ topology.multilang.serializer: "org.apache.storm.multilang.JsonSerializer"

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 From now what I can suggest is... breaking down STORM-2306 to "redesign messaging subsystem" and "switch to JCTools Queues", and try out latter part first. Let's just have new pull request

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 First of all, I think I should be more careful about like / retweet. Sorry about that and just reverted all. Regarding tweet, I think it heavily depends on which accounts (who) tweet

[GitHub] storm pull request #2224: STORM-2640: Deprecate KafkaConsumer.subscribe API ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.1 (rc1)

Sure, no problem. -Taylor > On Jul 26, 2017, at 3:45 PM, Stig Rohde Døssing > wrote: > > Taylor can you wait 2-3 minutes, I'd like to merge > https://github.com/apache/storm/pull/2244 in if you're making a new RC > anyway? > > 2017-07-26 21:34 GMT+02:00 P. Taylor

[GitHub] storm pull request #2244: STORM-2659: Add daemon.name variable to storm.cmd ...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [CANCELED] [VOTE] Release Apache Storm 1.1.1 (rc1)

Taylor can you wait 2-3 minutes, I'd like to merge https://github.com/apache/storm/pull/2244 in if you're making a new RC anyway? 2017-07-26 21:34 GMT+02:00 P. Taylor Goetz : > Canceling per discussion. > > -Taylor > > > On Jul 25, 2017, at 11:09 AM, P. Taylor Goetz

[CANCELED] [VOTE] Release Apache Storm 1.1.1 (rc1)

Canceling per discussion. -Taylor > On Jul 25, 2017, at 11:09 AM, P. Taylor Goetz wrote: > > This is a call to vote on releasing Apache Storm 1.1.1 (rc1) > > Full list of changes in this release: > >

Re: [VOTE] Release Apache Storm 1.1.1 (rc1)

Fair enough. I’ll apply the patches I have in mind to 1.1.x-branch and spin up a new release candidate. -Taylor > On Jul 26, 2017, at 2:24 AM, Jungtaek Lim wrote: > > Replying inline. My only concern is about semantic versioning. If we don't > change the version of

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129139943 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129663556 --- Diff: storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -102,6 +109,18 @@ private int getMaxSpoutPending(Map

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129109566 --- Diff: docs/Windowing.md --- @@ -266,3 +266,105 @@ tuples can be received within the timeout period. An example toplogy `SlidingWindowTopology` shows

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129655963 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -30,20 +30,20 @@ /** * Invokes {@link

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129109828 --- Diff: docs/Windowing.md --- @@ -266,3 +266,105 @@ tuples can be received within the timeout period. An example toplogy `SlidingWindowTopology` shows

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129652453 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129121999 --- Diff: storm-client/src/jvm/org/apache/storm/topology/IStatefulWindowedBolt.java --- @@ -15,12 +15,33 @@ * See the License for the specific language

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129652806 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129140797 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129113343 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/PersistentWindowingTopology.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129644551 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129665587 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TupleWindowIterImpl.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129109980 --- Diff: docs/Windowing.md --- @@ -266,3 +266,105 @@ tuples can be received within the timeout period. An example toplogy `SlidingWindowTopology` shows

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129651528 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129647014 --- Diff: storm-client/src/jvm/org/apache/storm/topology/SimpleWindowPartitionCache.java --- @@ -0,0 +1,191 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129662087 --- Diff: storm-client/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -127,26 +154,30 @@ private void validate(Map

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129111624 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/PersistentWindowingTopology.java --- @@ -0,0 +1,176 @@ +/* + * Licensed to the

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129643650 --- Diff: storm-client/src/jvm/org/apache/storm/topology/PersistentWindowedBoltExecutor.java --- @@ -0,0 +1,563 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2218: STORM-2614: Enhance stateful windowing to persist ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2218#discussion_r129110774 --- Diff: docs/Windowing.md --- @@ -266,3 +266,105 @@ tuples can be received within the timeout period. An example toplogy `SlidingWindowTopology` shows

Re: Setting heap size parameters by workers.childopts and supervisor.childopts

worker.childops is the default value that is set by the system administrator in storm.yaml on each of the supervisor nodes.  topology.worker.childopts is what you set in your topology conf if you want to add something more to the command line. - Bobby On Tuesday, July 25, 2017, 11:50:04 PM

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 @harshach I am running with defaults in all cases I build `mvn clean install -DskipTests` package `cd storm-dist/binary; mvn clean package` untar the result `tar -xzvf

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2241 @revans2 Do you mind posting your storm.yaml or are you running with defaults. We will try to see if we can reproduce this same behavior on our side. If there are any bugs we will work to fix it

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 I tried on Linux too and got very similar results. The CPU and memory usage of the topology was lower but the actual throughput and latency of the topology was very similar. --- If your project

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 I ran again with this exact version (5c0db923ecd8e4e1ce0e325ee2fd0f25bae7b0c2) and got the same results. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129566713 --- Diff: examples/storm-perf/src/main/java/org/apache/storm/perf/ConstSpoutIdBoltNullBoltTopo.java --- @@ -76,6 +76,8 @@ public static StormTopology

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129572370 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -155,134 +150,141 @@ public void start() throws Exception {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129572655 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -227,23 +223,15 @@ public LoadMapping getLoadMapping() {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129572400 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -155,134 +150,141 @@ public void start() throws Exception {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129569091 --- Diff: storm-client/src/jvm/org/apache/storm/Config.java --- @@ -548,22 +518,14 @@ public static final String

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129572165 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java --- @@ -155,134 +150,141 @@ public void start() throws Exception {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129569852 --- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java --- @@ -97,6 +97,8 @@ public void run() { // events.

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129571007 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java --- @@ -122,28 +130,33 @@ public Task(Executor executor, Integer taskId) throws IOException

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129566289 --- Diff: conf/defaults.yaml --- @@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500 topology.testing.always.try.serialize: false

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 -1 Perhaps I am running into some odd issues here so if I can be corrected I would be happy to change my vote, but nothing I have run with this patch is better in any way. Are all of the

I encountered an old problem "stormconf.ser' does not exist" with latest storm version 1.1.0

I learned that the problem has been fixed in Storm 0.9.4, but now I encountered the problem in 1.1.0The trace as follow err.log Description: Binary data

[GitHub] storm issue #2242: [STORM-1347] display topology version on UI

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2242 Thanks for review @HeartSaVioR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2239 @revans2 You're right. Let's postpone until someone raises an issue once more. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2239 @HeartSaVioR the biggest issue with addressing this on the 1.x branch is that the patch uses both a JDK8 specific feature (a default method in an interface) and breaks backwards compatibility with

[GitHub] storm issue #2242: [STORM-1347] display topology version on UI

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2242 Actually this issue is the subtask of topology online update, and topology version is expected to be set automatically to the increasing number. But I also think this patch doesn't hurt in

[GitHub] storm issue #2244: STORM-2659: Add daemon.name variable to storm.cmd to fix ...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2244 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2239: [STORM-2655] fix: log users cannot view worker.log on Sto...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2239 +1 Maybe better to address this also for 1.x branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 Btw, we should be careful if we drop something we provided. This patch seems focus to performance optimization (especially micro), and for some spots it might not be always better. One example

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129541976 --- Diff: storm-server/src/main/java/org/apache/storm/Testing.java --- @@ -712,6 +712,6 @@ public static Tuple testTuple(List values, MkTupleParam

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129526848 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -269,11 +263,9 @@ public WorkerState(Map conf,

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129539411 --- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java --- @@ -21,101 +21,100 @@ import java.util.HashMap; import

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129541604 --- Diff: storm-client/test/jvm/org/apache/storm/bolt/TestJoinBolt.java --- @@ -313,7 +313,7 @@ private static TupleWindow makeTupleWindow(ArrayList...

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129533410 --- Diff: storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java --- @@ -43,43 +45,59 @@ private static final Logger

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129541543 --- Diff: storm-client/test/jvm/org/apache/storm/bolt/TestJoinBolt.java --- @@ -291,7 +291,7 @@ private static TupleWindow makeTupleWindow(ArrayList...

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129528621 --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java --- @@ -635,14 +594,13 @@ public static boolean

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129537270 --- Diff: storm-client/src/jvm/org/apache/storm/serialization/KryoTupleDeserializer.java --- @@ -39,7 +38,7 @@ public KryoTupleDeserializer(final

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129538563 --- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java --- @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129538089 --- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java --- @@ -24,50 +24,56 @@ import org.apache.storm.task.GeneralTopologyContext;

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129506090 --- Diff: external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java --- @@ -69,7 +69,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129506700 --- Diff: external/storm-kafka/src/test/org/apache/storm/kafka/bolt/KafkaBoltTest.java --- @@ -293,7 +293,7 @@ public Fields

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129534437 --- Diff: storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java --- @@ -114,27 +136,29 @@ public void ack(Tuple input) {

[GitHub] storm pull request #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/2241#discussion_r129531103 --- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java --- @@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {

  1   2   >