Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2244
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2239
+1
Maybe better to address this also for 1.x branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2241
Btw, we should be careful if we drop something we provided. This patch
seems focus to performance optimization (especially micro), and for some spots
it might not be always better. One example is
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129541976
--- Diff: storm-server/src/main/java/org/apache/storm/Testing.java ---
@@ -712,6 +712,6 @@ public static Tuple testTuple(List values,
MkTupleParam param)
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129526848
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -269,11 +263,9 @@ public WorkerState(Map conf, IContext
mqContext,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129539411
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java
---
@@ -21,101 +21,100 @@
import java.util.HashMap;
import java.util
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129541604
--- Diff: storm-client/test/jvm/org/apache/storm/bolt/TestJoinBolt.java ---
@@ -313,7 +313,7 @@ private static TupleWindow
makeTupleWindow(ArrayList... s
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129533410
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java
---
@@ -43,43 +45,59 @@
private static final Logger
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129537270
--- Diff:
storm-client/src/jvm/org/apache/storm/serialization/KryoTupleDeserializer.java
---
@@ -39,7 +38,7 @@ public KryoTupleDeserializer(final Map
c
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129541543
--- Diff: storm-client/test/jvm/org/apache/storm/bolt/TestJoinBolt.java ---
@@ -291,7 +291,7 @@ private static TupleWindow
makeTupleWindow(ArrayList... s
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129528621
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -635,14 +594,13 @@ public static boolean isConnectionReady(IConnect
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129538563
--- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129538089
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java ---
@@ -24,50 +24,56 @@
import org.apache.storm.task.GeneralTopologyContext;
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506090
--- Diff:
external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -69,7 +69,7 @@ public Fields getCompon
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506700
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/bolt/KafkaBoltTest.java ---
@@ -293,7 +293,7 @@ public Fields getComponentOutputFields(Str
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129534437
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java
---
@@ -114,27 +136,29 @@ public void ack(Tuple input) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129531103
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129501786
--- Diff: conf/defaults.yaml ---
@@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize: false
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129508787
--- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java ---
@@ -97,6 +97,8 @@ public void run() {
// events.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506257
--- Diff:
external/storm-hive/src/test/java/org/apache/storm/hive/bolt/TestHiveBolt.java
---
@@ -451,7 +451,7 @@ public Fields getComponentOutputFields(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129541648
--- Diff:
storm-client/test/jvm/org/apache/storm/topology/WindowedBoltExecutorTest.java
---
@@ -78,7 +78,7 @@ public Fields getComponentOutputFields(Str
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129504652
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -43,7 +43,7 @@ public Fields
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129510117
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/GrouperFactory.java
---
@@ -137,7 +137,7 @@ public void prepare(WorkerTopologyContext context,
Gl
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129540613
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -323,20 +323,22 @@ public static boolean isSystemId(String id) {
* @retu
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129523335
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/supervisor/ClientSupervisorUtils.java
---
@@ -123,8 +123,8 @@ public static Process launchProcess
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129527658
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -488,84 +476,55 @@ public void registerCallbacks() {
L
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129536103
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -44,14 +47,15 @@
private final Boolean isEv
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506169
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestHdfsBolt.java
---
@@ -247,7 +247,7 @@ public Fields getComponentOutputFields(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506153
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java
---
@@ -224,7 +224,7 @@ public Fields getComponent
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129515502
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -122,28 +130,33 @@ public Task(Executor executor, Integer taskId) throws
IOExcept
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129504947
--- Diff: examples/storm-perf/pom.xml ---
@@ -81,7 +81,7 @@
maven-checkstyle-plugin
-
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129536804
--- Diff:
storm-client/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java ---
@@ -26,38 +26,25 @@
import java.util.ArrayList;
import java.u
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129519731
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -177,6 +190,38 @@ public BuiltinMetrics getBuiltInMetrics() {
return
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129534403
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/bolt/BoltOutputCollectorImpl.java
---
@@ -114,27 +136,29 @@ public void ack(Tuple input) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129525515
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,141 @@ public void start() throws Exception {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129496179
--- Diff: conf/defaults.yaml ---
@@ -231,16 +228,13 @@ topology.multilang.serializer:
"org.apache.storm.multilang.JsonSerializer"
topology.shellbolt
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129507731
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -574,13 +536,21 @@
public static final String
TOPOLOGY_TICK_TUPLE_FREQ_SECS="
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129497844
--- Diff: conf/defaults.yaml ---
@@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize: false
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506876
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/bolt/KafkaBoltTest.java ---
@@ -304,7 +304,7 @@ public Fields getComponentOutputFields(Str
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506643
--- Diff:
external/storm-kafka/src/test/org/apache/storm/kafka/PartitionManagerTest.java
---
@@ -238,6 +238,10 @@ public void emitDirect(int taskId, Str
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129499334
--- Diff: conf/defaults.yaml ---
@@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize: false
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129524633
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,141 @@ public void start() throws Exception {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129507113
--- Diff: storm-client/pom.xml ---
@@ -106,10 +106,11 @@
commons-collections
-
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506229
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestSequenceFileBolt.java
---
@@ -165,7 +165,7 @@ public Fields getComponentOutpu
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129506283
--- Diff:
external/storm-hive/src/test/java/org/apache/storm/hive/common/TestHiveWriter.java
---
@@ -168,7 +168,7 @@ public Fields getComponentOutputFie
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129530437
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129520803
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -177,6 +190,38 @@ public BuiltinMetrics getBuiltInMetrics() {
return
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129494647
--- Diff: conf/defaults.yaml ---
@@ -231,16 +228,13 @@ topology.multilang.serializer:
"org.apache.storm.multilang.JsonSerializer"
topology.shellbolt
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129504361
--- Diff: conf/defaults.yaml ---
@@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize: false
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129494209
--- Diff: conf/defaults.yaml ---
@@ -49,6 +49,9 @@ storm.nimbus.retry.times: 5
storm.nimbus.retry.interval.millis: 2000
storm.nimbus.retry.inter
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129498955
--- Diff: conf/defaults.yaml ---
@@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize: false
Github user JanecekPetr commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129525496
--- Diff: storm-client/src/jvm/org/apache/storm/utils/TransferDrainer.java
---
@@ -21,101 +21,100 @@
import java.util.HashMap;
import java.util
Github user JanecekPetr commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129522101
--- Diff: storm-client/src/jvm/org/apache/storm/task/IOutputCollector.java
---
@@ -30,4 +31,5 @@
void ack(Tuple input);
void fail(Tuple
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129517427
--- Diff: storm-client/src/jvm/org/apache/storm/task/IOutputCollector.java
---
@@ -30,4 +31,5 @@
void ack(Tuple input);
void fail(Tuple inp
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129502418
--- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129501931
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129500933
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -366,31 +330,42 @@ protected void setupTicks(boolean isSpout) {
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129500194
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java ---
@@ -488,84 +476,55 @@ public void registerCallbacks() {
LO
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129498049
--- Diff: conf/defaults.yaml ---
@@ -253,11 +247,16 @@ topology.trident.batch.emit.interval.millis: 500
topology.testing.always.try.serialize: false
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129497742
--- Diff: storm-client/pom.xml ---
@@ -257,7 +258,7 @@
**/generated/**
-
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r129496848
--- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
101 - 161 of 161 matches
Mail list logo
