Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2343
@revans2 Thanks for reviewing. I've addressed your comments, and rebased
with latest master.
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2297
@srdo
Thanks for your reply.I mean if curator has retried several times and
failed,the code where I modify will throw a exception,and it will never attempt
to connect another zkserver.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141220584
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/Sets.java ---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141219408
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/Sets.java ---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141209841
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141209476
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -103,6 +110,38 @@
public static final String STORM_SCHEDULER =
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141209321
--- Diff: storm-server/pom.xml ---
@@ -136,7 +136,7 @@
maven-checkstyle-plugin
-
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2348
+1 Thanks for the fix.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2331
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2348
Tested it manually under all four combinations by visiting pages/links.
| UI| LogViewer | all UI pages | Nimbus log | Supervisor
log | Worker log | Event Log | dumps and
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2343
Testing worked really well. I am +1 once my nits are addressed.
---
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141194357
--- Diff: storm-server/pom.xml ---
@@ -136,7 +136,7 @@
maven-checkstyle-plugin
-
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2348
[STORM-2757] Fix broken log links when HTTPS is in use
jira: https://issues.apache.org/jira/browse/STORM-2757
We have HTTPS configs for UI and Logviewer. But it's not working properly.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141187231
--- Diff: storm-server/pom.xml ---
@@ -136,7 +136,7 @@
maven-checkstyle-plugin
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141188960
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/Sets.java ---
@@ -0,0 +1,58 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141187500
--- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
@@ -103,6 +110,38 @@
public static final String STORM_SCHEDULER =
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141189175
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/strategies/DefaultBlacklistStrategy.java
---
@@ -0,0 +1,169 @@
+/**
+ *
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141188696
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2343#discussion_r141187945
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
---
@@ -0,0 +1,248 @@
+/**
+ * Licensed to the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141183179
--- Diff: external/storm-blobstore-migration/pom.xml ---
@@ -0,0 +1,126 @@
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141183242
--- Diff: external/storm-blobstore-migration/pom.xml ---
@@ -0,0 +1,126 @@
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141183809
--- Diff:
external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/ListHDFS.java
---
@@ -0,0 +1,52 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141184831
--- Diff:
external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/MigrateBlobs.java
---
@@ -0,0 +1,125 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141183394
--- Diff: external/storm-blobstore-migration/pom.xml ---
@@ -0,0 +1,126 @@
+http://maven.apache.org/POM/4.0.0;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141184296
--- Diff:
external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/ListHDFS.java
---
@@ -0,0 +1,52 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141185443
--- Diff:
external/storm-blobstore-migration/src/test/java/org/apache/storm/blobstore/AppTest.java
---
@@ -0,0 +1,38 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141183305
--- Diff:
external/storm-blobstore-migration/src/main/java/org/apache/storm/blobstore/ListHDFS.java
---
@@ -0,0 +1,52 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2347#discussion_r141182276
--- Diff: external/storm-blobstore-migration/Makefile ---
@@ -0,0 +1,19 @@
+PACKAGE_NAME=blobstore-migrator.tgz
+
+VERSION=$(shell cat VERSION ||
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2347
STORM-2760: Add Blobstore Migration Scripts
Add code and helper scripts for migrating active Storm clusters from a
locally-backed BlobStore to an HDFS-backed BlobStore.
You can merge this pull
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2346
Quick fix: typo in LogviewerServer
A quick fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ethanlm/storm patch-1
Alternatively you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2345
I have done a lot of manual testing with this patch, but if others want to
try it out feel free to kick the tires. Any feedback is appreciated.
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2345
STORM-2438: added in rebalance changes to support RAS
This is based off #2339 (which is in the first commit). If people want to
review it all together I am fine with closing the other one.
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2344
[STORM-2758] fix: logviewer_search page not found
JIRA: https://issues.apache.org/jira/browse/STORM-2758
logviewer_search page not found because the original code uses "./public"
as the
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141137280
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@HeartSaVioR
> We need to document how to use new metrics and its reporter, and also
need to have patch for master branch (maybe with removal of metrics V1 public
API).
As I
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141137596
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@arunmahadevan
> Currently this patch addresses registering custom metrics and sending the
metrics out via reporters and does not send any metrics to nimbus right? Why is
disruptor metrics
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r141131796
--- Diff:
examples/storm-starter/src/jvm/org/apache/storm/starter/AnchoredWordCount.java
---
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140987102
--- Diff: storm-core/src/jvm/org/apache/storm/task/TopologyContext.java ---
@@ -386,4 +388,28 @@ public ReducedMetric registerMetric(String name,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140971831
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140985025
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140984424
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/GraphiteStormReporter.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140985850
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140985795
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140971387
--- Diff: storm-core/src/jvm/org/apache/storm/metrics2/Metrics2Utils.java
---
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140971053
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/DisruptorMetrics.java ---
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140972146
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140973295
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140984053
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/GangliaStormReporter.java
---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140984437
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/GraphiteStormReporter.java
---
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140972434
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140973733
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140982289
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140985766
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140967211
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/ScheduledStormReporter.java
---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r140966853
--- Diff:
storm-core/src/jvm/org/apache/storm/metrics2/reporters/StormReporter.java ---
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache
56 matches
Mail list logo
