Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2714
This should be closed after #2805 is resolved.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
#2764 also depends on resolution of this issue. Please consider merging
that as well as part of the patch.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2800
As far as my understanding of the code goes I believe this fix should
resolve this particular issue. However my understanding in HB cache was limited
and the PR was pushed hastily during my last
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2800
Agreed. I think atomic reference is really just for Clojure compatibility
there. Iâll finish this up.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r212801285
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1565,23 +1565,26 @@ public static ComponentPageInfo aggCompExecsStats
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r212801204
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1565,23 +1565,26 @@ public static ComponentPageInfo aggCompExecsStats
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r212801069
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1525,27 +1528,24 @@ public static ComponentPageInfo aggCompExecsStats
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
cachedSummary shouldn't be refreshed too often based on current
implementation. So I don't think we should risk the race condition just for
negligible gain in performance.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367723
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367121
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209365696
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209363589
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
What do you think @srdo
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
Added clarifications to ClusterSummaryMetricSet
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209337293
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209335050
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception
GitHub user zd-project opened a pull request:
https://github.com/apache/storm/pull/2800
STORM-3162: Fix concurrent modification bug
See: https://issues.apache.org/jira/browse/STORM-3162
I managed to alter the Java implementation and it seems to be passing
storm-server test
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209315575
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
All nits addressed?
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209312212
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209311621
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209311426
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
All nits should have been addressed as of now.
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209305519
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209305125
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209303203
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209302512
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301707
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209301358
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209299849
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298650
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209298109
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209297840
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296760
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209296628
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209100932
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209099125
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098407
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098259
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -62,6 +64,14
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209098067
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097770
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,10 @@
public
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097464
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097286
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -251,10 +257,18 @@
private static final Meter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209097038
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096605
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209096098
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095662
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209095253
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209094640
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209088518
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209087810
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209082396
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209068547
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2891,33 +2884,26 @@ public void launchServer() throws Exception
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2754
Some important changes have been made to address nits you guys have,
especially on metrics for scheduler. @srdo @Ethanlm
---
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209059400
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209048016
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209042043
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2918,6 +2943,10 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209041653
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209039674
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2918,6 +2943,10 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209037387
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/DirectoryCleaner.java
---
@@ -186,7 +192,22 @@ private boolean
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209037023
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2057,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209036572
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209034728
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209031413
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209030437
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209029787
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4723,4 +4754,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209029163
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209029068
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4729,4 +4760,192 @@ public IScheduler getForcedScheduler
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209028432
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2871,16 +2897,15 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209023115
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209022892
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209004673
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208997165
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208987578
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208982864
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208970052
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208967428
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208748740
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749692
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,16 +2897,15 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208751049
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749524
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2807,16 +2897,15 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749175
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208748414
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208749367
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2219,21 +2305,16 @@ private void mkAssignments(String
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208747514
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746949
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2131,17 +2223,13 @@ private void mkAssignments(String
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746736
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746266
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208746090
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208745736
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
Please notice that only the last commit is under #2764, which was
previously out of sync with #2754 because I don't want to have too many
dependencies between PR. For issue specific to #2
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208744273
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -,13 +2231,23 @@ private void mkAssignments(String
Github user zd-project commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208743919
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/metrics/reporters/ConsolePreparableReporter.java
---
@@ -52,6 +52,7 @@ public void prepare
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2764
Has been rebased on 3133 now.
---
Github user zd-project closed the pull request at:
https://github.com/apache/storm/pull/2743
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2743
Merged in #2710
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Thanks again for helping me out of this issue though. Hope this don't
create too much trouble for you.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Also, I just dug into the error code you suggested. It turned out to be
caused by heartbeatTimer (instance of StormTimer) in Supervisor in
AsyncLocalizerTest.testKeyNotFoundException. But I don&#
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
Okay that alerted me one thing. What's our config file for the testing? If
it doesn't use ScheduledReporter for testing, this PR shouldn't make a matter
at all.
---
Github user zd-project commented on the issue:
https://github.com/apache/storm/pull/2789
I can't see changes in your link, so I looked into your latest change in
branch `non-static-metrics`. Please correct me if I interpret your code wrong.
Your implementation didn'
1 - 100 of 225 matches
Mail list logo
