Re: Forcefully Undeploy application from UI

2015-06-23 Thread Imesh Gunaratne
Great! Thanks Dakshika!! :-) On Wed, Jun 24, 2015 at 5:46 AM, Dakshika Jayathilaka wrote: > Hi Imesh, > > I have fixed that with *commit b29385025f703c72969b5010fd167ef1f6fb014b* > > Regards, > > *Dakshika Jayathilaka* > PMC Member & Committer of Apache Stratos > Senior Software Engineer > WSO2,

Re: Forcefully Undeploy application from UI

2015-06-23 Thread Dakshika Jayathilaka
Hi Imesh, I have fixed that with *commit b29385025f703c72969b5010fd167ef1f6fb014b* Regards, *Dakshika Jayathilaka* PMC Member & Committer of Apache Stratos Senior Software Engineer WSO2, Inc. lean.enterprise.middleware 0771100911 On Tue, Jun 23, 2015 at 10:53 PM, Imesh Gunaratne wrote: > As I

Re: Forcefully Undeploy application from UI

2015-06-23 Thread Imesh Gunaratne
As I found Force Undeployment does not redirect the user back to the Applications page and the Back button also does not work after executing it. We might need to fix this. Thanks On Thu, Jun 18, 2015 at 5:18 PM, Udara Liyanage wrote: > Hi, > > IMO user should be able to invoke forceful operati

Re: Forcefully Undeploy application from UI

2015-06-18 Thread Udara Liyanage
Hi, IMO user should be able to invoke forceful operation directly without attempting graceful invocation. Stratos API too allows this. Thinking in that way it is better to show both option at the same place. However I have seen some UI functions allows forceful operation only after graceful invoc

Re: Forcefully Undeploy application from UI

2015-06-18 Thread Imesh Gunaratne
Hi, @Anuruddha: Great work!! @ Lahiru: The initial thought we had was that "Forceful Undeployment" is an advanced feature so that it should not come as a standard operation. If the Graceful Undeployment did not work due to a problem in the cartridge, the user could see this button on the Topolog

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Lahiru Sandaruwan
Hi Dakshika, IMO graceful undeployment doesn't need to be the default. Graceful undeployment is the case where, user want to complete serving of all the requests that are serving at the moment of undeployment. If the user just want get rid of his deployment, he can do it forcefully. So, we can ha

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Dakshika Jayathilaka
Hi Lahiru, I'm wondering why we want to push forceful action by default. Is there any real user story behind this action by default ? IMHO forceful actions are use if something goes wrong after default action. IMO first time user may get confused if we introduce force action by default. Regards,

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Vishanth Balasubramaniam
Hi Anuruddha, I can remember I had an issue some time back where when I try to undeploy an application, I got the success message {"statusCode":202,"successMessage":"Application undeployed successfully: > [application] nested-group-app"} But application was not getting undeployed and where I wa

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Lahiru Sandaruwan
Hi Dakshika, On Thu, Jun 18, 2015 at 7:37 AM, Dakshika Jayathilaka wrote: > Hi All, > > Great work Anuruddha, I have few comments on above change. > > 1. IMO we need to follow current standard of button positioning. So this > force action button has to move on to right hand side. > > 2. I'm Not

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Dakshika Jayathilaka
Hi All, Great work Anuruddha, I have few comments on above change. 1. IMO we need to follow current standard of button positioning. So this force action button has to move on to right hand side. 2. I'm Not sure about the button name. Is it "Force Undeploy" or "Forcefully undeploy" @lahiru: AFA

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Udara Liyanage
Hi Anurudda, Shall we have this in CLI too.

Re: Forcefully Undeploy application from UI

2015-06-17 Thread Lahiru Sandaruwan
Great. Shall we bring the normal undeployment button to the same place? Thanks. On Wed, Jun 17, 2015 at 7:41 PM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi Devs, > > I have added force undeploy button for UI. > > The flow is as follows: > 1. User can un-deploy the application fro

Forcefully Undeploy application from UI

2015-06-17 Thread Anuruddha Liyanarachchi
Hi Devs, I have added force undeploy button for UI. The flow is as follows: 1. User can un-deploy the application from UI. 2. Once the un-deployment process starts application will be in Undeploying state [1]. 3. In undeploying state user can view the application from topology view, which enables