Re: Feature sponsorship proposal

2008-04-08 Thread Martin Gilday
I have to say I'm not really convinced this would be a benefit to the project. I'm sure there are rules in the ASF and licenses that prevent it, but I can ony see an increase in conflicts of interest. How do you decide if the dontated feature is large enough to warrant creditation? Do you take

Re: LoggingInterceptor output

2008-01-07 Thread Martin Gilday
svn annotate filename will list the revision the line changed in a less pretty fashion. - Original message - From: Ted Husted [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Mon, 7 Jan 2008 09:16:46 -0500 Subject: Re: LoggingInterceptor output Looking at the

Re: [s2] Build changes

2007-12-16 Thread Martin Gilday
Sounds very useful, especially for people wanting to test out the latest 2.1.x. Does this include getting artifacts published to a snapshot Struts 2 Maven repo (i.e. not central)? - Original message - From: Don Brown [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org

Re: Recent WebWork fixes

2007-12-04 Thread Martin Gilday
I've attached a patch for WW-2294/XW-593, ported from Toby's work. With Wes's fantastic work here I think that is the majority of the main WW fixes done. - Original message - From: Ted Husted [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Tue, 4 Dec 2007

Re: Missing source jars in maven repo

2007-12-03 Thread Martin Gilday
Normal Maven procedure would just entail sticking -DperformRelease=true on the end to generate source and javadoc jars. mvn deploy -DperformRelease=true Does performing a Struts 2 release require doing something non-maven standard? - Original message - From: Ted Husted [EMAIL

Re: JRuby in Struts 2

2007-12-02 Thread Martin Gilday
Could you explain your reasoning as to why you need a new framework? If someone wants a Rails like framework for JRuby, why would they not just use Rails on JRuby? If you were to make a diverging framework, as you mention, why would it need to have anything to do with Struts 2? What parts of

Re: JRuby in Struts 2

2007-12-02 Thread Martin Gilday
, since Sun employs 2 of the core JRuby developers, I don't think it's going away any time soon. I think originally we thought we could write S2 actions in JRuby. Since that didn't work out so well, the question becomes: 'Now what?' Tom Martin Gilday wrote: Could you explain your reasoning

Re: Keeping up with Toby :)

2007-12-01 Thread Martin Gilday
the CodeBehind/SmartURLs merger. -T. On Nov 30, 2007 8:43 AM, Ted Husted [EMAIL PROTECTED] wrote: Sure. Just try to see if there is already a matching ticket. Phil created a few during the transition period that might still be open. On Nov 30, 2007 8:15 AM, Martin Gilday [EMAIL PROTECTED

Re: Keeping up with Toby :)

2007-11-30 Thread Martin Gilday
Should we just create a matching Struts 2 JIRA issue, linking to the WW one and attach the patch there? - Original message - From: Ted Husted [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Fri, 30 Nov 2007 07:50:05 -0500 Subject: Keeping up with Toby :) Our

Re: Action packages and components

2007-10-25 Thread Martin Gilday
package com.example.actions.foo.bar; // will map to /foo/bar This parameter can be overridden if necessary in the applications configuration files. How about the override as an annotation in the package-info.java for the located package?

Re: [S2] Annotations (was Plugins gone wild!)

2007-10-25 Thread Martin Gilday
be accessible and only reveal setters for things it wants to consume. If I want something protected I put it in a web-business-service tier where it is better protected and I can control the injection and settings and frameworks don't introduce dangerous automatic handling. -bp Martin Gilday

Re: [S2] Annotations (was Plugins gone wild!)

2007-10-24 Thread Martin Gilday
:52:16 -0400 Subject: Re: [S2] Annotations (was Plugins gone wild!) On 10/23/07, Martin Gilday [EMAIL PROTECTED] wrote: Well I am looking at the Parameter Filter Interceptor (http://cwiki.apache.org/WW/parameter-filter-interceptor.html) which I am proposing we complement by allowing the same

Re: [S2] Plugins gone wild!

2007-10-23 Thread Martin Gilday
I haven't been following this topic too closely, so apologies if I have missed the point. Why is dojo being considered a core plugin? I understand it is used by some of the tags to simplify some AJAX tasks, are there any other benefits to it?. From my brief experience with it Dojo is not the

Re: [S2] Plugins gone wild!

2007-10-23 Thread Martin Gilday
Where abouts is the annotations plugin housed? I could not see it in the struts2 trunk or sandbox trunk. Following Don's comment in this https://issues.apache.org/struts/browse/WW-2264 I was interested in trying to created this feature A new feature we could add would be a new annotation so that

Re: [S2] Plugins gone wild!

2007-10-23 Thread Martin Gilday
I think I would agree actually. I'm not sure about the performance implications. I had only planned on preventing the parameters interceptor setting to them, so it wouldn't be on every field access. - Original message - From: Chris Pratt [EMAIL PROTECTED] To: Struts Developers List

Re: [S2] Plugins gone wild!

2007-10-23 Thread Martin Gilday
something? -bp Martin Gilday wrote: Where abouts is the annotations plugin housed? I could not see it in the struts2 trunk or sandbox trunk. Following Don's comment in this https://issues.apache.org/struts/browse/WW-2264 I was interested in trying to created this feature A new feature we

Re: Wiki access

2007-10-07 Thread Martin Gilday
On 9/26/07, Martin Gilday [EMAIL PROTECTED] wrote: Thanks, I've faxed in a CLA. - Original message - From: Martin Cooper [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Tue, 25 Sep 2007 07:40:14 -0700 Subject: Re: Wiki access On 9/25/07, Martin Gilday

Re: Wiki access

2007-09-26 Thread Martin Gilday
Thanks, I've faxed in a CLA. - Original message - From: Martin Cooper [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Tue, 25 Sep 2007 07:40:14 -0700 Subject: Re: Wiki access On 9/25/07, Martin Gilday [EMAIL PROTECTED] wrote: Hi, Could I please have write

Wiki access

2007-09-25 Thread Martin Gilday
Hi, Could I please have write access to the struts2 wiki? I'd like to update this page http://struts.apache.org/2.0.9/docs/how-do-we-get-access-to-the-session.html as it refers to servlet-config when in struts-default it is servletConfig. My account email is [EMAIL PROTECTED] Thanks, Martin.

Re: Release process and release Maven plugin (WAS: Re: Voting Process (was Re: Struts 2.0.9 release (WAS: Re: S2 security fix release planning (XWork 2.0.4 is out))))

2007-07-31 Thread Martin Gilday
In terms of reducing the actual amount of time spent on a release, a solid set of Selenium tests might make the most difference. +1 I think that someone is already working on Selenium tests, or am I confusing with Struts 1? Even if someone where, it's a very big job, and we

Re: Preventing OGNL evaluations of user input (was Re: Struts 2 performance)

2007-07-16 Thread Martin Gilday
As has been said the current fix is not ideal. The changes that have been made to params interceptor mean that the functionality in ParamsInterceptor and ParamFilterInterceptor are now very similar, except one supports regex. Would it be worthwile trying to combine these now that it is apparent

Re: [s2] OGNL Version 2.7

2007-07-02 Thread Martin Gilday
It is in the central repo. http://repo1.maven.org/maven2/ognl/ognl/2.7/ - Original message - From: Alexandru Popescu #9728; [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Mon, 2 Jul 2007 20:23:59 +0300 Subject: Re: [s2] OGNL Version 2.7 On 7/2/07, Musachy

Re: [s2] OGNL Version 2.7

2007-07-02 Thread Martin Gilday
I have tried a straight replacement in WebWork 2.2.5 and everything works fine. Some changes need to be made to XWork for the speed enchancements to work. I have posted about it on the Opensymphont forums. http://forums.opensymphony.com/thread.jspa?threadID=94470tstart=0 Hopefully the same

Has the WebWork rebranding to Struts2 been a failure?

2007-06-23 Thread Martin Gilday
This is something I have been thinking about for a while, but has been highlighted by Wicket recently graduating from the Apache Incubator. When checking out blogs, newsgroups, theserverside, infoq etc it has become apparent to me that Struts 2 is still very much thought of as just Struts 1++, in

Re: Struts .tld file is not generated.

2007-05-19 Thread Martin Gilday
How are you running the maven build? Sticking a good old clean in there is normally a good idea. e.g. mvn clean package - Original message - From: Nuwan Chandrasoma [EMAIL PROTECTED] To: Struts Developers List dev@struts.apache.org Date: Fri, 18 May 2007 20:19:39 -0700 (PDT) Subject:

Selenium Tests for Showcase

2007-05-06 Thread Martin Gilday
I have started working on some Selenium tests for the Showcase. So far the suite has 3 tests. 1. Checking that the index page loads 2. Checking that a Skill can be added in the CRUD section 3. Checking that a Skill can be edited in the CRUD section A few changes to the POM have also been made