Re: [VOTE] Proposal for User Preferences [SIP-127]

2024-06-20 Thread John Bodley
+1* (binding) * I'm generally supportive of this, but I previously posted a comment to the SIP proposal in relation to handling timezones (local versus UTC). I think certain aspects of this still need to be flushed out and

Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc1

2024-06-18 Thread John Bodley
+1* (binding) * We deployed said SHA to our production environment and haven't observed any regressions. On Tue, Jun 18, 2024 at 6:43 AM Michael S. Molina < michael.s.mol...@gmail.com> wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 4.0.2. >

Re: [VOTE] Release Apache Superset 3.1.3 based on Superset 3.1.3rc1

2024-05-02 Thread John Bodley
+1 (binding)* * This is the SHA we have deployed to our production environment sans a few minor changes to Codecov. On Thu, May 2, 2024 at 7:15 AM Michael S. Molina wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 3.1.3. > > The release

Re: [VOTE] [SIP-95] Proposal for Catalog Support in SQL Lab

2024-04-11 Thread John Bodley
+1 (binding) On Thu, Apr 11, 2024 at 6:26 AM Diego Pucci wrote: > +1 (binding) > > On Thu, Apr 11, 2024, 15:18 Craig Rueda wrote: > > > +1 > > > > - Craig > > > > > On Apr 11, 2024, at 5:54 AM, Beto Dealmeida > > wrote: > > > > > > Hi, folks! > > > > > > I'd like to call for a vote on

Re: [VOTE] Release Apache Superset 4.0.0 based on Superset 4.0.0rc2

2024-04-05 Thread John Bodley
+1* (binding) * We deployed this SHA to a test instance and have noticed any major regressions. On Fri, Apr 5, 2024 at 8:14 AM Евгений Целиков wrote: > The bug I've mentioned earlier fortunately doesn't reproduce on rc2 > > От: Joe Li > Отправлено: 4 апреля

Re: [VOTE] SIP-114 Proposal for Google Sheets Export

2024-04-03 Thread John Bodley
+1 (binding) On Wed, Apr 3, 2024 at 6:21 PM Elizabeth Thompson wrote: > +1 binding > > > On Apr 2, 2024, at 9:34 AM, Evan Rusackas > wrote: > > > > Hi everyone, > > > > Following the discussion [1] thread and the Issue thread on Github [2] > I’ld like to move this SIP forward by calling a

Re: [VOTE] Release Apache Superset 3.1.2 based on Superset 3.1.2rc1

2024-04-02 Thread John Bodley
+1* (binding) * We've had this SHA deployed in our production environment for a few days without any noticeable regressions. There are still some minor quirks with the SQLGlot integration, but we don't perceive these as blockers for the release. On Tue, Apr 2, 2024 at 10:48 AM Elizabeth Thompson

Re: [VOTE] [SIP-117] Improve SQL parsing

2024-01-31 Thread John Bodley
+1 (binding) On Thu, Feb 1, 2024 at 4:11 AM Michael S. Molina wrote: > +1 (binding) > > Best regards, > Michael S. Molina > > > On 31 Jan 2024, at 09:52, Diego Pucci wrote: > > > > +1 (binding) > > > >> Il giorno mer 31 gen 2024 alle ore 15:25 Beto Dealmeida > >> ha scritto: > >> > >> Hi,

Re: [VOTE] Release Apache Superset 3.0.3 based on Superset 3.0.3rc3

2024-01-16 Thread John Bodley
+1* (binding) * We deployed this SHA internally at Airbnb to production last Thursday afternoon and no related issues have been reported. On Tue, Jan 16, 2024 at 11:55 AM Ville Brofeldt wrote: > +1 (binding) > > I did my best to ensure that the latest x-axis changes didn't introduce > yet more

Re: 4.0 breaking change proposals for consensus

2024-01-11 Thread John Bodley
Hi, I would like to object to the following change: 51 - Drop support for SQLite metadata database < > https://github.com/orgs/apache/projects/292/views/1?pane=issue=40454778 > > > This proposal is to materialize SIP-33 < > https://github.com/apache/superset/issues/8874> and remove SQLite

Re: [VOTE] Release Apache Superset 3.0.3 based on Superset 3.0.3rc2

2023-12-19 Thread John Bodley
+1* (binding) * This SHA was tested in our staging environment—verifying correctness with production against a slew of key entities. Additionally, issue #26298 raised some concerns about a potential regression, however (per the discussion) this

Re: [VOTE][SIP-109]Global logs context

2023-12-12 Thread John Bodley
+1 (binding) On Tue, Dec 12, 2023 at 4:46 AM Diego Pucci wrote: > +1 (binding) > > On Tue, Dec 12, 2023, 14:11 Michael S. Molina > wrote: > > > +1 (binding) > > > > Best regards, > > Michael S. Molina > > > > > On 12 Dec 2023, at 01:42, Beto Dealmeida > > > wrote: > > > > > > +1, binding > >

Re: [VOTE][SIP-108] Superset Release Process

2023-12-04 Thread John Bodley
+1 (binding) On Mon, Dec 4, 2023 at 9:43 AM Michael S. Molina wrote: > Hi, > > Having launched a formal discussion thread for [SIP-108] Superset Release > Process (https://github.com/apache/superset/issues/26015) a few weeks > ago, I thought it would be prudent to > now put the SIP to a vote. >

Re: [VOTE] Release Apache Superset 3.1.0 based on Superset 3.1.0rc1

2023-12-01 Thread John Bodley
-1 (binding) Per the discussion thread there's already a handful of issues detected including an Alembic migration ordering issue—due to a picked cherry which went astray —which renders the application unusable when upgrading from 3.0 to 3.1.

[RESULT][VOTE][SIP-99] Proposal for correctly handling business logic

2023-12-01 Thread John Bodley
Hi, Thanks to everyone who voted. The vote for [SIP-99] Proposal for correctly handling business logic is now closed. The proposal has PASSED with four binding +1, and zero -1 votes: Binding +1 votes: - Craig - Elizabeth - Michael - Ville There

[VOTE][SIP-99] Proposal for correctly handling business logic

2023-11-28 Thread John Bodley
Hi, Having launched a formal discussion thread for [SIP-99] Proposal for correctly handling business logic a few weeks ago [1], and having not received any major feedback, I thought it would be prudent to now put the SIP to a vote. As a reminder

Re: [VOTE] Release Apache Superset 3.0.2 based on Superset 3.0.2rc2

2023-11-21 Thread John Bodley
+1* (binding) Based on Sam's comment regarding the Azure SSO issue being resolved and having deployed said SHA to our sandbox environment where I was able to confirm fixes to a subset of the additional changes included in 3.0.2rc2. On Tue, Nov 21, 2023 at 9:28 AM Daniel Gaspar wrote: > +1

Re: [VOTE] Release Apache Superset 3.0.2 based on Superset 3.0.2rc1

2023-11-14 Thread John Bodley
+1* (binding) * We’ve had this SHA deployed in production for the past week. On Tue, Nov 14, 2023 at 6:49 AM Michael S. Molina < michael.s.mol...@gmail.com> wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 3.0.2. > > The release candidate: >

Re: [DISCUSS][SIP-99] Proposal for correctly handling business logic

2023-11-09 Thread John Bodley
Hi, Given there's a lot to unpack with this SIP and the discussion has been relatively light, I thought there was merit in pinging this thread to garner any additional feedback before putting the SIP to a vote. -John On Thu, Nov 2, 2023 at 12:54 PM John Bodley wrote: > Hi, > > I w

[DISCUSS][SIP-99] Proposal for correctly handling business logic

2023-11-02 Thread John Bodley
Hi, I was hoping to start a formal discussion for [SIP-99] Proposal for correctly handling business logic . The SIP covers a slew of subtopics which are broken down into sub-SIPs, i.e., SIP-99 merely serves as an umbrella, whereas - [SIP-99A]

Re: [VOTE] Release Apache Superset 3.0.1 based on Superset 3.0.1rc2

2023-10-17 Thread John Bodley
+1* (binding) * We’ve deployed the SHA to our production environment without issue. On Mon, Oct 16, 2023 at 2:28 PM Ville Brofeldt wrote: > Hi all, > > +1 (binding) - changelog looks great! Hoping we can get the Trino async > query issue resolved in 3.0.2. > > Ville > > > On Oct 13, 2023, at

Re: [VOTE] Release Apache Superset 3.0.1 based on Superset 3.0.1rc1

2023-10-03 Thread John Bodley
+1* (binding) * Airbnb has already deployed this SHA internally to our production environment. On Tue, Oct 3, 2023 at 10:20 AM Michael S. Molina < michael.s.mol...@gmail.com> wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 3.0.1. > > The

Re: [VOTE][SIP-93] Proposal for non-blocking SQL Lab persistence

2023-10-02 Thread John Bodley
+1 (binding) On Mon, Oct 2, 2023 at 3:47 PM Justin Park wrote: > Hi, > > Since it seems the process outlined in the [SIP-93] Proposal for > non-blocking SQL Lab persistence [1] has been largely non-controversial, > I’d like to raise a VOTE. > > The vote will be open for at least 72 hours or

Re: [VOTE][SIP-100] Procedure for tracking status and implementation of Superset Improvement Proposals (SIPs)

2023-09-14 Thread John Bodley
+1 (binding) On Thu, Sep 14, 2023 at 9:03 AM Kamil Gabryjelski < kamil.gabryjel...@gmail.com> wrote: > +1 binding > > > On 14 Sep 2023, at 05:30, Evan Rusackas wrote: > > > > Hi all, > > > > Since it seems the process outlined in the SIP [1] has been largely > non-controversial, I’d like to

Re: [VOTE] Release Apache Superset 3.0.0 based on Superset 3.0.0rc4

2023-09-13 Thread John Bodley
+1* (binding) * Manual QA testing against a suite of production dashboards. On Wed, Sep 13, 2023 at 5:48 AM Michael S. Molina < michael.s.mol...@gmail.com> wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 3.0.0. > > The release candidate: >

Re: [VOTE] Release Apache Superset 3.0.0 based on Superset 3.0.0rc3

2023-08-29 Thread John Bodley
-1 (binding) Downvoting due to a number of critical issues mentioned here . On Mon, Aug 28, 2023 at 12:06 PM Evan Rusackas wrote: > Still testing this one too, but the signatures and checksums were also > verified here, just to get that

Re: [VOTE] Release Apache Superset 3.0.0 based on Superset 3.0.0rc2

2023-08-03 Thread John Bodley
-1 (binding) We've noticed a couple of regressions* which have since been addressed in master: - apache/superset#24874 - apache/superset#24850 * Note it's unclear where the latter is a

Re: [VOTE] Release Apache Superset 3.0.0 based on Superset 3.0.0rc1

2023-07-12 Thread John Bodley
-1 The current cache warmup logic only works for legacy chart types. Granted this issue existed pre-3.0, however 3.0 includes a number of migrations from legacy to non-legacy (ECharts) charts which will likely exacerbate the scale of the issue. On Mon, Jul 3, 2023 at 10:11 AM Michael S. Molina <

[RESULT][VOTE][SIP-92] Proposal for restructuring the Python code base

2023-05-30 Thread John Bodley
Hi, Thanks to everyone who voted. The vote has passed with five binding +1 votes, two non-binding +1 votes, zero +0 votes, and zero -1 votes. Binding +1 votes: - Bogdan Kyryliuk - Craig Rueda - Jesse Yang - Maxime Beauchemin - Yongjie Zhao Non-binding +1 votes: - Catherine

[VOTE] [SIP-92] Proposal for restructuring the Python code base

2023-05-09 Thread John Bodley
Hi, Following up from the corresponding DISCUSS email I sent way back in January (apologies for the delay), I was hoping to call a vote on [SIP-92] Proposal for restructuring the Python code base which should indirectly help both with the quality

Re: 3.0 change proposals for consensus (Wave 1)

2023-03-17 Thread John Bodley
Hi Evan, Thanks for sharing. Regarding (5) is it possible to delay this? We (Airbnb) are currently working on a revised migration workflow from legacy filters (filter-box charts, filter scopes, et al.) to native filters (see SIP-64 for details). It seems potentially prudent to have this logic

[DISCUSS] [SIP-92] Proposal for restructuring the Python code base

2023-01-20 Thread John Bodley
Hi, I was hoping to start a formal discussion for [SIP-92] Proposal for restructuring the Python code base which should indirectly help both with the quality and developer experience initiatives. Thanks -John

[RESULT][VOTE][SIP-64] Migrate filter_box to Dashboard Native Filter Component

2022-11-23 Thread John Bodley
Hi. Thanks to everyone who voted. The vote has passed with seven +1 binding votes, zero +0 votes, and zero -1 votes. Binding +1 votes: - Diego Pucci - Erik Ritter - Evan Rusackas - Krist Wongsuphasawat - Michael Molina - Srini Kadamati - Yongjie Zhao Thanks -John

[VOTE][SIP-64] Migrate filter_box to Dashboard Native Filter Component

2022-11-07 Thread John Bodley
Hi, Following up from the corresponding DISCUSS email I sent on 10/28, I was hoping to call a vote on [SIP-64] Migrate filter_box to Dashboard Native Filter Component —specfically the augmented proposal outlined in this comment

[DISCUSS] [SIP-64] Migrate filter_box to Dashboard Native Filter Component

2022-10-28 Thread John Bodley
Hi, Although [SIP-64] Migrate filter_box to Dashboard Native Filter Component was authored almost 18 months ago it was never put to a vote. Furthermore, though the work was partially completed (per apache/superset#16992)

Re: [VOTE][SIP-82] Improving Superset Theming

2022-06-06 Thread John Bodley
+1 (binding) On Mon, Jun 6, 2022 at 9:15 AM Diego Pucci wrote: > +1 (Binding) > > On Mon, Jun 6, 2022, 18:59 Craig Rueda wrote: > > > +1 > > > > On Mon, Jun 6, 2022 at 5:34 AM Michael S. Molina < > > michael.s.mol...@gmail.com> > > wrote: > > > > > Hi all, > > > > > > I'd like to call for a

Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0

2022-02-14 Thread John Bodley
+1 (binding) Thanks Aaron for coordinating this. On Tue, Feb 15, 2022 at 2:07 PM Elizabeth Thompson wrote: > +1 Binding > > > On Feb 14, 2022, at 5:02 PM, Aaron Suddjian wrote: > > > > In the process of checking the list, I noticed that "Turn on > > SQLLAB_BACKEND_PERSISTENCE by default"

Re: [VOTE][SIP-79] Guidelines for Superset PMC Membership

2022-01-26 Thread John Bodley
+1 (binding) On Thu, Jan 27, 2022 at 9:52 AM Kamil Gabryjelski < kamil.gabryjel...@gmail.com> wrote: > +1 > > śr., 26 sty 2022, 18:01 użytkownik Evan Rusackas napisał: > > > Hello everyone, > > > > Thank you for all the prior discussion on the proposal. Some adjustments > > and clarifications

Rethinking the Apache Superset Operational Model

2021-11-08 Thread John Bodley
*TL;DR* We are in the process of rethinking (formalizing) the Apache Superset Operational Model and wanted to both inform contributors about this work and request their feedback and contributions to help make this a reality. *What* In late August members of the Apache Superset community

Re: [VOTE][SIP-68] A better model for Datasets

2021-11-04 Thread John Bodley
+1 binding On Wed, Nov 3, 2021 at 4:24 PM Elizabeth Thompson wrote: > +1 binding > > > On Nov 3, 2021, at 3:47 PM, Beto Dealmeida > wrote: > > > > Hi Superset community, > > > > This is a call to vote for [SIP-68] A better model for Datasets < >

Re: [VOTE][SIP-58] Proposal to move superset-ui to this repo, "Monorepo"

2021-11-02 Thread John Bodley
+1 (binding) On Tue, Nov 2, 2021 at 2:36 PM Kamil Gabryjelski < kamil.gabryjel...@gmail.com> wrote: > +1! > > wt., 2 lis 2021, 22:28 użytkownik Ville Brofeldt < > ville.v.brofe...@gmail.com> > napisał: > > > Hello Superset Community, > > > > This is a call to vote for SIP-58: Proposal to move

Re: [VOTE][SIP-46]: Proposal for strict pylint enforcement

2021-10-25 Thread John Bodley
M -0700, Furkan KAMACI < > > furkankam...@gmail.com > > > >, > > > > > wrote: > > > > > > Hi, > > > > > > > > > > > > +1 (non-binding). > > > > > > > > > > > > Kind Regards

Re: [VOTE][SIP-64] Migrate filter_box to Dashboard Native Filter Component

2021-10-07 Thread John Bodley
+1 On Thu, Oct 7, 2021 at 3:01 PM Zuzana Vejrazkova wrote: > +1 > > On Thu, Oct 7, 2021 at 11:01 AM Srinivasa Kadamati > wrote: > > > +1 (non-binding). About time we bury this!! > > > > On Thu, Oct 7, 2021 at 1:58 PM Erik Ritter > > wrote: > > > > > +1 (binding) > > > > > > Erik > > > > > >

Re: Apache Superset Operational Model Breakout Groups

2021-09-13 Thread John Bodley
Hi, A friendly reminder, for those that are interested in participating, please respond before September 18th. Thanks -John On Fri, Sep 3, 2021 at 1:54 PM John Bodley wrote: > Hi, > > As some of you may be aware, we recently undertook a > brainstorming exercise to disc

Apache Superset Operational Model Breakout Groups

2021-09-03 Thread John Bodley
aking in any of these breakout sessions (I suspect the commitment will be an hour or so for a few sessions with the possibility of some homework tasks) please contact me either via email or Slack—"John Bodley (Airbnb)" with the following details before September 18th: 1. Your email addre

Re: [VOTE][SIP-24]: Proposal to introduce Flask app factory pattern

2021-04-21 Thread John Bodley
+1 On Thu, Apr 22, 2021 at 2:14 PM Craig Rueda wrote: > Hello Superset Community, > > This is another *very belated* call to vote for a SIP -- SIP-24 - Proposal > to introduce Flask app factory pattern: > https://github.com/apache/superset/issues/8318 > > Note that there was already a DISCUSS

[DISCUSS][SIP-11] Proposal for deprecating Druid REST connector

2021-04-21 Thread John Bodley
Hi, [SIP-11] Proposal for deprecating Druid REST connector was never officially brought up on this list for discussion. If you have any fresh context, please feel free to comment. Thanks -John

[VOTE][SIP-46]: Proposal for strict pylint enforcement

2021-04-21 Thread John Bodley
Hello Superset Community, This is a (very belated) call to vote for SIP-46: Proposal for strict pylint enforcement . The vote will be open for at least 1 week or until the necessary number of votes are reached. Please vote accordingly: [ ] +1

Re: [VOTE] Release Apache Superset (incubating) 0.38.0 based on Superset 0.38.0rc3

2020-11-06 Thread John Bodley
+1 (binding) > On Nov 6, 2020, at 8:25 AM, Craig Rueda wrote: > > +1 > > - Craig > >> On Nov 6, 2020, at 3:14 AM, daniel gaspar wrote: >> >> Hello Superset Community, >> >> This is a call for the vote to release Apache Superset >> (incubating) version 0.38.0. >> >> The release

Re: [VOTE] Release Apache Superset (incubating) 0.38.0 based on Superset 0.38.0rc2

2020-11-02 Thread John Bodley
+1 (binding) > On Nov 2, 2020, at 2:11 PM, Aaron Suddjian wrote: > > +1, binding > >> On Mon, Nov 2, 2020 at 10:13 AM William Barrett wrote: >> >> +1 (binding) >> >> Will Barrett >> Staff Software Engineer >> Preset, Inc. | https://preset.io >>> On Nov 2, 2020, 2:51 AM -0800, daniel gaspar

Re: [VOTE] Release Apache Superset (incubating) 0.37.2 based on Superset 0.37.2rc1

2020-09-16 Thread John Bodley
+1 (binding) > On Sep 16, 2020, at 7:52 AM, Craig Rueda wrote: > > +1 > > - Craig > >> On Sep 16, 2020, at 4:50 AM, Jim Jagielski wrote: >> >> +1 (binding) >> On Sep 16, 2020, at 4:34 AM, Ville Brofeldt wrote: >>> >>> Hello Superset Community, >>> >>> This is a call for the