[jira] [Commented] (THRIFT-4259) Thrift does not compile due to Ant Maven task errors

2018-01-12 Thread Alexander Volanis (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324891#comment-16324891 ] Alexander Volanis commented on THRIFT-4259: --- I am going to attempt converting the Java library

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324709#comment-16324709 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread vgotra
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Thanks - as I remember - I already merged (not re-based) some changes from master to pull request branch (in one or few previous commits) - not sure that this will correctly work with squash. ---

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324696#comment-16324696 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I'll squash it then. For future reference there are instructions on squashing here: https://thrift.apache.org/docs/HowToContribute ---

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324601#comment-16324601 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread vgotra
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hard to say - this can cause some time to make a single commit in manual way - if you know how I can make it fast and in simple way - then I can try to do it. Or we can simply re-run CI tests and

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324557#comment-16324557 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Would it be possible for you to squash this to a single commit, or does the commit history contain rebases? ---

[GitHub] thrift pull request #1466: THRIFT-4454 Large writes/reads may cause range ch...

2018-01-12 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1466 THRIFT-4454 Large writes/reads may cause range check errors in debug … …mode Client: Delphi Patch: Jens Geyer You can merge this pull request into a Git repository by running:

[jira] [Commented] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324554#comment-16324554 ] ASF GitHub Bot commented on THRIFT-4454: GitHub user Jens-G opened a pull request:

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324550#comment-16324550 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 I saw a dart signing key issue about 30 minutes ago, so yes it could be that. ---

[jira] [Updated] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode

2018-01-12 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4454: --- Summary: Large writes/reads may cause range check errors in debug mode (was: Large writes may cause

[jira] [Created] (THRIFT-4454) Large writes may cause range check errors in debug mode

2018-01-12 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4454: -- Summary: Large writes may cause range check errors in debug mode Key: THRIFT-4454 URL: https://issues.apache.org/jira/browse/THRIFT-4454 Project: Thrift Issue

[jira] [Commented] (THRIFT-82) Common Lisp support

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324523#comment-16324523 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue:

[jira] [Created] (THRIFT-4453) Go generator flag to turn off Context parameter

2018-01-12 Thread Renan DelValle (JIRA)
Renan DelValle created THRIFT-4453: -- Summary: Go generator flag to turn off Context parameter Key: THRIFT-4453 URL: https://issues.apache.org/jira/browse/THRIFT-4453 Project: Thrift Issue

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324417#comment-16324417 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread vgotra
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Yes - it can be (if such self-signed certs are not trusted and if it not possible to build and validate the chain - but we cannot change that, because this will cause security problems at

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324407#comment-16324407 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 All our tests use self-signed certificates... so validating the chain may result in a certificate error? ---

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread vgotra
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Hm - for csharp for tests I enabled validation of any certificate to be successful ``` csharp ((sender, certificate, chain, errors) => true, ) ``` in server tests code Do you

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324244#comment-16324244 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324235#comment-16324235 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 The log is there: ``` === *** Following 1 failures were unexpected ***: If it is introduced by you, please

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324224#comment-16324224 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread vgotra
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 Something at https://travis-ci.org/apache/thrift/jobs/328143179 - but locally I cannot reproduce this problem - also no logs at Travis CI. ---

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324154#comment-16324154 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 Currently the Ubuntu Xenial image which runs our cross tests in CI is installing dotnet-sdk-2.0.3, as is our Ubuntu Artful image. The latest is dotnet-sdk-2.1.4. Normally we like to have an older

[jira] [Commented] (THRIFT-82) Common Lisp support

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324147#comment-16324147 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue:

[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 Let me know what the commands are to add lisp to an Ubuntu Xenial system. We need to update the Dockerfile to include Common Lisp so that it actually runs in the build system. This has to happen

[GitHub] thrift pull request #1465: THRIFT-4352: update artful to use haxe 3.4.4 whic...

2018-01-12 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1465 THRIFT-4352: update artful to use haxe 3.4.4 which fixes a core in haxe You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324123#comment-16324123 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread vgotra
Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1449 It's already enabled - I removed disabled for netcore from tests.json ---

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324107#comment-16324107 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 To get netcore cross test running as a server you need to change "server-disabled" to "server" in test/tests.json, by the way... ---

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324085#comment-16324085 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324047#comment-16324047 ] ASF GitHub Bot commented on THRIFT-4434: Github user vgotra commented on the issue:

[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323930#comment-16323930 ] ASF GitHub Bot commented on THRIFT-4390: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1458: THRIFT-4390: Fix bug where binary/buffered messag...

2018-01-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1458 ---

[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323920#comment-16323920 ] ASF GitHub Bot commented on THRIFT-4452: Github user RobberPhex commented on a diff in the pull

[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile

2018-01-12 Thread RobberPhex
Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161216512 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl

[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323915#comment-16323915 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1464: THRIFT-4452: optimize Dockerfile

2018-01-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1464 I wish Dockerfile had a INCLUDE directive where common stuff could be factored out! ---

[jira] [Commented] (THRIFT-4390) Rust binary protocol and buffered transport cannot handle writes above 4096 bytes

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323913#comment-16323913 ] ASF GitHub Bot commented on THRIFT-4390: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1458: THRIFT-4390: Fix bug where binary/buffered messages > 4K...

2018-01-12 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1458 @jeking3 Looks like everything passed, so this patch is good to go. TY! ---

[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323911#comment-16323911 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323912#comment-16323912 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile

2018-01-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215374 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl

[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile

2018-01-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215273 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl

[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323909#comment-16323909 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile

2018-01-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161215006 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl

[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

2018-01-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4352: --- Component/s: Build Process > Ubuntu Artful doesn't appear to be compatible with

[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

2018-01-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4352: --- Component/s: (was: Build Process) > Ubuntu Artful doesn't appear to be

[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

2018-01-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4352: --- Environment: docker ubuntu-artful with haxe 3.4.2 (stock) (was: docker

[jira] [Commented] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

2018-01-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323905#comment-16323905 ] James E. King, III commented on THRIFT-4352: Good news - the latest Haxe 3.4.4 seems to work

[jira] [Updated] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

2018-01-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4352: --- Summary: Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4.2

[jira] [Assigned] (THRIFT-4352) Ubuntu Artful doesn't appear to be compatible with Thrift and Haxe 3.4

2018-01-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4352: -- Assignee: James E. King, III > Ubuntu Artful doesn't appear to be compatible

[jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323895#comment-16323895 ] ASF GitHub Bot commented on THRIFT-4452: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1464: THRIFT-4452: optimize Dockerfile

2018-01-12 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1464#discussion_r161212364 --- Diff: build/docker/ubuntu-artful/Dockerfile --- @@ -41,10 +43,21 @@ RUN apt-get update && \ # dotnet (core) RUN curl

[GitHub] thrift pull request #1340: THRIFT-4295: reworked docker images to resolve bu...

2018-01-12 Thread stigsb
Github user stigsb commented on a diff in the pull request: https://github.com/apache/thrift/pull/1340#discussion_r161191042 --- Diff: lib/php/lib/Thrift/Transport/TSocket.php --- @@ -242,8 +242,10 @@ public function open() throw new TException($error); }

[jira] [Commented] (THRIFT-4295) Refresh the Docker image file suite for Ubuntu, Debian, and CentOS

2018-01-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323818#comment-16323818 ] ASF GitHub Bot commented on THRIFT-4295: Github user stigsb commented on a diff in the pull