Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161389750
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds for
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161389720
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds for
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161389670
--- Diff: lib/java/build.gradle ---
@@ -0,0 +1,495 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161387659
--- Diff: lib/java/build.gradle ---
@@ -0,0 +1,495 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161387623
--- Diff: lib/java/CMakeLists.txt ---
@@ -17,14 +17,13 @@
# under the License.
#
-file(GLOB java_sources src/**/*.java)
-
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161387726
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds for fd303
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161387735
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds for fd303
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161387718
--- Diff: lib/java/gradle.properties ---
@@ -0,0 +1,35 @@
+# This file is shared currently between this Gradle build and the
+# Ant builds for fd303
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1469
Looks like another problem in the older Trusty environment; this time ruby
rack-test updated and dropped support for older ruby environments.
---
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1469
Thrift 4434: squashed
There were 22 commits to squash - I hope I got them all. Had to do some
cleanup commits after. Will the CI gods bless us with green checkmarks?
You can merge this pull
[
https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325384#comment-16325384
]
Alexander Volanis commented on THRIFT-4259:
---
I submitted a Pull Request
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161384041
--- Diff: lib/java/gradle/wrapper/gradle-wrapper.properties ---
@@ -0,0 +1,5 @@
+distributionBase=GRADLE_USER_HOME
--- End diff --
This
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161384037
--- Diff: lib/java/gradlew ---
@@ -0,0 +1,172 @@
+#!/usr/bin/env sh
--- End diff --
This script is autogenerated by the Gradle Wrapper
Github user Alex-Vol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1468#discussion_r161384031
--- Diff: lib/java/gradlew.bat ---
@@ -0,0 +1,84 @@
+@if "%DEBUG%" == "" @echo off
--- End diff --
This script is autogenerated by the
GitHub user Alex-Vol opened a pull request:
https://github.com/apache/thrift/pull/1468
Thrift 4259: Thrift does not compile due to Ant Maven task errors
This pull request changes the build system used to Gradle. The integration
uses the recommended and popular option of the Gradle
[
https://issues.apache.org/jira/browse/THRIFT-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325340#comment-16325340
]
ASF GitHub Bot commented on THRIFT-4455:
GitHub user Jens-G opened a pull request:
Jens Geyer created THRIFT-4455:
--
Summary: Missing dispose calls in ThreadedServer & ThreadpoolServer
Key: THRIFT-4455
URL: https://issues.apache.org/jira/browse/THRIFT-4455
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-4454.
Resolution: Fixed
Committed
> Large writes/reads may cause range check errors in debug mode
>
[
https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325328#comment-16325328
]
ASF GitHub Bot commented on THRIFT-4454:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1466
---
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
and one more change: ensure-externals uses `[[` syntax, so it must be run
with bash (not sh) â modified makefile and script to take this requirement
into account.
---
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325288#comment-16325288
]
ASF GitHub Bot commented on THRIFT-82:
--
Github user dkochmanski commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325284#comment-16325284
]
ASF GitHub Bot commented on THRIFT-82:
--
Github user dkochmanski commented on the issue:
Github user dkochmanski commented on the issue:
https://github.com/apache/thrift/pull/1412
@jeking3 Thanks for the pointers. I've added requested info and updated
Dockerfiles. Also rebased against master.
---
[
https://issues.apache.org/jira/browse/THRIFT-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325201#comment-16325201
]
James E. King, III commented on THRIFT-4259:
Remember that we use autoconf on linux and cmake
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325198#comment-16325198
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1449
I changed the lib/netcore/Makefile.am to this, maybe it's enough to do both:
```
SUBDIRS = .
all-local: \
$(DOTNETCORE) build
check-local: \
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1449
Okay, well, I squashed it all and found the following issues:
1. I don't see any netcore tests being run in the autotools build (make
check). It builds some things but I don't see any test
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325197#comment-16325197
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325192#comment-16325192
]
ASF GitHub Bot commented on THRIFT-4434:
Github user vgotra commented on a diff in the pull
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375270
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
As usually - some settings of different editors. Maybe you can provide
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325191#comment-16325191
]
ASF GitHub Bot commented on THRIFT-4434:
Github user vgotra commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325190#comment-16325190
]
ASF GitHub Bot commented on THRIFT-4434:
Github user vgotra commented on a diff in the pull
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375244
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375224
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325188#comment-16325188
]
ASF GitHub Bot commented on THRIFT-4434:
Github user vgotra commented on a diff in the pull
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375213
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user vgotra commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161375191
--- Diff: test/features/known_failures_Linux.json ---
@@ -1,46 +1,48 @@
[
- "c_glib-limit_container_length_binary_buffered-ip",
--- End diff --
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325185#comment-16325185
]
ASF GitHub Bot commented on THRIFT-4434:
Github user vgotra commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161374818
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
Here's the diff
```
diff tests.json.old.normalized
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325174#comment-16325174
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325159#comment-16325159
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373936
--- Diff: test/tests.json ---
@@ -1,689 +1,686 @@
-[
--- End diff --
By changing the indentation you have made it a very difficult task to
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325154#comment-16325154
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1449
I'll cleanup the autoconf issues I see here, and probably submit another PR
for the squash and fixup to make sure it still works properly. This will
probably take a little while though.
---
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325152#comment-16325152
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373681
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325150#comment-16325150
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325149#comment-16325149
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373426
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161373415
--- Diff: lib/netcore/Makefile.am ---
@@ -19,86 +19,25 @@
SUBDIRS = .
-THRIFT = $(top_builddir)/compiler/cpp/thrift
-
-TESTDIR
[
https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325146#comment-16325146
]
ASF GitHub Bot commented on THRIFT-4434:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1449#discussion_r161372982
--- Diff: test/features/known_failures_Linux.json ---
@@ -1,46 +1,48 @@
[
- "c_glib-limit_container_length_binary_buffered-ip",
--- End diff
53 matches
Mail list logo
