[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-14 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161421393 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-14 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161412135 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for fd303

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-14 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161404044 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-14 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161403984 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161389750 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161389720 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161389670 --- Diff: lib/java/build.gradle --- @@ -0,0 +1,495 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161387659 --- Diff: lib/java/build.gradle --- @@ -0,0 +1,495 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161387623 --- Diff: lib/java/CMakeLists.txt --- @@ -17,14 +17,13 @@ # under the License. # -file(GLOB java_sources src/**/*.java) -

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161387726 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for fd303

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161387735 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for fd303

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161387718 --- Diff: lib/java/gradle.properties --- @@ -0,0 +1,35 @@ +# This file is shared currently between this Gradle build and the +# Ant builds for fd303

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161384041 --- Diff: lib/java/gradle/wrapper/gradle-wrapper.properties --- @@ -0,0 +1,5 @@ +distributionBase=GRADLE_USER_HOME --- End diff -- This

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161384037 --- Diff: lib/java/gradlew --- @@ -0,0 +1,172 @@ +#!/usr/bin/env sh --- End diff -- This script is autogenerated by the Gradle Wrapper

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
Github user Alex-Vol commented on a diff in the pull request: https://github.com/apache/thrift/pull/1468#discussion_r161384031 --- Diff: lib/java/gradlew.bat --- @@ -0,0 +1,84 @@ +@if "%DEBUG%" == "" @echo off --- End diff -- This script is autogenerated by the

[GitHub] thrift pull request #1468: Thrift 4259: Thrift does not compile due to Ant M...

2018-01-13 Thread Alex-Vol
GitHub user Alex-Vol opened a pull request: https://github.com/apache/thrift/pull/1468 Thrift 4259: Thrift does not compile due to Ant Maven task errors This pull request changes the build system used to Gradle. The integration uses the recommended and popular option of the Gradle