[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952514#comment-15952514
]
James E. King, III commented on THRIFT-2457:
This issue stalled; there's an open pull request
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170363#comment-15170363
]
Aki Sukegawa commented on THRIFT-2457:
--
[~andrewcox79] would you accept pull requests if we send
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044738#comment-15044738
]
Jens Geyer commented on THRIFT-2457:
@[~andrewcox79] & [~roger.meier],
re other languages: IMHO we
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042243#comment-15042243
]
ASF GitHub Bot commented on THRIFT-2457:
Github user bufferoverflow commented on the pull
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039490#comment-15039490
]
Andrew Cox commented on THRIFT-2457:
I've sent up https://github.com/apache/thrift/pull/731 which
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030281#comment-15030281
]
Roger Meier commented on THRIFT-2457:
-
I just had a look at the fbthrift source long time ago and
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028782#comment-15028782
]
Markus Werle commented on THRIFT-2457:
--
Is there any chance that introducing float will take place
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029246#comment-15029246
]
Roger Meier commented on THRIFT-2457:
-
We just need to rebase the patches, add float to cross
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029268#comment-15029268
]
Jens Geyer commented on THRIFT-2457:
... plus add it to several languages that are not part of
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029287#comment-15029287
]
Aki Sukegawa commented on THRIFT-2457:
--
[~roger.meier] I couldn't find "the patch", which one do you
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738301#comment-14738301
]
Martin Ba commented on THRIFT-2457:
---
Has anything been done wrt. this issue / float32 support?
It
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988139#comment-13988139
]
Roger Meier commented on THRIFT-2457:
-
[~jensg] A compiler supporting float will
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988152#comment-13988152
]
Randy Abernethy commented on THRIFT-2457:
-
I also think float would be a nice to
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988161#comment-13988161
]
Ben Craig commented on THRIFT-2457:
---
I would argue for a warning like the following:
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988196#comment-13988196
]
Jens Geyer commented on THRIFT-2457:
@[~ben.craig]: +1 this way the warning _ensure
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980838#comment-13980838
]
Jens Geyer commented on THRIFT-2457:
Just to follow up on the type code thoughts:
A
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980918#comment-13980918
]
Andrew Cox commented on THRIFT-2457:
In binary, float and i32 are both 4 bytes, so
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13981782#comment-13981782
]
Jens Geyer commented on THRIFT-2457:
I just noticed that the list / set / map and
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979773#comment-13979773
]
Jens Geyer commented on THRIFT-2457:
Another, maybe simpler version could be to
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979787#comment-13979787
]
Andrew Cox commented on THRIFT-2457:
But how will versioning the protocol here
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979794#comment-13979794
]
Ben Craig commented on THRIFT-2457:
---
Hopefully it helps in that we can tell the person
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979979#comment-13979979
]
Andrew Cox commented on THRIFT-2457:
Ben, the problem I think is that receivers
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980184#comment-13980184
]
Jens Geyer commented on THRIFT-2457:
{quote}
But how will versioning the protocol
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980194#comment-13980194
]
Roger Meier commented on THRIFT-2457:
-
I think bump of version is not required for
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980198#comment-13980198
]
Jens Geyer commented on THRIFT-2457:
[~roger.meier]: Assumed, I just received the
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980240#comment-13980240
]
Ben Craig commented on THRIFT-2457:
---
Here are some questions we need to explicitly
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980304#comment-13980304
]
Jens Geyer commented on THRIFT-2457:
[~roger.meier] What version has the compiler
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976034#comment-13976034
]
Roger Meier commented on THRIFT-2457:
-
Yes, Ben this might cause issues.
However save
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976049#comment-13976049
]
Ben Craig commented on THRIFT-2457:
---
Maybe scan the entire .thrift file for usages of
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976226#comment-13976226
]
Jens Geyer commented on THRIFT-2457:
We are still at 0.9.x, so we have a certain
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972925#comment-13972925
]
Ben Craig commented on THRIFT-2457:
---
I do have a concern about adding new types. Say
[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965491#comment-13965491
]
Dave Watson commented on THRIFT-2457:
-
It looks like it was implemented for cpp, py,
32 matches
Mail list logo
