[
https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250633#comment-16250633
]
ASF GitHub Bot commented on TINKERPOP-1830:
---
Github user mpollmeier commented on the issue:
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/745
ok that's done. added a changelog entry, merged this branch into tp32 and
merged tp32 into master.
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/745
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250629#comment-16250629
]
ASF GitHub Bot commented on TINKERPOP-1830:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TINKERPOP-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249953#comment-16249953
]
ASF GitHub Bot commented on TINKERPOP-1807:
---
Github user FlorianHockmann commented on the
[
https://issues.apache.org/jira/browse/TINKERPOP-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249917#comment-16249917
]
ASF GitHub Bot commented on TINKERPOP-1807:
---
Github user davebshow commented on a diff in
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/741#discussion_r150620490
--- Diff:
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
@@ -121,6 +125,19 @@ class X(object):
[
https://issues.apache.org/jira/browse/TINKERPOP-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249860#comment-16249860
]
ASF GitHub Bot commented on TINKERPOP-1813:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/743
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249787#comment-16249787
]
ASF GitHub Bot commented on TINKERPOP-1807:
---
Github user davebshow commented on a diff in
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/741#discussion_r150589566
--- Diff:
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
@@ -121,6 +125,19 @@ class X(object):
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249753#comment-16249753
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on the issue:
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
`docker/build.sh -t -n -i` succeeds and tests pass.
VOTE: +1
---
Github user jorgebay commented on the issue:
https://github.com/apache/tinkerpop/pull/747
Fixes look good to me!
I'm running integration tests locally on docker and I'll come back to give
my plus one.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249576#comment-16249576
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on the issue:
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249570#comment-16249570
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249569#comment-16249569
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150542775
--- Diff:
gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150542730
--- Diff: gremlin-python/src/main/jython/radish/feature_steps.py ---
@@ -0,0 +1,231 @@
+'''
+Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/TINKERPOP-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249538#comment-16249538
]
ASF GitHub Bot commented on TINKERPOP-1830:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/745
sorry - i missed the `tp32` comment in your description. your changes look
fine now.
VOTE +1
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249536#comment-16249536
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user spmallette commented on the issue:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/747
@jorgebay fixed all the nits - thanks.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249532#comment-16249532
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user spmallette commented on a diff in
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150531652
--- Diff:
gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150530902
--- Diff: gremlin-python/src/main/jython/radish/feature_steps.py ---
@@ -0,0 +1,231 @@
+'''
+Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/TINKERPOP-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249521#comment-16249521
]
ASF GitHub Bot commented on TINKERPOP-1807:
---
Github user FlorianHockmann commented on a diff
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/741#discussion_r150529077
--- Diff:
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
@@ -121,6 +125,19 @@ class X(object):
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249454#comment-16249454
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150497558
--- Diff: gremlin-python/src/main/jython/radish/feature_steps.py ---
@@ -0,0 +1,231 @@
+'''
+Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249453#comment-16249453
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249455#comment-16249455
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249456#comment-16249456
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
[
https://issues.apache.org/jira/browse/TINKERPOP-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249457#comment-16249457
]
ASF GitHub Bot commented on TINKERPOP-1784:
---
Github user jorgebay commented on a diff in the
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150476717
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs ---
@@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150517147
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs ---
@@ -36,15 +36,27 @@ namespace Gremlin.Net.Driver.Remote
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150477310
--- Diff: gremlin-python/pom.xml ---
@@ -440,6 +440,17 @@ limitations under the License.
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/747#discussion_r150502204
--- Diff:
gremlin-test/src/test/java/org/apache/tinkerpop/gremlin/process/FeatureCoverageTest.java
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to
38 matches
Mail list logo