[VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
Hi, Mod_jk 1.2.22 has been available for testing for some days. No new bugs have been reported so far, so it is time to proceed with the release vote. The source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.22/ or

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread William A. Rowe, Jr.
Mladen Turk wrote: The source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.22/ or http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/ May I ask -why-? It's not released (quite yet, has 0 votes) - what on

Re: Candidate binaries for 6.0.11

2007-04-13 Thread Peter Rossbach
Hi, I also see the APR JMX memory leak with following APR Connector config Connector port=30011 URIEncoding=UTF-8 useExecutor=false minSpareThreads=150 maxSpareThreads=150

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: The source distribution can be downloaded from: http://tomcat.apache.org/dev/dist/tomcat-connectors/jk/source/jk-1.2.22/ or http://www.apache.org/dist/tomcat/tomcat-connectors/jk/source/jk-1.2.22/ May I ask -why-? It's not released (quite yet,

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread William A. Rowe, Jr.
Mladen Turk wrote: Don't understand your question. It was more then a week available for a developers review. The official stable is still 1.2.21 until 1.2.22 gets votes or not, in which case we'll go for 1.2.23. So what's the problem? How many times will I repeat to this list that until

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: Don't understand your question. It was more then a week available for a developers review. The official stable is still 1.2.21 until 1.2.22 gets votes or not, in which case we'll go for 1.2.23. So what's the problem? How many times will I repeat

Re: Candidate binaries for 6.0.11

2007-04-13 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: The memory leak exists in the APR and JIO connector, when and only when they use the shared Executor and the Executor has a minSpareThreadsmaxThreads. I know that, I was planning to adapt your patch. Rémy

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread William A. Rowe, Jr.
Mladen Turk wrote: I suggest you revoke my commit privileges to the www.apache.org/dist/ so it won't happen again and you won't need to repeat this again. I'm sure infra would be happy to if you would prefer this. I'm assuming the (this might be news to you) was news to you, but this struck

Re: Candidate binaries for 6.0.11

2007-04-13 Thread Remy Maucherat
Peter Rossbach wrote: I also see the APR JMX memory leak with following APR Connector config minSpareThreads=150 maxSpareThreads=150 maxThreads=150 I don't think there's a leak in that connector. For starters minSpareThreads and

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: Mladen Turk wrote: I suggest you revoke my commit privileges to the www.apache.org/dist/ so it won't happen again and you won't need to repeat this again. I'm sure infra would be happy to if you would prefer this. LOL. Man, you really don't like me ;) Is it

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Yoav Shapira
Hi, On 4/13/07, Mladen Turk [EMAIL PROTECTED] wrote: William A. Rowe, Jr. wrote: Mladen Turk wrote: I suggest you revoke my commit privileges to the www.apache.org/dist/ so it won't happen again and you won't need to repeat this again. I'm sure infra would be happy to if you would prefer

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Henri Gomez
Let's try to chill out, please ;) I'm sure putting the candidate binaries on the official mirrors before the vote was an honest mistake. So let's move them to /dev/dist, have a proper vote like we're having right now, and then put the legit release on the mirrors again in a couple of days. +1

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Rainer Jung
Apache Tomcat Connectors 1.2.22 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Thanks for RM. -

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Guenter Knauf
Apache Tomcat Connectors 1.2.22 is: [x] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Guenter. -

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Jim Jagielski
On Apr 13, 2007, at 7:20 AM, Yoav Shapira wrote: Let's try to chill out, please ;) I'm sure putting the candidate binaries on the official mirrors before the vote was an honest mistake. So let's move them to /dev/dist, have a proper vote like we're having right now, and then put the legit

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Jim Jagielski
On Apr 13, 2007, at 2:33 AM, Mladen Turk wrote: Hi, Apache Tomcat Connectors 1.2.22 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are So let it be written; so

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
Jim Jagielski wrote: On Apr 13, 2007, at 7:20 AM, Yoav Shapira wrote: Let's try to chill out, please ;) I'm sure putting the candidate binaries on the official mirrors before the vote was an honest mistake. ++1 (especially on the chill out part ;) ) !! I think the issue is that,

svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 08:32:19 2007 New Revision: 528524 URL: http://svn.apache.org/viewvc?view=revrev=528524 Log: This write has to be synchronized since comet can write to the buffer and cause a buffer overflow if more than one thread is writing Modified:

svn commit: r528526 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 08:33:44 2007 New Revision: 528526 URL: http://svn.apache.org/viewvc?view=revrev=528526 Log: if the flush is not guaranteed, then try again Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Modified:

svn commit: r528528 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 08:39:44 2007 New Revision: 528528 URL: http://svn.apache.org/viewvc?view=revrev=528528 Log: Prevent NPE on a key that was cancelled by the poller Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified:

Re: svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: fhanik Date: Fri Apr 13 08:32:19 2007 New Revision: 528524 URL: http://svn.apache.org/viewvc?view=revrev=528524 Log: This write has to be synchronized since comet can write to the buffer and cause a buffer overflow if more than one thread is writing That's

DO NOT REPLY [Bug 42115] New: - WebappClassLoader.loadClass throws java.lang.ClassNotFoundException: [Ljava.lang.String; in JDK 6.0

2007-04-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=42115. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 41949] - mod_jk 1.2.21 POST JSP Page SSI JSP sub request does not complete

2007-04-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=41949. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Jim Jagielski
On Apr 13, 2007, at 10:00 AM, Mladen Turk wrote: Jim Jagielski wrote: On Apr 13, 2007, at 7:20 AM, Yoav Shapira wrote: Let's try to chill out, please ;) I'm sure putting the candidate binaries on the official mirrors before the vote was an honest mistake. ++1 (especially on the chill out

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Peter Rossbach
+1 Am 13.04.2007 um 08:33 schrieb Mladen Turk: So here's the vote, which will be open until Tuesday April 17, 12:00 GMT. Apache Tomcat Connectors 1.2.22 is: [x] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple

Re: svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: fhanik Date: Fri Apr 13 08:32:19 2007 New Revision: 528524 URL: http://svn.apache.org/viewvc?view=revrev=528524 Log: This write has to be synchronized since comet can write to the buffer and cause a buffer overflow if more than one thread

svn commit: r528551 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 09:51:54 2007 New Revision: 528551 URL: http://svn.apache.org/viewvc?view=revrev=528551 Log: prevent a timeout when a servlet write is issued, but not flushed Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Modified:

DO NOT REPLY [Bug 42103] - Parans trustStoreType trustStorePass trustStoreFile

2007-04-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=42103. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 42103] - Parans trustStoreType trustStorePass trustStoreFile

2007-04-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=42103. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

svn commit: r528570 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 11:08:43 2007 New Revision: 528570 URL: http://svn.apache.org/viewvc?view=revrev=528570 Log: Use the remaining for the byte buffer as the capacity is the total capacity and not the limit Modified:

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread William A. Rowe, Jr.
Jim Jagielski wrote: On Apr 13, 2007, at 10:00 AM, Mladen Turk wrote: Jim Jagielski wrote: On Apr 13, 2007, at 7:20 AM, Yoav Shapira wrote: Let's try to chill out, please ;) I'm sure putting the candidate binaries on the official mirrors before the vote was an honest mistake. ++1

DO NOT REPLY [Bug 42119] New: - request.getCharacterEncoding misparses charset=UTF-8; xyz=3

2007-04-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=42119. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

svn commit: r528594 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 12:05:01 2007 New Revision: 528594 URL: http://svn.apache.org/viewvc?view=revrev=528594 Log: consolidate usage between executor runnables and worker threads Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified:

svn commit: r528605 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 12:16:08 2007 New Revision: 528605 URL: http://svn.apache.org/viewvc?view=revrev=528605 Log: remove redundant calls, easier to track usage Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified:

Re: svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Lets say you have two threads writing to the response (async write from comet) both of them could end up on the line: socket.getBufHandler().getWriteBuffer().put(buf, offset, length); assuming nothing is synced in the path down to here, hence causing a buffer

svn commit: r528702 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors: TcpFailureDetector.java TcpPingInterceptor.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 16:26:07 2007 New Revision: 528702 URL: http://svn.apache.org/viewvc?view=revrev=528702 Log: Added a TCP ping for membership, to be used with static memberships and with the TCP failure detector Added:

svn commit: r528735 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/core/StandardThreadExecutor.java tomcat/util/net/NioEndpoint.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 18:41:35 2007 New Revision: 528735 URL: http://svn.apache.org/viewvc?view=revrev=528735 Log: Smarter executor, only create threads if no threads are available Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardThreadExecutor.java

svn commit: r528744 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net: NioEndpoint.java SocketProperties.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 19:48:45 2007 New Revision: 528744 URL: http://svn.apache.org/viewvc?view=revrev=528744 Log: Minor optimizations Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

svn commit: r528751 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java

2007-04-13 Thread fhanik
Author: fhanik Date: Fri Apr 13 20:45:41 2007 New Revision: 528751 URL: http://svn.apache.org/viewvc?view=revrev=528751 Log: minor optimization, go directly to the poller, chances of another request being present at that very time is very slim Modified:

Re: [VOTE] Releasing Tomcat Connectors 1.2.22

2007-04-13 Thread Mladen Turk
William A. Rowe, Jr. wrote: So, can we agree I made an mistake? Hey, I make 'em all the time... No - I don't dislike you Mladen :) Nor Redhat - work with Marc and Joe all the time on httpd-stuff. Cool, let's move forward. I'll make sure I don't upload files on random places any more :)

Re: svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2007-04-13 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Lets say you have two threads writing to the response (async write from comet) both of them could end up on the line: socket.getBufHandler().getWriteBuffer().put(buf, offset, length); assuming nothing is synced in the path down to here,