Use (or not) of @SuppressWarnings

2013-08-07 Thread Mark Thomas
For trunk we have been running a policy of zero warnings in the code. This has helped to highlight issues as code is edited as any warnings are immediately clear. Obviously, this depends on what warnings are enabled. Currently, we use Eclipse's "Ignore unavoidable generic type problems." Recently

[Bug 55372] Bind JPDA_ADDRESS by default to localhost

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55372 --- Comment #3 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Mark Thomas from comment #2) > Or just change JPDA_ADDRESS back to 8000 in setenv.sh > > This has been applied to trunk and will be in 8.0.0-RC2 onwards. I'll also > a

[Bug 55372] Bind JPDA_ADDRESS by default to localhost

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55372 --- Comment #4 from Mark Thomas --- (In reply to Michael Osipov from comment #3) > (In reply to Mark Thomas from comment #2) > > Or just change JPDA_ADDRESS back to 8000 in setenv.sh > > > > This has been applied to trunk and will be in 8.

svn commit: r1511204 - /tomcat/trunk/bin/catalina.bat

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 07:53:09 2013 New Revision: 1511204 URL: http://svn.apache.org/r1511204 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55372 Make listening on localhost only be the default when enabling jpda. Modified: tomcat/trunk/bin/catalina.bat Modified: tomca

Re: jaasrealm regression

2013-08-07 Thread Mark Thomas
On 06/08/2013 08:51, Romain Manni-Bucau wrote: > Hi > > it seems we can now configure jaasrealm to use a jaas config file from the > webapp. That's great but it would need to fallback to old behavior (jaas > system property to find its location) by default otherwise apps using an > older tomcat ar

Re: jaasrealm regression

2013-08-07 Thread Romain Manni-Bucau
well maybe it does (surely since that's the LoginContext behavior) but error is not obvious at all. I didn't got time to dig deeper into it but i think you are right and the main issue is the error message which should be more explicit saying configFile was not set and system property is missing o

Re: jaasrealm regression

2013-08-07 Thread Mark Thomas
On 07/08/2013 10:21, Romain Manni-Bucau wrote: > well maybe it does (surely since that's the LoginContext behavior) but > error is not obvious at all. > > I didn't got time to dig deeper into it but i think you are right and the > main issue is the error message which should be more explicit sayin

[Bug 55372] Bind JPDA_ADDRESS by default to localhost

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55372 --- Comment #5 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Mark Thomas from comment #4) > [..] > > res/ide-support/netbeans/README.txt. Was that intentional? Though, I do not > > know how to port forward a port with RDP. > > n

Re: jaasrealm regression

2013-08-07 Thread Romain Manni-Bucau
ok, sorry i basically just set up a simple war sample using tomee maven plugin (but for the part we speak about only tomcat is relevant). This sample was using JAASRealm with the default LoginModule of tomee (properties one if you care). IIRC before when the setup was wrong you get an error messa

svn commit: r1511212 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 08:47:35 2013 New Revision: 1511212 URL: http://svn.apache.org/r1511212 Log: No functional change. Move some longer lines around prior to some functional changes. Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java Modified: tomc

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-07 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4793 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: Fixing bug 55365

2013-08-07 Thread Mark Thomas
On 07/08/2013 08:43, Mark Thomas wrote: > On 07/08/2013 08:02, Rainer Jung wrote: >> On 07.08.2013 00:26, Rainer Jung wrote: >>> For completeness I checked out r932968 and am now running the TCK under >>> security manager. I'll report the original failures that the patch >>> should have fixed later

svn commit: r1511217 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 09:16:31 2013 New Revision: 1511217 URL: http://svn.apache.org/r1511217 Log: When using a security manager always use the same method inside the doPrivileged call as triggered the call. This fixes an startup failure when running 8.0.x under a security manager as it

svn commit: r1511219 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContextFacade.java

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 09:18:31 2013 New Revision: 1511219 URL: http://svn.apache.org/r1511219 Log: No functional change. Fix long lines. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationContextFacade.java Propchange

svn commit: r1511221 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContextFacade.java webapps/docs/changelog.xml

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 09:23:07 2013 New Revision: 1511221 URL: http://svn.apache.org/r1511221 Log: When using a security manager always use the same method inside the doPrivileged call as triggered the call. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk

Re: jaasrealm regression

2013-08-07 Thread Mark Thomas
On 07/08/2013 10:33, Romain Manni-Bucau wrote: > ok, sorry > > i basically just set up a simple war sample using tomee maven plugin (but > for the part we speak about only tomcat is relevant). This sample was using > JAASRealm with the default LoginModule of tomee (properties one if you > care). >

[Bug 55365] Server fails to start with security on due to websocket classes

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55365 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55365] Server fails to start with security on due to websocket classes

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55365 --- Comment #2 from Mark Thomas --- This has been fixed in trunk (along with some related issues) and will be included in 8.0.0-RC2. It has also been back-ported to 7.0.x where it will be included in 7.0.43 onwards. -- You are receiving t

Re: Fixing bug 55365

2013-08-07 Thread Konstantin Kolinko
2013/8/6 Mark Thomas : > Rainer (or anyone else that can figure this out), > > I am in the process of fixing [1] and find myself having to revert some > of one of your commits [2]. My concern is that I can't figure out what > problem [2] was meant to solve and how it solves it. > > The problem is t

Re: jaasrealm regression

2013-08-07 Thread Romain Manni-Bucau
you are probably right but having the check "the path you specified doesn't exist" is quite easy and would be a nice enhancement (it is common to think the config is right when it is wrong). *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau

Re: Fixing bug 55365

2013-08-07 Thread Mark Thomas
On 07/08/2013 12:11, Konstantin Kolinko wrote: > From r1511217 I think you have already figured this. I hadn't figured out the classcache was the root cause but I had figured out the fix. It does mean a very small performance hit but I'm not concerned about that at this point as this is web appli

Re: [VOTE] Release Apache Taglibs 1.2.0-RC1

2013-08-07 Thread sebb
On 2 August 2013 20:32, Jeremy Boynes wrote: > A proposed release candidate Apache Taglibs 1.2.0-RC1 is now available for > voting. > > This is release candidate for an implementation of JSTL 1.2 and can be > obtained from the staging repo at: > https://repository.apache.org/content/repositori

[Bug 55357] Cannot deserialize session when it contains Externalizable objects (using PersistentManager)

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55357 maxime.fala...@gmail.com changed: What|Removed |Added OS||All --- Comment #1 from

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Nick Williams
On Aug 7, 2013, at 2:41 AM, Mark Thomas wrote: > For trunk we have been running a policy of zero warnings in the code. > This has helped to highlight issues as code is edited as any warnings > are immediately clear. Obviously, this depends on what warnings are enabled. > > Currently, we use Ecli

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #2 from Ingolf Knopf --- Created attachment 30687 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30687&action=edit part 1 of 25 Sorry about the huge war file. It contains only one jar, but this is necessary to demon

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #3 from Ingolf Knopf --- Created attachment 30688 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30688&action=edit part 2 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #4 from Ingolf Knopf --- Created attachment 30689 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30689&action=edit part 3 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #5 from Ingolf Knopf --- Created attachment 30690 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30690&action=edit part 4 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #6 from Ingolf Knopf --- Created attachment 30691 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30691&action=edit part 3 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #7 from Ingolf Knopf --- Created attachment 30692 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30692&action=edit part 6 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #8 from Ingolf Knopf --- Created attachment 30693 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30693&action=edit part 7 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #9 from Ingolf Knopf --- Created attachment 30694 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30694&action=edit part 8 of 25 -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #10 from Ingolf Knopf --- Created attachment 30695 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30695&action=edit part 9 of 25 -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #11 from Ingolf Knopf --- Created attachment 30696 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30696&action=edit part 10 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #12 from Ingolf Knopf --- Created attachment 30697 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30697&action=edit part 11 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #13 from Ingolf Knopf --- Created attachment 30698 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30698&action=edit part 11 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 Ingolf Knopf changed: What|Removed |Added Attachment #30691|part 3 of 25|part 5 of 25 description|

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 Ingolf Knopf changed: What|Removed |Added Attachment #30698|part 11 of 25 |part 12 of 25 description|

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #14 from Ingolf Knopf --- Created attachment 30699 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30699&action=edit part 13 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #15 from Ingolf Knopf --- Created attachment 30700 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30700&action=edit part 14 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #16 from Ingolf Knopf --- Created attachment 30701 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30701&action=edit part 15 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #17 from Ingolf Knopf --- Created attachment 30702 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30702&action=edit part 16 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #18 from Ingolf Knopf --- Created attachment 30703 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30703&action=edit part 17 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #20 from Ingolf Knopf --- Created attachment 30705 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30705&action=edit part 19 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #19 from Ingolf Knopf --- Created attachment 30704 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30704&action=edit part 18 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #21 from Ingolf Knopf --- Created attachment 30706 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30706&action=edit part 20 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #22 from Ingolf Knopf --- Created attachment 30707 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30707&action=edit part 21 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #23 from Ingolf Knopf --- Created attachment 30708 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30708&action=edit part 22 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #24 from Ingolf Knopf --- Created attachment 30709 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30709&action=edit part 23 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #26 from Ingolf Knopf --- Created attachment 30711 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30711&action=edit part 25 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #25 from Ingolf Knopf --- Created attachment 30710 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30710&action=edit part 24 of 25 -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 Ingolf Knopf changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #27 from Ingolf Kno

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Jeremy Boynes
On Aug 7, 2013, at 12:41 AM, Mark Thomas wrote: > For trunk we have been running a policy of zero warnings in the code. > This has helped to highlight issues as code is edited as any warnings > are immediately clear. Obviously, this depends on what warnings are enabled. > > Currently, we use Ecl

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Brian Burch
On 07/08/13 14:14, Nick Williams wrote: On Aug 7, 2013, at 2:41 AM, Mark Thomas wrote: For trunk we have been running a policy of zero warnings in the code. This has helped to highlight issues as code is edited as any warnings are immediately clear. Obviously, this depends on what warnings are

[Bug 55314] Provide option to allow programmatic deployment of server (WebSocket) endpoint at runtime

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55314 --- Comment #7 from Mark Thomas --- I've done some refactoring locally. Would the following method on WsServerContainer meet you requirements? public void doUpgrade( HttpServletRequest request, HttpServletResponse response,

Re: [Bug 55372] Bind JPDA_ADDRESS by default to localhost

2013-08-07 Thread Brian Burch
On 07/08/13 09:32, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=55372 --- Comment #5 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Mark Thomas from comment #4) [..] res/ide-support/netbeans/README.txt. Was that intentional? Though, I do not know how

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 --- Comment #28 from Mark Thomas --- There is a 1MB upload limit in Bugzilla for a reason. It is not there just to provide a few hoops to jump through if you want to upload a larger file. In future, if you hit a limit on *any* ASF service a

[Bug 55367] cannot compile JSPs while Vaadin webapp is deployed

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55367 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1511434 - /tomcat/trunk/bin/catalina.sh

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 18:44:32 2013 New Revision: 1511434 URL: http://svn.apache.org/r1511434 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45428 Trigger a thread dump to aid diagnostics if Tomcat fails to stop in a timely manner. Modified: tomcat/trunk/bin/catalina.sh

svn commit: r1511436 - in /tomcat/tc7.0.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 18:49:37 2013 New Revision: 1511436 URL: http://svn.apache.org/r1511436 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45428 Trigger a thread dump to aid diagnostics if Tomcat fails to stop in a timely manner. Modified: tomcat/tc7.0.x/trunk/ (pro

Re: Use (or not) of @SuppressWarnings

2013-08-07 Thread Konstantin Kolinko
2013/8/7 Brian Burch : > > I use netbeans exclusively. I get warnings about import order from almost > every tc source file. Periodically I scratch around looking for the rules > template so I can change them to conform with the ant checkstyle rules, > which are happy with the current import order.

[Bug 45428] warn if the tomcat stop doesn't complete

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45428 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Component|Catalina

[Bug 55381] New: Issue with the Non Blocking API & TestNonBlockingAPI test

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55381 Bug ID: 55381 Summary: Issue with the Non Blocking API & TestNonBlockingAPI test Product: Tomcat 8 Version: trunk Hardware: PC OS: Mac OS X 10.4

svn commit: r1511448 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java webapps/docs/changelog.xml webapps/docs/config/ajp.xml webapps/docs/config/http.xml webapps/docs/config/syste

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 19:20:51 2013 New Revision: 1511448 URL: http://svn.apache.org/r1511448 Log: Part of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 Change the default URIEncoding for all connectors to UTF-8. Modified: tomcat/trunk/java/org/apache/catalina/conn

[Bug 48550] Update examples and default server.xml to use UTF-8

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 --- Comment #9 from Mark Thomas --- Part 1 of the 4 tasks in the description has been completed for trunk (a.k.a 8.0.x) -- You are receiving this mail because: You are the assignee for the bug. ---

svn commit: r1511453 - /tomcat/trunk/webapps/examples/WEB-INF/web.xml

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 19:37:39 2013 New Revision: 1511453 URL: http://svn.apache.org/r1511453 Log: Part of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 Enable the character encoding filter for the examples web-app with UTF-8. Modified: tomcat/trunk/webapps/example

svn commit: r1511463 - in /tomcat/trunk/webapps/examples/jsp: cal/cal1.jsp cal/cal2.jsp jsp2/el/functions.jsp jsp2/el/implicit-objects.jsp

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 20:00:51 2013 New Revision: 1511463 URL: http://svn.apache.org/r1511463 Log: Part of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 Make sure JSPs that could output UTF-8 mark the content as UTF-8. I think I found all the places where this needed t

svn commit: r1511468 - /tomcat/trunk/webapps/examples/WEB-INF/classes/SessionExample.java

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 20:07:15 2013 New Revision: 1511468 URL: http://svn.apache.org/r1511468 Log: Part of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 Make sure Servlets that could output UTF-8 mark the content as UTF-8. I think I found all the places where this need

svn commit: r1511469 - /tomcat/trunk/webapps/docs/changelog.xml

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 20:09:56 2013 New Revision: 1511469 URL: http://svn.apache.org/r1511469 Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/change

[Bug 48550] Update examples and default server.xml to use UTF-8

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48550 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55383] New: Improve markup and design of Tomcat's HTML pages

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55383 Bug ID: 55383 Summary: Improve markup and design of Tomcat's HTML pages Product: Tomcat 8 Version: trunk Hardware: All OS: All Status: NEW Severity:

svn commit: r1511497 - /tomcat/trunk/java/org/apache/juli/OneLineFormatter.java

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 21:11:15 2013 New Revision: 1511497 URL: http://svn.apache.org/r1511497 Log: Improve the one line formatter so it outputs the correct thread ID even when using the async log writer. Modified: tomcat/trunk/java/org/apache/juli/OneLineFormatter.java Modified: to

svn commit: r1511501 - in /tomcat/trunk: conf/logging.properties java/org/apache/juli/FileHandler.java webapps/docs/changelog.xml

2013-08-07 Thread markt
Author: markt Date: Wed Aug 7 21:14:55 2013 New Revision: 1511501 URL: http://svn.apache.org/r1511501 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52092 Switch to the AsyncLogWriter and OneLineFormatter by default Modified: tomcat/trunk/conf/logging.properties tomcat/trunk

[Bug 52092] Please make AsyncFileHandler and OneLineFormatter the default for logging.properties

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52092 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55383] Improve markup and design of Tomcat's HTML pages

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55383 Mark Thomas changed: What|Removed |Added CC||d...@smart.net --- Comment #1 from M

[Bug 16579] documentation page layout/style breaks wrapping to fit browser window

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=16579 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55383] Improve markup and design of Tomcat's HTML pages

2013-08-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55383 --- Comment #2 from Mark Thomas --- An overhaul of the docs and site is long overdue as you can tell from the age of the duplicate. Please, go ahead. If you attach proposed patches, I'm happy to review and apply them as I am sure other com