Re: Microprofile OpenAPI

Browser and all clients default to */* or octect/stream so the else is never used normally and was here just to put a mimetype from an optional. Browsers even send a kind of "all you can" value (*/*, html, xml at least). So yes we can make this value confifurable but this never happens. Ivan's ca

Re: Microprofile OpenAPI

The question posed to the MP team does not really match the question posted here, and seems to be a tangental ask. The problem is this line of code [1], and nothing to do with TomEE's behavior; it defaults to JSON even though the spec states it should be YAML. Perhaps a clean solution would be to

Re: How can I help?

Hi Richard, I opened a new email thread "Improvement for Community section from the website - TOMEE-2300 [WIP]" in which you will find an initial PR that I started today in order to provide the place we all can contribute to improving the Contribute section from the website. If you haven't setup

Improvement for Community section from the website - TOMEE-2300 [WIP]

Hi, I created the initial structure to improve the current Community section we have in TomEE website. Ticket and initial PR were created. https://github.com/apache/tomee-site-generator/pull/6 https://issues.apache.org/jira/browse/TOMEE-2300 @Richard, you can work on the clean page I left for yo

[GitHub] tomee-site-generator pull request #6: TOMEE-2300 - Improvement for Community...

GitHub user cesarhernandezgt opened a pull request: https://github.com/apache/tomee-site-generator/pull/6 TOMEE-2300 - Improvement for Community section from the website You can merge this pull request into a Git repository by running: $ git pull https://github.com/cesarhernan

Re: Forking for new PRs

Also, if you don't mind Squashing your PR before submitting the request, that will help port anything to other branches! -- Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Why we don't have Jira and Github integration?

Hi, list: Contributing by example: this is how my PR for the MP rest client example looks like: https://github.com/apache/tomee/pull/210 However, this PR is not ready to be a merge, why? Well, the ticket reference from the PR has the context: https://issues.apache.org/jira/browse/TOMEE-2297 @J

Re: [TOMEE-2287] Histogram Prometheus Output

Thanks, Richard! Mike. On Thu, Nov 29, 2018 at 1:39 PM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > Cool to see you getting involved, Mike! Keep it up! > > On Thu, Nov 29, 2018 at 11:14 AM Michael Redlich > wrote: > >> Thanks, Ivan! >> >> Mike. >> >> >> On Thu, Nov 29, 2018 at 6:41

Re: Forking for new PRs

Lol. Ok, thank you! On Thu, Nov 29, 2018 at 2:44 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > > If I create a branch, will that branch have its own unique PRs separate > from other PRs? > > Yep. Create a branch for each PR you want to open. That reminds me, I > should probably

Re: Use Managed Executor with Safeguard Fault Tolerance lib - PR #201

Also merged and I'll run a local build. Was there going to be another iteration to provide some configuration on the executor service? Jon On Thu, Nov 29, 2018 at 11:47 AM Bruno Baptista wrote: > Hi > > Can some committer decide if this is good to merge? > > https://github.com/apache/tomee/pull

[GitHub] tomee pull request #201: TOMEE-2278 - Use Managed Executor with Safeguard Fa...

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/201 ---

Re: TOMEE-2283 New Example: Websocket,with TLS and Basic Auth - PR #214

Merged. We'll see how the build does. It looks like this has fixed ports - 8081 and 8443, I think we might have to look to see if we can use a random rather than fixed port. What do you think? Jon On Thu, Nov 29, 2018 at 12:29 PM Bruno Baptista wrote: > Fixed > > Bruno Baptista > https://twitte

[GitHub] tomee pull request #214: TOMEE-2283 - Websocket tls basic auth example

Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/214 ---

Re: Microprofile OpenAPI

Response is fine (thanks jaxrs), request is up to jaxrs runtime so depends where you deploy it (i dont think implementing a custom writer for that is right for users, it has too much pitfalls once integrated to anything else than this very specific spec). Le jeu. 29 nov. 2018 21:39, Jonathan Galli

Re: Forking for new PRs

> If I create a branch, will that branch have its own unique PRs separate from other PRs? Yep. Create a branch for each PR you want to open. That reminds me, I should probably clean up the 138 branches I have in my fork. :-) Jon On Thu, Nov 29, 2018 at 7:59 PM Richard Monson-Haefel < monsonhae..

Re: Microprofile OpenAPI

If the spec requires that, then I'd expect to get a YAML response if making a request without an `Accept` header on the request. I haven't looked through the microprofile-openapi TCK, but I'd expect that to be tested, and I'd suggest contributing a test there if there isn't one. If you wanted to

Re: Microprofile OpenAPI

True. It also doesn't mean that you not wrong. ;-) On Thu, Nov 29, 2018 at 2:04 PM Romain Manni-Bucau wrote: > Does not mean im not right ;) > > Le jeu. 29 nov. 2018 20:33, Richard Monson-Haefel > a écrit : > > > Ivan is right. The default for MicroProfile is yaml. It would only be > > json if

Re: Microprofile OpenAPI

Does not mean im not right ;) Le jeu. 29 nov. 2018 20:33, Richard Monson-Haefel a écrit : > Ivan is right. The default for MicroProfile is yaml. It would only be > json if the accept heard specifies json. Here is the exact wording from > section 5.2 > > "The default format of the /openapi endpo

Forking for new PRs

Hi Guys, The last several commits I had all went under the same PR. I would like to be able to create new PRs when working on unrelated stuff, but whenever I try to create a new PR it always gets added to the one I have open. I was told that I need a new fork to get my PRs separated but when I tr

Re: How can I help?

Hi Cesar, I can create a pull request for that ... I guess I was waiting to have some more meat on the bones but I keep getting sidetracked so having help would be great. I'm not sure where the document should live. Right now its in my Google Drive as a Google Doc, but I'm happy to put it wherever

Re: How can I help?

Hi Richard, For the Beginners Guide you mentioned on this thread, do we have an open PR already and/or an email thread? I was trying to see how I can contribute to them because, for instance, some communication tools like https://openejb.markmail.org/search/?q= have been helping me a lot to sear

Re: Microprofile OpenAPI

Ivan is right. The default for MicroProfile is yaml. It would only be json if the accept heard specifies json. Here is the exact wording from section 5.2 "The default format of the /openapi endpoint is YAML. Vendors must also support the JSON format if the request contains an Accept header with

Re: Example for concurrency utilities

+1 On Thu, Nov 29, 2018 at 1:22 PM César Hernández Mendoza < cesargu...@gmail.com> wrote: > +1 > > El jue., 29 nov. 2018 a las 11:55, Bruno Baptista () > escribió: > > > Hi folks, > > > > I'm thinking of creating an example related to the JEE7 concurrency > > utilities. > > > > Will be creating a

Re: Example for concurrency utilities

+1 El jue., 29 nov. 2018 a las 11:55, Bruno Baptista () escribió: > Hi folks, > > I'm thinking of creating an example related to the JEE7 concurrency > utilities. > > Will be creating a task on jira for it. > > Cheers. > > -- > Bruno Baptista > https://twitter.com/brunobat_ > > > -- Atentamente

Re: [TOMEE-2287] Histogram Prometheus Output

Cool to see you getting involved, Mike! Keep it up! On Thu, Nov 29, 2018 at 11:14 AM Michael Redlich wrote: > Thanks, Ivan! > > Mike. > > > On Thu, Nov 29, 2018 at 6:41 AM Ivan Junckes Filho > wrote: > > > Hi Michael, > > > > These are some commands that may help you. > > > > #Create a branch

Re: Example for concurrency utilities

Hey Bruno, that is a nice one! +1 Em qui, 29 de nov de 2018 às 14:55, Bruno Baptista escreveu: > Hi folks, > > I'm thinking of creating an example related to the JEE7 concurrency > utilities. > > Will be creating a task on jira for it. > > Cheers. > > -- > Bruno Baptista > https://twitter.com/b

Example for concurrency utilities

Hi folks, I'm thinking of creating an example related to the JEE7 concurrency utilities. Will be creating a task on jira for it. Cheers. -- Bruno Baptista https://twitter.com/brunobat_

Re: MicroProfile dependency matrix.

Hi Cesar, that is really nice, I believe which we can push it to the website on documentation section. :) Em qui, 29 de nov de 2018 às 09:01, Ivan Junckes Filho < ivanjunc...@gmail.com> escreveu: > I think this is very useful César. Not sure where would be the best place > to document this thoug

Re: [TOMEE-2287] Histogram Prometheus Output

Thanks, Ivan! Mike. On Thu, Nov 29, 2018 at 6:41 AM Ivan Junckes Filho wrote: > Hi Michael, > > These are some commands that may help you. > > #Create a branch from master > git checkout -b > > #List the remotes you have > git remote -v > > #Create a new remote > git remote add > > #Push to

Re: Microprofile OpenAPI

Hello Ivan, this is actually not exactly the case, the impl is writer agnostic and fully relies on JAXRS for that so if you have a body writer which matches OpenAPI and returns yaml by default or which prefer yaml over json then you will have the behavior you describe. To get yaml you can send th

Re: Microprofile OpenAPI

Hey Romain, take a look on: https://download.eclipse.org/microprofile/microprofile-open-api-1.0/microprofile-openapi-spec.html#_content_format It is clear for me there, that the default should be yaml. On Thu, Nov 29, 2018 at 2:58 PM Romain Manni-Bucau wrote: > Hello Ivan, > > this is actually

Microprofile OpenAPI

Hey guys, I think I found a bug in OpenAPI implementation. The spec says: "The default format of the /openapi endpoint is YAML." But when I try to access /openapi it returns JSON by default. This is not correct. Also how can I access yaml if it is not default?

Re: How can I help?

Hi Alex, Good to hear from you. I'm glad you are interested. Below is the response I've been sharing with people interested, but I wanted to say that I'm looking forward to seeing you on the dev list and checking out your first commit to TomEE! I'm currently working on a beginners guide but it'

Re: TOMEE-2283 New Example: Websocket,with TLS and Basic Auth - PR #214

Fixed Bruno Baptista https://twitter.com/brunobat_ On 29/11/18 11:55, Bruno Baptista wrote: Yeah... fixing it. It's sitting for too long. Bruno Baptista https://twitter.com/brunobat_ On 29/11/18 11:51, Ivan Junckes Filho wrote: Bruno, there is a conflict in the PR. On Thu, Nov 29, 2018 at

[GitHub] tomee issue #214: TOMEE-2283 - Websocket tls basic auth example

Github user brunobat commented on the issue: https://github.com/apache/tomee/pull/214 Resolved conflict and edited some commits with the wrong jira id ---

Re: MicroProfile dependency matrix.

I think this is very useful César. Not sure where would be the best place to document this though. On Wed, Nov 28, 2018 at 6:22 PM César Hernández Mendoza < cesargu...@gmail.com> wrote: > Hi, > > While working on an issue with MP rest client on current TomEE master, I > invested a couple of hou

Re: TOMEE-2283 New Example: Websocket,with TLS and Basic Auth - PR #214

Yeah... fixing it. It's sitting for too long. Bruno Baptista https://twitter.com/brunobat_ On 29/11/18 11:51, Ivan Junckes Filho wrote: Bruno, there is a conflict in the PR. On Thu, Nov 29, 2018 at 9:49 AM Bruno Baptista wrote: Hi, Can some committer please decide if this is good to merge

Re: TOMEE-2283 New Example: Websocket,with TLS and Basic Auth - PR #214

Bruno, there is a conflict in the PR. On Thu, Nov 29, 2018 at 9:49 AM Bruno Baptista wrote: > Hi, > > Can some committer please decide if this is good to merge? > > https://github.com/apache/tomee/pull/214 > > Thanks > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 26/11/18 17:58, Bru

TOMEE-2283 New Example: Websocket,with TLS and Basic Auth - PR #214

Hi, Can some committer please decide if this is good to merge? https://github.com/apache/tomee/pull/214 Thanks Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 17:58, Bruno Baptista wrote: Hi Romain, Thanks for you feedback. I've pushed changes and added a comment to the PR. Chee

Use Managed Executor with Safeguard Fault Tolerance lib - PR #201

Hi Can some committer decide if this is good to merge? https://github.com/apache/tomee/pull/201 Cheers Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 16:36, Romain Manni-Bucau wrote: @Bruno: note that this is not what we are doing, I'm just mentionning that TomEE does not need tha

Re: [TOMEE-2287] Histogram Prometheus Output

Hi Michael, These are some commands that may help you. #Create a branch from master git checkout -b #List the remotes you have git remote -v #Create a new remote git remote add #Push to the remote branch git push On Thu, Nov 29, 2018 at 8:25 AM Michael Redlich wrote: > Hi Romain: > >

Re: [TOMEE-2287] Histogram Prometheus Output

Hi Romain: Thanks for all the background information on this! I certainly appreciate it. Mike. On Wed, Nov 28, 2018 at 10:47 AM Romain Manni-Bucau wrote: > Hello Michael, > > in prometheus, histograms are not represented directly like their class > and the prometheus representation is done th

Re: [TOMEE-2287] Histogram Prometheus Output

Hi Ivan: Yes, I will clean things up a bit and do that soon. I would also like to try Romain's suggestion. I'm not all that experienced in pushing to a remote branch, so if you could complete the command below, it would be much appreciated. Thanks! *git push* Mike. On Wed, Nov 28, 2018 at 10

Re: CMP/JPA mapping not accounting for in persistence.xml

This is my work in progress so far: https://github.com/apache/tomee/pull/222 . I'd like to incorporate some Arquillian tests today, and ensure that this works with things like relationships between entities. The change here is fairly straightforward though; we pick up a persistence unit called "c

[GitHub] tomee pull request #222: TOMEE-2295 fix being ignored

GitHub user jgallimore opened a pull request: https://github.com/apache/tomee/pull/222 TOMEE-2295 fix being ignored This is still a work in progress as I'd like to incorporate some Arquillian tests today, and ensure that this works with things like relationships between entities.