[GitHub] tomee issue #343: (TOMEE-2438) Centralise TomEE and OpenEJB system propertie...

2019-01-02 Thread gerdogdu
Github user gerdogdu commented on the issue: https://github.com/apache/tomee/pull/343 Any update on this? ---

Re: TOMEE-2289

2019-01-02 Thread Puneeth PS
Hi Ivan, I have made the changes requested and I've some questions regarding the spec which I've asked on the github thread, can you please clarify these? On Wed 2 Jan, 2019, 6:09 PM Ivan Junckes Filho Puneeth, I did some comments here > https://github.com/apache/tomee/pull/340#pullrequestreview

Re: Hello

2019-01-02 Thread Rodrigo Graciano
Since I've nor permission, can someone assign this documentation task to me (https://issues.apache.org/jira/browse/TOMEE-2378)? username: graciano Tks On Wed, Jan 2, 2019 at 8:38 AM Richard Monson-Haefel wrote: > Hi Rodrigo, > > Welcome to TomEE! > > On Wed, Jan 2, 2019 at 3:35 AM Bruno Baptist

Re: Ejemplos en Español

2019-01-02 Thread Carlos Chacín
+1 please let me know how I can help On Mon, Dec 24, 2018, 8:24 PM Daniel Dias Dos Santos < daniel.dias.analist...@gmail.com wrote: > +1 : ) > -- > > *Daniel Dias dos Santos* > Java Developer > SouJava & JCP Member > GitHub: https://github.com/Daniel-Dos > Linkedin: www.linkedin.com/in/danieldi

Re: Ejemplos en Español

2019-01-02 Thread Rodrigo Graciano
I can help with Portuguese On Wed, Jan 2, 2019 at 7:10 PM César Hernández Mendoza wrote: > +1 > I can definitely help on this one and amplify the initiative to the Latin > America community on the translation epic :)! > > I created the main Task for this initiative: > https://issues.apache.org/j

Re: Ejemplos en Español

2019-01-02 Thread César Hernández Mendoza
+1 I can definitely help on this one and amplify the initiative to the Latin America community on the translation epic :)! I created the main Task for this initiative: https://issues.apache.org/jira/browse/TOMEE-2442 @David, do you have already a PR that can be associated with this Task? El vie

Re: Microprofile release train

2019-01-02 Thread César Hernández Mendoza
+1, now the current mp-examples added in the last couple of months are also value smoke tests to find gaps that the MP TCK might not cover. El lun., 31 dic. 2018 a las 11:08, Jean-Louis Monteiro (< jlmonte...@tomitribe.com>) escribió: > Thanks Bruno for looking after it. > There is something bro

Re: Move to Gitbox?

2019-01-02 Thread César Hernández Mendoza
@Jonathan, It seems https://issues.apache.org/jira/browse/INFRA-17417 is waiting for your final "go ahead" reply. El sáb., 29 dic. 2018 a las 10:12, Mark Struberg () escribió: > +1, at minimum the ee-api project should also be moved to gitbox. > > LieGrue, > strub > > > Am 28.12.2018 um 22:59 sch

[GitHub] tomee pull request #326: tomee-directory-structure.html formatting additions

2019-01-02 Thread cesarhernandezgt
Github user cesarhernandezgt commented on a diff in the pull request: https://github.com/apache/tomee/pull/326#discussion_r244879966 --- Diff: docs/tomee-directory-structure.adoc --- @@ -17,9 +17,9 @@ CONDITIONS OF ANY KIND, either express or implied. See the License for the s

Re: MP example already assigned

2019-01-02 Thread César Hernández Mendoza
Hi Khalid, Remember that you can also review current PR's related with TOMEE-2285. You can also propose improvements to the existing ones. As far as I know, we haven't created and epic related with Java EE 8 examples. El vie., 28 dic. 2018 a las 8:53, Khalid HORRI () escribió: > Hi Reberto, > >

Re: TOMEE-2361 - Improve main README file

2019-01-02 Thread Bruno Baptista
Glad to help :) Bruno Baptista https://twitter.com/brunobat_ On 02/01/19 21:13, César Hernández Mendoza wrote: Thanks Bruno for the updates added in my initial PR. This ticket and it's PR is ready for Committer review: https://issues.apache.org/jira/browse/TOMEE-2361 please move forward. El

Re: Migrate MP README's to adoc and create MP index-group

2019-01-02 Thread César Hernández Mendoza
thank you, Ivan, for the cleanup on this PR. El jue., 27 dic. 2018 a las 8:11, Ivan Junckes Filho () escribió: > Cesar has a pending PR, I resolved the conflicts for him. > > Can someone merge it? It will get too outdated and will be hard to merge > later if it takes too long. > https://github.co

Re: How can I help?

2019-01-02 Thread César Hernández Mendoza
Welcome, Wilder! For contributors workflow, you can check: http://tomee.apache.org/community/contributing/workflow.html El jue., 27 dic. 2018 a las 5:25, Richard Monson-Haefel (< monsonhae...@gmail.com>) escribió: > Welcome, Wilder! > > On Thu, Dec 27, 2018 at 5:22 AM Ivan Junckes Filho > wrote:

Re: How can I help ?

2019-01-02 Thread César Hernández Mendoza
Wellcome Désiré-Lévi ! We currently have two JIRA Epics targeted for new contributors, feel free to request the assignment of one Ticket or create a new one if you think it needs it. Generation of MP examples: https://issues.apache.org/jira/browse/TOMEE-2285 Improving documentation: https://issue

Re: Review TOMEE-2286

2019-01-02 Thread César Hernández Mendoza
Hi Ivan, Can you please fix the conflict on the PR. El mié., 26 dic. 2018 a las 8:04, Ivan Junckes Filho () escribió: > Can anyone review and merge this please? > > https://github.com/apache/tomee/pull/213 > -- Atentamente: César Hernández Mendoza.

Re: How can I help?

2019-01-02 Thread César Hernández Mendoza
Hello Puneeth! El lun., 24 dic. 2018 a las 2:44, Puneeth PS () escribió: > Hi, > > I am Puneeth I live in Bangalore India. I am new to open-source > contribution so I am willing to work on anything. > > -- Atentamente: César Hernández Mendoza.

Re: TOMEE-2339 Describe Workflow for Contribution

2019-01-02 Thread César Hernández Mendoza
I'm just catching up with the latest http://tomee.apache.org/community/contributing/workflow.html. A.w.e.s.o.m.e teamwork :) !!! El jue., 20 dic. 2018 a las 10:04, César Hernández Mendoza (< cesargu...@gmail.com>) escribió: > Yes, Frankie you are right. > Can any of the committers please review a

Re: TOMEE-2361 - Improve main README file

2019-01-02 Thread César Hernández Mendoza
Thanks Bruno for the updates added in my initial PR. This ticket and it's PR is ready for Committer review: https://issues.apache.org/jira/browse/TOMEE-2361 please move forward. El dom., 23 dic. 2018 a las 22:10, César Hernández Mendoza (< cesargu...@gmail.com>) escribió: > Hi Bruno, > > I just

Re: How can I help?

2019-01-02 Thread César Hernández Mendoza
Welcome Federico! El dom., 23 dic. 2018 a las 3:46, Federico Mariani (< federico.mariani.1...@gmail.com>) escribió: > Hello, > I'm Federico Mariani a 28 years old software developer from italy, actually > i'm working for a society called 'Engineering, ingegneria informatica'. > I've been working

Re: How can I help?

2019-01-02 Thread César Hernández Mendoza
Wellcome Santhosh! El vie., 21 dic. 2018 a las 18:30, Santhosh Kumar (< santhosh.bs.ku...@gmail.com>) escribió: > Dear Team, > > This is Santhosh, from Chennai, India. I work for a Software Services > company & presently working in client location at Manila, Philippines. > I recently read an arti

[GitHub] tomee pull request #350: TOMEE-2440 - Documentation improvements MDB, CDI, J...

2019-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/350 ---

[GitHub] tomee issue #299: TOMEE-2361 Improve main README file (WIP)

2019-01-02 Thread cesarhernandezgt
Github user cesarhernandezgt commented on the issue: https://github.com/apache/tomee/pull/299 👍 to Bruno's updates. ---

Re: TOMEE-2332 MP-JWT JWKs example PR

2019-01-02 Thread Mitja Jeseničnik Kotnik
Hello Jean-Louis, thanks for the review. I'll take into account the comments and improve the README.adoc file. Are there any other issues I could start working on? Best regards, *Mitja J. Kotnik** | *Software engineer Mobile: +386 40 432 182 *mi...@cotnic.com * | *https://www.cotnic.com

Re: Stabilize TomEE Build

2019-01-02 Thread Bruno Baptista
I think there's a vote for a minor release fixing an issue there. Bruno Baptista https://twitter.com/brunobat_ On 02/01/19 18:56, Roberto Cortez wrote: The OpenTracing update was also failing the TCK. I’ve reverted it back until we figure out what is going on. On 2 Jan 2019, at 16:50, Rober

Re: Stabilize TomEE Build

2019-01-02 Thread Roberto Cortez
The OpenTracing update was also failing the TCK. I’ve reverted it back until we figure out what is going on. > On 2 Jan 2019, at 16:50, Roberto Cortez wrote: > > It seems to fail intermittently. It took me a few tries to make it fail. On > the latest buildbot it seems fine. > > Not sure if it

[GitHub] tomee pull request #351: TOMEE-2441 - Fixing diamond types

2019-01-02 Thread ivanjunckes
GitHub user ivanjunckes opened a pull request: https://github.com/apache/tomee/pull/351 TOMEE-2441 - Fixing diamond types You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/tomee diamond_maven2 Alternatively you can rev

Re: example/mp-rest-jwt seems to be broken

2019-01-02 Thread Jose Henrique Ventura
Hi Cesar, I was sure that I sent a follow-up about this that night. I had to build the mp-jwt again and things worked as expected m Best Regards, José Henrique Ventura. Original Message On Jan 2, 2019, 5:43 PM, César Hernández Mendoza wrote: > Hi Jose, > Just catching up with

Re: example/mp-rest-jwt seems to be broken

2019-01-02 Thread César Hernández Mendoza
Hi Jose, Just catching up with the list. did you find why this was not building on your side? El jue., 20 dic. 2018 a las 16:24, Jose Henrique Ventura () escribió: > Hi Cesar, > > I tried both here and the same result. I will try to rebuild > ../tomee/mp-jwt project. > > Cheers. > > Best Regards,

Re: Stabilize TomEE Build

2019-01-02 Thread Roberto Cortez
It seems to fail intermittently. It took me a few tries to make it fail. On the latest buildbot it seems fine. Not sure if it was like this before or if it was something we did. > On 2 Jan 2019, at 12:14, Jean-Louis Monteiro wrote: > > [ERROR] Failures: > [ERROR] LegacyServerTest.test:208->a

[GitHub] tomee pull request #350: TOMEE-2440 - Documentation improvements MDB, CDI, J...

2019-01-02 Thread ivanjunckes
GitHub user ivanjunckes opened a pull request: https://github.com/apache/tomee/pull/350 TOMEE-2440 - Documentation improvements MDB, CDI, JPA You can merge this pull request into a Git repository by running: $ git pull https://github.com/ivanjunckes/tomee doc_adjustments Alte

[GitHub] tomee issue #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread puneethps
Github user puneethps commented on the issue: https://github.com/apache/tomee/pull/340 I noticed one more difference from the spec and the implementation, what I understood from the spec was that there is supposed to be a components field in the yaml or the json if there is a schema a

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread puneethps
Github user puneethps commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244777643 --- Diff: examples/mp-openapi/README.adoc --- @@ -0,0 +1,112 @@ +:index-group: MicroProfile +:jbake-type: page +:jbake-status: unpublished +

Re: TOMEE-2332 MP-JWT JWKs example PR

2019-01-02 Thread Jean-Louis Monteiro
Left 2 or 3 comments but sample looks good so I'll proceed and merge within the next hour. Thanks a lot. Great job -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 11:32 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Thank you

[GitHub] tomee pull request #342: TOMEE-2332 MP-jwt-jwk example

2019-01-02 Thread jeanouii
Github user jeanouii commented on a diff in the pull request: https://github.com/apache/tomee/pull/342#discussion_r244751383 --- Diff: examples/mp-rest-jwt-jwk/README.adoc --- @@ -0,0 +1,76 @@ += MicroProfile JWT JWKs +:index-group: MicroProfile +:jbake-type: page +:

[GitHub] tomee pull request #342: TOMEE-2332 MP-jwt-jwk example

2019-01-02 Thread jeanouii
Github user jeanouii commented on a diff in the pull request: https://github.com/apache/tomee/pull/342#discussion_r244752028 --- Diff: examples/mp-rest-jwt-jwk/pom.xml --- @@ -0,0 +1,215 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSc

[GitHub] tomee pull request #342: TOMEE-2332 MP-jwt-jwk example

2019-01-02 Thread jeanouii
Github user jeanouii commented on a diff in the pull request: https://github.com/apache/tomee/pull/342#discussion_r244751685 --- Diff: examples/mp-rest-jwt-jwk/README.adoc --- @@ -0,0 +1,76 @@ += MicroProfile JWT JWKs +:index-group: MicroProfile +:jbake-type: page +:

Re: TomEE logo poll

2019-01-02 Thread Richard Monson-Haefel
Thanks for the clarification! +1 on that plan! On Wed, Jan 2, 2019 at 7:52 AM Ivan Junckes Filho wrote: > The idea I had in mind is: > > 1 - Give a 1 week time for people to advocate for a logo. (Share the logo > in github issue) > 2 - Give a 1 week time for voting (we would gather all the logo

Re: TomEE logo poll

2019-01-02 Thread Ivan Junckes Filho
The idea I had in mind is: 1 - Give a 1 week time for people to advocate for a logo. (Share the logo in github issue) 2 - Give a 1 week time for voting (we would gather all the logos that people advocated for and add to another github issue and ask for thumbs up) The logo that gets more thumbs up

Re: Hello

2019-01-02 Thread Richard Monson-Haefel
Hi Rodrigo, Welcome to TomEE! On Wed, Jan 2, 2019 at 3:35 AM Bruno Baptista wrote: > Hi Rodrigo, > > Welcome to TomEE! > > Here you will find some useful reading about how to contribute: > http://tomee.apache.org/community/index.html > > We have currently a couple of Epics targeted for new cont

Re: How can I help?

2019-01-02 Thread Richard Monson-Haefel
Hi Chege, welcome to TomEE! On Tue, Jan 1, 2019 at 10:25 PM Chege Kĩnũthia wrote: > Hi, > > I am Chege, a freelance Java developer based in Thika, Kenya. I have no > experience in developing application servers. I look forward in > starting small and learning my way up. > > I have been developin

Re: TomEE logo poll

2019-01-02 Thread Richard Monson-Haefel
Hi Ivan, Your call to action on this is awesome but what exactly are we +1ing about? The act of considering a logo or are we +1ing David's Logo (by the way the link on your post didn't work for me personally). thanks! Richard On Wed, Jan 2, 2019 at 5:40 AM Ivan Junckes Filho wrote: > Would b

[GitHub] tomee pull request #349: Some of the returned values are performance dependa...

2019-01-02 Thread doychin
GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/349 Some of the returned values are performance dependant - stddev This one is more complex as change. stdDev value in histogram depends on how fast values are added to the histogram on the server. In or

[GitHub] tomee pull request #348: Copy dependency with base version

2019-01-02 Thread doychin
GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/348 Copy dependency with base version When running against snapshot build dependency must be copied with it's base version. You can merge this pull request into a Git repository by running: $ git p

Re: TOMEE-2289

2019-01-02 Thread Ivan Junckes Filho
Puneeth, I did some comments here https://github.com/apache/tomee/pull/340#pullrequestreview-188661807, please take a look. On Wed, Jan 2, 2019 at 9:51 AM Ivan Junckes Filho wrote: > Hi Puneeth, I will review it for you. > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS wrote: > >> Hi, >> >> I have

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244726062 --- Diff: examples/mp-openapi/src/test/java/org/superbiz/openapi/WeatherServiceTest.java --- @@ -0,0 +1,208 @@ +package org.superbiz.openapi; +

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244724535 --- Diff: examples/mp-openapi/README.adoc --- @@ -0,0 +1,112 @@ +:index-group: MicroProfile +:jbake-type: page +:jbake-status: unpublished

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244725387 --- Diff: examples/mp-openapi/src/main/java/org/superbiz/openapi/WeatherService.java --- @@ -0,0 +1,52 @@ +package org.superbiz.openapi; + +

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244725773 --- Diff: examples/mp-openapi/src/main/java/org/superbiz/openapi/WeatherService.java --- @@ -0,0 +1,52 @@ +package org.superbiz.openapi; + +

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244725584 --- Diff: examples/mp-openapi/src/main/java/org/superbiz/openapi/Weather.java --- @@ -0,0 +1,25 @@ +package org.superbiz.openapi; + +import or

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244723832 --- Diff: examples/mp-openapi/src/main/java/org/superbiz/openapi/WeatherService.java --- @@ -0,0 +1,52 @@ +package org.superbiz.openapi; + +

[GitHub] tomee pull request #340: TOMEE-2289 microprofile openAPI example

2019-01-02 Thread ivanjunckes
Github user ivanjunckes commented on a diff in the pull request: https://github.com/apache/tomee/pull/340#discussion_r244724385 --- Diff: examples/mp-openapi/README.adoc --- @@ -0,0 +1,112 @@ +:index-group: MicroProfile +:jbake-type: page +:jbake-status: unpublished

[GitHub] tomee pull request #347: when asking for counter value it will return only t...

2019-01-02 Thread doychin
GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/347 when asking for counter value it will return only the value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/doychin/tomee invalid-expected-json

[GitHub] tomee pull request #346: jitter=0 is incorrect. jitter has to be > 0

2019-01-02 Thread doychin
GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/346 jitter=0 is incorrect. jitter has to be > 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/doychin/tomee jitter=0 Alternatively you can review

[GitHub] tomee pull request #345: Incorrect artifact version in the test

2019-01-02 Thread doychin
GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/345 Incorrect artifact version in the test You can merge this pull request into a Git repository by running: $ git pull https://github.com/doychin/tomee incorrect-artifact-version Alternatively yo

[GitHub] tomee pull request #344: On Windows getJarLocation returns path like x:\tome...

2019-01-02 Thread doychin
GitHub user doychin opened a pull request: https://github.com/apache/tomee/pull/344 On Windows getJarLocation returns path like x:\tomee\bla\bla\bla This is not ok for the code that uses this path and tries to convert it to URL. For that reason a valid URL string must be re

[GitHub] tomee issue #287: Fix test for TomEECliIT

2019-01-02 Thread danielsoro
Github user danielsoro commented on the issue: https://github.com/apache/tomee/pull/287 @radcortez That is really weird, I can't reproduce the error here. Can you run it in the buildbot to see the results? ---

Re: Stabilize TomEE Build

2019-01-02 Thread Jean-Louis Monteiro
[ERROR] Failures: [ERROR] LegacyServerTest.test:208->assertBalance:219 Bad number of invocations for the bean "green". expected:<2> but was:<1> -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 1:14 PM Jean-Louis Monteiro wrote: > I also

Re: Stabilize TomEE Build

2019-01-02 Thread Jean-Louis Monteiro
I also get this one locally -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 1:05 PM Roberto Cortez wrote: > One issue at least was with the Safeguard upgrade. I’ve reverted it back. > Lets see if this helps. > > > On 2 Jan 2019, at 11:33

Re: Stabilize TomEE Build

2019-01-02 Thread Roberto Cortez
One issue at least was with the Safeguard upgrade. I’ve reverted it back. Lets see if this helps. > On 2 Jan 2019, at 11:33, Roberto Cortez wrote: > > Yeah, just noticed it as well. Was about to send a message too. I can have a > look. > >> On 2 Jan 2019, at 11:00, Jean-Louis Monteiro >> wr

Re: TomEE logo poll

2019-01-02 Thread Gurkan Erdogdu
+1 On Wed, Jan 2, 2019 at 2:51 PM Daniel Cunha wrote: > +1 > > Em qua, 2 de jan de 2019 às 08:40, Ivan Junckes Filho < > ivanjunc...@gmail.com> > escreveu: > > > Would be nice to get some +1 or -1 from some committers here :) > > > > On Fri, Dec 28, 2018 at 9:31 PM Bruno Baptista > wrote: > > >

Re: TomEE logo poll

2019-01-02 Thread Daniel Cunha
+1 Em qua, 2 de jan de 2019 às 08:40, Ivan Junckes Filho escreveu: > Would be nice to get some +1 or -1 from some committers here :) > > On Fri, Dec 28, 2018 at 9:31 PM Bruno Baptista wrote: > > > +1 > > > > Bruno Baptista > > https://twitter.com/brunobat_ > > > > > > On 28/12/18 16:32, Ivan Ju

Re: TOMEE-2289

2019-01-02 Thread Ivan Junckes Filho
Hi Puneeth, I will review it for you. On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS wrote: > Hi, > > I have created a PR ( https://github.com/apache/tomee/pull/340 ) for > TOMEE-2289. Can someone take a look and help me improve it? >

Re: TomEE logo poll

2019-01-02 Thread Ivan Junckes Filho
Would be nice to get some +1 or -1 from some committers here :) On Fri, Dec 28, 2018 at 9:31 PM Bruno Baptista wrote: > +1 > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 28/12/18 16:32, Ivan Junckes Filho wrote: > > Hey guys, we have been through this discussion before but I don't t

Re: Stabilize TomEE Build

2019-01-02 Thread Roberto Cortez
Yeah, just noticed it as well. Was about to send a message too. I can have a look. > On 2 Jan 2019, at 11:00, Jean-Louis Monteiro wrote: > > Ok, looks like we are back to red. > Someone working on it? > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > >

Re: Stabilize TomEE Build

2019-01-02 Thread Jean-Louis Monteiro
Ok, looks like we are back to red. Someone working on it? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Dec 21, 2018 at 12:59 AM Roberto Cortez wrote: > By the way, lets try to keep it that way :) > > > On 20 Dec 2018, at 20:48, César Hernández Mendoz

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Gurkan Erdogdu
I created a pull request, https://github.com/apache/tomee/pull/343 New maven project tomee-config is introduced with single class, TomEESystemConfig. This will include all system properties for tomee.* Also updated TomcatWebAppBuilder to remove some tomee.* properties and use the config class provi

[GitHub] tomee pull request #343: (TOMEE-2438) Centralise TomEE and OpenEJB system pr...

2019-01-02 Thread gerdogdu
GitHub user gerdogdu opened a pull request: https://github.com/apache/tomee/pull/343 (TOMEE-2438) Centralise TomEE and OpenEJB system properties Initial attempt for TomEE system config. You can merge this pull request into a Git repository by running: $ git pull https://github

TOMEE-2289

2019-01-02 Thread Puneeth PS
Hi, I have created a PR ( https://github.com/apache/tomee/pull/340 ) for TOMEE-2289. Can someone take a look and help me improve it?

Re: TOMEE-2332 MP-JWT JWKs example PR

2019-01-02 Thread Jean-Louis Monteiro
Thank you. I'll have a look after lunch. Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 11:20 AM Mitja Jeseničnik Kotnik wrote: > Hello, > > I've sent a PR on GitHub > for MicroProfile > JWT Exam

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Jean-Louis Monteiro
Agreed. For such a critical and low level need on the system, I'm not so fan about creating a hard dependency on a spec and an implementation. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 11:26 AM Roberto Cortez wrote: > I think we sho

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Roberto Cortez
I think we should stay away from MP Config for now. TomEE does a lot more regarding substitution and config on several places that MP Config doesn’t support. > On 2 Jan 2019, at 09:55, Bruno Baptista wrote: > > Sounds like a good plan. :) > > Bruno Baptista > https://twitter.com/brunobat_ <

TOMEE-2332 MP-JWT JWKs example PR

2019-01-02 Thread Mitja Jeseničnik Kotnik
Hello, I've sent a PR on GitHub for MicroProfile JWT Example for JWK . If there is something to improve please let me know. Best Regards, *Mitja J. Kotnik** | *Software engineer Mobile: +386 40 432 18

Re: MicroProfile Integration in Plus and Plume

2019-01-02 Thread Roberto Cortez
Hi, Thank you for the feedback. We actually had to remove MP from Plus and Plume because we found some other issues. See here: https://jira.apache.org/jira/browse/TOMEE-2407 It is possible to disable it, but I don’t think it is possible to enabl

[GitHub] tomee pull request #342: TOMEE-2332 MP-jwt-jwk example

2019-01-02 Thread cotnic
GitHub user cotnic opened a pull request: https://github.com/apache/tomee/pull/342 TOMEE-2332 MP-jwt-jwk example Implemented the MP-jwt for JWKs public key example. Also included the usage of MP-rest-client for testing. You can merge this pull request into a Git repository

Re: TOMEE-2334 merge PR

2019-01-02 Thread Jean-Louis Monteiro
Sounds awesome. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 11:01 AM Mitja Jeseničnik Kotnik wrote: > Thanks Jean-Louis, > > today I'll also send a new PR for TOMEE-2332. > > Best regards, > > *Mitja J. Kotnik** | *Software engineer >

Re: TOMEE-2334 merge PR

2019-01-02 Thread Mitja Jeseničnik Kotnik
Thanks Jean-Louis, today I'll also send a new PR for TOMEE-2332. Best regards, *Mitja J. Kotnik** | *Software engineer Mobile: +386 40 432 182 *mi...@cotnic.com * | *https://www.cotnic.com * On Wed, Jan 2, 2019 at 10:57 AM Jean-Louis Monteiro < jlmonte...@tomitribe.

[GitHub] tomee pull request #339: TOMEE-2334 MP-jwt-principal example

2019-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/339 ---

[GitHub] tomee pull request #341: Fixes issue https://issues.apache.org/jira/browse/T...

2019-01-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tomee/pull/341 ---

Re: TOMEE-2334 merge PR

2019-01-02 Thread Jean-Louis Monteiro
It's in. Thanks a lot -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Jan 1, 2019 at 5:50 AM Mitja Jeseničnik Kotnik wrote: > Yes, of course. That would be great. Thank you. > > Br, > Mitja J. Kotnik > > pon., 31. dec. 2018 23:25 je oseba Jean-Louis Mon

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Bruno Baptista
Sounds like a good plan. :) Bruno Baptista https://twitter.com/brunobat_ On 02/01/19 09:47, Gurkan Erdogdu wrote: For me, using services-jar.xml approach is not so visible to users. All defaults are configured in this file and packaged within JAR file. Users are not able to read the parameter

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Gurkan Erdogdu
For me, using services-jar.xml approach is not so visible to users. All defaults are configured in this file and packaged within JAR file. Users are not able to read the parameter explanation from services-jar.xml files. Also, services.-jar.xml is somebit different from using the system properties

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Bruno Baptista
Yes, there is. This is also the most basic MP spec and nothing prevents us from using it everywhere. There might be Jakarta EE restrictions in how to handle configurations that need to be assessed. Overall, I think that if we are going to mess with configs, we should use state of the art.

Re: How can I help?

2019-01-02 Thread Bruno Baptista
Hi Chege, Welcome to TomEE! Here you will find some useful reading about how to contribute: http://tomee.apache.org/community/index.html We have currently a couple of Epics targeted for new contributors, I'm sure you can find in there a task for you: Generation of MP examples: https://issues

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Jean-Louis Monteiro
Going with small steps is desired indeed. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 10:39 AM Gurkan Erdogdu wrote: > Hi Bruno, Jean-Louis > > My initial attempt is to remove constant string literals from the codebase > but only i

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Gurkan Erdogdu
Hi Bruno, Jean-Louis My initial attempt is to remove constant string literals from the codebase but only in these two classes. After this removal period, we can further update the architecture using microprofile config or any other way. So, there will be only 2 classes to hold: - TomEE specif

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Jean-Louis Monteiro
I think with microprofile-config we may have a chicken and the egg problem, isn't it? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Wed, Jan 2, 2019 at 10:30 AM Bruno Baptista wrote: > Hi Gurkan, > > I agree we have a problem with the documentation of the

Re: Hello

2019-01-02 Thread Bruno Baptista
Hi Rodrigo, Welcome to TomEE! Here you will find some useful reading about how to contribute: http://tomee.apache.org/community/index.html We have currently a couple of Epics targeted for new contributors, I'm sure you can find in there a task for you: Generation of MP examples: https://issu

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Jean-Louis Monteiro
Hey Gurkan, I am ok to better document the system properties. Few comments though... - I probably dreamt it, but I think there is an object that tries to load openejb.XXX and falls back to tomee.XXX if not found. Not sure if it's there or not. - I think system properties have been abused over t

Re: [DISCUSS] Regarding TomEE and OpenEJB related system properties

2019-01-02 Thread Bruno Baptista
Hi Gurkan, I agree we have a problem with the documentation of the different properties and that we need to improve it. Doing the inventory and using the proposed syntax looks ok to me but I also think we should go even further. How about to migrate all the properties to use microprofile-co