[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631720#comment-15631720 ] ASF GitHub Bot commented on TWILL-138: -- Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631701#comment-15631701 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread yaojiefeng
Github user yaojiefeng commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86288660 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -475,6 +496,11 @@ private void sendMessage(final

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631691#comment-15631691 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread yaojiefeng
Github user yaojiefeng commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86288445 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -575,18 +601,74 @@ private boolean

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86287618 --- Diff: twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java --- @@ -89,8 +91,7 @@ public String getRmSchedulerAddr() {

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631642#comment-15631642 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631641#comment-15631641 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86287397 --- Diff: twill-yarn/src/test/java/org/apache/twill/yarn/LogLevelChangeTestRun.java --- @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86287245 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java --- @@ -296,8 +298,42 @@ public TwillPreparer addSecureStore(SecureStore

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86286972 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java --- @@ -475,6 +496,11 @@ private void sendMessage(final String

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631542#comment-15631542 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631426#comment-15631426 ] ASF GitHub Bot commented on TWILL-138: -- Github user yaojiefeng commented on a diff in the pull

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread yaojiefeng
Github user yaojiefeng commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86282861 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java --- @@ -89,4 +90,44 @@ * @return A {@link Future} that will be completed

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631269#comment-15631269 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631266#comment-15631266 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631267#comment-15631267 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631273#comment-15631273 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631277#comment-15631277 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-138) Runtime change of Application runnable log level

2016-11-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631275#comment-15631275 ] ASF GitHub Bot commented on TWILL-138: -- Github user anew commented on a diff in the pull request:

[GitHub] twill pull request #14: TWILL-138 Runtime log level change

2016-11-02 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/14#discussion_r86275201 --- Diff: twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java --- @@ -158,4 +174,31 @@ public String toString() { ",