Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/672
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/672
Merged to master branch. Thanks @nkalmar !
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226681741
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class ClientCnxnSocketNett
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226690548
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -335,29 +260,34 @@ public void operationComplet
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226682998
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected() {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226689302
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void channelConnecte
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226687650
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
---
@@ -200,24 +186,13 @@ public void setSessionId(long sessi
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226684843
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void messageReceived(ChannelH
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226685450
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Ap
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226690017
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void channelConnecte
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226683922
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -184,7 +213,9 @@ void cleanup() {
@Overr
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226684209
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656984#comment-16656984
]
Hudson commented on ZOOKEEPER-3032:
---
FAILURE: Integrated in Jenkins build Zookeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657033#comment-16657033
]
Fangmin Lv commented on ZOOKEEPER-3169:
---
[~TyqITstudent] is this a duplicate Ji
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657035#comment-16657035
]
Fangmin Lv commented on ZOOKEEPER-3169:
---
Btw, can you point the code where the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657037#comment-16657037
]
Fangmin Lv commented on ZOOKEEPER-3170:
---
Thanks [~andorm] for tracking all thos
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/674
ZOOKEEPER-3032: MAVEN MIGRATION - branch-3.5 - zookeeper-server
Separating the java code is not feasible. Moving common and client back to
server.
Author: Norbert Kalmar
Review
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/674
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2476/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2476/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 82.05 MB...]
[exec]
==
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657133#comment-16657133
]
Hudson commented on ZOOKEEPER-3032:
---
SUCCESS: Integrated in Jenkins build ZooKeeper
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/669
@eolivelli , good find with EPoll. :)
When @ivmaykov first mentioned using EPoll to me as a potential
optimization, I recommended leaving it for later so we would do the reviewers a
favor
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/675
ZOOKEEPER-3032: MAVEN MIGRATION - branch-3.4 - zookeeper-server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755285
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class ClientCnxnSocketNetty
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755419
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755668
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -184,7 +213,9 @@ void cleanup() {
@Overri
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756052
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756565
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apa
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756353
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void messageReceived(ChannelHa
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756739
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
---
@@ -200,24 +186,13 @@ public void setSessionId(long sessio
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226757057
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void channelConnected
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226757190
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void channelConnected
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226757240
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -335,29 +260,34 @@ public void operationComplete
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@eolivelli thanks so much for the review! See my responses inline.
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2477/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 41.06 MB...]
[exec]
==
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/675
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2477/
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv reassigned ZOOKEEPER-3179:
-
Assignee: (was: Suyog Mapara)
> Add snapshot compression to reduce the disk IO
>
Fangmin Lv created ZOOKEEPER-3179:
-
Summary: Add snapshot compression to reduce the disk IO
Key: ZOOKEEPER-3179
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3179
Project: ZooKeeper
Is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3180:
--
Description:
On read heavy use case with large response data size, the serialization of
re
Fangmin Lv created ZOOKEEPER-3180:
-
Summary: Add response cache to improve the throughput of read
heavy traffic
Key: ZOOKEEPER-3180
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3180
Project:
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/567
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2478/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2478/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.84 MB...]
[exec]
==
See https://builds.apache.org/job/ZooKeeper-trunk/241/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 198.43 KB...]
[junit] Running org.apache.zookeeper.test.
I think the argument for keeping concurrency is that it may manifest some
unknown problems with the code.
Maybe a middle ground - move largest offenders into separate junit tag and
run them after rest of the test with threads=1. Hopefully this will make
life better for PRs.
On the note of larges
43 matches
Mail list logo
