Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/ --- Review request for zookeeper, fpj, michim, and Raul Gutierrez Segales. Bugs: ZO

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36935 --- ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36945 --- ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java, > > line 274 > > > > > > hmm, so at what point do we check if this dir exists

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36951 --- ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 6:13 p.m., michim wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 68 > > > > > > Can we remove this block? Doesn't the server create the data directory

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review36966 --- ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 5:43 p.m., Raul Gutierrez Segales wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 67 > > > > > > nit: coding style (if (autocreate) {) ok, I'll modify

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 7:27 p.m., Camille Fournier wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 82 > > > > > > Looks like the apache commons dep is only for the releaseaud

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 7:27 p.m., Camille Fournier wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 82 > > > > > > Looks like the apache commons dep is only for the releaseaud

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 7:27 p.m., Camille Fournier wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 82 > > > > > > Looks like the apache commons dep is only for the releaseaud

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 7:27 p.m., Camille Fournier wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 82 > > > > > > Looks like the apache commons dep is only for the releaseaud

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

> On March 12, 2014, 7:27 p.m., Camille Fournier wrote: > > ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java, > > line 82 > > > > > > Looks like the apache commons dep is only for the releaseaud

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/ --- (Updated March 14, 2014, 2:44 p.m.) Review request for zookeeper, fpj, michim,

Re: Review Request 19089: Inconsistent behavior in autocreation of dataDir and dataLogDir

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19089/#review37219 --- Ship it! Ship It! - Raul Gutierrez Segales On March 14, 2014, 2: