Re: Intent to ship: Retained Display Lists

2017-10-31 Thread Ben Kelly
On Oct 26, 2017 12:15 AM, wrote: On Monday, October 9, 2017 at 1:22:55 PM UTC+13, Matt Woodrow wrote: > We're planning on landing the code for retaining display lists in 58, > behind the pref layout.display.list.retain. > This has now landed in Nightly, and looks to be

Re: De-XBL Plans

2017-10-31 Thread Bobby Holley
As one of the lonely few peers for our XBL implementation, I am thrilled that this is finally happening. My deepest gratitude to everyone involved! bholley On Tue, Oct 31, 2017 at 3:06 PM, Dave Townsend wrote: > Having not heard any show-stopping concerns with the plan

Re: Mapping source files to Bugzilla components

2017-10-31 Thread Gregory Szorc
On Tue, Oct 24, 2017 at 11:59 AM, Gregory Szorc wrote: > Freshly landed in bug 1411343, CI now produces JSON files containing info > about how source files map to Bugzilla components. > > You'll notice a new "Bugzilla" task in Treeherder. It will write some > artifacts to the

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Boris Zbarsky
On 10/31/17 3:21 PM, Gregory Szorc wrote: It is "wrong" for the set of "people performing profiling." Just to be clear, that set is "everyone". Now the set of "people performing profiling on builds they create themselves" is a separate question -Boris

Re: nsAutoConfig

2017-10-31 Thread Nicholas Nethercote
Thank you for the info! I will leave that code alone :) Nick On Wed, Nov 1, 2017 at 2:22 AM, wrote: > On Tuesday, October 31, 2017 at 12:10:21 AM UTC-5, Nicholas Nethercote > wrote: > > Hi, > > > > I was just looking at the extensions/pref/autoconfig/ directory and > trying

Re: PSA: Retiring Bugzilla Socorro Lens

2017-10-31 Thread Anthony Hughes
Due to an unrelated infrastructure issue the push has been delayed. Apologies for the delay. On 30 October 2017 at 13:27, Anthony Hughes wrote: > This is a heads up that I am shutting down further development of my > Bugzilla Socorro Lens add-on. If you're currently using

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Kris Maglione
On Tue, Oct 31, 2017 at 03:39:39PM -0400, Jeff Muizelaar wrote: On Tue, Oct 31, 2017 at 3:21 PM, Gregory Szorc wrote: It is "wrong" for the set of "people performing profiling." This set is different from "people compiling Gecko." Which is different from "people who actually

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Ben Kelly
Would it be possible to have our profiling tools warn if about:compiler optimization flags are not in about:buildconfig? On Tue, Oct 31, 2017 at 3:39 PM, Jeff Muizelaar wrote: > On Tue, Oct 31, 2017 at 3:21 PM, Gregory Szorc wrote: > > On Tue, Oct 31,

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Jeff Muizelaar
On Tue, Oct 31, 2017 at 3:21 PM, Gregory Szorc wrote: > On Tue, Oct 31, 2017 at 12:02 PM, Jeff Muizelaar > wrote: >> >> As another piece of evidence in support opt-level=1 being the wrong >> default, Glenn also got bitten profiling with the wrong

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Kris Maglione
On Tue, Oct 31, 2017 at 12:21:42PM -0700, Gregory Szorc wrote: On Tue, Oct 31, 2017 at 12:02 PM, Jeff Muizelaar wrote: As another piece of evidence in support opt-level=1 being the wrong default, Glenn also got bitten profiling with the wrong options.

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Gregory Szorc
On Tue, Oct 31, 2017 at 12:02 PM, Jeff Muizelaar wrote: > As another piece of evidence in support opt-level=1 being the wrong > default, Glenn also got bitten profiling with the wrong options. > https://github.com/servo/webrender/issues/1817#issuecomment-340553613 It is

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Simon Sapin
On 31/10/17 19:30, Randell Jesup wrote: Note that this means that profiles taken with local builds will be "off" compared to Nightly/etc, unless you rebuild with extra options. How much off? probably not a lot unless you're super-focused on Rust code, but that's just a guess. This was also

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Jeff Muizelaar
As another piece of evidence in support opt-level=1 being the wrong default, Glenn also got bitten profiling with the wrong options. https://github.com/servo/webrender/issues/1817#issuecomment-340553613 -Jeff On Thu, Oct 26, 2017 at 2:51 PM, Jeff Muizelaar wrote: > FWIW,

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Randell Jesup
>On 2017-10-25 1:34 PM, Gregory Szorc wrote: >> Adding --enable-release to your mozconfig (the configuration for builds we >> ship to users) enables -Copt-level=2. (i.e. we didn't change optimization >> settings for builds we ship to users.) > >I've added a note about this to our benchmarking

Re: Reorganization of Firefox-UI tests in mozilla-central

2017-10-31 Thread Martijn
Update MDN docs when moving Marionette tests all over the place. On Wed, Nov 9, 2016 at 11:16 AM, Henrik Skupin wrote: > Henrik Skupin wrote on 01/09/16 17:37: > > After a longer time without a response I would like to give a follow-up > on where we stand at the moment and

Re: nsAutoConfig

2017-10-31 Thread mkaply
On Tuesday, October 31, 2017 at 12:10:21 AM UTC-5, Nicholas Nethercote wrote: > Hi, > > I was just looking at the extensions/pref/autoconfig/ directory and trying > to understand what it does. > > As far as I can tell, the code is there to allow custom deployments with > particular prefs set, as

Re: Intent to ship: Retained Display Lists

2017-10-31 Thread Shako Ho
Hi J. Ryan, Yes, the concept of AIL is pretty similar to the definition of input latency of RAIL. RAIL StepKey MetricUser Actions Response Input latency (from tap to paint) < 100ms. User taps a button (for example, opening navigation And I think the only difference is Hasal using different

Re: Intent to ship: Retained Display Lists

2017-10-31 Thread J. Ryan Stinnett
How is the AIL metric defined? I looked around Hasal for a bit, but I didn't see a clear definition. Is it similar to RAIL[1], or something entirely different? [1]: https://developers.google.com/web/fundamentals/performance/rail - Ryan On Tue, Oct 31, 2017 at 5:23 AM, Shako Ho

Re: Visual Studio 2017 coming soon

2017-10-31 Thread Sylvestre Ledru
2017-10-30 19:19 GMT+01:00 Kris Maglione : > Our static analysis tools are pretty good at catching a lot of lambda > capture bugs at this point, though. I'd be much less comfortable using them > if they weren't. > > It's probably worth considering whether we need to write

Re: How much context does CF_HTML really need?

2017-10-31 Thread Ted Mielczarek
On Tue, Oct 31, 2017, at 05:46 AM, Henri Sivonen wrote: > (Context: I'm trying to understand the requirements for our > serializers in case we rewrite them [in Rust].) > > The HTML fragment parsing algorithm can have only one context node. > The context is never a chain of nodes towards to the

Re: Re: nsAutoConfig

2017-10-31 Thread Marco Castelluccio
Are you sure the test you wrote is testing nsAutoConfig and not nsReadConfig? nsReadConfig does not instantiate nsAutoConfig unless autoadmin.global_config_url exists and is not emtpy:

Re: nsAutoConfig

2017-10-31 Thread Masatoshi Kimura
On 2017/10/31 19:22, Marco Castelluccio wrote: > It is not covered by any automated test: > https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/src/nsAutoConfig.cpp > (this doesn't mean it isn't actually used ever, but it can be a clue).

Re: Intent to ship: Retained Display Lists

2017-10-31 Thread Shako Ho
Hi Matt, We just re-run the Hasal against the latest nightly with layout.display-list.retain=true, and you can see the detail report as below: https://gist.github.com/ShakoHo/f9a654e327ee9dfa499584a8eeb27b7a Summary: - 60% of test cases(12/20) indicate AIL time improved on this

Re: nsAutoConfig

2017-10-31 Thread Marco Castelluccio
It is not covered by any automated test: https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/src/nsAutoConfig.cpp (this doesn't mean it isn't actually used ever, but it can be a clue). - Marco. Il 31/10/2017 05:09, Nicholas Nethercote

How much context does CF_HTML really need?

2017-10-31 Thread Henri Sivonen
(Context: I'm trying to understand the requirements for our serializers in case we rewrite them [in Rust].) The HTML fragment parsing algorithm can have only one context node. The context is never a chain of nodes towards to the root, since such a thing wouldn't affect the result per the HTML

Re: upcoming requirements changes for Stylo builds + request for help

2017-10-31 Thread Simon Sapin
On 31/10/17 10:37, m...@fireburn.co.uk wrote: I'm curious as to why Clang is required, why doesn't GCC work? rust-bindgen uses libclang to parse C++ header files and generate corresponding Rust definitions. GCC can still be used for compiling. -- Simon Sapin

Re: upcoming requirements changes for Stylo builds + request for help

2017-10-31 Thread mike
I'm curious as to why Clang is required, why doesn't GCC work? ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-31 Thread Mark Banner
On 11/10/2017 19:41, Botond Ballo wrote: On Wed, Oct 11, 2017 at 2:37 PM, Chris Cooper wrote: On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: Does this user have a bugzilla :alias so that folks submitting patches via MozReview or similar can just

Security Principles for coding secure IPC

2017-10-31 Thread Paul Theriault
With tighter sandbox restrictions hitting release in 57, I thought it might be a good time to provide some tips on writing IPC in a safe way. Our sandbox is less effective if we punch holes in it through due to IPC bugs or overly permissive APIs. This document highlights some of the common issues