Re: Some changes to how errors are thrown from Web IDL methods

2020-02-14 Thread Boris Zbarsky
On 2/7/20 10:13 AM, Nathan Froyd wrote: If you have other things you'd like this static analysis to be used for, please file dependencies on bug 1613440. Nice! I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1614548 -Boris ___ dev-platform mail

Re: Intent to Unship: in content

2020-02-14 Thread Patrick Brosset
Thanks Kris. Related to this: RDM (Responsive Design Mode, in DevTools) is one of the consumers of . We've been at work removing the dependency from RDM on this type of iframe, and are nearing the completion of the main bucket of work. By March this year, we should have a new, fully functional ver

Re: Intent to Deploy: ThreadSanitizer

2020-02-14 Thread Daniel Veditz
On Thu, Feb 6, 2020 at 6:12 AM Christian Holler wrote: > Furthermore, data races are undefined behavior and can lead to > unforeseeable code behavior once compilers exploit this fact for better > optimizations. We have evidence that data races can cause intermittent > crashes and use-after-free m

Re: Improvements to Web IDL exception message strings

2020-02-14 Thread Anne van Kesteren
On Mon, Feb 10, 2020 at 3:23 PM Boris Zbarsky wrote: > You can test this now in the console using: > >CSS.escape() /* no args */ >document.getElementById() /* no args */ > > My changes did not affect the error messages from those, note; just used > that same string in more places. Would u

Re: Upgrading to Node 10 early Nightly 75 (week of February 10th)

2020-02-14 Thread Dan Mosedale
As Ed Lee posted last week [1], we’re about to start requiring NodeJS version 10 for our builds for Firefox 75 and later [2]. In the next small number of days, I plan to land this change via Lando. After the patch from [2] merges to mozilla-central and you’ve updated your copy of m-c, in orde

Re: what if to not to give firefox sys_admin capability with apparmor?

2020-02-14 Thread gcpascutto
On Monday, 10 February 2020 15:22:38 UTC+1, dinar qurbanov wrote: > i have enabled firefox apparmor profile in linux mint, and one of log > messages about denied requests is sys_admin capability. firefox works > normally at its surface behavior, for me. how much bad things may > happen because it

Intent to Ship: form.requestSubmit()

2020-02-14 Thread John Dai
In Firefox 75, I intend to turn form.requestSubmit() on by default. Summary: The form.requestSubmit() function which requests form submission. It includes interactive constraint validation, dispatches a 'submit' event, and takes a reference to the submitter button. The difference between form.subm

Re: Some changes to how errors are thrown from Web IDL methods

2020-02-14 Thread Anne van Kesteren
On Thu, Feb 6, 2020 at 3:12 PM Boris Zbarsky wrote: > I would really like to get to the point where when web developers see > errors in their console they don't have to guess what caused those > errors, and having meaningful messages is the simplest way to get there. This is a great goal and we s

Re: Some changes to how errors are thrown from Web IDL methods

2020-02-14 Thread Boris Zbarsky
On 2/11/20 8:57 AM, Anne van Kesteren wrote: I don't know how much work this is, but ideally the signature is something like throwType(safeMessage, consoleMessage), whereby consoleMessage defaults to safeMessage or some such. We can certainly do that. It's "some" work for DOMException: adjusti

Re: Improvements to Web IDL exception message strings

2020-02-14 Thread Boris Zbarsky
On 2/10/20 9:57 AM, Anne van Kesteren wrote: Would using Document.prototype.getElementById be too long? That is a good question. I'm going to do a bit of refactoring so we only need to change one place to try these ideas out and would love some feedback! In the meantime, someone who wants t

Re: Intent to prototype and ship: lazy load images

2020-02-14 Thread Anne van Kesteren
On Mon, Feb 10, 2020 at 3:22 PM Hiroyuki Birchill Ikezoe wrote: > Is this feature enabled by default in sandboxed iframes?: no, as of now > there is no proposed flag to enable this feature in sandboxed iframes. I think the answer to this question is more complicated. It's disabled if scripts are

Re: [IMPORTANT] Submit your PI Requests for Firefox 75 QA feature testing by Feb 14

2020-02-14 Thread Tania Maity
Just a quick reminder that the deadline for submitting PI requests for 75 is *tomorrow*. Kindly submit your PI requests as soon as possible. Link to JIRA *create Issue* page: here PI Request process: here

Re: Improvements to Web IDL exception message strings

2020-02-14 Thread Simon Giesecke
Hi, helpful exception messages are very important, and ensuring that sufficient context is present is a good contribution to that. Thanks for pushing this forward! When starting work on replacing uses of the deprecated ErrorResult::Throw(nsresult), I noticed that the existing error messages show

Re: IPCError-browser | ShutDownKill signatures are about to change

2020-02-14 Thread William Kahn-Greene
Hi! There was some confusion around signatures that suddenly showed up a week ago that used to have a ShutDownKill signature, but since I only reprocessed a week of them, everything was complicated. I went through and reprocessed all 660k crash reports with ShutDownKill signature today. Now ther

Re: Intent to prototype and ship: lazy load images

2020-02-14 Thread Boris Zbarsky
On 2/6/20 5:26 PM, Hiroyuki Birchill Ikezoe wrote: Is this feature enabled by default in sandboxed iframes?: no, as of now there is no proposed flag to enable this feature in sandboxed iframes. But is it disabled by default there? I would assume not, unless it's specifically gated on sandboxi

ESLint now enabled for all of mozilla-central

2020-02-14 Thread Mark Banner
Yesterday, I landed the last patch to enable ESLint on all our javascript code in mozilla-central*. You can read more about this in my blog post (tweet

Intent to Unship: in content

2020-02-14 Thread Kris Maglione
in non-chrome documents has been unsupported in production environments for some time. Maintaining support for it in content processes has become increasingly difficult in the light of Fission, to the point that we've decided it is time to fully remove support. Since support is disabled by def

Re: Intent to implement: Cookie SameSite=lax by default and SameSite=none only if secure

2020-02-14 Thread oneovr
On Thursday, May 23, 2019 at 3:34:14 AM UTC-5, Andrea Marchesini wrote: > Link to the proposal: > https://tools.ietf.org/html/draft-west-cookie-incrementalism-00 > > Summary: > "1. Treat the lack of an explicit "SameSite" attribute as >"SameSite=Lax". That is, the "Set-Cookie" value "k

Android tests - do not forget logcat!

2020-02-14 Thread Geoffrey Brown via dev-platform
Lately it feels like there is more activity around running, investigating, and fixing Android automated tests -- that's great to see! When looking at logs from automated test logs, be aware that there are differences between desktop and Android. Some messages dumped to standard output will appear

Re: Intent to unship: system SQLite support on Linux (--enable-system-sqlite)

2020-02-14 Thread Lina Cambridge
Thank you very much for sending this out, Marco! I completely agree with your analysis: allowing system SQLite complicates things for us, and introduces many sharp edges without benefitting our users. With packaging conventions changing, it makes even less sense to keep around. I fully support its

happy bmo push day!

2020-02-14 Thread David Lawrence
the following changes have been pushed to bugzilla.mozilla.org: (tag: https://github.com/mozilla-bteam/bmo/tree/release-20200211.1) https://bugzil.la/1613686 : Improper encoding of content-type, content-transfer-encoding for security reports causes content to not be displayed properly https://b

Re: what if to not to give firefox sys_admin capability with apparmor?

2020-02-14 Thread Jed Davis
On Monday, February 10, 2020 at 11:14:26 AM UTC-7, gcpas...@gmail.com wrote: > IIRC CAP_SYS_ADMIN is needed to install seccomp-bpf filters. We don't need capabilities for seccomp-bpf. We do need capabilities for anything namespace-related: chroot()ing to a deleted directory to revoke filesystem

Intent to ship: Autodiscovery of WebExtension search engines

2020-02-14 Thread Dale Harvey
Summary: Since Firefox 57, users have been able to install additional search engines in the shape of a WebExtension[1] from addons.mozilla.org (AMO), whereas this used to only be possible using the OpenSearch XML format[2]. Since Firefox 68, all the search engines we distribute are WebExtensions[3]

Re: Intent to prototype and ship: lazy load images

2020-02-14 Thread Hiroyuki Birchill Ikezoe
On Tue, Feb 11, 2020 at 12:43 AM Anne van Kesteren wrote: > On Mon, Feb 10, 2020 at 3:22 PM Hiroyuki Birchill Ikezoe > wrote: > > Is this feature enabled by default in sandboxed iframes?: no, as of now > > there is no proposed flag to enable this feature in sandboxed iframes. > > I think the ans

Intent to Ship: SubmitEvent interface

2020-02-14 Thread John Dai
In Firefox 75, I intend to turn SubmitEvent on by default. Summary: The 'submit' event dispatched upon form submission gains a 'submitter' property to tell which submit button triggered the submission. Bug: https://bugzilla.mozilla.org/show_b

Re: Intent to ship: Autodiscovery of WebExtension search engines

2020-02-14 Thread Daniel Veditz
On Fri, Feb 14, 2020 at 11:50 AM Dale Harvey wrote: > We’re proposing a new mime-type [...]: “x-xpinstall” for WebExtension > search > engines. Example: /" some authors will tend to fill in the "missing" bit and get it wrong, and others will complain that the syntax is non-standard and broken. D