Intent to ship: unprefixed appearance property

2020-07-14 Thread Cameron McCormack
I intend to land bug 1620467 tomorrow, which implements the unprefixed appearance property and removes many non-standard values of -moz-appearance. Intent to Prototype mail: https://groups.google.com/g/mozilla.dev.platform/c/nlun5QV63Bo/m/xUXCmySGAgAJ The only things that have changed since tha

Intent to prototype: unprefixed appearance property

2020-07-02 Thread Cameron McCormack
Summary: The appearance property allows authors to specify that a widget element (such as a form control element) is to be rendered as a regular element without its usual themed appearance. For example, `appearance: none` on a prevents the element from being rendered with its usual (currently

Re: Intent to ship: a change to the initial value of image-orientation

2020-04-17 Thread Cameron McCormack
On Mon, Feb 17, 2020, at 8:19 AM, Cameron McCormack wrote: > This doesn't really fit the format of an Intent email, but just as a > heads up, I am landing a change to the initial value of the > image-orientation property, from "none" to "from-image". The eff

Re: Intent to unship: FTP protocol implementation

2020-03-19 Thread Cameron McCormack
If you plan to time the unshipping of our FTP support to be after Chrome 81, then please be aware that Chrome releases are currently paused on Chrome 80. https://chromereleases.googleblog.com/2020/03/upcoming-chrome-and-chrome-os-releases.html On Thu, Mar 19, 2020, at 8:56 PM, Michal Novotny wro

Re: Land your tests for now-public security bugs

2020-03-09 Thread Cameron McCormack
On Tue, Mar 10, 2020, at 10:33 AM, Daniel Veditz wrote: > We need to do better at the remembering-to-land part. If you've fixed a > security > bug in the past please check if you have any hanging *in-testsuite?* bugs > for bugs that are now public. Thank you for the reminder. (I've got tests goi

Re: Intent to ship: a change to the initial value of image-orientation

2020-02-17 Thread Cameron McCormack
On Mon, Feb 17, 2020, at 9:12 PM, Anne van Kesteren wrote: > Where is this standardized? https://drafts.csswg.org/css-images-3/#the-image-orientation > See https://github.com/whatwg/html/issues/4495 for some tricky questions > that come up that haven't been conclusively answered yet, as far as I

Intent to ship: a change to the initial value of image-orientation

2020-02-16 Thread Cameron McCormack
This doesn't really fit the format of an Intent email, but just as a heads up, I am landing a change to the initial value of the image-orientation property, from "none" to "from-image". The effect of this change is that EXIF orientation data in JPEG images used in HTML elements and in the CSS

Re: Intent to ship: CSS subgrid

2019-10-17 Thread Cameron McCormack
On Fri, Oct 18, 2019, at 9:31 AM, ikilpatr...@chromium.org wrote: > I'd argue that the color example is a "trivial" feature, unlike > subgrid. But the original framer of the policy would have a better > understanding of what that meant. > > FWIW most new CSS features are placed behind values/etc

Re: Intent to unship SVGZoomAndPan interface

2019-09-28 Thread Cameron McCormack
On Sun, Sep 29, 2019, at 1:22 PM, Boris Zbarsky wrote: > Sure, we could pass that by making it a mixin, not an interface, but > that says nothing about the `zoomAndPan` attribute on SVGSVGElement and > SVGViewElement. What does the compat situation look like for those? Both Chrome and Safari st

Re: What to do about scroll anchoring?

2019-09-28 Thread Cameron McCormack
How useful is scroll anchoring outside of the two cases mentioned in https://drafts.csswg.org/css-scroll-anchoring/#intro i.e. images loading and ad iframes being inserted? Would it be feasible to make scroll anchoring a much less general mechanism, and to scope it down to handling these specif

Re: Intent to unship SVGZoomAndPan interface

2019-09-28 Thread Cameron McCormack
On Sat, Sep 28, 2019, at 11:41 PM, longs...@gmail.com wrote: > In [1] I intend to unship the SVGZoomAndPan interface. The SVG WG > decided to remove this interface in [2] as it's either not implemented > at all or does nothing in current implementations. Our implementation > is currently the "do

Re: Intend to deprecate: XLink attributes on MathML elements

2019-08-24 Thread Cameron McCormack
On Sat, Aug 24, 2019, at 8:31 PM, Frédéric Wang wrote: > In bug 1548524, I intend to deprecate XLink attributes (“href”, “type”, > “show” and “actuate”) on MathML elements. This has never been supported > by other browsers and AFAIK there is not any plan to do so. Gecko > actually only has partial

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Cameron McCormack
This is going to let us simplify a whole lot of URL handling code in the style system, where we otherwise have to store strings and lazily creating nsIURIs when we're back on the main thread. Thanks so much! On Mon, Jun 10, 2019, at 1:08 PM, Valentin Gosu wrote: > Hello everyone, > > nsIURI ha

Re: Intent to unship: hasFeature() method on some SVG elements

2019-05-03 Thread 墨俊凱 / Cameron McCormack
On Fri, May 3, 2019, at 8:31 PM, Christopher Mills wrote: > On Fri, May 3, 2019 at 3:38 AM Cameron McCormack wrote: >> The hasFeature() method on some SVG elements comes from SVG 1.0 and was >> intended to be used as part of SVG's extension mechanisms. This function >&g

Intent to unship: hasFeature() method on some SVG elements

2019-05-02 Thread Cameron McCormack
The hasFeature() method on some SVG elements comes from SVG 1.0 and was intended to be used as part of SVG's extension mechanisms. This function never returned anything other than false in browser implementations, and was removed in SVG 2. Chrome no longer supports this, although WebKit still

Re: nsIPresShell has gone

2019-05-02 Thread Cameron McCormack
On Fri, May 3, 2019, at 11:44 AM, Masayuki Nakano wrote: > Finally, I completely got rid of nsIPresShell from our tree. > https://bugzilla.mozilla.org/show_bug.cgi?id=253889 Thank you for doing this, Masayuki! ___ dev-platform mailing list dev-platform@l

Re: Lack of browser mochitests in non-e10s configuration and support for turning off e10s on desktop going forward

2019-04-25 Thread Cameron McCormack
On Thu, Apr 25, 2019, at 7:55 PM, Gijs Kruitbosch wrote: > Ideally, I think the debugging usecase would be better served by a more > barebones "here's a docshell that will load arbitrary content off our > trusted localhost server in 1 process" type app than by making desktop > firefox run these

Re: Proposal to remove unnecessary [type] attributes on script tags in mozilla-central

2019-04-08 Thread Cameron McCormack
On Tue, Apr 9, 2019, at 1:56 PM, Cameron McCormack wrote: > You should exclude layout/reftests/w3c-received/ too. layout/reftests/w3c-css/received/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/

Re: Proposal to remove unnecessary [type] attributes on script tags in mozilla-central

2019-04-08 Thread Cameron McCormack
On Tue, Apr 9, 2019, at 1:39 PM, Brian Grinstead wrote: > I'd like to rewrite markup in the tree to avoid using the [type] > attribute on

Re: SVG text coordinate systems

2019-04-01 Thread Cameron McCormack
Hi Alex, On Tue, Apr 2, 2019, at 1:47 AM, Alex Henrie wrote: > Hi, I am trying to fix Bug 1529182,[1] but debugging the SVG > code is particularly difficult for me because it uses at least six > coordinate spaces, and I can't figure out how they relate to each > other: > > - Run space > - Run us

MOZ_DBG

2019-03-29 Thread Cameron McCormack
Lately I've been finding Rust's dbg!() macro[1] useful for quick debugging. Its main usefulness is in avoiding the need to extract out an expression into a separate variable just so that you can print out its value and then use the value in its original context. I wanted something similar for

Re: Where to put timeout test?

2019-03-05 Thread Cameron McCormack
On Wed, Mar 6, 2019, at 5:05 PM, violet.bugrep...@gmail.com wrote: > However, both the reviewer and me don't know how to put a timeout test. > It won't crash in any case, so it's not a crash test. But the mochitest > can only be used to check JavaScript assertion, if I use mochitest, the > test

Intent to implement: -webkit-line-clamp

2019-02-14 Thread Cameron McCormack
Summary: -webkit-line-clamp is a feature implemented in WebKit, Blink, and Edge that allows authors to control the height of a block so that it contains at most the specified number of lines, and if there are excess lines, an ellipsis is inserted in the last non-excess line. http://dropshado.w

Re: Intent to unship: -moz-binding CSS property from content.

2019-01-30 Thread Cameron McCormack
On Thu, Jan 31, 2019, at 8:03 AM, Emilio Cobos Álvarez wrote: > In bug 1523712 I intend to unship the `-moz-binding` CSS property from > content pages. Sounds good to me, thanks! ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.

Re: Proposed W3C Charter: SVG Working Group

2019-01-23 Thread Cameron McCormack
On Thu, Jan 10, 2019, at 12:38 AM, Henri Sivonen wrote: > A (non-changed) part of the charter says under SVG2: "This > specification updates SVG 1.1 to include HTML5-compatible parsing". Is > that in reference to > https://svgwg.org/svg2-draft/single-page.html#embedded-HTMLElements or > something e

Re: Proposed W3C Charter: SVG Working Group

2019-01-23 Thread Cameron McCormack
On Mon, Dec 24, 2018, at 4:59 AM, L. David Baron wrote: > Please reply to this thread if you think there's something we should > say as part of this charter review, or if you think we should > support or oppose it. Given our past involvement, we should > probably have some comment, even if it's sim

Re: nasm will soon become a build dependency

2018-12-20 Thread Cameron McCormack
On Fri, Dec 21, 2018, at 3:17 PM, Martin Thomson wrote: > The OP said >= 2.10. But you appear to have that. Oh, missed that. I just tried building some other versions of nasm from source (since 2.11 is the latest packaged in my distribution) and 2.13 was the earliest that I could build with. _

Re: nasm will soon become a build dependency

2018-12-20 Thread Cameron McCormack
On Fri, Dec 21, 2018, at 11:05 AM, Thomas Daede wrote: > nasm is now required for building on Linux. Is there a minimum version required? I am getting errors like this building: /z/moz/g/third_party/dav1d/src/x86/ipred_ssse3.asm:42: error: operand 1: expression is not simple or relocatable $ n

Re: Bypassing about:home/privacy page loads on new test profile builds via mach

2018-10-28 Thread Cameron McCormack
On Tue, Oct 23, 2018, at 9:53 AM, Kyle Machulis wrote: > Adding the following prefs turns off all new profile about:home loads > and just starts the browser with about:blank: > > [runprefs] > browser.startup.blankWindow=true > browser.newtabpage.enabled=false > browser.startup.firstrunSkipsHomepag

Re: Enabling (many) assertions in opt builds locally and eventually Nightly

2018-09-19 Thread Cameron McCormack
On Thu, Sep 20, 2018, at 1:52 AM, Ehsan Akhgari wrote: > While it may be the case that we may need to be more stable for > MOZ_RELEASE_ASSERTs, I very much doubt that every single MOZ_ASSERT in our > codebase is actually a guaranteed to never fail, so promoting them all to > be enabled in something

Re: CSS Scroll Snap Level 1

2018-09-05 Thread Cameron McCormack
On Wed, Sep 5, 2018, at 7:30 PM, Chris Mills wrote: > https://drafts.csswg.org/css-scroll-snap-1/ > > > Have we got any current or future plans for implementing this in Gecko? Yes, we have an implementation of an earlier draft for this feature, which

Layout Bugzilla components

2018-08-30 Thread Cameron McCormack
[bcc: firefox-dev, firefox-triage-leads] Hi, The Layout team has done some Bugzilla component reorganization to distribute features and areas of code a bit better. There are a number of new components split out from existing ones: * Previously covered by CSS Parsing and Computation: ** CSS Tr

PSA: static atom definitions have moved to xpcom/ds/StaticAtoms.py

2018-08-17 Thread Cameron McCormack
Hi everyone, Just a heads up on some changes to static atoms that I landed a couple of days. Static atom definitions now live in xpcom/ds/StaticAtoms.py. This script generates nsGkAtomList.h at build time. nsGkAtomList.h is still used by nsGkAtoms.{h,cpp} to actually define the C++ atoms and

Re: Intent to implement: Visual Viewport API

2018-07-24 Thread Cameron McCormack
On Tue, Jul 24, 2018, at 12:22 PM, Boris Zbarsky wrote: > On 7/23/18 7:36 PM, Tanushree Podder wrote: > > Secure contexts: Yes > > I'm not sure what this line means here. I updated the intent to implement template at https://wiki.mozilla.org/ExposureGuidelines#Intent_to_implement to make it cle

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Cameron McCormack
On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > I actually have a patch sitting around with helpers to make it super easy to > use smart pointers as tagged pointers :) I never wound up putting it up for > review, since my original use case went away, but it you can think of any > specif

Intent to unship: explicit values in image-orientation

2018-07-05 Thread Cameron McCormack
https://drafts.csswg.org/css-images-3/#the-image-orientation The CSS image-orientation property allows an author to control whether an image (in an or generated content) is automatically rotated and flipped according to the EXIF data in the image. Originally, the specification only allowed ex

Re: Intent to Unship: -moz-is-resource-document media feature from content pages.

2018-06-14 Thread Cameron McCormack
On Fri, Jun 15, 2018, at 8:02 AM, Emilio Cobos Álvarez wrote: > I expect no compat fallout whatsoever since it can only match, well, in > SVG resource documents, and it was meant to be an internal media feature > in the first place. This is fine. I expect approximately zero content relies on th

Re: modifying vendored Rust crates locally

2018-05-14 Thread Cameron McCormack
On Tue, May 15, 2018, at 8:22 AM, Myk Melez wrote: > With the fixes for bug 1323557 [1] and cargo-vendor issue #71 [2], it's > now more straightforward to modify a vendored Rust crate to test changes > locally or on tryserver. That is great! Thank you for making this easier, Myk. __

Re: Is super-review still a thing?

2018-04-25 Thread Cameron McCormack
On Thu, Apr 26, 2018, at 12:41 AM, Mark Côté wrote: > How we might use blocking reviewers in our workflow is still open, but > it could be used for training up reviewers, in which case the trainee > would be a regular reviewer and the module peer/owner would be a > blocking reviewer. It's not u

Re: Using WebIDL objects in XPIDL

2018-04-18 Thread Cameron McCormack
On Thu, Apr 19, 2018, at 1:19 PM, Nika Layzell wrote: > This allows us to avoid using nsISupports to pass WebIDL objects which > don't have corresponding XPIDL interfaces through XPIDL defined methods. Thanks Nika, this is great! Avoiding nsIDOMBlah interfaces in C++ was one of the reasons that

Intent to unship: SVGSVGElement.{pixel, screenPixel}UnitToMillimeter{X, Y}

2018-04-17 Thread Cameron McCormack
In https://bugzilla.mozilla.org/show_bug.cgi?id=1133172 I plan to remove our implementations of these four IDL attributes on SVGSVGElement: pixelUnitToMillimeterX pixelUnitToMillimeterY screenPixelUnitToMillimeterX screenPixelUnitToMillimeterY These were originally in SVG 1, but they never had m

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

2018-04-09 Thread Cameron McCormack
On Tue, Apr 10, 2018, at 11:58 AM, Jeff Gilbert wrote: > Do we have a heuristic for when to /not/ include something from HTML in SVG? If it doesn't make two features which already exist in both HTML and SVG more consistent, then I wouldn't include it. > More or less, these additions to SVG just

Re: Intent to implement and ship: ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG elements

2018-04-09 Thread Cameron McCormack
On Tue, Apr 10, 2018, at 7:56 AM, Jeff Gilbert wrote: > Can we not put more things into SVG? Making SVG more complicated seems > like it should be an anti-goal for the web platform. I think we should align the features and behavior of HTML and SVG . something I don't see why the t

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-08 Thread Cameron McCormack
On Fri, Mar 9, 2018, at 9:41 AM, Robert O'Callahan wrote: > It might be worth measuring how that translates to installer code. One > might hope that all that repetitive boilerplate code compresses well > (or can be made to). Testing my local bug 1341546 patches, I get a 59 KiB increase in .tar.bz2

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-08 Thread Cameron McCormack
On Fri, Mar 9, 2018, at 8:41 AM, Bobby Holley wrote: > The problem is precisely that it's gradual - a few kilobytes at a > time, certainly nothing to trigger our alerts. Waiting for it all to > pile up and then launching a herculean effort to move things _back_ to > XPIDL would be a huge waste of t

performing cross-context instanceof checks

2018-01-10 Thread Cameron McCormack
Hi, For a long time Firefox's behaviour for instanceof checks on DOM objects, when the right-hand side interface object comes from a different window from the object on the left, has differed from other browsers. For example, otherWindow.document instanceof Node evaluates to true in Firefox

Re: De-XBL Plans

2017-10-20 Thread Cameron McCormack
On Sat, Oct 21, 2017, at 01:47 AM, Dave Townsend wrote: > Are there any other concerns that we're missing? One thing I'm wondering about is memory usage of the Web Components implementations of these components compared to the XBL ones. Specifically for style, XBL has the ability to list the style

Re: Debugging Firefox e10s with rr?

2017-08-29 Thread Cameron McCormack
On Tue, Aug 29, 2017, at 08:58 PM, Emilio Cobos Álvarez wrote: > I didn't find any obvious docs in either the rr wiki[1] or MDN, so I > thought I'd ask before I actually need it. > > What is the best/easiest way to debug Firefox multi-process using rr? > > Right now I just disable e10s, but that'

Re: [PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

2017-07-31 Thread Cameron McCormack
Hi Enrico, Firefox patches should be submitted via Bugzilla, rather than by email to dev-platform. Please see: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed Thanks, Cameron On Mon, Jul 31, 2017, at 03:14 PM, Enrico Weigelt, metux

Re: Intent to unship: HTML scoped style sheets (

2017-06-21 Thread Cameron McCormack
On Wed, Jun 21, 2017, at 10:56 PM, Ehsan Akhgari wrote: > Why only in the medium term? Restyling is very costly for browser.xul > right now, and it would be very nice if we can use Stylo to gain some > advantages there, especially since costly restyles in the parent process > do mean UI jank fo

Re: Intent to unship: HTML scoped style sheets (

2017-06-20 Thread Cameron McCormack
On Wed, Jun 21, 2017, at 02:05 AM, Bobby Holley wrote: > Yeah - stylo for the frontend would be nice, but it's not part of > our MVP. Thanks for confirming what I thought was the case. :-) On Tue, Jun 20, 2017, at 03:26 PM, Patrick Brosset wrote: > Cameron, what bug should this one block (iiuc chr

Re: Intent to unship: HTML scoped style sheets (

2017-06-20 Thread Cameron McCormack
On Tue, Jun 20, 2017, at 03:26 PM, Patrick Brosset wrote: > DevTools also uses a scoped stylesheet in its tooltip widget [1]. > I have filed a bug [2] to remove it. Thank you. > Cameron, what bug should this one block (iiuc chrome support will be > removed a bit later, so we have some time, do yo

Re: Intent to unship: HTML scoped style sheets (

2017-06-19 Thread Cameron McCormack
On Tue, Jun 20, 2017, at 01:08 PM, Jared Wein wrote: > We use a scoped stylesheet for styling the popup for [1]. We > chose this route to limit performance impact as well as limit our > temporary stylesheet from affecting other parts of the browser UI. > Will your removal also remove support in th

Intent to unship: HTML scoped style sheets (

2017-06-19 Thread Cameron McCormack
HTML scoped style sheets is a feature that allows the effects of style sheets to be scoped to a subtree of a document. Support for this feature was introduced first in Chrome 19 behind a flag (in mid-2012) and in Firefox 21 without a pref (in mid-2013). Since then, Chrome removed their implementa

Re: Introducing mozilla::Result for better error handling

2017-01-04 Thread Cameron McCormack
On Tue, Dec 20, 2016, at 09:46 PM, Jan de Mooij wrote: > A few weeks ago we added mozilla::Result to MFBT [0][1]. I was > asked > to inform dev-platform about this, so here's a quick overview. > mozilla::Result is based on Rust's Result type [2]. It contains > either a success value of type V or an

Ensuring new CSS features are supported in Quantum CSS

2016-12-14 Thread Cameron McCormack
Hi, For the Quantum CSS project, we are aiming not to regress support for CSS features when the Servo-backed style system is turned on. This means that if you are implementing a new CSS feature that will land (behind a pref or not) before Quantum CSS is ready to ship, we'll need to do some work t

Re: Intent to Use Counter: Everything

2016-05-11 Thread Cameron McCormack
e’ve already expanded shorthands out to their component longhands: https://dxr.mozilla.org/mozilla-central/source/layout/style/nsCSSDataBlock.cpp#712 We could handle shorthands by recording them earlier, up in nsCSSParser somewhere. -- Cameron McCormack ≝ http://mcc.id.au/ __

Re: Intent to ship: unprefix :dir pseudo-class

2016-05-11 Thread Cameron McCormack
ich involves looking at localedir="" on the root element or a pref.) -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: #include sorting: case-sensitive or -insensitive?

2016-03-28 Thread Cameron McCormack
nclude "bbb/ccc/ddd.h" #include "bbb/eee/fff.h" #include "bbb/ggg.h" #include "ccc.h" or #include "bbb/ccc/ddd.h" #include "bbb/eee/fff.h" #include "bbb/bbb.h" #include "bbb/ggg.h" #include "aaa.h" #include &quo

Re: Returning dictionaries in WebIDL

2016-02-14 Thread Cameron McCormack
he object, then you have to use “object” as the type and invoke the type conversions or do the JS property getting in the spec yourself. -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.

Re: Intent to Implement: HTML and tags

2015-11-20 Thread Cameron McCormack
open' to the details. > > An example: Open the example in Chrome or Safari. http://simpl.info/details/ > > Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=591737 Great work Ting-Yu, and thanks very much for picking this up! -- Cameron McCormack ≝ http://mcc.id.au/ __

Re: API request: MutationObserver with querySelector

2015-09-19 Thread Cameron McCormack
styling, effectively modelling any registered selector observers as an additional style sheet rule (that doesn’t have any properties set in it). All of the data we store in the rule cascade so that we can quickly decide whether a given element needs to have rule matching run again could be re-used. -- Ca

Re: Operating CSS font parsing and associated font objects all usable from worker threads.

2015-09-14 Thread Cameron McCormack
can’t be used from other threads, although it might not be too much work to make it threadsafe for the things that 2D canvas contexts need it for. In fact that might be less work than duplicating and <‘font’> parsing. -- Cameron McCormack ≝ http://mcc.id.au/ __

Re: Help needed: define Bugzilla components in moz.build files

2015-03-04 Thread Cameron McCormack
ptr, which got filed in components like Core :: XPCOM. -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Reversely iterating nsTArray

2015-01-28 Thread Cameron McCormack
rRange. -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: It is time to solve making a push to Try server show a performance regression or validate a fix

2014-12-13 Thread Cameron McCormack
Hi Joel, jmaher wrote: I believe so, the easy way is to abuse the 'orange' color for a job on treeherder. The way I see it working is like this: * push to try, include some talos jobs in your patch * at the end of your job after data is uploaded, we query graph server for the try data and com

Re: Proposal: Standardize initializer list formatting in our coding style guide

2014-12-04 Thread Cameron McCormack
[Sorry, white space got eaten up in the previous mail...] Nicholas Nethercote wrote: This is already present in the example at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes: class MyClass : public X // when deriving from more than one class, put each on

Re: Proposal: Standardize initializer list formatting in our coding style guide

2014-12-04 Thread Cameron McCormack
Nicholas Nethercote wrote: This is already present in the example at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes: class MyClass : public X // when deriving from more than one class, put each on its own line , public Y I have encountered far more examp

Re: Using c++11 right angle bracket in template code?

2014-10-01 Thread Cameron McCormack
On 02/10/14 09:24, Eric Rescorla wrote: Obviously, if you have some argument that auto is bad programming practice or a hazard and should thus be forbidden, that's something you could make and see if people generally agree... The style guide is probably a better place to describe where we want

Re: Using c++11 right angle bracket in template code?

2014-10-01 Thread Cameron McCormack
On 01/10/14 19:23, Nicholas Nethercote wrote: Note the large, red warning at the top of that page "This page is a draft for expository and exploratory purposes. Do not trust the information listed here." I don't know why that page exists with such an authoritative-looking URL. We should make t

Re: Using c++11 right angle bracket in template code?

2014-10-01 Thread Cameron McCormack
On 01/10/14 17:57, Kan-Ru Chen (陳侃如) wrote: It seems all the compilers we use support the c++11 ">>" in template, could we start using it in new code? Yes we have some uses of that already. It's also mentioned in https://developer.mozilla.org/en-US/docs/Using_CXX_in_Mozilla_code. _

Re: Intent to implement: "image-rendering: pixelated" CSS property-value

2014-09-23 Thread Cameron McCormack
On 24/09/14 09:24, Jonas Sicking wrote: Would it make sense to have separate properties for "scale up" and "scale down"? With image-rendering being a shorthand for setting both? Separately, isn't "image-rendering" a bit too generic of a name for setting scaling strategy? I guess it was chosen

Re: Intent to ship: CSS mask-type property

2014-08-28 Thread Cameron McCormack
in WebKit and Blink for more than a year. -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Upcoming changes to Mac package layout, signing

2014-08-12 Thread Cameron McCormack
Ben Hearsum wrote: Apple recently announced changes to how OS X applications must be packaged and signed Does this also apply if you run .app/Contents/MacOS/firefox binary manually rather than opening the .app? If developers do update their OS to 10.9.5 when it's released, is there a way t

Re: Intent to implement and ship: Improved ruby parsing in HTML with new tag omission rules

2014-07-02 Thread Cameron McCormack
On 02/07/14 17:05, Henri Sivonen wrote: On Tue, Jul 1, 2014 at 10:58 PM, Koji Ishii wrote: Platform coverage: all platforms (parsing only, layout will be in separate intents) The parsing change is the easy part. Is there a plan to get the layout part implemented? My general take on this iss

Re: Intent to implement: CSS Font Loading API

2014-06-24 Thread Cameron McCormack
On 24/06/14 17:21, Anne van Kesteren wrote: That part of IDL is wrong. That needs to be fixed to use Symbol.iterator. Yep, aware of that. And ideally an easier way to define an iterator than having to define the entire thing. E.g. for something like FormData all you need is iterating over Arr

Re: Intent to implement: CSS Font Loading API

2014-06-24 Thread Cameron McCormack
On 24/06/14 16:30, Jonas Sicking wrote: I don't understand why anyone would want to key gets and sets using FontFace instances. I.e. why would you want to ever call fontFaceSet.has(myFontFace). That returning false doesn't really tell you anything about what fonts are or are not loaded. It tell

Re: Intent to implement: CSS Font Loading API

2014-06-23 Thread Cameron McCormack
On 24/06/14 16:35, Anne van Kesteren wrote: No, no more indexed getters. You should know! Yes hence the "something similar". :-) Was just easiest for working with while implementing. Making the object iterable seems like the right thing to do, but our bindings generation scripts don't handl

Re: Intent to implement: Proposal for SVG iframe element

2014-06-23 Thread Cameron McCormack
On 24/06/14 11:10, Robert O'Callahan wrote: Instead I think we should focus on extending HTML and making it easier to use from SVG, e.g. by eliminating the need to wrap it in . This is another argument for going forward with http://dev.w3.org/SVG/proposals/improving-svg-dom/ (at least the na

Re: Intent to implement: CSS Font Loading API

2014-06-23 Thread Cameron McCormack
On 24/06/14 06:30, Jonas Sicking wrote: Has the [MapClass] issue been resolved yet? No. There's a note in the spec that says [SetClass] will be removed in favour of members on the interface that feel like a Set, but there's nothing concrete in there yet. I'm proceeding with something simple

Intent to implement: CSS Font Loading API

2014-06-20 Thread Cameron McCormack
Summary: The CSS Font Loading API provides a mechanism for authors to load a font from the network that can then be used from the font-family property. This allows control over when the font load happens -- something that fonts referenced by @font-face rules currently occurs only when a glyph

Re: Intent to implement: DOMMatrix

2014-06-04 Thread Cameron McCormack
On 05/06/14 07:20, Milan Sreckovic wrote: In general, is “this is how it worked with SVGMatrix” one of the design principles? I was hoping this would be the time matrix rotate() method goes to radians, like the canvas rotate, and unlike SVGMatrix version that takes degrees... By the way, in th

Re: Intent to ship: :scope support in querySelector(All)

2014-04-17 Thread Cameron McCormack
ections to turning this on? Anyone actively in agreement? Sounds good to me. -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Graceful Platform Degradation

2014-03-26 Thread Cameron McCormack
Jet Villegas: > I've asked Cameron McCormack to look into how Firefox and other > browsers should behave when under mild to severe stress. As all > browser engines have to manage how to run under low memory, feeble > network, pegged CPU, weak GPU, low battery, small/slow screens

Re: Intent to ship: CSS Variables

2014-03-19 Thread Cameron McCormack
smaug wrote: Curious, how much have we tested the performance of our implementation and are there some known perf issues? I have not tested. The only extra work we should be doing at the moment when variables aren't used in the style sheet is nsRuleNode::ResolveVariableReferences. That iter

Intent to ship: CSS Variables

2014-03-18 Thread Cameron McCormack
CSS Variables is a feature that allows authors to define custom properties that cascade and inherit in the same way that regular properties do, and to reference the values of these custom properties in the values of regular properties (and other custom properties too). http://dev.w3.org/cssw

Intent to ship: paint-order property

2014-03-13 Thread Cameron McCormack
The paint-order property is a new property defined in SVG 2 that controls the order that the { fill, stroke, markers } of an element are painted in. I blogged about the feature when it was implemented here: http://mcc.id.au/blog/2013/01/paint-order It lives behind the svg.paint-order.enable

Re: Column numbers appended to URLs recently

2014-03-03 Thread Cameron McCormack
Jan Honza Odvarko wrote: Next example: http://example.com:80 Now it isn't clear whether it's a port number or a line number. Could we somehow fix this? "http://example.com/"; is equivalent to "http://example.com"; so you could just ensure that you output a "/" when the path is empty. (http

Re: support for Visual Studio 2010

2014-02-26 Thread Cameron McCormack
Ted Mielczarek wrote: Historically we haven't updated toolchains without a pressing reason, since there's a lot of hassle involved. Is there a specific reason you're asking? The two recent things I have had to work around in VS2010 were bugs in handling sized enums > 32 bits (enum Blah : uint6

Re: support for Visual Studio 2010

2014-02-25 Thread Cameron McCormack
Cameron McCormack wrote: When do we plan to drop support for Visual Studio 2010? I remember at one point that it was not possible to generate builds that ran on Windows XP with VS2010, but Update 1 (released in November) added support for that. Not possible to generate builds that ran on

Re: support for Visual Studio 2010

2014-02-25 Thread Cameron McCormack
Cameron McCormack wrote: When do we plan to drop support for Visual Studio 2010? I remember at one point that it was not possible to generate builds that ran on Windows XP with VS2010, but Update 1 (released in November) added support for that. November 2012, that is

support for Visual Studio 2010

2014-02-25 Thread Cameron McCormack
When do we plan to drop support for Visual Studio 2010? I remember at one point that it was not possible to generate builds that ran on Windows XP with VS2010, but Update 1 (released in November) added support for that. ___ dev-platform mailing list

Re: Mozilla Location Services - Heads up

2014-02-02 Thread Cameron McCormack
Doug Turner wrote: In the mean time, if you want to help, download the Stumbler application for Android and start helping the world by mapping your area: https://github.com/mozilla/MozStumbler/releases I have the "Mozilla location services" box ticked in my Firefox for Android. Will that do

using LLDB to debug Gecko

2014-01-21 Thread Cameron McCormack
Hi, For those of you who are using LLDB -- either by choice, or against your will after upgrading to OS X 10.9 -- I've added some Gecko-specific LLDB functionality to an .lldbinit file in the tree. I've mainly started with porting across the commands from the in-tree .gdbinit that were still

Re: Style guide clarity on C++-isms

2014-01-07 Thread Cameron McCormack
Ehsan Akhgari wrote: Exactly. If we require braces on their own lines for function bodies everywhere, we wouldn't need to solve this! Are you sure? :) There are a bunch of instances of class A { A(int aMember) : mMember(aMamber) {} }; through the tree. Depends how the "b

Re: Mozilla style guide issues, from a JS point of view

2014-01-07 Thread Cameron McCormack
Speaking of the troubles with 80 character line lengths, I find I often need to write variable and function declaration/calls like this: https://hg.mozilla.org/mozilla-central/file/8f1c9cdedba5/layout/style/nsCSSParser.cpp#l429 https://hg.mozilla.org/mozilla-central/file/8f1c9cdedba5/layout/styl

Re: Mozilla style guide issues, from a JS point of view

2014-01-07 Thread Cameron McCormack
Patrick McManus wrote: Typically I have to choose between 1] 80 columns 2] descriptive and non-abbreviated naming 3] displaying a logic block without scrolling to me, #1 is the least valuable. Thoroughly agree. ___ dev-platform mailing list dev

Re: Style guide clarity on C++-isms

2014-01-07 Thread Cameron McCormack
Benjamin Smedberg wrote: 1) Bracing of method bodies in a C++ class declaration Currently, C++ method bodies inline within a class declaration are documented to start on the next line, e.g. class B { public: void Method() { // Inline body brace is on the next line, column 2 } }; Mozilla code w

Re: nsGUIEvent.h related stuff has been sorted out

2013-10-28 Thread Cameron McCormack
Masayuki Nakano wrote: I have no idea why you thinks eventStructType should be only in debug build. Only because you mentioned that you were looking at possibly removing it. If that happens, then I was suggesting it might be helpful to keep around in debug builds for assertions like nsINode::

Re: nsGUIEvent.h related stuff has been sorted out

2013-10-25 Thread Cameron McCormack
king eventStructType member ;-) Would it make sense to make eventStructType exist only in debug builds, and to assert its value inside the As*Event() functions? -- Cameron McCormack ≝ http://mcc.id.au/ ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

  1   2   >