Re: Poll: What do you need in MXR/DXR?

2013-10-26 Thread Shih-Chiang Chien
First of all, thanks you guys who working of DXR. It is my major tool for studying the Gecko code base and it helps a lot. I would like to have DXR lists all the implementation of a virtual function. This is quite handy when you are studying an interface which has more than one level of inherita

Re: Poll: What do you need in MXR/DXR?

2013-10-25 Thread Zack Weinberg
On 2013-10-25 11:10 AM, Ehsan Akhgari wrote: On 2013-10-25 10:45 AM, Erik Rose wrote: ... would it be better, from your point of view, to index the generated files or to magically turn up the IDL line "attribute short foo" when you search for "function:GetFoo" or "function:SetFoo"? (I'm not sure

Re: Poll: What do you need in MXR/DXR?

2013-10-25 Thread Dave Hylands
- Original Message - > From: "Erik Rose" > To: "Dave Hylands" > Cc: "Ehsan Akhgari" , dev-platform@lists.mozilla.org > Sent: Friday, October 25, 2013 10:58:02 AM > Subject: Re: Poll: What do you need in MXR/DXR? > > > Going back t

Re: Poll: What do you need in MXR/DXR?

2013-10-25 Thread Erik Rose
> Going back to the idl is probably the best. > > It isn't just attributes, though, its also structure definitions as well, > like: > http://dxr.mozilla.org/mozilla-central/source/dom/ipc/PContent.ipdl#l73 > > So if I'm on this line: > http://dxr.mozilla.org/mozilla-central/source/dom/devicestor

Re: Poll: What do you need in MXR/DXR?

2013-10-25 Thread Dave Hylands
s.mozilla.org > Sent: Friday, October 25, 2013 8:10:42 AM > Subject: Re: Poll: What do you need in MXR/DXR? > > On 2013-10-25 10:45 AM, Erik Rose wrote: > >>> What features do you most use in MXR and DXR? > >> > >> One feature I'd like to see in DXR i

Re: Poll: What do you need in MXR/DXR?

2013-10-25 Thread Ehsan Akhgari
On 2013-10-25 10:45 AM, Erik Rose wrote: What features do you most use in MXR and DXR? One feature I'd like to see in DXR is the ability to click on a header file shown in a #include and have it be opened. For example, if I search for ErrorResult, I see #include "mozilla/ErrorResult.h" I'd

Re: Poll: What do you need in MXR/DXR?

2013-10-25 Thread Erik Rose
>> What features do you most use in MXR and DXR? > > One feature I'd like to see in DXR is the ability to click on a header file > shown in a #include and have it be opened. > > For example, if I search for ErrorResult, I see > > #include "mozilla/ErrorResult.h" > > I'd like to be able to clic

Re: Poll: What do you need in MXR/DXR?

2013-10-24 Thread Dave Hylands
Hi Erik, - Original Message - > From: "Erik Rose" > To: dev-platform@lists.mozilla.org > Sent: Wednesday, October 2, 2013 12:33:40 PM > Subject: Poll: What do you need in MXR/DXR? > > What features do you most use in MXR and DXR? One feature I'd lik

Re: Poll: What do you need in MXR/DXR?

2013-10-11 Thread Henri Sivonen
On Wed, Oct 2, 2013 at 10:33 PM, Erik Rose wrote: > What features do you most use in MXR and DXR? String search. Then identifier search. In this order, because I don't trust the latter to recognize all identifiers. It would help to be able to trust. > What keeps you off DXR? Main reason I've st

Re: Poll: What do you need in MXR/DXR?

2013-10-10 Thread Erik Rose
> Better python support. For example, the function name parameter doesn't work > with ext: .py > > http://dxr.mozilla.org/mozilla-central/search?q=function%3Astart%20ext%3A.py > <-- no results > http://dxr.mozilla.org/mozilla-central/search?q=%22def%20start%22%20ext%3A.py > <-- results To clar

Re: Poll: What do you need in MXR/DXR?

2013-10-09 Thread Erik Rose
Thanks, everyone, for your thoughtful and voluminous input! I bequeath you the following behind-the-scenes links so you can see the effect your feedback is having on DXR's future. We've collected, de-duped, and categorized your feedback at https://wiki.mozilla.org/DXR_UI_Refresh#Feedback. If yo

Re: Poll: What do you need in MXR/DXR?

2013-10-09 Thread Andrew Halberstadt
Better python support. For example, the function name parameter doesn't work with ext: .py http://dxr.mozilla.org/mozilla-central/search?q=function%3Astart%20ext%3A.py <-- no results http://dxr.mozilla.org/mozilla-central/search?q=%22def%20start%22%20ext%3A.py <-- results On 10/02/2013 03:

Re: Poll: What do you need in MXR/DXR?

2013-10-09 Thread Georg Fritzsche
I'd like to see: - carrying over the line numbers from the URL to the blame link On Oct 2, 2013, at 9:43 PM, Benoit Jacob wrote: > - DXR permanent code links i.e. code links to a particular hg changeset, > not to "tip", so that I can paste code links on a bug and they stay valid. > Currently I fa

Re: Poll: What do you need in MXR/DXR?

2013-10-09 Thread Neil
Nicholas Nethercote wrote: On Wed, Oct 9, 2013 at 1:49 AM, Neil wrote: Nor can I seem to get regexp search to work; I never get any results. If you're using the regexp field in the advanced search, you're probably failing to put '/' (or some other delimiter) at the start and end. I

Re: Poll: What do you need in MXR/DXR?

2013-10-09 Thread Nicholas Nethercote
On Wed, Oct 9, 2013 at 1:49 AM, Neil wrote: > > Nor can I seem to get regexp search to work; I never get any results. If you're using the regexp field in the advanced search, you're probably failing to put '/' (or some other delimiter) at the start and end. I too was having trouble with this unt

Re: Poll: What do you need in MXR/DXR?

2013-10-08 Thread Mook
On 10/02/2013 12:33 PM, Erik Rose wrote: What features do you most use in MXR and DXR? (Apologies for the late reply; didn't really check newsgroups during the summit - bad wifi and having too much to do. Didn't about the design session in SC for the same reason.) I look up XPCOM interfaces

Re: Poll: What do you need in MXR/DXR?

2013-10-08 Thread Erik Rose
> - Clicking on macros seem to lead to some results, but definitely not the one > I'd expect - > the definition of the macro. For example, if you click ROLE at http://dxr.mozilla.org/mozilla-central/source/accessible/src/base/RoleMap.h#l34, does the "Jump to definition" item from the context m

Re: Poll: What do you need in MXR/DXR?

2013-10-08 Thread Gijs Kruitbosch
http://dxr.mozilla.org/mozilla-central shouldn't 404, but do something useful (probably redirect to either root or %source/) ~ Gijs ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Poll: What do you need in MXR/DXR?

2013-10-08 Thread Neil
Erik Rose wrote: What are the MXR things you use constantly? I can't seem to get the advanced search form to work at all. (It does at least tell me the prefixes that I can use in the simple search form, but it's not 100% clear what they mean.) When it does work I would like a direct link t

Re: Poll: What do you need in MXR/DXR?

2013-10-07 Thread Jens Müller
Am 02.10.2013 21:33, schrieb Erik Rose: What features do you most use in MXR and DXR? I'd like to have the index generated by MXR/DXR integrated into an IDE (e.g., Eclipse, although I am currently not all satisfied with the handling of mixed C++/JS projects in Eclipse ...). _

Re: Poll: What do you need in MXR/DXR?

2013-10-07 Thread Jesse Ruderman
Features I'd like: * Show declarations and definitions (including webidl!) above refs * context:3 * context:statement * Search only within string literals / "search by color" * A way to load ALL results (other than holding Cmd+Down) * Offer `hg grep --all --follow word file` when I click a word

Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread Nicolas B. Pierron
On 10/04/2013 04:14 PM, Nicolas B. Pierron wrote: On 10/03/2013 02:38 PM, Ehsan Akhgari wrote: On 2013-10-03 3:24 PM, Nicolas B. Pierron wrote: DXR gives a nice contextual navigation, but the size of the code base is overwhelming to have a clear understanding of what is going on. One of the th

Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread Erik Rose
What a lot of great input! Thank you! I'll reply individually to those I've missed in the days after the Summit. In case you happen to be at the Mozilla Summit in Santa Clara, we're holding a DXR design session to mash all that juicy input together and make sure we have a UI/UX sketch that enab

Re: Poll: What do you need in MXR/DXR?

2013-10-05 Thread smaug
- Clicking on macros seem to lead to some results, but definitely not the one I'd expect - the definition of the macro. - Trying to find files is hard. (Still haven't figured out how to get easily from the main page to Navigator.cpp on dom/base) - "cycleCollection" on the right side may or m

Re: Poll: What do you need in MXR/DXR?

2013-10-04 Thread Cameron McCormack
Brian Smith wrote: * When in blame mode, the revision number of the most change to the line is shown. I would like a link next to every line's revision number that links to the *previous* revision where the line changed. That way, I can navigate the change history much easier. Yes, I think bein

Re: Poll: What do you need in MXR/DXR?

2013-10-04 Thread Erik Rose
That should be easy enough; I expect it doesn't have any dependencies the mainline moz-central has. I'll add it to the list to try for in Q4! On Oct 2, 2013, at 13:33 , Mike Conley wrote: > I love DXR for mozilla-central, and would love it if the UX branch > (https://mxr.mozilla.org/projects-c

Re: Poll: What do you need in MXR/DXR?

2013-10-04 Thread Nicolas B. Pierron
On 10/03/2013 02:38 PM, Ehsan Akhgari wrote: On 2013-10-03 3:24 PM, Nicolas B. Pierron wrote: The code base is compiled for multiple platforms. Currently I cannot find the functions which are defined on ARM unless we use a search as we used to do on MXR. This is a fundamental problem with DXR

Re: Poll: What do you need in MXR/DXR?

2013-10-04 Thread Benjamin Peterson
Erik Rose writes: > > What features do you most use in MXR and DXR? This is probably rather low priority, but MXR can be loaded over https, and DXR can not currently. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozill

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Erik Rose
Added with gusto. This actually drives me crazy, too. :-) On Oct 2, 2013, at 14:47 , Dave Townsend wrote: >> Things that drive me nuts about mxr when I've tried to use it: >> >> * When navigating down the directory/file tree, it keeps autofocusing the >> search field, which is super-annoying if

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Brian Smith
On Wed, Oct 2, 2013 at 12:33 PM, Erik Rose wrote: > What features do you most use in MXR and DXR? Blame. I wish blame mode was the default (only?) view. > What keeps you off DXR? (What are the MXR things you use constantly? Or the > things which are seldom-used but vital?) * Linking to a speci

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Joshua Cranmer 🐧
On 10/2/2013 2:33 PM, Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently renamed Web Engineering group, we're working hard to retire MXR. It hasn't been maintained for a long time, and there's a lot of duplication between it and DXR, which rests upon a more mod

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Steve Fink
On Thu 03 Oct 2013 03:36:08 PM PDT, Steve Fink wrote: > * It doesn't know that #include "mozilla/*" can be found in mfbt/*, so > those headers aren't linkified. Whoops, wrong. I was looking at an autogenerated header. I do notice that when viewing jsapi.h, it can find all of headers in js/public

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Steve Fink
* It doesn't know that #include "mozilla/*" can be found in mfbt/*, so those headers aren't linkified. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Ehsan Akhgari
On 2013-10-03 3:24 PM, Nicolas B. Pierron wrote: The code base is compiled for multiple platforms. Currently I cannot find the functions which are defined on ARM unless we use a search as we used to do on MXR. This is a fundamental problem with DXR and will be difficult to fix, because the DX

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Nicolas B. Pierron
Hi, On 10/02/2013 12:33 PM, Erik Rose wrote: What features do you most use in MXR and DXR? First of all I am using DXR since a while and I love it interface which give a contextual navigation as opposed to MXR. One of the feature I miss in DXR as opposed to MXR is that double-quotes are in

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Ehsan Akhgari
On 2013-10-03 2:31 AM, Justin Dolske wrote: On 10/2/13 1:48 PM, Terrence Cole wrote: I've been using DXR (at least when it has been working) since 2011. One thing I'd like to see should be simple to implement: typing a file name into the search bar should find that file rather than nothing. I'

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Ehsan Akhgari
On 2013-10-02 5:31 PM, Nicholas Cameron wrote: Could we run with DEBUG on? We'd index strictly more code (I think) and sometimes I miss debug-only things. (One day I would love to get Windows-only stuff indexed, but I guess we have to wait for Clang to work on Windows for that). clang is wor

Re: Poll: What do you need in MXR/DXR?

2013-10-03 Thread Ehsan Akhgari
On 2013-10-02 4:52 PM, Boris Zbarsky wrote: On 10/2/13 3:33 PM, Erik Rose wrote: What keeps you off DXR? (What are the MXR things you use constantly? Or the things which are seldom-used but vital?) MXR things I use constantly that don't seem to have obvious dxr counterparts: * Search on the "

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Justin Dolske
On 10/2/13 12:33 PM, Erik Rose wrote: What keeps you off DXR? (What are the MXR things you use constantly? Or the things which are seldom-used but vital?) First -- this work is really awesome. DXR already feels like it's close to being something I can switch over to. If for no other reason th

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Justin Dolske
On 10/2/13 1:48 PM, Terrence Cole wrote: I've been using DXR (at least when it has been working) since 2011. One thing I'd like to see should be simple to implement: typing a file name into the search bar should find that file rather than nothing. I'd like support for file/directory name matchi

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Steve Fink
On Wed 02 Oct 2013 12:33:40 PM PDT, Erik Rose wrote: > What features do you most use in MXR and DXR? > > Over in the recently renamed Web Engineering group, we're working hard to > retire MXR. It hasn't been maintained for a long time, and there's a lot of > duplication between it and DXR, which

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Bill McCloskey
ists.mozilla.org > Sent: Wednesday, October 2, 2013 2:47:19 PM > Subject: Re: Poll: What do you need in MXR/DXR? > > On Wed, Oct 2, 2013 at 1:52 PM, Boris Zbarsky wrote: > > > On 10/2/13 3:33 PM, Erik Rose wrote: > > > >> What ke

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Dave Townsend
On Wed, Oct 2, 2013 at 1:52 PM, Boris Zbarsky wrote: > On 10/2/13 3:33 PM, Erik Rose wrote: > >> What keeps you off DXR? (What are the MXR things you use constantly? Or >> the things which are seldom-used but vital?) >> > > Things that drive me nuts about mxr when I've tried to use it: > > * When

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Nicholas Cameron
Could we run with DEBUG on? We'd index strictly more code (I think) and sometimes I miss debug-only things. (One day I would love to get Windows-only stuff indexed, but I guess we have to wait for Clang to work on Windows for that). Nick On Thursday, October 3, 2013 8:33:40 AM UTC+13, Erik Ros

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Nick Alexander
On 13-10-02 2:09 PM, Gijs Kruitbosch wrote: On 02/10/13 21:33 , Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently renamed Web Engineering group, we're working hard to retire MXR. It hasn't been maintained for a long time, and there's a lot of duplication betwee

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Justin Wood (Callek)
Erik Rose wrote: > What features do you most use in MXR and DXR? > > Over in the recently renamed Web Engineering group, we're working hard to > retire MXR. It hasn't been maintained for a long time, and there's a lot of > duplication between it and DXR, which rests upon a more modern foundation

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Gijs Kruitbosch
On 02/10/13 21:33 , Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently renamed Web Engineering group, we're working hard to retire MXR. It hasn't been maintained for a long time, and there's a lot of duplication between it and DXR, which rests upon a more moder

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Boris Zbarsky
On 10/2/13 3:33 PM, Erik Rose wrote: What keeps you off DXR? (What are the MXR things you use constantly? Or the things which are seldom-used but vital?) MXR things I use constantly that don't seem to have obvious dxr counterparts: * Search on the "firefox" tree to follow pre-hg blame. Fea

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Terrence Cole
I've been using DXR (at least when it has been working) since 2011. One thing I'd like to see should be simple to implement: typing a file name into the search bar should find that file rather than nothing. On 10/02/2013 12:33 PM, Erik Rose wrote: > What features do you most use in MXR and DXR? >

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Mike Conley
I love DXR for mozilla-central, and would love it if the UX branch (https://mxr.mozilla.org/projects-central/source/ux/) was indexed there as well! Keep up the great work, -Mike On 02/10/2013 3:33 PM, Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently rename

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Ehsan Akhgari
DXR is looking awesome these days! I find the call graph information to be wrong some of the time, I have never been able to tell why. See this query for example:

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Axel Hecht
On 10/2/13 9:33 PM, Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently renamed Web Engineering group, we're working hard to retire MXR. It hasn't been maintained for a long time, and there's a lot of duplication between it and DXR, which rests upon a more moder

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Erik Rose
> One of the neat things with mxr and multiple trees is that when viewing a > file on say mozilla-central I can easily switch to the mozilla-aurora version > to see how it looks there, this is really useful for figuring out how a bug > affects different branchs. Bonus points might include a file

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Erik Rose
> - Easy access to hg annotate, as in mxr (could be better than mxr even, by > integrating into the existing view instead of being a separate view). Assuming I understand you right, we've just added this last week. :-) See the Blame link at http://dxr.mozilla.org/mozilla-central/source/embedd

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Dave Townsend
This is looking awesome and I'm going to attempt to switch my mxr quick searches over to it. A couple of immediate things that you might want to think about: Right now I think mxr updates from mozilla-central faster than daily. I've used that on a number of occasions to figure out what has broken

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Benoit Jacob
I need: - DXR permanent code links i.e. code links to a particular hg changeset, not to "tip", so that I can paste code links on a bug and they stay valid. Currently I fall back to hg.mozilla.org for that use case. - Easy access to hg annotate, as in mxr (could be better than mxr even, by integra

Poll: What do you need in MXR/DXR?

2013-10-02 Thread Erik Rose
What features do you most use in MXR and DXR? Over in the recently renamed Web Engineering group, we're working hard to retire MXR. It hasn't been maintained for a long time, and there's a lot of duplication between it and DXR, which rests upon a more modern foundation and has been developing l