Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support

[AMD Official Use Only - General] We need the use case on our platforms, it says we don’t have plan at the moment. However we are welcome anyone from community to implement it.  Abner From: Yoshinoya Sent: Wednesday, November 1, 2023 1:20 PM To: devel@edk2.groups.io; Chang, Abner Cc:

Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support

Hi, Abner: Got it, Thanks. Is there any plan to implement MTCP-over-smbus or MTCP-over-PCIE ? Thanks At 2023-10-31 15:00:03, "Chang, Abner via groups.io" wrote: MCTP over KCS defines two types of KCS-like access, one is compatible with IPMI KCS, another is memory map I/O

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/RedfishLib: align with edk2 RedfishLib

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, October 26, 2023 4:35 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH]

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi Mike, Thank you for review. Please see my answers below the text. -Original Message- From: Mike Maslenkin Sent: Tuesday, October 31, 2023 9:00 PM To: devel@edk2.groups.io; Igor Kulchytskyy Cc: Abner Chang ; Nickle Wang Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] RedfishPkg:

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

Acked-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Henz, > Patrick > Sent: Wednesday, November 1, 2023 12:51 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Henz, > Patrick > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

+CC ARM maintainers On Wed, Nov 1, 2023 at 12:40 AM Joe L wrote: > > Hello, > > During experimentation on an AARCH64 platform with a PCIe endpoint that > supports option ROM, it was found that the ordering of transactions between > ECAM (Cfg-Write) and MMIO (Mem-Read) is not preserved by the

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

[AMD Official Use Only - General] Sure, thanks for this change. Reviewed-by: Abner Chang mailto:abner.ch...@amd.com>> From: Nickle Wang Sent: Wednesday, November 1, 2023 8:53 AM To: Mike Maslenkin ; devel@edk2.groups.io; Chang, Abner Cc: Igor Kulchytskyy ; Nick Ramirez Subject: RE:

Re: [edk2-devel] [PATCH v3 0/5] StarFive/VisionFive2: Add VisionFive 2 platform

Hi Sunil, Okay, I will update the "Maintainers.txt" file in patch v4. By the way, I wonder if you also review this series? [PATCH v2 0/5] Designware MMCDXE changes and enhancement Thanks, John -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

On Tue, Oct 31, 2023 at 7:52 PM Henz, Patrick wrote: > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578 > > The implementation of XhcGetElapsedTicks did not account for > non-zero start and stop values for the performance counter > timer, potentially resulting in an incorrect elapsed

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi Igor please find my comments below. On Tue, Oct 31, 2023 at 8:56 PM Igor Kulchytskyy via groups.io wrote: > > Supported function of the driver changed to wait for all newtwork > interface to be installed. > Filer out the network interfaces which are not supported by > Redfish Host Interface.

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

> Ack. > Looks good to me. Thanks for your review, Mike! @Abner Chang, could you please provide reviewed-by to version 3 if this looks good to you? Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, October 31, 2023

[edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

Hello, During experimentation on an AARCH64 platform with a PCIe endpoint that supports option ROM, it was found that the ordering of transactions between ECAM (Cfg-Write) and MMIO (Mem-Read) is not preserved by the CHI HN-I node. The observed sequence is as follows: 1. EFI issues a Cfg-Write

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

On 10/31/23 18:06, Laszlo Ersek wrote: > (3) During all this discussion here, I have been *distinctly* > recalling that I've experienced an *actual performance regression* > sometime, after we had unwittingly switched from the REP variant to > the non-REP variant. > > And now I have actually

Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

On 10/31/23 12:37, Neal Gompa via groups.io wrote: From: Neal Gompa Currently, the ReadyToBoot event is only signaled when a formal Boot Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). However, the introduction of Platform Recovery in UEFI 2.5 makes it necessary to signal

[edk2-devel] [PATCH v1 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list

From: Michael Kubacki - Adds Apache License 2.0 as an acceptable source license per discussion in https://edk2.groups.io/g/devel/message/110226 - Updates the URL for existing licenses to match the current path used by opensource.org. - The submodule list in this file is stale and is very

Re: [edk2-devel] [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file

On 10/31/23 21:33, Laszlo Ersek wrote: > On 10/7/23 08:32, Yuanhao Xie wrote: >> Cc: Eric Dong >> Cc: Rahul Kumar >> Cc: Tom Lendacky >> Signed-off-by: Yuanhao Xie >> --- >> UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Queued in

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

On 10/31/23 17:51, Henz, Patrick wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578 > > The implementation of XhcGetElapsedTicks did not account for > non-zero start and stop values for the performance counter > timer, potentially resulting in an incorrect elapsed tick > count

Re: [edk2-devel] [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file

On 10/7/23 08:32, Yuanhao Xie wrote: > Cc: Eric Dong > Cc: Rahul Kumar > Cc: Tom Lendacky > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Queued in .

[edk2-devel] [PATCH v1 1/1] BaseTools: Resolve invalid escape sequence

Resolves an invalid escape sequence in a regex string that occurs because the string was not marked as a raw string, so backslash characters create unexpected escape sequences. This was brought to light due to Python 3.12 now detecting invalid escape sequences and generates a warning. It is best

Re: [edk2-devel] CodeQL and Apache Licensed Files

On Tue, Oct 31, 2023 at 7:43 PM Kinney, Michael D wrote: > > Hi Pedro, > > SPDX is only for licenses, not copyrights. IANAL, but several FOSS projects (including Linux) have generally replaced the "Copyright (c) ..." verbiage with SPDX. I assume there has to be some legal basis for this,

Re: [edk2-devel] CodeQL and Apache Licensed Files

Hi Michael, I agree that SPDX is preferred in file headers over license text in TianoCore projects. I just do not know what the rules are when you copy a file from An external project if you can replace without permission from the owning project since many of the licenses state that the license

Re: [edk2-devel] CodeQL and Apache Licensed Files

Hi Pedro, SPDX is only for licenses, not copyrights. There used to be a requirement for Intel copyright end year to be updated. That is no longer a requirement, and should reduce the churn on the file headers. Mike > -Original Message- > From: Pedro Falcato > Sent: Tuesday, October

Re: [edk2-devel] CodeQL and Apache Licensed Files

On Sat, Oct 28, 2023 at 12:51 PM Laszlo Ersek wrote: > > On 10/27/23 23:11, Michael Kubacki wrote: > > I'd like to bring attention to Apache License 2.0 code in the CodeQL > > series I sent to the mailing list for steward review. > > > > In particular, the files in the

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On Tue, Oct 31, 2023 at 9:55 AM Dhaval Sharma wrote: > > I am posting an update on behalf of Jingyu as he had trouble with posting. > CC'ing him here: > In summary what we have verified so far: > > I have verified that instructions/op codes are okay. I have also verified on > Qemu that

Re: [edk2-devel] CodeQL and Apache Licensed Files

Michael, I noticed some of the files had Apache 2.0 license and then you added content under BSD-2-Clause-Patent. Why wouldn't you continue with the original Apache 2.0 license? Also, I am not sure if you can replace the license text with the SPDX identifier if the original file had the text.

[edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Igor Kulchytskyy ---

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

On Thu, Oct 26, 2023 at 12:39 PM Laszlo Ersek wrote: > > On 10/26/23 18:19, Laszlo Ersek wrote: > > On 10/26/23 15:53, Neal Gompa wrote: > >> From: Neal Gompa > >> > >> Currently, the ReadyToBoot event is only signaled when a formal Boot > >> Manager option is executed (in BmBoot.c ->

[edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

From: Neal Gompa Currently, the ReadyToBoot event is only signaled when a formal Boot Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). However, the introduction of Platform Recovery in UEFI 2.5 makes it necessary to signal ReadyToBoot when a Platform Recovery boot loader runs

Re: [edk2-devel] CodeQL and Apache Licensed Files

On 10/31/23 17:07, Michael Kubacki wrote: > On 10/28/2023 7:51 AM, Laszlo Ersek wrote: >> On 10/27/23 23:11, Michael Kubacki wrote: >>> I'd like to bring attention to Apache License 2.0 code in the CodeQL >>> series I sent to the mailing list for steward review. >>> >>> In particular, the files in

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

On 10/31/23 10:56, duntan wrote: > Hi Tom, > Thanks for your testing and comments. I'll modify the patch commit > message and code according to your comments. > Yes the patch changes the behavior for IoReadFifo/ IoWriteFifo API for > non-Tdx and non-SEV case. Looking forward to more comments from

Re: [edk2-devel] [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

I think I misunderstood the intent. Reviewing the full patchset, it seems this is necessary to avoid using the new CMO path in the Virt platform (since the default value is all FFs). Shouldn’t the default Pcd value here be all 0’s – i.e. CMO or any other feature use becomes “opt in” instead of

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578 The implementation of XhcGetElapsedTicks did not account for non-zero start and stop values for the performance counter timer, potentially resulting in an incorrect elapsed tick count getting returned to the caller. Account for non-zero

Re: [edk2-devel] CodeQL and Apache Licensed Files

On 10/28/2023 7:51 AM, Laszlo Ersek wrote: On 10/27/23 23:11, Michael Kubacki wrote: I'd like to bring attention to Apache License 2.0 code in the CodeQL series I sent to the mailing list for steward review. In particular, the files in the BaseTools/Plugin/CodeQL/analyze directory of this

Re: [edk2-devel] [PATCH] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

On 10/31/23 11:43, Attar, AbdulLateef (Abdul Lateef) via groups.io wrote: > [Public] > > Hi Laszlo and @Lin, Jacque > Please find my response inline. > Thanks > AbduL > -Original Message- > From: Laszlo Ersek > Sent: Monday, October 30, 2023 7:34 PM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

On 10/31/23 10:55, Dhaval Sharma wrote: > I am posting an update on behalf of Jingyu as he had trouble with > posting. ... that should be rectified now -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110431):

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

> > Implement Cache Management Operations (CMO) defined by > RISC-V spec https://github.com/riscv/riscv-CMOs. > > Notes: > 1. CMO only supports block based Operations. Meaning cache > flush/invd/clean Operations are not available for the entire > range. In that case we fallback on fence.i

Re: [edk2-devel] [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file

Reviewed-by: Rahul R Kumar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110427): https://edk2.groups.io/g/devel/message/110427 Mute This Topic: https://groups.io/mt/101813022/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

[Public] +Laszlo, +Gerd, +Paolo PR: https://github.com/tianocore/edk2/pull/4982 -Original Message- From: Lin, Jacque Sent: Tuesday, October 31, 2023 11:07 AM To: devel@edk2.groups.io Cc: Lin, Jacque ; Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner Subject: [PATCH v2]

Re: [edk2-devel] [PATCH] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

[Public] Hi Laszlo and @Lin, Jacque Please find my response inline. Thanks AbduL -Original Message- From: Laszlo Ersek Sent: Monday, October 30, 2023 7:34 PM To: devel@edk2.groups.io; Lin, Jacque Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, Abner ; Gerd Hoffmann ; Paolo

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

On 10/31/23 14:42, Laszlo Ersek wrote: > On 10/30/23 18:27, Jeff Brasen via groups.io wrote: >> Anything else needed to get this merged would as the November stable release >> is coming up. > > Queued via . Commit

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

On 10/31/23 14:43, Laszlo Ersek wrote: > On 10/31/23 13:23, Laszlo Ersek wrote: >> On 10/31/23 00:09, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> Since the code is most regularly tested in CI, distro/versioning >>> details are updated to match the latest CI configuration. >>> >>> CI

Re: [edk2-devel] [PATCH v3 4/4] ArmVirtPkg: Add varpolicy shell command

On 10/31/23 14:43, Laszlo Ersek wrote: > On 10/30/23 23:36, Ard Biesheuvel wrote: >> On Mon, 30 Oct 2023 at 21:31, wrote: >>> >>> From: Michael Kubacki >>> >>> Adds the varpolicy EFI shell command to all DSC files that >>> currently include other dynamic shell commands from ShellPkg. >>> >>>

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Fix Python version (to 3.12)

On 10/31/23 14:43, Laszlo Ersek wrote: > On 10/30/23 20:07, Michael Kubacki wrote: >> Reviewed-by: Michael Kubacki > > Queued via . Commit 8e7462907050350f8a9ed54437a4441082180a9c. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

On 10/31/23 14:44, Laszlo Ersek wrote: > On 10/31/23 02:41, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Adds a GitHub workflow that uses the actions/stale GitHub action to >> automatically leave notifications on and close PRs that have had no >> activity for a long time. >> >> Note:

Re: [edk2-devel] [PATCH v2 2/5] MdePkg ACPI65: Add 0x0B/PRM to Generic Address Structure

On 10/31/23 14:42, Laszlo Ersek wrote: > On 10/31/23 10:19, Jinlong Xu wrote: >> Hi, Liming >> >> Could you please help merge the patch? This is a portion of PRM ACPI 6.5 >> support feature. > > Queued via . Merged as commit

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

On 10/31/2023 8:23 AM, Laszlo Ersek wrote: On 10/31/23 00:09, Michael Kubacki wrote: From: Michael Kubacki Since the code is most regularly tested in CI, distro/versioning details are updated to match the latest CI configuration. CI has moved from Ubuntu 18.04 to Ubuntu 22.04 since the time

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io wrote: > > There are two definitions for below functions in RedfishCrtLib.h. Create > this change to remote duplicated functions. > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), > strlen(), strchr(), strcasecmp(),

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

Right. But if you break in with debugger, you can still skip over the jmp instruction and continue. I agree XIP does not allow variable value to be updated, but we would never want to do that or all future dead loops in non XIP code would not loop. Mike From: Ni, Ray Sent: Tuesday, October

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

On 10/31/23 02:41, Michael Kubacki wrote: > From: Michael Kubacki > > Adds a GitHub workflow that uses the actions/stale GitHub action to > automatically leave notifications on and close PRs that have had no > activity for a long time. > > Note: Modifications to a PR reset the staleness

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

On 10/31/23 13:23, Laszlo Ersek wrote: > On 10/31/23 00:09, Michael Kubacki wrote: >> From: Michael Kubacki >> >> Since the code is most regularly tested in CI, distro/versioning >> details are updated to match the latest CI configuration. >> >> CI has moved from Ubuntu 18.04 to Ubuntu 22.04

Re: [edk2-devel] [PATCH v3 4/4] ArmVirtPkg: Add varpolicy shell command

On 10/30/23 23:36, Ard Biesheuvel wrote: > On Mon, 30 Oct 2023 at 21:31, wrote: >> >> From: Michael Kubacki >> >> Adds the varpolicy EFI shell command to all DSC files that >> currently include other dynamic shell commands from ShellPkg. >> >> This command allows variable policies to be dumped

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Fix Python version (to 3.12)

On 10/30/23 20:07, Michael Kubacki wrote: > Reviewed-by: Michael Kubacki Queued via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110414): https://edk2.groups.io/g/devel/message/110414

Re: [edk2-devel] [PATCH v2 2/5] MdePkg ACPI65: Add 0x0B/PRM to Generic Address Structure

On 10/31/23 10:19, Jinlong Xu wrote: > Hi, Liming > > Could you please help merge the patch? This is a portion of PRM ACPI 6.5 > support feature. Queued via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

On 10/30/23 18:27, Jeff Brasen via groups.io wrote: > Anything else needed to get this merged would as the November stable release > is coming up. Queued via . -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

That’s a great catch, thank you for bringing this to my attention Laszlo. Work is in progress. Patrick Henz -Original Message- From: Laszlo Ersek Sent: Tuesday, October 31, 2023 7:16 AM To: devel@edk2.groups.io; hao.a...@intel.com; Henz, Patrick ; Michael Brown Cc: Kinney, Michael D

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files

On Tue, 31 Oct 2023 at 13:30, Laszlo Ersek wrote: > > On 10/30/23 15:36, Ard Biesheuvel wrote: > > On Fri, 27 Oct 2023 at 07:43, duntan wrote: > >> > >> Use BaseIoLibIntrinsic.inf in dsc files. The > >> BaseIoLibIntrinsic supports Tdx and sev now. > >> The BaseIoLibIntrinsicSev will be removed

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

Thanks Mike! By following the logic, strlen() can be removed too. Version 3 patch is here: https://edk2.groups.io/g/devel/message/110408 I removed memcmp, memmove, and strlen. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Sunday, October 29, 2023 9:58 PM > To:

[edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

There are two definitions for below functions in RedfishCrtLib.h. Create this change to remote duplicated functions. Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), memcpy(), memchr(), memcmp() and memmove().

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: use BaseIoLibIntrinsic.inf in dsc files

On 10/30/23 15:36, Ard Biesheuvel wrote: > On Fri, 27 Oct 2023 at 07:43, duntan wrote: >> >> Use BaseIoLibIntrinsic.inf in dsc files. The >> BaseIoLibIntrinsic supports Tdx and sev now. >> The BaseIoLibIntrinsicSev will be removed in >> the following patches. >> >> Signed-off-by: Dun Tan >> Cc:

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On Sat, Oct 28, 2023 at 12:23:30 -0700, Michael D Kinney wrote: > Over the past few months, all the of the Maintainers and > Reviewers listed in Maintainers.txt have been contacted to make > sure Maintainers.txt accurately represents the TianoCore > community members that are actively

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

On 10/31/23 00:09, Michael Kubacki wrote: > From: Michael Kubacki > > Since the code is most regularly tested in CI, distro/versioning > details are updated to match the latest CI configuration. > > CI has moved from Ubuntu 18.04 to Ubuntu 22.04 since the time of the > file's creation, but the

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

On 10/31/23 02:41, Wu, Hao A wrote: > (Add MdePkg maintainers for their feedbacks) > > Sorry that I do not have strong opinion on this one. > > Some of my thoughts are: > * If you find the to-be-added APIs can be used in serveral places to reduce > repetative codes, then it will be worthwhile

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Use Performance Timer for XHCI Timeouts

On 10/31/23 02:41, Wu, Hao A wrote: > (Add MdePkg maintainers for their feedbacks) > > Sorry that I do not have strong opinion on this one. > > Some of my thoughts are: > * If you find the to-be-added APIs can be used in serveral places to reduce > repetative codes, then it will be worthwhile

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

On Tue, Oct 31, 2023 at 10:16 AM Attar, AbdulLateef (Abdul Lateef) wrote: > > [Public] > > +Laszlo, +Gerd, +Paolo > PR: https://github.com/tianocore/edk2/pull/4982 I left a comment in the PR. The patch is only correct if this code is only ever used on 64-bit processors. Note that KVM uses the

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MmSaveStateLib: Remove checking Smm Rev ID in AMD MmSaveStateLib

Hi, On 10/31/23 10:15, Attar, AbdulLateef (Abdul Lateef) wrote: > [Public] > > +Laszlo, +Gerd, +Paolo > PR: https://github.com/tianocore/edk2/pull/4982 ... My opinion, stated elsewhere in this thread in detail, is that this patch is wrong, and should not be merged. Laszlo > > -Original

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

comment below On 10/31/23 09:37, Xu, Wei6 wrote: > Delete one my wrong comments. > > -Original Message- > From: Xu, Wei6 > Sent: Tuesday, October 31, 2023 2:40 PM > To: Laszlo Ersek ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar > ; Ni, Ray > Subject: RE: [PATCH v3 2/4]

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

On 10/31/23 07:10, jacopo.r0...@gmail.com wrote: > Hi Laszlo, > > If I generate the certificate like > > /openssl req -new -nodes -x509 -days 365 -keyout server.key -out > server.crt -config config / > > it works perfectly fine (with the original configuration). > > The problem stands with the

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On 10/30/23 12:22, Sunil V L wrote: > On Mon, Oct 30, 2023 at 04:48:18PM +0530, Sunil V L wrote: >> On Sun, Oct 29, 2023 at 08:16:12PM +0530, Dhaval Sharma wrote: >>> Use newly defined cache management operations for RISC-V where possible >>> It builds up on the support added for RISC-V cache

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On 10/30/23 12:18, Sunil V L wrote: > On Sun, Oct 29, 2023 at 08:16:12PM +0530, Dhaval Sharma wrote: >> Use newly defined cache management operations for RISC-V where possible >> It builds up on the support added for RISC-V cache management >> instructions in BaseLib. >> Cc: Michael D Kinney >>

Re: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check

On 10/31/23 02:41, mikub...@linux.microsoft.com wrote: > From: Michael Kubacki > > Adds a GitHub workflow that uses the actions/stale GitHub action to > automatically leave notifications on and close PRs that have had no > activity for a long time. > > Note: Modifications to a PR reset the

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/28/23 21:23, Michael D Kinney wrote: > Over the past few months, all the of the Maintainers and > Reviewers listed in Maintainers.txt have been contacted to make > sure Maintainers.txt accurately represents the TianoCore > community members that are actively participating in their > roles.

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 10/30/23 23:18, Kinney, Michael D wrote: > Hi Laszlo, > > I do not support orphaned categories and that option should be > removed from Maintainer.txt. One of the motivations to get > Maintainers.txt updated is to work on the set of tasks related to > using GitHub PRs for code review. I

Re: [edk2-devel] [PATCH 0/7] Support Tdx and sev in BaseIoLibIntrinsic and remove BaseIoLibIntrinsicSev

Hi Tom, Thanks for your testing and comments. I'll modify the patch commit message and code according to your comments. Yes the patch changes the behavior for IoReadFifo/ IoWriteFifo API for non-Tdx and non-SEV case. Looking forward to more comments from the community. Hi Laszlo, May I know

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

I am posting an update on behalf of Jingyu as he had trouble with posting. CC'ing him here: In summary what we have verified so far: 1. I have verified that instructions/op codes are okay. I have also verified on Qemu that functionally it seems to be calling correct instructions. Ensured

Re: [edk2-devel] [PATCH v3 0/5] StarFive/VisionFive2: Add VisionFive 2 platform

Hi John, I forgot to mention that you need one more patch to add the maintainer entry for the platform. Otherwise, for the series, Acked-by: Sunil V L Thanks, Sunil On Fri, Oct 27, 2023 at 11:19:01AM +0800, John Chew wrote: > v3: > - Combine "Add VisionFive 2 platform" patch series with >

Re: [edk2-devel] [PATCH v2 2/5] MdePkg ACPI65: Add 0x0B/PRM to Generic Address Structure

Hi, Liming Could you please help merge the patch? This is a portion of PRM ACPI 6.5 support feature. Thanks Jinlong -Original Message- From: Xu, Jinlong Sent: Wednesday, October 25, 2023 3:29 PM To: gaoliming ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: [PATCH v2 2/5]

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

Reviewed-by: mailto:ashraf.al...@intel.com>>; Thanks., S, Ashraf Ali From: Kuo, Ted Sent: Tuesday, October 31, 2023 2:06 PM To: Ni, Ray ; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; S, Ashraf Ali ; Mohapatra, Susovan

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

Delete one my wrong comments. -Original Message- From: Xu, Wei6 Sent: Tuesday, October 31, 2023 2:40 PM To: Laszlo Ersek ; devel@edk2.groups.io Cc: Ard Biesheuvel ; Sami Mujawar ; Ni, Ray Subject: RE: [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue Thanks a lot

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

Reviewed-by: Ted Kuo mailto:ted@intel.com>> From: Ni, Ray Sent: Tuesday, October 31, 2023 4:26 PM To: devel@edk2.groups.io; Ni, Ray Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, Susovan Subject: Re:

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

Mike, This is not friendly for XIP code. With XIP code, the global variable is not able to be updated as it sits in read-only SPI flash. Thanks, Ray From: Kinney, Michael D Sent: Tuesday, October 31, 2023 11:37 AM To: Ni, Ray ; Andrew (EFI) Fish ;

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

Sorry, I copied the maintainers from Maintainers.txt but forgot to change all M/R to "Cc". That caused not all the maintainers/reviewers are CCed. I will fix the commit message before merging. Thanks, Ray From: devel@edk2.groups.io on behalf of Ni, Ray Sent:

[edk2-devel] [PATCH] IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

When FSP runs in API mode, it saves the IDTR in its own stack then switches to bootloader's stack before it returns from FspMemoryInit. Next time when the bootloader calls TempRamExit, FSP switches to its own stack and restores IDTR from its stack saved earlier. However, due to a bug in

Re: [edk2-devel] [PATCH V1 2/2] OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA

On Tuesday, October 31, 2023 8:45 AM, Erdem Aktas wrote: > On Sun, Oct 29, 2023 at 11:42 PM Sun, CepingX > mailto:cepingx@intel.com>> > wrote: > > > > On Saturday, October 28, 2023 12:45 AM, Erdem Aktas wrote: > > This should be the [PATCH V1 2/2] I assume? > > Yes, the name is same

[edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/RedfishFeatureUtilityLib: fix issues and enhancement

-Add RedfishDebugLib to print Redfish request and response details when PATCH and POST request return error. -Use "%a:" in debug print to align with the style in EDK2. -Enhance GetConfigureLang() to handle pending resource URI. Pending resource share ths same schema as its active resource. So we

[edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue

-RedfishConfigLangMapDxe relies on variable arch protocol. -Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf | 4 ++--

[edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/RedfishETagDxe: fix uninitialized variable issue

Status variable is not initialized. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c

[edk2-devel] [edk2-redfish-client][PATCH 0/3] Fix various issues and enhancement.

Fix various issues and add enhancement to RedfishClientPkg. PR is opened here: https://github.com/tianocore/edk2-redfish-client/pull/55 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (3): RedfishClientPkg/RedfishETagDxe: fix uninitialized

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

On Mon, Oct 30, 2023 at 11:24:15PM -0700, Dhaval Sharma wrote: > Can we define these bits in the header file so that the definitions can > be used by multiple modules? > [Dhaval] I could put it un Baselib.h (MDE_CPU_RISCV64) but sounds like right > now BaseLib.h is free of such #defines. If you

Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support

MCTP over KCS defines two types of KCS-like access, one is compatible with IPMI KCS, another is memory map I/O access. It doesn't require any special HW, just require the I/O cycle or memory cycle can be delivered to the management controller. Yes, we can consider MCTP is a software layer

Re: [edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

[AMD Official Use Only - General] Reviewed-by: Abner Chang I can help to merge this change if maintainer or review have no problem with it, as I am not any of those. Abner > -Original Message- > From: Lixia Huang > Sent: Tuesday, October 31, 2023 2:24 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

Thanks a lot for reviewing the patch. I have different opinions with (2), could you please check that? Thanks a lot. If you agree (2) is not an issue, I will prepare a new patch version to only address (1) and (3) BR, Wei >-Original Message- >From: Laszlo Ersek >Sent: Monday, October

Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support

Hi, Abner: I ask you a favor. KCS actually layer on LPC interface. KCS is a usual BMC-to-CPU communication channel. Does MCTP-over-KCS feature require some special LPC interface hardware changes? Or, MCTP is just a software stack and it uses current LPC interface, not any special hardward

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 2023-10-28 12:23:30, Michael D Kinney wrote: > @@ -497,7 +463,6 @@ F: OvmfPkg/ > W: http://www.tianocore.org/ovmf/ > M: Ard Biesheuvel [ardbiesheuvel] > M: Jiewen Yao [jyao1] > -R: Jordan Justen [jljusten] > R: Gerd Hoffmann [kraxel] > S: Maintained Acked-by: Jordan Justen

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

Can we define these bits in the header file so that the definitions can be used by multiple modules? [Dhaval] I could put it un Baselib.h (MDE_CPU_RISCV64) but sounds like right now BaseLib.h is free of such #defines. If you think it is still better would do it. I do not have any preference.

[edk2-devel] [PATCH v4 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver Cc: Abner Chang Cc: Nate DeSimone Signed-off-by: Lixia Huang ---

Re: [edk2-devel] [PATCH v7 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

NIT: I am wondering whether PcdRiscVCpuFeatureDisable is better so that it is explicit. [Dhaval] Well setting it to 1 would mean feature is enabled. Do it would be confusing to see PcdRiscVCpuFeatureDisable == 1 means feature is enabled. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

Thanks. This PCD is for Virt platform only. Or maybe I am missing the point. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110369): https://edk2.groups.io/g/devel/message/110369 Mute This Topic: https://groups.io/mt/102256471/21656

Re: [edk2-devel] [PATCH v3 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

[AMD Official Use Only - General] > -Original Message- > From: Lixia Huang > Sent: Tuesday, October 31, 2023 2:00 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nate DeSimone > > Subject: [PATCH v3 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone > MM > > Caution: This message

Re: [edk2-devel] SSL handshake in HTTPS boot if the certificate was signed with a root certificate

Hi Laszlo, If I generate the certificate like openssl req -new -nodes -x509 -days 365 -keyout server.key -out server.crt -config config it works perfectly fine (with the original configuration). The problem stands with the *chain* of certificates, meaning that I have a root certificate

[edk2-devel] [PATCH v3 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM

Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver Cc: Abner Chang Cc: Nate DeSimone Signed-off-by: Lixia Huang ---

  1   2   >