Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 20/04/2022 09:44 pm, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance for the
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds support to the UEFI
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Updates VariableRuntimeDxe
Hi Michael,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new GUID that is used
Hi Michael,
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 12/04/2022 05:29 pm, Michael Kubacki via groups.io wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id
Hi Ming,
I am not sure if this is an issue at my end, but I cannot apply this patch
series, can you check, please?
Also, is it possible to share these patches on a Github branch.
Regards,
Sami Mujawar
On 30/03/2022, 10:37, "Ming Huang" wrote:
Hi,
Any comment about t
Hi Rebecca,
Apologies for the delay.
Pushed as e18e208e7105..1e5be97660c6
Regards,
Sami Mujawar
On 01/04/2022, 15:51, "Rebecca Cran" wrote:
Could someone review these, and if they look good push them please?
Thanks.
Rebecca Cran
On 3/19/22 14:13, Rebecca
Hi Rebecca,
I will do this shortly.
Regards,
Sami Mujawar
On 01/04/2022, 15:51, "Rebecca Cran" wrote:
Could someone review these, and if they look good push them please?
Thanks.
Rebecca Cran
On 3/19/22 14:13, Rebecca Cran wrote:
> I noticed Linux repor
Hi Jiewen,
I was informed there is an ASWG ECR
https://mantis.uefi.org/mantis/view.php?id=2177 for TDEL. I can see the content
has been approved for ACPI 6.5.
Do you plan to update this ECR to reflect the changes for CCEL or this would be
a separate request?
Regards,
Sami Mujawar
On 10/03
Hi Rebecca,
Thank you for this patch. This change looks good to me.
I have a minor suggestion marked inline as [SAMI].
With that upated,
Tested-by: Sami Mujawar
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/03/2022 04:19 AM, Rebecca Cran wrote:
Add a RES0 device to the SSDT to
Hi Rebecca,
I have one minor suggestion marked inline as [SAMI]. Otherwise these
changes look good to me.
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/03/2022 04:19 AM, Rebecca Cran wrote:
Instead of using a custom Pcd for the ECAM address
Hi Rebecca,
Thank you for this patch. These change look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 05/03/2022 04:19 AM, Rebecca Cran wrote:
Other .asl files in Platform/ARM/JunoPkg/AcpiTables use spaces, while
AcpiSsdtRootPci.asl uses tabs. To be consistent, convert it
sure if you would need to retrigger the stalled pull request for the
CI to proceed.
If you still find that the gcc_arm_linux tools are failing, please do let me
know.
Regards,
Sami Mujawar
From: on behalf of "Bob Feng via groups.io"
Reply to: "devel@edk2.groups.io" , &
Hi All,
The GCC download link is now restored and the EDK2 CI is functional again.
This patch has been merged as a13dfc769bd7..c8ea48bdf955
Regards,
Sami Mujawar
On 14/03/2022, 15:00, "Sami Mujawar" wrote:
Hi All,
Azure pipeline jobs are failing due to broken download li
g to get the download links fixed. In the meantime, some patches may
not get merged in edk2.
Apologies for the inconvenience.
Regards,
Sami Mujawar
On 14/03/2022, 11:49, "Sunny Wang" wrote:
I tested this patch as well and confirmed this patch fixed the FWTS failure
below. Thanks
Hi Wenyi,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 14/03/2022, 09:26, "devel@edk2.groups.io on behalf of wenyi,xie via
groups.io"
wrote:
Fix header files on #ifdef.
Cc: Leif Lindholm
Cc: Ard
Hi Pranav,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 11/03/2022 06:06 AM, Pranav Madhu wrote:
Hi Sami,
Thanks for your comments. Please find my reply inline.
Regards,
Pranav
-Original Message-
From: Sami Mujawar
Sent: Thursday, March 10, 2022 9:01 PM
full device
path for the serial port device, and this results in a FWTS
test failure.
Therefore, populate the full namespace device path for the
serial port in DBG2 table.
Signed-off-by: Sami Mujawar
---
The changes can be seen at:
https://github.com/samimujawar/edk2/tree
Hi Pranav,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/03/2022 01:10 PM, Pranav Madhu wrote:
The warm reboot requests are mapped to cold reboot as the power control
module was not capable of handling the warm reboot requests in the
Hi Jiewen,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 10/03/2022, 05:49, "Yao, Jiewen" wrote:
HI Sami
I think it is OK to update signature to `CCEL`. That means it will be
applicable for other CC, right?
[SAMI] Yes, the same table can then
Hi Min,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 02/03/2022 12:28 AM, Min Xu wrote:
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the
event-log information
/show_bug.cgi?id=3831
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 15/02/2022 09:57 AM, Ming Huang wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3838
These definitions are added according UEFI spec 2.9.
Signed-off-by: Ming Huang
---
MdePkg/Include/Guid/Cper.h | 522
Thanks.
Pushed as c9e377b00fc0..958fc02b1593
Regards,
Sami Mujawar
On 28/02/2022 05:57 PM, patrik.bergl...@arm.com wrote:
From: Patrik Berglund
The definition of macros (e.g. SECURE_BOOT_ENABLE and others) in
ArmVExpress.dsc.inc overrides the setting configured in the platform
DSC file
Hi Patrik,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/02/2022 05:57 PM, patrik.bergl...@arm.com wrote:
From: Patrik Berglund
The definition of macros (e.g. SECURE_BOOT_ENABLE and others) in
ArmVExpress.dsc.inc
Hi Abdul,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/02/2022 11:13 AM, Abdul Lateef Attar wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3839
Adds PrintFormatter function to the FADT flags field.
Prints indivisual flag name along with flag
Hi Abdul,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 16/02/2022 11:13 AM, Abdul Lateef Attar wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3839
Adds ParseAcpiBitFields() which is based on
ParseAcpi() and capable of parsing the bit fields
Hi Ming,
Thank you for this patch.
I have a few comments, marked inline as [SAMI].
With those addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/02/2022 01:54 AM, Ming Huang wrote:
These definitions are added according UEFI spec.
Signed-off-by: Ming Huang
---
MdePkg
Hi All,
We are going to skip the IORT Rev E.b and E.c. I will be submitting a new patch
series, so please ignore this series.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86367): https://edk2.groups.io/g/devel
Hi All,
We are going to skip the IORT Rev E.b and E.c. I will be submitting a new patch
series, so please ignore this series.
Regards,
Sami Mujawar
On 03/02/2022, 15:24, "devel@edk2.groups.io on behalf of Rebecca Cran via
groups.io"
wrote:
Reviewed-by: Rebecca Cran
O
For this series,
Reviewed-by: Sami Mujawar
Merged as 017564d637e9..33189f052783
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
Add functions to generate code for the Memory32Fixed ASL macro and a
method returning an Integer.
Remove a redundant cast from
Hi Rebecca,
Thank you for this patch.
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
Add AmlCodeGenMethodRetInteger function to generate AML code for
a Method returning an Integer.
Signed-off-by: Rebecca Cran
Reviewed-by
Hi Rebecca,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to
AmlSetFixedArgument is redundant because ReturnNode is already
Hi Rebecca,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Regards,
Sami Mujawar
On 13/01/2022 04:40 PM, Rebecca Cran wrote:
Add a Memory32Fixed function to generate code for the corresponding
Memory32Fixed macro in AML
Hi Ard,
Thank you for this patch.
The timeout value 5 appears to be standard across platforms, so it looks good
to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/02/2022, 09:42, "devel@edk2.groups.io on behalf of PierreGondois via
groups.io"
wrote:
Hi,
Hi Rebecca,
Thanks for catching this.
I think we also need to add a check in Acpiview to report this issue. However,
that would be another patch series.
Regards,
Sami Mujawar
From: Rebecca Cran
Date: Monday, 31 January 2022 at 15:17
To: devel@edk2.groups.io , Pierre Gondois
Cc: Ard
Hi Rebecca,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
From: Ard Biesheuvel
Date: Sunday, 30 January 2022 at 11:01
To: Rebecca Cran
Cc: edk2-devel-groups-io , Ard Biesheuvel
, Samer El-Haj-Mahmoud
, Leif Lindholm , Sami Mujawar
, Wenyi Xie , Peng Xie
, Ling Jia
Merged as 805059812997..239181acdd45
Regards,
Sami Mujawar
From: devel@edk2.groups.io on behalf of Sami Mujawar via
groups.io
Date: Monday, 24 January 2022 at 18:16
To: Khasim Mohammed , devel@edk2.groups.io
Cc: nd , Pierre Gondois , Khasim Mohammed
Subject: Re: [edk2-devel] [PATCH v7 0
Hi Khasim,
Thank you for splitting the patches.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Khasim Mohammed
Date: Monday, 24 January 2022 at 15:56
To: devel@edk2.groups.io
Cc: nd , Sami Mujawar , Pierre Gondois
, Khasim Mohammed
Subject: [PATCH v7 0/6] Enable
Pushed as 8eb3b2f8be26..805059812997
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86016): https://edk2.groups.io/g/devel/message/86016
Mute This Topic: https://groups.io/mt/87284484/21656
Group Owner
Hi Khasim,
Thank you for the updated patch series.
These changes look good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/01/2022 03:26 PM, Khasim Syed Mohammed wrote:
The patch series removes PciExpressLib and enables CCIX port
as PCIe root on N1SDP.
V6
Hi Zhichao, Abdul,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
From: "Gao, Zhichao"
Date: Thursday, 20 January 2022 at 08:37
To: "Attar, AbdulLateef (Abdul Lateef)" ,
"devel@edk2.groups.io" , Sami Mujawar
Cc: "Ni, Ray" , nd
Hi Abdul,
Please also create a bugzilla ticket and add a reference to it in the
commit message.
Regards,
Sami Mujawar
On 19/01/2022 04:44 PM, Sami Mujawar wrote:
Hi Abdul,
Thank you for providing a patch to add this feature to Acpiview.
I have some minor feedback marked inline as [SAMI
Hi Abdul,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/12/2021 02:44 PM, Abdul Lateef Attar wrote:
Adds PrintFormatter function to the FADT flags field.
Prints indivisual flag name along with flag value.
Cc: Ray Ni
Cc
Hi Abdul,
Thank you for providing a patch to add this feature to Acpiview.
I have some minor feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 19/12/2021 02:44 PM, Abdul Lateef Attar wrote:
Adds ParseAcpiBitFields() which is based on
ParseAcpi() and capable of parsing the bit
Hi Khasim,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
The patch removes PciExpressLib implementation for N1Sdp as:
a) The PciSegmentLib implementation for N1Sdp
Hi Khasim,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
This patch enables CCIX root complex support by updating
the root complex node info in PciHostBridge library
Hi Khasim,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI]. Otherwise this patch
looks good to me.
With that changed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
PCD entries are updated to
Hi Khasim,
Thank you for this patch.
Please find my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote:
The BasePCISegment Library in MdePkg doesn't allow configuring
multiple segments required for PCIe and CCIX root
Hi Leif,
Apologies, I had forgotten to send a patch to add myself as the reviewer for
ArmPkg.
I have now sent a patch to update the maintainer.txt at
https://edk2.groups.io/g/devel/message/85812
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Add Sami as the reviewer for ArmPkg[SAMI]
Ref: https://edk2.groups.io/g/devel/message/82219
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b
Hi Kun,
Thank you for this patch series.
These changes look good to me. For this series
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 21/12/2021 01:33 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF: https://bugzilla.tianocore.org
Hi Kun,
I will review this patch series shortly.
Regards,
Sami Mujawar
On 18/01/2022, 22:07, "devel@edk2.groups.io on behalf of Kun Qin via
groups.io"
wrote:
I thought the reply on website will retain the original CC list. But I
was wrong about that.
Thanks for th
Hi Ard,
On 17/12/2021, 16:34, "Ard Biesheuvel" wrote:
On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote:
>
> Hi Leif, Ard, Wenyi,
>
> Is it possible to review and provde feedback for this change, please?
>
I agree that this should be resol
Hi Leif, Ard, Wenyi,
Is it possible to review and provde feedback for this change, please?
Regards,
Sami Mujawar
On 17/12/2021 02:15 PM, Pierre Gondois wrote:
Hi Sami,
You are correct, as stated in
Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf:
"Based o
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
The body of a function should be contained by open
and close braces that
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Only Doxygen commands '@bug', '@todo', '@examp
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
A comparison of any pointer to zero must be done
via the NULL type
Signed
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
There should be no trailing white space in one line.
Signed-off-by: Pierre
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
File has invalid Non-ACSII char.
Signed-off-by: Pierre Gondois
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
'TAB' character is not allowed in source code,
please replace
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following packages have the same GUID:
- Platform/ARM/VExpressPkg/ArmVExpressPkg.dec
- edk2/ArmPlatformPkg
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/VExpressPkg/Library/
ArmVExpressLibRTSM/ArmVExpressLib.inf
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/Morello/Library/PciHostBridgeLib/
PciHostBridgeLibFvp.inf
Hi Pierre,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The two following modules have the same GUID:
- Platform/ARM/VExpressPkg/Library/
ArmVExpressLibRTSM/ArmVExpressLibSec.inf
- Silicon
EbcDxe is not supported for AArch32 builds of the firmware.
Therefore, move EbcDxe so that it is included only for AArch64
builds of the firmware.
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 4 +++-
Platform/Socionext/SynQuacerEvalBoard
This patch series fixes the build breaks in SynQuacerEvalBoard.
Note: I have only tested that the build is fixed. I don't have
a board to test the functionality.
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2015_fix_arm_plat_build_break_v1
Sami Mujaw
BdsDxe depends on VariablePolicyHelperLib, so move it out from
VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and
LibraryClasses.DXE_RUNTIME_DRIVER.
This is required to fix the build break in SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext
ArmSoftFloatLib is required for the AARCH32 build of the firmware
for SynQuacerEvalBoard.
Therefore, add the missing ArmSoftFloatLib to SynQuacerEvalBoard.dsc
Signed-off-by: Sami Mujawar
---
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++
1 file changed, 3 insertions
Hi Ard,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 15:07, "Ard Biesheuvel via groups.io"
wrote:
On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz
wrote:
>
> W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze:
>
Hi Rebecca,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 13:14, "Rebecca Cran" wrote:
On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
> You appear to have missed a few instances:
>
> Platform/AMD/OverdriveBoard
Hi Nhi,
I have a minor suggestion to use FixedPcdGetPtr(), other than that this
patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
Currently, the serial and part number of a processor are filled with
fixed PCDs
Hi Nhi,
Other than the code style issue (which I believe uncrustify will
complain about), this patch looks good to me.
With that fixed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
Typically, the information of the SMBIOS type 1
Hi Nhi,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
This patch removes duplicate HII string definition in the
MiscSystemManufacturer.uni.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Hi Nhi,
These patches do not cleanly apply. I guess you would need to run
uncrustify for these patches.
Can you check, please?
Regards,
Sami Mujawar
On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote:
This patchset leverages the OemUpdateSmbiosInfo API functions from
OemMiscLib for
Pushed as 9006967c8d24..38f6d78c3b62
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v3:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v2. [Pierre]
v2:
- Various small fixes (change status returned
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:32 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v3:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v2. [Pierre]
v2:
- Various small
Hi Chris,
Thanks for fixing this issue.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Chris Jones
Date: Tuesday, 14 December 2021 at 12:38
To: devel@edk2.groups.io
Cc: ray...@intel.com , zhichao@intel.com
, rebe...@nuviainc.com , Sami
Mujawar , nd
Subject: [PATCH v1 1/1
Hi Pierre,
Thank you for this patch series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:31 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
v4:
- Run uncrustify and apply the required formatting. [Pierre]
- No other change with v3. [Pierre]
v3:
- Populate the
/tianocore.github.io/wiki/EDK-II-Code-Formatting
Regards,
Sami Mujawar
From: Attar, AbdulLateef (Abdul Lateef)
Date: Tuesday, 14 December 2021 at 11:18
To: Sami Mujawar , devel@edk2.groups.io
, Ray Ni , Zhichao Gao
Cc: nd
Subject: RE: [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield
Hi Rebecca,
Thank you for reporting this issue.
We will try to recreate the problem and provide a fix.
Regards,
Sami Mujawar
From: devel@edk2.groups.io on behalf of Rebecca Cran via
groups.io
Date: Tuesday, 14 December 2021 at 01:53
To: edk2-devel-groups-io , Ard Biesheuvel
, Leif Lindholm
Hi Kun,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 30/11/2021 12:39 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751
Current MM communicate routine from ArmPkg would conduct few
Thanks,
Pushed as e07d27e24d5d..ec37fd9c1fbc
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84746): https://edk2.groups.io/g/devel/message/84746
Mute This Topic: https://groups.io/mt/87608847/21656
Group Owner
Hi Rebecca,
Thank you for this patch series.
The patch series does not apply on top of latest master, which I believe
is due to the Uncrustify changes.
I have some minor suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami
Hi Rebecca,
Thank you for this patch.
I believe the patch subject line needs to be updated to "...
ArmCallSmc0/1/2/3 ...". Other than that, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 01/11/2021 10:11 PM, Rebecca Cran wrote:
New SMC helper
#x27;ll need to rebase on top of the
uncrustify changes in any case.
Sami, Leif: any comments?
I have some minor suggestions, that I will reply back shortly.
Regards,
Sami Mujawar
On 11/9/21 5:15 AM, Ard Biesheuvel wrote:
On Tue, 9 Nov 2021 at 12:57, Leif Lindholm wrote:
On Mon, Nov 08, 2
Hi Pierre,
Thank you for this patch series.
This series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/12/2021 09:24 AM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682
As part of the DynamicTablesPkg
Hi Jiewen, Min,
Thank you for making the measurement protocol architecture neutral.
I will monitor the mailing list for any further CC measurement
interface/implementations. However, I request you to copy me, in case I miss
any patches.
Regards,
Sami Mujawar
From: Yao, Jiewen
Date: Sunday
Merged as 0f1d7477c0a8..e81a81e5846e
Regards,
Sami Mujawar
On 09/12/2021 05:00 PM, Sami Mujawar via groups.io wrote:
Hi Chris,
Thank you for this patch series.
Other than my feedback for optimisation in patch 7/7 (which I will
address before merging), this patch series looks good to me
Hi Chris,
Thank you for this patch series.
Other than my feedback for optimisation in patch 7/7 (which I will
address before merging), this patch series looks good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 08/12/2021 04:06 PM, Chris Jones wrote
Hi Chris,
Thank you for this patch.
Please see my feedback below inline marked [SAMI].
Regards,
Sami Mujawar
On 08/12/2021 04:06 PM, Chris Jones wrote:
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697)
Update the PPTT generator with the CacheId field as defined in table
Hi Chandni,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
Morello SoC platform support has added and also
boot flow modified to reflect the new boot flow
for both Morello FVP and Morello SoC platforms
Signed-off
Hi Chandni,
Please find my feedback inline marked [SAMI].
With those fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: sah01
Support has been added to parse NT_FW_CONFIG DTB to get the
platform information.
Signed-off-by
Hi Chandni,
Please find my feedback marked inline as [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: Anurag Koul
Add definitions for both PCIe and CCIX Root Complex in PciHostBridge
Library. Also, use
Hi Chandni,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
With those addressed.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: Anurag Koul
Morello platform requires a custom platform-specific PCI Express
Hi Chandni,
Thank you for this patch.
I have a minor suggestion marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
From: Anurag Koul
A custom PCI Segment library is required
Hi Chandni,
I would suggest adding a brief introduction about the Morello SoC
platform in the commit message.
Otherwise, this patch looks good to me.
With the commit message updated.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
This
.
Otherwise, these changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
This patch implements the configuration manager for Morello
SoC platform. It enables support for generating the following
ACPI tables for Morello SoC
Hi Chandni,
Please find my feedback inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
This patch adds PlatformDxe support for Morello SoC platform.
It includes the registration of ramdisk device.
Signed
Hi Chandni,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
With that updated,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/12/2021 12:30 PM, Chandni Cherukuri wrote:
It includes virutal memory map for Morello SoC platform.
Signed-off-by: Chandni
801 - 900 of 1564 matches
Mail list logo
