Re: Suppressed template errors in admin

2011-09-06 Thread Jens Diemer
Am 25.08.2011 06:19, schrieb h3: But this would have side effects on the non-admin templates too.. so it's not ideal. Maybe something like this: TEMPLATE_STRING_IF_INVALID = {'default: '!! Invalid var !!', 'django.contrib.admin': ''} I do a hack in my admin.py: ---

Re: Suppressed template errors in admin

2011-09-06 Thread Ole Laursen
On 6 Sep., 09:17, Thomas Guettler wrote: > Ole, can you please set up a a branch at github or bitbucket? Eh, is that not overkill? I don't think discussing this is worth anyone's time. No need to promise anything or elevate this to a Big Decision as long as it's about trivial non-intrusive fixes

Re: Suppressed template errors in admin

2011-09-06 Thread Russell Keith-Magee
On Tue, Sep 6, 2011 at 3:17 PM, Thomas Guettler wrote: > > > Am 03.09.2011 16:13, schrieb Luke Plant: >> On 25/08/11 00:39, Russell Keith-Magee wrote: >> >>> On principle, I have no objection to the idea of making the admin >>> templates more robust in the presence of TEMPLATE_STRING_IF_INVALID; >

Re: Suppressed template errors in admin

2011-09-06 Thread Thomas Guettler
Am 03.09.2011 16:13, schrieb Luke Plant: > On 25/08/11 00:39, Russell Keith-Magee wrote: > >> On principle, I have no objection to the idea of making the admin >> templates more robust in the presence of TEMPLATE_STRING_IF_INVALID; >> adding dummy values in the context sounds like a reasonable a

Re: Suppressed template errors in admin

2011-09-05 Thread Yuri Baburov
Hi Luke, On Sat, Sep 3, 2011 at 9:13 PM, Luke Plant wrote: > On 25/08/11 00:39, Russell Keith-Magee wrote: > >> On principle, I have no objection to the idea of making the admin >> templates more robust in the presence of TEMPLATE_STRING_IF_INVALID; >> adding dummy values in the context sounds li

Re: Suppressed template errors in admin

2011-09-03 Thread Luke Plant
On 25/08/11 00:39, Russell Keith-Magee wrote: > On principle, I have no objection to the idea of making the admin > templates more robust in the presence of TEMPLATE_STRING_IF_INVALID; > adding dummy values in the context sounds like a reasonable approach > -- *if* doing this doesn't undermine bro

Re: Suppressed template errors in admin

2011-08-26 Thread Ole Laursen
On 25 Aug., 06:19, h3 wrote: > I'm not sure suppressing templates errors for the admin is such a > great idea. The suggestion on the table is to fix the couple of places where admin is sloppy and doesn't include all the variables it uses in the context. Normally you don't see this because this ki

Re: Suppressed template errors in admin

2011-08-26 Thread Ole Laursen
On 25 Aug., 01:39, Russell Keith-Magee wrote: > On principle, I have no objection to the idea of making the admin > templates more robust in the presence of TEMPLATE_STRING_IF_INVALID; > adding dummy values in the context sounds like a reasonable approach > -- *if* doing this doesn't undermine bro

Re: Suppressed template errors in admin

2011-08-24 Thread h3
I'm not sure suppressing templates errors for the admin is such a great idea. I work on two projects[1] where I would lose a useful debugging information and it would be the same lost to anyone working on the admin or extending the admin. Of course we could use a settings to toggle on/off the adm

Re: Suppressed template errors in admin

2011-08-24 Thread Russell Keith-Magee
On Wed, Aug 24, 2011 at 11:44 PM, Ole Laursen wrote: > Hi! > > I have a project where setting TEMPLATE_STRING_IF_INVALID has been > invaluable in finding problems (for various reasons). The caveat > mentioned in the docs don't kick in here because no templates are > inherited from elsewhere. Excep

Re: Suppressed template errors in admin

2011-08-24 Thread Jonas H.
On 08/24/2011 05:44 PM, Ole Laursen wrote: Hi! I have a project where setting TEMPLATE_STRING_IF_INVALID has been invaluable in finding problems (for various reasons). The caveat mentioned in the docs don't kick in here because no templates are inherited from elsewhere. Except the admin which un

Suppressed template errors in admin

2011-08-24 Thread Ole Laursen
Hi! I have a project where setting TEMPLATE_STRING_IF_INVALID has been invaluable in finding problems (for various reasons). The caveat mentioned in the docs don't kick in here because no templates are inherited from elsewhere. Except the admin which unfortunately breaks down in some places. I re