Re: [r300] r420 related changes

2005-03-04 Thread Vladimir Dergachev
there will be any chips in the future for which neither of the current choices work, the DRI will likely have to be disabled for them anyway. As for DRIScreenInit - I looked at the code again and its logic appears correct to me, could you elaborate a bit where you would like the R300 check to appe

Re: [r300] r420 related changes

2005-03-04 Thread Michel Dänzer
On Fri, 2005-03-04 at 13:53 -0500, Vladimir Dergachev wrote: > > On Fri, 4 Mar 2005, Michel [ISO-8859-1] Dnzer wrote: > > > On Fri, 2005-03-04 at 01:50 +0100, Rune Petersen wrote: > >> > >> if ( (info->ChipFamily == CHIP_FAMILY_R300) || > >> (info->ChipFamily == CHIP_FAMILY_R350) || > >>

Re: [r300] r420 related changes

2005-03-04 Thread Adam K Kirchhoff
Vladimir Dergachev wrote: On Fri, 4 Mar 2005, Michel [ISO-8859-1] Dïnzer wrote: On Fri, 2005-03-04 at 01:50 +0100, Rune Petersen wrote: if ( (info->ChipFamily == CHIP_FAMILY_R300) || (info->ChipFamily == CHIP_FAMILY_R350) || - (info->ChipFamily == CHIP_FAMILY_RV350) ) + (info->ChipFamily == CHIP_F

Re: [r300] r420 related changes

2005-03-04 Thread Vladimir Dergachev
On Fri, 4 Mar 2005, Michel [ISO-8859-1] Dänzer wrote: On Fri, 2005-03-04 at 01:50 +0100, Rune Petersen wrote: if ( (info->ChipFamily == CHIP_FAMILY_R300) || (info->ChipFamily == CHIP_FAMILY_R350) || -(info->ChipFamily == CHIP_FAMILY_RV350) ) +(info->ChipFamily == CHIP

Re: [r300] r420 related changes

2005-03-04 Thread Michel Dänzer
On Fri, 2005-03-04 at 01:50 +0100, Rune Petersen wrote: > > if ( (info->ChipFamily == CHIP_FAMILY_R300) || >(info->ChipFamily == CHIP_FAMILY_R350) || > - (info->ChipFamily == CHIP_FAMILY_RV350) ) > + (info->ChipFamily == CHIP_FAMILY_RV350) || > + (info->ChipFamily == CH

Re: [r300] r420 related changes

2005-03-04 Thread Vladimir Dergachev
Why do you the value is 7 ? According to my docs the number of pipes is a magic value that should be architecture dependent. Of course, my documentation is for R300 2d only.. I would expect that there is no easy formula. The 7 came from fglrx using radeon_dump. Ahh ! In this case it should be sa

Re: [r300] r420 related changes

2005-03-04 Thread Rune Petersen
Vladimir Dergachev wrote: Why do you the value is 7 ? According to my docs the number of pipes is a magic value that should be architecture dependent. Of course, my documentation is for R300 2d only.. I would expect that there is no easy formula. The 7 came from fglrx using radeon_dump. Ahh !

Re: [r300] r420 related changes

2005-03-04 Thread Vladimir Dergachev
Could you test that your patch works with regular freedesktop.org DRM driver as far as 2d is concerned ? It should print a message in the log that DRI is enabled, though, of course, you would not be able to use R300 Mesa driver. I gave it a try, no problem. patch: r420_drm-microcode-fix.patch I

Re: [r300] r420 related changes

2005-03-04 Thread Vladimir Dergachev
On Thu, 3 Mar 2005, Rune Petersen wrote: With the latest changes to drm in r300_driver I was reminded of a few problems with R420 cards and the r300 driver. 1) the Xorg driver defaults to R200 for R420 cards. RADEONDRIKernelInit() in radeon_dri.c Could you test that your patch works with regular

Re: [r300] r420 related changes

2005-03-04 Thread Rune Petersen
Vladimir Dergachev wrote: 3) I can enable more pipes for r420 cards, but am unable to test it on 420 cards with fewer pipes. Do I just add this and wait for someone to complain? A better way would be to read carefully specs of R4xx cards on ATI website to find out how many actual pipes are avail

Re: [r300] r420 related changes

2005-03-03 Thread Rune Petersen
Vladimir Dergachev wrote: On Thu, 3 Mar 2005, Rune Petersen wrote: 1) the Xorg driver defaults to R200 for R420 cards. RADEONDRIKernelInit() in radeon_dri.c Could you test that your patch works with regular freedesktop.org DRM driver as far as 2d is concerned ? It should print a message in the lo

[r300] r420 related changes

2005-03-03 Thread Rune Petersen
With the latest changes to drm in r300_driver I was reminded of a few problems with R420 cards and the r300 driver. 1) the Xorg driver defaults to R200 for R420 cards. RADEONDRIKernelInit() in radeon_dri.c 2) RADEONInitDispBandwidth() is disabled for r420 cards. I have no problem enabling this. a