This patches rename CoreGetMemoryMapPropertiesTable to
CoreGetMemoryMapWithSeparatedImageSection.
The reason is that CoreGetMemoryMapPropertiesTable is called
by MemoryAttributesTable.c to get separated PE image section
information.
It is confusing to use *PropertiesTable, because it is NOT
relat
This patches rename CoreGetMemoryMapPropertiesTable to
CoreGetMemoryMapWithSeparatedImageSection.
The reason is that CoreGetMemoryMapPropertiesTable is called
by MemoryAttributesTable.c to get separated PE image section
information.
It is confusing to use *PropertiesTable, because it is NOT
relat
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Wednesday, May 11, 2016 5:30 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: Fix bug to not mix comment int
Hi, Darbin
We need more internal discussion on NvmExpressLib. So I would suggest you work
on #1 & 2 patch at first. I will get back to you if we have conclusion on this.
As for the second concern, it's user choice. We can have a separate header file
like Pci sample, we also can have a single h
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Wednesday, May 11, 2016 5:30 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch] BaseTools/GenFds: enhance INF built arch filter
>
> The bug is use FILE_GUID override to build the same module mo
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, May 11, 2016 3:17 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric
> Subject: [patch] MdeModulePkg/SetupBrowser: Should free ConfigResp when it no
> longer be used
>
> When submit form fail, the progress
Reviewed-by: Liming Gao
> -Original Message-
> From: Samer El-Haj-Mahmoud [mailto:samer.el-haj-mahm...@hpe.com]
> Sent: Thursday, May 12, 2016 4:54 AM
> To: edk2-devel@lists.01.org
> Cc: samer.el-haj-mahm...@hpe.com; Kinney, Michael D
> ; Gao, Liming ; Samer
> El-Haj-Mahmoud
> Subject: [
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Friday, May 13, 2016 1:08 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Tian, Feng ;
> Ni, Ruiyu
> Subject: [PATCH 0/2] Return error for empty str VariableName to GetVariable
>
> Current GetVariable
Current GetVariable implementation will return the first variable for
empty str VariableName, it is because GetVariable and GetNextVariablename
are sharing same function FindVariable.
But UEFI sepc defines SetVariable that If VariableName is an empty string,
then EFI_INVALID_PARAMETER is returned,
Current GetVariable implementation will return the first variable for
empty str VariableName, it is because GetVariable and GetNextVariablename
are sharing same function FindVariable.
But UEFI sepc defines SetVariable that If VariableName is an empty string,
then EFI_INVALID_PARAMETER is returned,
Current GetVariable implementation will return the first variable for
empty str VariableName, it is because GetVariable and GetNextVariablename
are sharing same function FindVariable.
But UEFI sepc defines SetVariable that If VariableName is an empty string,
then EFI_INVALID_PARAMETER is returned,
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, May 13, 2016 11:24 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Gao, Liming ;
> wang xiaofeng
> Subject: [edk2] [PATCH] PcAtChipsetPkg A
Add DEBUG messages in DxeImageerificationLib to help debug Secure Boot image
verification failures
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia
Reviewed-by: Samer EL-Haj-Mahmoud
---
.../DxeImageVerificationLib/DxeImageVerificationLib.c | 19 +
From: wang xiaofeng
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) &
EnableMask) != EnableMask)) {
The bracket place is not right, I think it should be
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) &
EnableMask) != EnableMask)
Cc: Ruiyu Ni
Cc:
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Thursday, May 12, 2016 4:32 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 0/2] Change code for easy customization.
>
> Base on the former
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jaben
Carsey
Sent: Friday, May 13, 2016 6:10 AM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin
Subject: [edk2] [Patch] Use a local variable to cache the pointer.
CC: Qiu Shumin
Reviewed-by: Ye Ting
-Original Message-
From: Long, Qin
Sent: Thursday, May 12, 2016 4:44 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting
Subject: [Patch] CryptoPkg/SmmCryptLib: Enable AES support for SMM.
Enable AES cipher support for SmmCryptLib instance.
Cc: Ting Ye
Contributed-under
Hi Star,
The attached is my code change for this issue .You can see the
difference with beyond compare. It is not based on latest code. Could you help
to start a formal code review with this patch on behalf of me? I am not
familar the process of checking code to edk2.
Thanks !
I think you are right. Could you help contribute the patch to fix it?
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang
xiaofeng
Sent: Friday, May 13, 2016 10:20 AM
To: edk2-devel@lists.01.org
Subject: [edk2] a minor logic error in
Hi Everyone ,
Please refer to the code in AcpiTimerLibConstructor in
PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
The orginal code is
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) &
EnableMask) != EnableMask)) {
The bracket place is not right, I
Reviewed-by: Fu Siyuan
> -Original Message-
> From: Nagaraj Hegde [mailto:nagaraj-p.he...@hpe.com]
> Sent: Friday, May 6, 2016 6:20 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Fu, Siyuan ; Ye,
> Ting ; samer.el-haj-mahm...@hpe.com
> Subject: [PATCH v2 1/1] NetworkPkg:HttpDxe: Cod
Hi Ard,
Here is the PE/COFF spec update for RISC-V. Already published.
http://download.microsoft.com/download/9/C/5/9C5B2167-8017-4BAE-9FDE-D599BAC8184A/pecoff_v83.docx.
-Original Message-
From: Chang, Abner (HPS SW/FW Technologist)
Sent: Monday, May 09, 2016 10:35 PM
To: 'Ard Biesheuvel
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gary Lin
> Sent: Monday, May 9, 2016 12:33 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [edk2] [PATCH] NetworkPkg: Make HttpBootGetBootFile
From: Jeff Fan
Use the MSR MSR_IA32_MISC_ENABLE definition defined in UefiCpuPkg/Include and
remove the local definition.
Cc: Michael Kinney
Cc: Jiewen Yao
Cc: Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
From: Jeff Fan
SmmProfile feature depends on BTS feature to get the invoker IP (in SMM) from
last branch record. If this feature is not supported, SmmProfile cannot get the
invoker IP (in SMM). Per IA-32 Architectures Software Developer's Manual, BTS
feature is detected by IA32_MISC_ENABLE. If BI
From: Jeff Fan
BTS used DS save area by IA32_DS_AREA MSR to get invoker IP instead of the
Last Branch Record Stack. So, removed the unnecessary BTS MSRs.
Cc: Michael Kinney
Cc: Jiewen Yao
Cc: Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiC
This patch series
* Fixes a logic bug checking that BTS feature status.
* Removes some unnecessary BST MSRs.
* Adds use of the Msr.h file and uses MSR definitions from Msr.h
to test/save/restore MSR register values for the BTS and XD features.
Jeff Fan (3):
UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfil
Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Nagaraj Hegde
> Sent: Thursday, May 5, 2016 2:59 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [edk2] [PATCH v2 1/1] MdeModuleP
Looks fine. We will update again after the OHCI driver is moved into
MdeModulePkg.
Reviewed-by: Maurice Ma
Regards,
Maurice
-Original Message-
From: Leahy, Leroy P
Sent: Thursday, May 12, 2016 4:05 PM
To: edk2-devel@lists.01.org; Leahy, Leroy P; maruice...@intel.com; Agyeman,
Prince
Hi Lin,
Thanks for your exposing. I haven't meet this crash yet. But, I will check this
potential crash according your feedback. If any process, I will inform you.
Thanks and Best Regards.
Jiaxin
> -Original Message-
> From: Gary Lin [mailto:g...@suse.com]
> Sent: Thursday, May 12, 2016
Is there much point to the PCDs after this?
Even before, the benefit was minimal. I think there was the idea that
they could allow you to get the base address without having to include
the platform specific include files. (OvmfPlatforms.h)
Another idea could be to go ahead and convert it to a dyn
Hi Mike,
This was the specific request from the CorebootPayloadPkg maintainers. The
first version of the patch copied the code into CorebootModulePkg to eliminate
this require dependency.
Lee Leahy
(425) 881-4919
Intel Corporation
Suite 125
2700 - 156th Ave NE
Bellevue, WA 98007-6554
-Ori
Hi Feng,
1. That crossed my mind. Sure, I can do that.
2. Shouldn't v1.2 definitions go in a separate header e.g. Nvme12.h? For
instance, I see Pci22.h and Pci33.h under IndustryStandard. There are some
conflicting definitions between the two versions of the spec. Compare v1.1
Figure 82 with v
> On May 12, 2016, at 4:01 PM, Kinney, Michael D
> wrote:
>
> Leif,
>
> Yes. Typecasts are used by the caller if the type does not match. Here is
> an
> example from the PciCfg2.c that you referenced.
>
> IN OUTVOID *Buffer
>
> //
> // Aligned Pci addr
Hi Lee,
It seems strange for the CorebootPayloadPkg to depend on the QuarkPlatformPkg.
There is a request to add OHCI to MdeModulePkg.
http://article.gmane.org/gmane.comp.bios.edk2.devel/7536/match=ohci
Maybe Samer has some updates on testing.
Thanks,
Mike
> -Original Message--
Add the USB OHCI driver from revision 24ca2f35 of QuarkSocPkg.
Change-Id: Ie7aa0bc47d4ff06adc57976a5efb0e40ce4e1673
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
---
CorebootPayloadPkg/CorebootPayloadPkg.fdf| 5 +
CorebootPayloadPkg/CorebootPayloadP
Fix build errors due to locals variables being set but not used
and missing EFIAPI in a protocol service.
V2 version updates copyright dates
V3 fixes author email format
Lee Leahy (3):
QuarkPlatformPkg: Fix build errors
QuarkPlatformPkg: Fix variable set but not used build errors
QuarkSocPk
From: Lee Leahy
Add the missing EFIAPI to fix the inconsistent routine declaration and
implementation of a protocol service.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
Reviewed-by: Michael Kinney
---
QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/
From: Lee Leahy
Fix variable set but not used errors detected by GCC 4.8.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
Reviewed-by: Michael Kinney
---
QuarkPlatformPkg/Acpi/DxeSmm/SmmPowerManagement/Ppm.c| 16 ++--
.../Library/PlatformHelper
From: Lee Leahy
Fix build errors detected with GCC 4.8.4: local variable set but not
used!
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
Reviewed-by: Michael Kinney
---
QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c| 4 +---
QuarkPlatform
Jordan,
Yes. I noticed that when git was in the sending the emails mode and it
complained.
I am sending V3 now.
Mike
> -Original Message-
> From: Justen, Jordan L
> Sent: Thursday, May 12, 2016 3:57 PM
> To: Kinney, Michael D ; edk2-devel@lists.01.org
> Cc: Leahy, Leroy P
> Subject:
Leif,
Yes. Typecasts are used by the caller if the type does not match. Here is an
example from the PciCfg2.c that you referenced.
IN OUTVOID *Buffer
//
// Aligned Pci address access
//
WriteUnaligned16 (((UINT16 *) Buffer), PciRead16 (PciLib
On 2016-05-12 15:36:06, Michael Kinney wrote:
> From: "Leahy, Leroy P"
Can you fix the author on these patches?
git commit --amend --author="Lee Leahy "
Maybe Lee needs to fix his user.name and user.email settings?
-Jordan
>
> Fix build errors detected with GCC 4.8.4: local variable set but
On Thu, May 12, 2016 at 10:29:34PM +, Kinney, Michael D wrote:
> Leif,
>
> Why does the current definition strictly require alignment?
>
> I know we have used this for a long time with many compilers passing in
> unaligned pointers to UINT16, UINT32, UINT64 values without any compiler
> warn
From: "Leahy, Leroy P"
Fix build errors detected with GCC 4.8.4: local variable set but not
used!
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
Reviewed-by: Michael Kinney
---
QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c| 4 +---
QuarkP
From: "Leahy, Leroy P"
Fix variable set but not used errors detected by GCC 4.8.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
Reviewed-by: Michael Kinney
---
QuarkPlatformPkg/Acpi/DxeSmm/SmmPowerManagement/Ppm.c| 16 ++--
.../Library/Platfor
From: "Leahy, Leroy P"
Add the missing EFIAPI to fix the inconsistent routine declaration and
implementation of a protocol service.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
Reviewed-by: Michael Kinney
---
QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControl
Fix build errors due to locals variables being set but not used
and missing EFIAPI in a protocol service.
V2 version updates copyright dates
Leahy, Leroy P (3):
QuarkPlatformPkg: Fix build errors
QuarkPlatformPkg: Fix variable set but not used build errors
QuarkSocPkg/SDControllerDxe: Add E
Leif,
Why does the current definition strictly require alignment?
I know we have used this for a long time with many compilers passing in
unaligned pointers to UINT16, UINT32, UINT64 values without any compiler
warnings/errors.
Also, the patch contains locals that are initialized in the declara
Amended for commit.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Thursday, May 12, 2016 3:20 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Qiu, Shumin
> Subject: Re: [edk2] [Patch] Use a local variable to ca
The ReadUnaligned##/WriteUnaligned## functions provide a portable way of
accessing potentially unaligned locations, but the prototypes in
BaseLib.h all specify strictly aligned pointers.
Change the prototypes as well as the implementations across Ia32/X64,
ARM/AArch64 and IPF to use VOID * pointer
Subject line should have a ShellPkg prefix.
ShellPkg: Use a local variable to cache the pointer.
On 2016-05-12 15:09:32, Jaben Carsey wrote:
> CC: Qiu Shumin
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jaben Carsey
> ---
> ShellPkg/Application/Shell/Shell.c | 6 +
Reviewed-by: Erik Bjorge
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Thursday, May 12, 2016 3:10 PM
> To: edk2-devel@lists.01.org
> Cc: Qiu, Shumin
> Subject: [edk2] [Patch] Use a local variable to cache the pointer
CC: Qiu Shumin
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
---
ShellPkg/Application/Shell/Shell.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Application/Shell/Shell.c
b/ShellPkg/Application/Shell/Shell.c
index b06c1
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Leahy, Leroy P
> Sent: Thursday, May 12, 2016 2:27 PM
> To: edk2-devel@lists.01.org; Leahy, Leroy P ; Kinney,
> Michael D ; Steele, Kelly
> Subject: [PATCH 3/3] QuarkSocPkg/SDControllerDxe: Add EFIAPI to
> SetHighSpeedMode
>
Add the missing EFIAPI to fix the inconsistent routine declaration and
implementation of a protocol service.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Lee Leahy
---
QuarkSocPkg/QuarkSouthCluster/Sdio/Dxe/SDControllerDxe/SDController.c | 1 +
1 file changed, 1 inserti
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Leahy, Leroy P
> Sent: Wednesday, May 11, 2016 4:08 PM
> To: edk2-devel@lists.01.org; Leahy, Leroy P ; Kinney,
> Michael D ; Steele, Kelly
> Subject: [PATCH 1/3] QuarkPlatformPkg: Fix build errors
>
> Fix build errors detect
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Leahy, Leroy P
> Sent: Wednesday, May 11, 2016 4:08 PM
> To: edk2-devel@lists.01.org; Leahy, Leroy P ; Kinney,
> Michael D ; Steele, Kelly
> Subject: [PATCH 2/3] QuarkPlatformPkg: Fix variable set but not used build
> errors
Leroy,
The QuarkSocPkg does not support 64-bit. The DSC file for that package only
lists IA32.
I agree that protocol services need to be EFIAPI, so please update commit
message so the reason for the change is to add missing EFIAPI for a protocol
service.
Thanks,
Mike
> -Original Messa
> On May 12, 2016, at 9:32 AM, Andrew Fish wrote:
>
>
>> On May 12, 2016, at 8:49 AM, Kinney, Michael D
>> wrote:
>>
>> Andrew,
>>
>> I recall an issues with var args in the past (not CLANG related) that
>> requires the
>> Use of EFIAPI on all var args functions even internal ones.
>>
>
> On May 12, 2016, at 8:49 AM, Kinney, Michael D
> wrote:
>
> Andrew,
>
> I recall an issues with var args in the past (not CLANG related) that
> requires the
> Use of EFIAPI on all var args functions even internal ones.
>
If that is part of the coding standard that would help.
It is star
> On May 12, 2016, at 8:28 AM, Shi, Steven wrote:
>
> Below is my Clang3.8 output. The Clang3.8 simply does not permit use mix use
> _ms_va_list related builtins with System V ABI, only for Win64 ABI.
>
That seems to imply ti would break in the edk2 too?
> $ clang -flto -Wl,-Os ms_abi.c
> ms
Andrew,
I recall an issues with var args in the past (not CLANG related) that requires
the
Use of EFIAPI on all var args functions even internal ones.
This is similar to the rule that all functions implemented in assembly must be
EFIAPI to the register calling convention is matched.
Mike
> -
Below is my Clang3.8 output. The Clang3.8 simply does not permit use mix use
_ms_va_list related builtins with System V ABI, only for Win64 ABI.
$ clang -flto -Wl,-Os ms_abi.c
ms_abi.c:19:3: error: '__builtin_ms_va_start' used in System V ABI function
VA_START (Marker, len);
^
ms_abi.c:6:38:
> On May 12, 2016, at 7:51 AM, Shi, Steven wrote:
>
> Hi Andrew,
> Below is my clang3.8 output:
> $ clang --version
> clang version 3.8.0 (tags/RELEASE_380/final)
> Target: x86_64-unknown-linux-gnu
> Thread model: posix
> InstalledDir: /usr/local/bin
>
> $ clang -Os -flto ms_abi.c
> ms_abi.c:19
Hi Andrew,
Below is my clang3.8 output:
$ clang --version
clang version 3.8.0 (tags/RELEASE_380/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/bin
$ clang -Os -flto ms_abi.c
ms_abi.c:19:3: error: 'va_start' used in Win64 ABI function
VA_START (Marker, len);
> On May 12, 2016, at 5:30 AM, Michael Zimmermann
> wrote:
>
>> For AARCH64, that would be sufficient, but for ARM there are plenty of
>> other compiler intrinsics, so you should always include the
>> CompilerIntrinsicsLib.inf anyway (which the upstream DSCs are already
>> doing)
>
> since the
On some platforms, performing cache maintenance on regions that are backed
by NOR flash result in SErrors. Since cache maintenance is unnecessary in
that case, create a PEIM specific version that only performs said cache
maintenance in its constructor if the module is shadowed in RAM.
Contributed-
On 12 May 2016 at 14:32, Laszlo Ersek wrote:
> On 05/12/16 11:06, Ard Biesheuvel wrote:
>> This implements the platform glue for the new generic BDS implementation.
>> It is based on the ArmVirtQemu version, with the QEMU references removed.
>>
>> During the timeout, the following message is print
On 05/12/16 11:06, Ard Biesheuvel wrote:
> This implements the platform glue for the new generic BDS implementation.
> It is based on the ArmVirtQemu version, with the QEMU references removed.
>
> During the timeout, the following message is printed, with an additional
> trailing period added for
> For AARCH64, that would be sufficient, but for ARM there are plenty of
> other compiler intrinsics, so you should always include the
> CompilerIntrinsicsLib.inf anyway (which the upstream DSCs are already
> doing)
since there already seems to be AArch64 support
in ArmPkg/Library/CompilerIntrinsi
On 12 May 2016 at 14:17, Michael Zimmermann wrote:
>> The EDK2 build system already does that for IPF under GCC>
>>
>> DEFINE GCC_IPF_SYMRENAME_FLAGS = --redefine-sym memcpy=CopyMem
>
> this probably should be moved to the global GCC flags then, also GCC can
> generate other symbols too, i.e.
> The EDK2 build system already does that for IPF under GCC>
>
> DEFINE GCC_IPF_SYMRENAME_FLAGS = --redefine-sym memcpy=CopyMem
this probably should be moved to the global GCC flags then, also GCC can
generate other symbols too, i.e. "struct x = {0};" results in memset. (this
one would need a
On 12 May 2016 at 14:13, Michael Zimmermann wrote:
>> Michael,
>>
>> Can you try adding "-ffreestanding"?
>>
>
> that doesn't work either, but what Ard says does actually make sense. What
> else should GCC do to copy the struct data if we'd disallow memcpy?
> It would be useful if they'd provide a
> Michael,
>
> Can you try adding "-ffreestanding"?
>
that doesn't work either, but what Ard says does actually make sense. What
else should GCC do to copy the struct data if we'd disallow memcpy?
It would be useful if they'd provide a option to define the name of such
functions so we could just s
Michael,
Can you try adding "-ffreestanding"?
Alexei.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: 12 May 2016 12:27
To: Michael Zimmermann
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] facing compilation failure : unde
On 11 May 2016 at 11:13, Ard Biesheuvel wrote:
> Instead of cleaning the data cache to the PoU by virtual address and
> subsequently invalidating the entire I-cache, invalidate only the
> range that we just cleaned. This way, we don't invalidate other
> cachelines unnecessarily.
>
> Contributed-un
On 11 May 2016 at 13:57, Ard Biesheuvel wrote:
> On 11 May 2016 at 14:54, Laszlo Ersek wrote:
>> On 05/11/16 14:47, Ard Biesheuvel wrote:
>>> This implements the platform glue for the new generic BDS implementation.
>>> It is based on the ArmVirtQemu version, with the QEMU references removed.
>>>
On 12 May 2016 at 12:49, Michael Zimmermann wrote:
> this is weird because fno-builtin (which is set for AARCH64) should prevent
> that.
>
No, it doesn't. -fbuiltin affects GCC builtins only. Calls to memcpy
and memset (but also various EABI specific routines on 32-bit ARM)
will still be emitted
this is weird because fno-builtin (which is set for AARCH64) should prevent
that.
Michael
On Thu, May 12, 2016 at 12:20 PM, Meenakshi Aggarwal <
meenakshi.aggar...@nxp.com> wrote:
> Hi,
>
>
> I made SavedDataGuid STATIC and issue goes away with this.
> Thanks for your help :)
>
>
> Any pointer f
Hi,
I was testing HTTP Boot with the latest OMVF and found that it crashed
when downloading the remote image from the http server. Here is my
bisect result:
commit b347a22aecbfac9aac47831fee9a30aa810d6d0b
NetworkPkg: Avoid the indefinite wait case in HttpDxe
Actually, it sometimes worked but was
Hi,
I made SavedDataGuid STATIC and issue goes away with this.
Thanks for your help :)
Any pointer for similar error in PrintLib.c:
/home/tools/meenakshi/edk2/MdePkg/Library/BasePrintLib/PrintLib.c:415:
undefined reference to `memcpy'
Issue is coming on calling BasePrintLibSPrintMarker:
UIN
Hi,
when I override or set a variable using -DNAME=VAL from the build cmdline
these are visible to the DSC file only, the FDF continues using the
old/undefined values - at least if you use them as a value, i.e.:
BaseAddress = $(FD_BASE)|gArmTokenSpaceGuid.PcdFdBaseAddress
is this intended behav
This implements the platform glue for the new generic BDS implementation.
It is based on the ArmVirtQemu version, with the QEMU references removed.
During the timeout, the following message is printed, with an additional
trailing period added for every second waited.
Press ESCAPE for boot optio
Extra Notes for this change:
It will do some small changes for the current front page and
BootMaintenanceManager(BMM) page menus. Detail see below pic. Left is the
current UI and right is the new UI.
[cid:image014.jpg@01D1AC5A.DA2643F0][cid:image016.jpg@01D1AC5A.DA2643F0]
[cid:image018.jpg@01
Hi Andrew,
Yes. I get the same messages from Mark and Dong to work on a staging branch for
RISC-V as this is a public branch. I will work on branch first and then Dong
will submit the ECRs.
Regards to a driver which provides the version of RISC-V implementation, I
think OSs/softwares can recogni
Enable AES cipher support for SmmCryptLib instance.
Cc: Ting Ye
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Qin Long
---
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/CryptoPkg/Library/BaseCryp
Base on the former changes, we change code in front page and
BMM page to make they easy to be customzied.
Eric Dong (2):
BootMaintenanceManagerUiLib: change code for customization.
MdeModulePkg UiApp: change code for easy customization.
MdeModulePkg/Application/UiApp/FrontPage.c | 6
Change file arrangement to let user easy customize the front page UI.
After this change:
1. UiCustomizeFrontPage function in FrontPageCustomizedUi.c use to
let user customize front page menus. UiFrontPageCallbackHandler
function use to handle the callback for the added menus.
2. FrontPageCustomized
Change file arrangement to let user easy customize the BMM UI.
After this change:
1. UiCustomizeBMMPage function in BootMaintenanceManagerCustomizedUi.c
use to let user customize BMM first page menus. UiBMMCallbackHandler
function use to handle the callback for the added menus.
2. BootMaintenanceMa
On 05/12/16 07:57, Ni, Ruiyu wrote:
>
>
> Reviewed-by: Ruiyu Ni
Thanks guys, commit 14b2ebc30c8b.
Laszlo
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, May 11, 2016 6:28 PM
>> To: Gary Lin ; edk2-de...@ml01.01.org
>> Cc: Justen, Jordan L ; N
On 05/11/16 23:50, Michael Brown wrote:
> Conform to the specification for GetStatus(), which states that "if
> there are no transmit buffers to recycle and TxBuf is not NULL, *TxBuf
> will be set to NULL".
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribution Ag
On 11 May 2016 at 23:50, Michael Brown wrote:
> Conform to the specification for GetStatus(), which states that "if
> there are no transmit buffers to recycle and TxBuf is not NULL, *TxBuf
> will be set to NULL".
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Contributed-under: TianoCore Contribut
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Thursday, May 12, 2016 2:32 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch] BaseTools/GenFw: enhance to use Magic Field to identify
> the image
>
> Original use the File Header Machine Field
94 matches
Mail list logo
