Re: [edk2] BlockIo2 Protocol test tool

2019-02-01 Thread Sajeesh Kk
Hello Laszlo, Thanks for the quick response. I have some doubts regarding "TransactionStatus" that should be signaled by the driver when an IO operation is completed. If my understanding is not correct please educate. 1. As per UEFI spec, the error codes EFI_DEVICE_ERROR, EFI_NO_MEDIA,

Re: [edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix potential NULL pointer dereference issue

2019-02-01 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A > Chen > Sent: Friday, February 1, 2019 10:07 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2] [PATCH] MdeModulePkg/CapsuleApp: Fix potential

Re: [edk2] [PATCH] FatPkg/FatPei/Gpt.c: Fix uninitialized variable issue

2019-02-01 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chen A > Chen > Sent: Friday, February 1, 2019 10:21 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [edk2] [PATCH] FatPkg/FatPei/Gpt.c: Fix uninitialized

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] Maintainers.txt: AdvancedFeaturePkg and ClevoOpenBoardPkg maintainers

2019-02-01 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, February 2, 2019 10:38 AM > To: edk2-devel@lists.01.org > Cc: Desimone, Nathaniel L ; Chaganty, > Rangasai V ; Sinha, Ankit > ; Kinney, Michael D ; > Oram, Isaac W ; Gao, Liming > > Subject:

Re: [edk2] [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable tracehub

2019-02-01 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun -Original Message- From: Wei, David Sent: Saturday, February 02, 2019 12:55 PM To: Qian, Yi ; edk2-devel@lists.01.org Cc: Sun, Zailiang Subject: RE: [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable tracehub Reviewed-by: David Wei Regards,

Re: [edk2] [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable tracehub

2019-02-01 Thread Wei, David
Reviewed-by: David Wei Regards, David Intel Firmware Development -Original Message- From: Qian, Yi Sent: Saturday, February 2, 2019 12:51 PM To: edk2-devel@lists.01.org Cc: Qian, Yi ; Wei, David ; Sun, Zailiang Subject: [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable

[edk2] [Patch V2] edk2-platforms/devel-IntelAtomProcessorE3900: Enable tracehub

2019-02-01 Thread yqian4
https://bugzilla.tianocore.org/show_bug.cgi?id=1508 Expose npk related setup options and convey right settings to fsp upd for tracehub enabling. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yi Qian CC: David Wei CC: Zailiang Sun ---

[edk2] [edk2-platforms/devel-MinPlatform][PATCH v1 1/1] Maintainers.txt: AdvancedFeaturePkg and ClevoOpenBoardPkg maintainers

2019-02-01 Thread Michael Kubacki
Adds maintainers and reviewers for the AdvancedFeaturePkg and ClevoOpenBoardPkg. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Ankit Sinha Cc: Michael D Kinney Cc: Isaac W Oram Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kubacki ---

[edk2] [Patch] BaseTools: Correct the PcdDatabase Info in AutoGen

2019-02-01 Thread Feng, Bob C
From: Zhaozh1x PcdDriver AutoGen code shows PCD DB format for debug purpose only. But now, AutoGen code doesn't exactly match the generated PCD DB binary file. It brings the complex for Pcd driver debug. This patch is going to fix that issue. Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch] BaseTools: Correct the error message for UPT

2019-02-01 Thread Feng, Bob C
This patch is going to correct the error message for UPT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Hess Chen Cc: Liming Gao --- .../Python/UPT/Library/UniClassObject.py | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

Re: [edk2] LocateProtocol - gEfiTcp4ServiceBindingProtocolGuid

2019-02-01 Thread Ye, Ting
Hi Ivan, I can't find your attachment. Maybe removed by the mailing system. I have no idea about the tree you are using. Is it possible for you to use the EDKII trunk code? It is available at https://github.com/tianocore/edk2. Thanks, Ting -Original Message- From: edk2-devel

Re: [edk2] [PATCH V2] BaseTools: PCD value incorrect in structure pcd sku case.

2019-02-01 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, February 1, 2019 3:41 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2] BaseTools: PCD value incorrect in structure pcd sku case. Defined 2 PCDs(Test4 & Test401) and 2

Re: [edk2] [PATCH] BaseTools:StructurePCD value display incorrect in "Not used" section.

2019-02-01 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Friday, February 1, 2019 10:11 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:StructurePCD value display incorrect in "Not used" section. StructurePCD value display

Re: [edk2] [PATCH] BaseTools/ECC: Add a new type of exception

2019-02-01 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, Bob C Sent: Wednesday, January 30, 2019 4:49 PM To: edk2-devel@lists.01.org Cc: Chen, Hess Subject: [edk2] [PATCH] BaseTools/ECC: Add a new type of exception From:

[edk2] updated proposal for license changes

2019-02-01 Thread Doran, Mark
Hi Everyone: I hope this note finds everyone rested and back up to speed after the holidays! Or maybe I should say Happy New Year to those reading in Asia :) I wanted to follow up on the note I sent way back in October. Specifically I wanted to address the situation with Intel Contribution

Re: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths

2019-02-01 Thread Jeff Brasen
From: Wu, Hao A Sent: Friday, February 1, 2019 12:54 AM To: Jeff Brasen; edk2-devel@lists.01.org Cc: Edgar Handal Subject: RE: [edk2] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Use 16/32-bit IO widths > -Original Message- > From: Jeff Brasen

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-02-01 Thread Leif Lindholm
Please assume that for now. If you're ready to resubmit and we change our mind, I'll do the rework. Regards, Leif On Fri, Feb 01, 2019 at 10:28:32AM +, Pete Batard wrote: > All, > > From the feedback below, I'm going to assert that the current consensus is > to keep Bcm2836.h in

[edk2] [PATCH edk2-platforms v1 15/16] Hisilicon/D06: Use CalculateCrc16 in BaseLib

2019-02-01 Thread Ming Huang
This patch is relative with "Add new API CalculateCrc16()" in edk2. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Library/OemNicLib/OemNicLib.c | 69 ++-- 1 file changed, 5 insertions(+), 64 deletions(-) diff --git

[edk2] [PATCH edk2-platforms v1 16/16] Hisilicon/D0x: Modify version to 19.02

2019-02-01 Thread Ming Huang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 4 ++-- Platform/Hisilicon/D05/D05.dsc | 4 ++-- Platform/Hisilicon/D06/D06.dsc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[edk2] [PATCH edk2-non-osi v1 7/7] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-01 Thread Ming Huang
Add setup item "Support DPC" to enable or disable PCIe DPC (Downstream Port Containment). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.efi | Bin 232832 -> 226784 bytes 1 file changed, 0 insertions(+),

[edk2] [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function

2019-02-01 Thread Ming Huang
As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 context. PI specifies 'BSP' for Boot-strap Processor, as the one executing all of the EDK2 code. It then uses 'AP' to refer to Additional Processors, which can be assigned tasks using the EFI_MP_SERVICES_PROTOCOL. In a TianoCore

[edk2] [PATCH edk2-non-osi v1 3/7] Hisilicon/D06: Update Mbigen and gic RAS register

2019-02-01 Thread Ming Huang
As chip group suggestions, update Mbigen and gic RAS configuration flow. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Drivers/RasInitDxe/RasInitDxe.efi | Bin 17984 -> 18720 bytes 1 file changed, 0 insertions(+), 0 deletions(-)

[edk2] [PATCH edk2-non-osi v1 6/7] Hisilicon/D06: Fix numa node wrong issue

2019-02-01 Thread Ming Huang
Numa informations are acquired from HOB that build from memory initialization module. Correct numa informations to match booting from TA(Totem A or super cpu cluster A). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-non-osi v1 1/7] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-01 Thread Ming Huang
SAS controller is always existed, so accessing SAS register don't depend on PciBusDxe (pci enumeration). Modify SAS driver remove the dependence on pci enumeration. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-non-osi v1 0/7] Upload D0x binary modules

2019-02-01 Thread Ming Huang
Main Changes : 1 Fix numa node wrong issue; 2 Use new flash layout; 3 Update RAS binary; 4 Rename StartupAp() function; 5 Optimize SAS driver for reducing boot time; Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: 1902-non-osi-v1 Ming Huang (7):

[edk2] [PATCH edk2-non-osi v1 5/7] Hisilicon/D06: Use new flash layout

2019-02-01 Thread Ming Huang
In new flash layout, BIOS fd change from offset 1M to 8M in 16M spi flash. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/CustomData.Fv | Bin 0 -> 65536 bytes

[edk2] [PATCH edk2-non-osi v1 4/7] Hisilicon/D06: Support PCIe local RAS

2019-02-01 Thread Ming Huang
Add some registers configuration in PcieRasInitDxe and add PCIe local RAS interrupt handle in trusted firmware to support PCIe local RAS. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/Drivers/PcieRasInitDxe/PcieRasInitDxe.efi | Bin

Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 10:50, Philippe Mathieu-Daudé wrote: > Hi, > > On 2/1/19 6:34 AM, Shenglei Zhang wrote: >> Remove content related to UNIXGCC in README. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1377 >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Anthony Perard >>

[edk2] [PATCH edk2-platforms v1 14/16] Hisilicon/D0x: Remove SP805 watchdog pcd

2019-02-01 Thread Ming Huang
SP805 watchdog is no used for D0x, so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 3 --- Platform/Hisilicon/D05/D05.dsc | 3 ---

[edk2] [PATCH edk2-platforms v1 13/16] Hisilicon/D06: Remove SECURE_BOOT_ENABLE definition

2019-02-01 Thread Ming Huang
As secure boot is not ready, remove SECURE_BOOT_ENABLE and relative code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 12 Platform/Hisilicon/D06/D06.fdf | 11 --- 2 files changed, 23 deletions(-)

[edk2] [PATCH edk2-platforms v1 09/16] Hisilicon/D06: Add PCI_OSC_SUPPORT

2019-02-01 Thread Ming Huang
Add PCI_OSC_SUPPORT for remaining host bridges to remove fail output in kernel: [ 103.478893] acpi PNP0A08:01: _OSC failed (AE_NOT_FOUND); Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 64

[edk2] [PATCH edk2-platforms v1 11/16] Hisilicon/D06: Add Setup Item "Support DPC"

2019-02-01 Thread Ming Huang
Add setup item "Support DPC" to enable or disable PCIe DPC (Downstream Port Containment). Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/OemConfigData.h | 1 +

[edk2] [PATCH edk2-platforms v1 03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time

2019-02-01 Thread Ming Huang
SAS controller is always existed, so accessing SAS register don't depend on PciBusDxe (pci enumeration). Move the SAS module early in D06.fdf for dispatching SAS driver early. This can avoid wait in BDS normally and reduce boot time. This patch is relative with SasDriverDxe in edk2-non-osi.

[edk2] [PATCH edk2-platforms v1 02/16] Hisilicon/D0x: Add DriverHealthManagerDxe

2019-02-01 Thread Ming Huang
DriverHealthManagerDxe Collect driver health form of third party drivers to repair no healthy card. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D03/D03.dsc | 1 + Platform/Hisilicon/D05/D05.dsc | 1 + Platform/Hisilicon/D06/D06.dsc |

[edk2] [PATCH edk2-platforms v1 10/16] Hisilicon/D06: Modify for M7 self-Adapte support

2019-02-01 Thread Ming Huang
As new M7(Cortex-M7) firmware support self-adapte, so do not need BIOS to implement some function, remove useless funtions and report CPU0/CPU1 Nic NCL offset to M7. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-platforms v1 12/16] Hisilicon/D06: Use new flash layout

2019-02-01 Thread Ming Huang
In new flash layout, BIOS fd change from offset 1M to 8M in 16M spi flash. Use the new CustomData.Fv which indicate the offset of fd and which flash area can be updated for BMC. This patch is relative with patch "Use new flash layout" in edk2-non-osi. Contributed-under: TianoCore Contribution

[edk2] [PATCH edk2-platforms v1 06/16] Hisilicon/D06: Add OemGetCpuFreq to encapsulate difference

2019-02-01 Thread Ming Huang
From: xingjiang tang Implementation OemGetCpuFreq() to get cpu frequency from cpld to encapsulate project difference, for some projects don't support get cpu frequency by this way. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang ---

[edk2] [PATCH edk2-platforms v1 07/16] Hisilicon/D0x: Rename StartupAp() function

2019-02-01 Thread Ming Huang
As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 context. PI specifies 'BSP' for Boot-strap Processor, as the one executing all of the EDK2 code. It then uses 'AP' to refer to Additional Processors, which can be assigned tasks using the EFI_MP_SERVICES_PROTOCOL. In a TianoCore

[edk2] [PATCH edk2-platforms v1 00/16] Fix issues and improve D0x

2019-02-01 Thread Ming Huang
Main Changes : 1 Use new flash layout; 2 Modify for M7 self-Adapte support; 3 Add PCI_OSC_SUPPORT for ACPI/DSDT; 4 Change HCCS speed from 30G to 26G; 5 Rename StartupAp() function; 6 Fix access variable fail issue; 7 Optimize SAS driver for reducing boot time; 8 Add DriverHealthManagerDxe; 9

[edk2] [PATCH edk2-platforms v1 08/16] Hisilicon/D06: Change HCCS speed from 30G to 26G

2019-02-01 Thread Ming Huang
Follow chip team suggestion to change HCCS(Huawei Cache-Coherent System) speed from 30G to 26G, this modification can avoid some unstable stress issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Include/Library/OemMiscLib.h

[edk2] [PATCH edk2-platforms v1 04/16] Hisilicon/D06: Fix access variable fail issue

2019-02-01 Thread Ming Huang
From: Jason Zhang BmcWdtEnable is a field of OemConfigData structure, need have runtime service attribution if use it during exit boot service Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr |

[edk2] [PATCH edk2-platforms v1 05/16] Hisilicon/D06: Add more PCIe port INT-x support

2019-02-01 Thread Ming Huang
From: Jason Zhang Since NVMe riser width is 6*X4, need add the related port's INT-x support to match OS driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Dsdt/Hi1620Pci.asl | 65 +++- 1 file

[edk2] [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib

2019-02-01 Thread Ming Huang
SerdesLib is useless for SmbiosMiscDxe and D06, so remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- Platform/Hisilicon/D06/D06.dsc | 2 -- Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 - 2

Re: [edk2] [PATCH 00/10] Remove unused tool chain configuration

2019-02-01 Thread Gao, Liming
Ard: If no tool chain depends on GCCLD, I agree to remove it from build_rule.template. Thanks Liming > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Friday, February 1, 2019 6:25 PM > To: Zhang, Shenglei > Cc: edk2-devel@lists.01.org; Feng, Bob

Re: [edk2] [PATCH 12/14] OvmfPkg/MptScsiDxe: Implement the PassThru method

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > Machines should be able to boot after this commit. Tested with different Linux > distributions (Ubuntu, CentOS) and different Windows versions (Windows 7, > Windows 10, Server 2016). > > Contributed-under: TianoCore Contribution Agreement 1.1 >

[edk2] LocateProtocol - gEfiTcp4ServiceBindingProtocolGuid

2019-02-01 Thread Ivan Novgorodtsev
Hi, I'm having trouble with sending a tcp packet from UEFI Application. I'm using code from this github: https://github.com/YunWang/uefi-programming-guider/tree/master/book/Network I attached two screenshot were I suppose something went wrong. In first one, at lines 91-94  LocateProtocol

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-01 Thread Gao, Liming
Ming: What's usage model of new Crc16()? Can they use the same algorithm in DebugAgent? Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ming > Huang > Sent: Friday, February 1, 2019 3:12 PM > To: Ni, Ray ;

Re: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 0/6] Add initial ClevoOpenBoardPkg

2019-02-01 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Kubacki > Sent: Saturday, January 26, 2019 9:06 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [edk2-platforms/devel-MinPlatform][PATCH v3 0/6] Add initial

Re: [edk2] [PATCH 11/14] OvmfPkg/MptScsiDxe: Initialize hardware

2019-02-01 Thread Laszlo Ersek
Hi Nikita, I've jumped ahead a little bit to point out other style issues, so you can address them at once in v2. These are again general comments, likely applying to several patches in the series. On 01/31/19 11:07, Nikita Leshenko wrote: > +typedef struct { > + UINT8 WhoInit; > + UINT8

Re: [edk2] [PATCH 04/14] OvmfPkg/MptScsiDxe: Probe PCI devices and look for MptScsi

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > The MptScsiControllerSupported function is called for every handle > that appears on the system This statement is incorrect. The Supported() function is generally called on such handles that the ConnectController() boot service tries to connect. More

Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-01 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, February 01, 2019 5:40 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support > LockBox enlarge in UpdateLockBox() > > Hi

Re: [edk2] [PATCH v3 10/12] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-01 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, February 01, 2019 5:18 PM > To: Wu, Hao A; edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: Re: [edk2] [PATCH v3 10/12] MdeModulePkg/SmmLockBox(PEI): > Remove an ASSERT in RestoreLockBox() > > On

Re: [edk2] Conditional Compilation support in INF file

2019-02-01 Thread KarunakarPoosapalli
Hi Stephano, I've updated the comment in BugZill 1446. Can you please send invite for Bug Scrub meetings to discuss on it. Thanks & Regards, karunakar -Original Message- From: stephano [mailto:stephano.cet...@linux.intel.com] Sent: Thursday, January 31, 2019 9:57 PM To: Gao, Liming;

Re: [edk2] OvmfPkg: Support booting from Fusion-MPT SCSI controllers

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > This series adds driver support for: > - LSI53C1030 > - SAS1068 > - SAS1068E > > These controllers are widely supported by QEMU, VirtualBox and VMWare. This > work > is part of the more general agenda of enhancing OVMF boot device support to > have >

[edk2] [PATCH] SecurityPkg/OpalPassword: Add NULL pointer check before using it

2019-02-01 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1503 A pointer variable should be checked if it is NULL or Valid before using it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Maggie Chu Cc: Chao Zhang Cc: Jiewen Yao Cc: Eric Dong ---

[edk2] [PATCH] SecurityPkg/OpalPassword: Update strings on Opal Setup page

2019-02-01 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1506 Updated some descriptions on SETUP page to avoid user confusion. Currently it shows "1.0 UEFI Opal Driver", however it may be mislead user to think it is only for Opal drive but not for Pyrite drive. Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-02-01 Thread Pete Batard
All, From the feedback below, I'm going to assert that the current consensus is to keep Bcm2836.h in IndustryStandard/ and therefore, outside of adding an additional description with regards to its purpose, I will keep this patch as-is for v5. If this is not what we want, please let me

Re: [edk2] [PATCH] EmbeddedPkg/PrePiLib: Correct function name

2019-02-01 Thread Ard Biesheuvel
On Fri, 1 Feb 2019 at 05:28, Jeff Brasen wrote: > > Update header file function name for FfsFindFileByName to match > implementation function name. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jeff Brasen > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by:

Re: [edk2] [patch 0/2] Fix coding style issues in MdeModulePkg and MdePkg

2019-02-01 Thread Ard Biesheuvel
On Fri, 1 Feb 2019 at 07:02, Dandan Bi wrote: > > Cc: Ard Biesheuvel > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao Wu > Dandan Bi (2): > MdeModulePkg: Fix coding style issues > MdePkg: Fix coding style issues > > .../FaultTolerantWriteSmmCommon.h| 4 ++-- >

Re: [edk2] [PATCH 03/14] OvmfPkg/MptScsiDxe: Report name of driver

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > Install Component Name protocols to have a nice display name for the > driver in places such as UEFI shell. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk >

Re: [edk2] [PATCH 00/10] Remove unused tool chain configuration

2019-02-01 Thread Ard Biesheuvel
On Fri, 1 Feb 2019 at 06:34, Shenglei Zhang wrote: > > VS2003, VS2005, DDK3790, UNIXGCC, ELFGCC, CYGCC and MYTOOLS are > too old. There is no verification for them. So remove them from > edk2/master. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > Do we still need the GCCLD toolchain

Re: [edk2] [PATCH 02/14] OvmfPkg/MptScsiDxe: Install DriverBinding Protocol

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > In order to probe and connect to the MptScsi device we need this > protocol. Currently it does nothing. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by:

Re: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver

2019-02-01 Thread Laszlo Ersek
On 02/01/19 03:16, Bi, Dandan wrote: > Hi Nikita, > > I have one comment here, could you help to verify this patch series with VS > tool chain build before commit the patches? (1) Nikita, when you post the v2 series, please push it to a public repo/branch of yours as wel. So that developers

Re: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > In preparation for implementing LSI Fusion MPT SCSI devices, create a > basic scaffolding for a driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by:

Re: [edk2] [MdePkg/BaseLib v1 1/1] MdePkg BaseLib: Add new API CalculateCrc16()

2019-02-01 Thread Ard Biesheuvel
On Fri, 1 Feb 2019 at 08:11, Ming Huang wrote: > > > > On 2/1/2019 2:37 PM, Ni, Ray wrote: > > There is an CRC16 calculation implementation in > > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > > > > Does your implementation generate the same CRC16 as above one? > > It is

Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC

2019-02-01 Thread Philippe Mathieu-Daudé
Hi, On 2/1/19 6:34 AM, Shenglei Zhang wrote: > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-under: TianoCore Contribution

Re: [edk2] OvmfPkg: Support booting from Fusion-MPT SCSI controllers

2019-02-01 Thread Laszlo Ersek
On 01/31/19 11:07, Nikita Leshenko wrote: > This series adds driver support for: > - LSI53C1030 > - SAS1068 > - SAS1068E > > These controllers are widely supported by QEMU, VirtualBox and VMWare. This > work > is part of the more general agenda of enhancing OVMF boot device support to > have >

Re: [edk2] [PATCH v3 11/12] MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox()

2019-02-01 Thread Laszlo Ersek
Hi Hao, On 02/01/19 06:47, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1409 > > This commit will add the support to enlarge a LockBox when using the > LockBoxLib API UpdateLockBox(). > > Please note that the new support will ONLY work for LockBox with attribute >

Re: [edk2] [PATCH edk2-platforms] Silicon/Bcm2836: add random number generator driver

2019-02-01 Thread Ard Biesheuvel
On Thu, 31 Jan 2019 at 19:35, Leif Lindholm wrote: > > On Thu, Jan 31, 2019 at 06:14:45PM +0100, Ard Biesheuvel wrote: > > On Thu, 31 Jan 2019 at 16:05, Leif Lindholm > > wrote: > > > > > > On Wed, Jan 30, 2019 at 08:39:43PM +0100, Ard Biesheuvel wrote: > > > > Expose the SoC's RNG peripheral

Re: [edk2] [PATCH v3 10/12] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox()

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:47, Hao Wu wrote: > This commit is out of the scope for BZ-1409. It is a refinement for the > PEI library instance within SmmLockBoxLib. > > For the below ASSERT statement within function RestoreLockBox(): > Status = SmmCommunicationPpi->Communicate ( >

Re: [edk2] [PATCH v3 09/12] MdeModulePkg/SmmLockBoxLib: Use 'DEBUG_' prefix instead of 'EFI_D_'

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:47, Hao Wu wrote: > This commit is out of the scope for BZ-1409. It is a coding style > refinement for the SmmLockBoxLib. > > More specifically, the commit will remove all the debug message display > level macros starting with 'EFI_D_' and replace them with macros starting > with

[edk2] [Patch] BaseTools: Fix the build report issue about Structure PCD

2019-02-01 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1472 build report use incorrect method to parse DynamicDefault/DynamicExDefault and DynamicVpd/DynamicExVpd structure Pcd value. This patch is to fix this issue. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc:

Re: [edk2] [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > CYGGCC is too old.There is no verification for it. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang >

[edk2] [PATCH] MdeModulePkg/PciBus: Fix a bug PPB MEM32 BAR isn't restored sometimes

2019-02-01 Thread Ray Ni
From: Ruiyu Ni REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1505 When a device under PPB contains option ROM but doesn't require 32bit MMIO, ProgrameUpstreamBridgeForRom() cannot correctly restore the PPB MEM32 RANGE BAR. It causes the 32bit MMIO conflict which may cause system hangs in

Re: [edk2] [PATCH 08/10] BaseTools/tools_def.template: Remove ELFGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > ELFGCC is too old.There is no verification for it. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang >

Re: [edk2] [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-under: TianoCore Contribution

Re: [edk2] [Patch v2 00/33] BaseTools python3 migration patch set

2019-02-01 Thread Laszlo Ersek
On 02/01/19 04:13, Feng, Bob C wrote: > I have pushed py3 patch set to edk2 master. Thanks! I've noted the commit range on the BZ (cc01b26e053c..8189be6fd7d7) and closed the BZ (#55). Laszlo ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] [PATCH 04/10] BaseTools/tools_def.template: Remove UNIXGCC

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > UNIXGCC is too old.There is no verification for it. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang >

Re: [edk2] [PATCH 05/10] OvmfPkg: Remove UNIXGCC in DSC files

2019-02-01 Thread Laszlo Ersek
On 02/01/19 06:34, Shenglei Zhang wrote: > Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc > and OvmfPkgX64.dsc. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall >

Re: [edk2] [PATCH v4 edk2-platforms 01/23] Silicon/Broadcom/Bcm282x: Add interrupt driver

2019-02-01 Thread Laszlo Ersek
On 01/31/19 22:01, Andrew Fish wrote: > > >> On Jan 31, 2019, at 11:57 AM, Leif Lindholm wrote: >> >> +Andrew, Laszlo, Mike. >> >> On Thu, Jan 31, 2019 at 06:19:48PM +0100, Ard Biesheuvel wrote: >>> On Thu, 31 Jan 2019 at 16:24, Leif Lindholm >>> wrote: On Tue, Jan 29, 2019 at