Re: [edk2] UEFI App embedded on another uefi app

nal Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Rafael Machado > Sent: Thursday, December 21, 2017 1:32 AM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] UEFI App embedded on another uefi ap

Re: [edk2] [Patch] ShellPkg: Fix a build error in Ping6 shell command.

On 12/18/2017 5:29 PM, fanwang2 wrote: From: Wang Fan <fan.w...@intel.com> Last check in involved a build error, this patch is to fix this issue. Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wang Fan <fan

Re: [edk2] UEFI App embedded on another uefi app

On 12/15/2017 7:45 PM, Rafael Machado wrote: Hi Everyone. I have a limited space problem at a project. To solve this we had an idea, but would like to ask to you before expending time on trying to do it, due to some tight schedule. (We know that the best is to try before ask, but we do not have

Re: [edk2] [PATCH] UefiCpuPkg: Keep library class header file definition independent

On 12/14/2017 4:31 PM, Song, BinX wrote: Keep library class header file definition independent Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song ---

Re: [edk2] [PATCH] PerformancePkg: Remove it

On 12/14/2017 9:46 AM, Zeng, Star wrote: Ruiyu, Do you need to update Maintainers.txt accordingly at the same time? Yes I will do that after the PerformancePkg is deleted. Just would like to split the big changes into two steps:) Thanks, Star

Re: [edk2] [PATCH 1/3] MdePkg: break #defines out of Uefi/UefiMultiPhase.h

On 12/13/2017 8:26 PM, Leif Lindholm wrote: Turns out all .vfr files in the tree interacting with DynamicPcds manually copy the same set of EFI_VARIABLE_* definitions, since the rest of UefiMultiPhase.h is incompatible with VfrCompile. Split these out into a separate header file

Re: [edk2] [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

On 12/13/2017 4:44 PM, Laszlo Ersek wrote: On 12/13/17 03:35, Song, BinX wrote: V2: Update function name, add more detail description. V1: Check and assert invalid RegisterCpuFeature function parameter Cc: Eric Dong Cc: Laszlo Ersek Contributed-under:

Re: [edk2] [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

tializeFunc); Feature = VA_ARG (Marker, UINT32); + ASSERT (RegisterCpuFeatureLibIsFeatureValid(Feature)); while (Feature != CPU_FEATURE_END) { ASSERT ((Feature & (CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER)) != (CPU_FEATURE_BEFORE | CPU_FEATURE_AFTER)); Re

Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

> -Original Message- > From: Song, BinX > Sent: Monday, December 11, 2017 6:00 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: ler...@redhat.com; Dong, Eric <eric.d...@intel.com> > Subject: RE: [edk2] [PATCH] UefiCpuPkg: Check invalid

Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

On 12/11/2017 4:16 PM, Song, BinX wrote: Check and assert invalid RegisterCpuFeature function parameter Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song ---

Re: [edk2] [PATCH 0/3] Correct function description for ALLOCATE_BUFFER

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, December 11, 2017 2:54 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen@intel.com>; > Ni, Rui

Re: [edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Fix duplicate symbol

egister memory discovered callback function!\n")); CpuDeadLoop (); Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -- Thanks, Ray ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/KeyboardDxe: Use macro to enable/disable page 0

to just use a new macro ACCESS_PAGE0_CODE( ); to replace above methods to do the same job, which also makes code more readability. Cc: Liming Gao <liming@intel.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com>

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/LegacyBiosDxe: Use macro to enable/disable page 0

( ); to replace above methods to do the same job, which also makes code more readability. Cc: Liming Gao <liming@intel.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 S

Re: [edk2] [PATCH v2 1/3] IntelFrameworkPkg/LegacyBios.h: Add a macro to guarantee page 0 access

(similar to DEBUG_CODE macro): ACCESS_PAGE0_CODE( ); Cc: Liming Gao <liming@intel.com> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Ruiyu Ni <ruiyu...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jia

Re: [edk2] [PATCH v3 1/2] MdeModulePkg/DxeIpl: Mark page table as read-only

to specify the size and alignment for page table pool. For IA32 processor 0x20 (2MB) is the only choice for both of them to meet the requirement of page table pool. Cc: Jiewen Yao <jiewen@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc: Eric Dong <eric.d...@intel.com> Cc: Rui

Re: [edk2] [PATCH 2/3] IntelFrameworkModulePkg/LegacyBiosDxe: Use macro to enable/disable page 0

On 12/6/2017 3:31 PM, Jian J Wang wrote: Current implementation uses following two methods EnableNullDetection() DisableNullDetection() to enable/disable page 0. These two methods will check PCD PcdNullPointerDetectionPropertyMask to know if the page 0 is disabled or not. This is due

Re: [edk2] [PATCH 1/3] IntelFrameworkPkg/LegacyBios.h: Add a macro to guarantee page 0 access

On 12/6/2017 3:31 PM, Jian J Wang wrote: Due to the introduction of NULL pointer detection feature, page 0 will be disabled if the feature is enabled, which will cause legacy code failed to update legacy data in page 0. This macro is introduced to make sure the page 0 is enabled before those

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: introduce SD/MMC override protocol

tar -Original Message- From: Ni, Ruiyu Sent: Wednesday, December 6, 2017 11:22 AM To: Ard Biesheuvel <ard.biesheu...@linaro.org>; edk2-devel@lists.01.org Cc: leif.lindh...@linaro.org; Kinney, Michael D <michael.d.kin...@intel.com>; Zeng, Star <star.z...@intel.com>; Tian, Feng

Re: [edk2] [PATCH v3 2/2] MdeModulePkg/SdMmcPciHcDxe: allow HC capabilities to be overridden

Ard, I should have provided some of them in the last version. Sorry about that. We just found an internal/private SdMmcPciHc implementation developed by other teams. We are evaluating whether your proposed SdMmcOverride can be used to retire that private implementation. On 12/6/2017 2:01 AM,

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: introduce SD/MMC override protocol

On 12/6/2017 2:01 AM, Ard Biesheuvel wrote: Many ARM based SoCs have integrated SDHCI controllers, and often, these implementations deviate in subtle ways from the pertinent specifications. On the one hand, these deviations are quite easy to work around, but on the other hand, having a

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: introduce SD/MMC override protocol

On 12/5/2017 6:24 PM, Ard Biesheuvel wrote: On 5 December 2017 at 10:12, Ni, Ruiyu <ruiyu...@intel.com> wrote: Some comments re the detailed interfaces embedded in below. On 11/30/2017 6:11 PM, Ard Biesheuvel wrote: Many ARM based SoCs have integrated SDHCI controllers, and

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: introduce SD/MMC override protocol

Some comments re the detailed interfaces embedded in below. On 11/30/2017 6:11 PM, Ard Biesheuvel wrote: Many ARM based SoCs have integrated SDHCI controllers, and often, these implementations deviate in subtle ways from the pertinent specifications. On the one hand, these deviations are quite

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: introduce SD/MMC override protocol

On 12/5/2017 3:20 PM, Zeng, Star wrote: If making this protocol a platform level singleton instance, is it so hard to define the interfaces and parameters since different controllers may need different hook points and parameters? Thanks, Star -Original Message- From: Ni, Ruiyu Sent

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: introduce SD/MMC override protocol

On 11/30/2017 6:11 PM, Ard Biesheuvel wrote: Many ARM based SoCs have integrated SDHCI controllers, and often, these implementations deviate in subtle ways from the pertinent specifications. On the one hand, these deviations are quite easy to work around, but on the other hand, having a

Re: [edk2] [PATCH] ShellPkg/ShellPkg.dec: Change comments for PcdShellLibAutoInitialize

That's fine. Faster than me in the review response. > -Original Message- > From: Carsey, Jaben > Sent: Saturday, December 2, 2017 1:00 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [PATCH] ShellPkg/ShellPkg

Re: [edk2] [PATCH 2/2] QuarkPlatformPkg: Use DpDynamicCommand to replace PerformancePkg/dp

Kelly, I pushed the commit, following your below recommendation. > -Original Message- > From: Steele, Kelly > Sent: Saturday, December 2, 2017 1:18 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kin...@intel.com&

Re: [edk2] edk2 interface deprecation policy

I prefer to remove all deprecated items because I like clean:) But then lots of customer complains may come. So just provide my thoughts: Deprecated items can be separated into: 1. Definitions: E.g.: UgaDraw protocol, DriverConfiguration2 protocol Keep: But harm the newbie developers

Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp library removal

Ersek wrote: > >> Ray, > >> > >> On 11/29/17 11:14, Ruiyu Ni wrote: > >>> The TFTP command was converted from a NULL class library instance to > >>> a dynamic shell command in commit 0961002352e9. > >>> > >>> Contributed-

Re: [edk2] [PATCH v3 6/6] OvmfPkg: Add tftp dynamic command

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, November 29, 2017 6:54 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Anthony Perard <anthony.per...@citrix.com>; Justen, Jordan L > <jordan.l.

Re: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp library removal

ro.org] > Sent: Wednesday, November 29, 2017 5:59 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel@lists.01.org; Laszlo Ersek <ler...@redhat.com> > Subject: Re: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp > library removal > > On 29 N

Re: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp library removal

352e9. This patch complements commit f9bc2f876326, which only removed the old library, but didn't add the new dynamic command." Thanks/Ray > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, November 29, 2017 5:45 PM > To: Ni, Rui

Re: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp library removal

r...@redhat.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org> > Subject: [edk2] [PATCH v3 3/6] ArmVirtPkg: Fix build failure due to Tftp > library removal > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> >

Re: [edk2] [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp library removal

iesheu...@linaro.org] > Sent: Wednesday, November 29, 2017 3:57 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindh...@linaro.org> > Subject: Re: [PATCH v3 4/6] BeagleBoardPkg: Fix build failure due to Tftp > library removal > >

Re: [edk2] [PATCH] Add Ruiyu as MdeModulePkg reviewer

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 28, 2017 6:02 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> > Subjec

Re: [edk2] [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command

I just realized OVMF platform is referencing the INF. I will search in all edkII code. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Tuesday, November 28, 2017 3:35 PM > To: Ni, Ruiyu <

Re: [edk2] [PATCH 0/2] MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes

Ersek [mailto:ler...@redhat.com] > Sent: Monday, November 27, 2017 10:10 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel@lists.01.org; Paolo Bonzini <pbonz...@redhat.com>; Yao, > Jiewen <jiewen@intel.com>; Zeng, Star <star.z...@intel.com> >

Re: [edk2] [patch] PcAtChipsetPkg: Add description for new added PCD in commit e78aab9d2

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Tuesday, November 28, 2017 11:51 AM > To: edk2-devel@lists.01.org > Cc: Leo Duran <leo.du...@amd.com>; Ni, Ruiyu <ruiyu...@intel.com> > Subject: [pa

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

Maybe win10 does some optimization in S4 path. Sent from a small-screen device 在 2017年11月24日，上午8:01，Paolo Bonzini <pbonz...@redhat.com<mailto:pbonz...@redhat.com>> 写道： On 23/11/2017 14:08, Laszlo Ersek wrote: On 11/23/17 03:20, Ni, Ruiyu wrote: I cannot explain precisely why t

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

Sent from a small-screen device 在 2017年11月24日，上午1:19，Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>> 写道： On 11/23/17 15:58, Ni, Ruiyu wrote: Laszlo, A S3 flag PCD was added to optimize boot flow. Let's say, setting the flag to false is to remove some unnecessary c

Re: [edk2] [PATCH 3/5] MdeModulePkg/UefiBootManagerLib: report EDKII_OS_LOADER_DETAIL status code

Sent from a small-screen device 在 2017年11月24日，上午1:08，Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>> 写道： On 11/23/17 15:53, Ni, Ruiyu wrote: Comments below. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 23, 2017 10:

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

the PciBus change, Microsoft gave their Signed-off. /Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 23, 2017 9:08 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com>; edk2- > devel-01 <

Re: [edk2] [PATCH 3/5] MdeModulePkg/UefiBootManagerLib: report EDKII_OS_LOADER_DETAIL status code

age- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 23, 2017 7:59 AM > To: edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Ni, Ruiyu <ru

Re: [edk2] [PATCH 1/5] MdeModulePkg/BdsDxe: fall back to a Boot Manager Menu loop before hanging

Thanks for the patch. It follows the idea described in: https://lists.01.org/pipermail/edk2-devel/2017-April/010294.html. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, Novembe

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

I cannot explain precisely why the S4 resume fails. I can just guess: Windows might have some assumptions on the BM bit. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 22, 2017 6:26 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek

Re: [edk2] [PATCH] MdeModulePkg/AtaAtapiPassThru: disable only BM-DMA at ExitBootServices()

Laszlo, Our QA found Win10 S4 resume fails due to your change. As you might notice that I just rolled back the BM disabling patches in PciBus module, I am thinking about maybe you need to rollback the whole ExitBootServices callback as well to fix the compatibility issue. Thanks/Ray >

Re: [edk2] [patch] PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> > -Original Message- > From: Bi, Dandan > Sent: Wednesday, November 22, 2017 10:02 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [patch] PcAtChipsetPkg/IsaAcpiDxe: Fix

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, November 14, 2017 4:41 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com> > Subjec

Re: [edk2] [PATCH] ShellPkg/Shell: Check the OpenVolume result in OpenRootByHandle()

e MEDIA_CHANGED is not the only error that could happen. Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Tuesday, November 14, 2017 3:54 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni,

Re: [edk2] [PATCH 3/4] UefiCpuPkg/MtrrLib: Update algorithm to calculate optimal settings

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 9, 2017 9:16 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Justen, Jordan L > <jordan.l.jus...@intel.com>; Jeff Fan <vanjeff_...@hotmail.com> > Cc: Kinney, M

Re: [edk2] [PATCH 3/4] UefiCpuPkg/MtrrLib: Update algorithm to calculate optimal settings

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Thursday, November 9, 2017 2:56 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com> > Cc: Kinney, Michael D <michael.d.kin...@intel

Re: [edk2] [PATCH 3/4] UefiCpuPkg/MtrrLib: Update algorithm to calculate optimal settings

side, and then use MtrrGetAllMtrrs()/MtrrSetAllMtrrs() to sync the changes to all other Aps. Thanks/Ray > -Original Message- > From: Justen, Jordan L > Sent: Thursday, November 9, 2017 9:54 AM > To: Laszlo Ersek <ler...@redhat.com>; Ni, Ruiyu <ruiyu...@intel.

Re: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW

Thanks for the explanation. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Kinney, Michael D > Sent: Thursday, November 9, 2017 12:29 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org; Kinney, Michael > D

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

Yes. 2 seconds is for some other terminal tools, that cannot do the F10 translation. Thanks/Ray > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Wednesday, November 8, 2017 4:45 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

No. Even a terminal tool can recognize F10, it still needs to translate it into "ESC [ V" and send the three bytes to firmware. Thanks/Ray > -Original Message- > From: Heyi Guo [mailto:heyi@linaro.org] > Sent: Wednesday, November 8, 2017 4:31 PM > To: Ni, Rui

Re: [edk2] [MdeModulePkg/TerminalDxe] Why do we delay 2s for ESC being pressed?

inal). So a 2 second timeout is added to wait additional keys. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 8, 2017 3:25 PM > To: Heyi Guo <heyi@linaro.org>; edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; D

Re: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW

Mike, I am a bit confused about mapping 0x18 to upper arrow. I remembered that in old days, pressing ALT+18 in DOS window can generate upper arrow. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael D Kinney > Sent:

Re: [edk2] [PATCH 1/2] PcAtChipsetPkg: Define FixePCD's for RTC register values

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Leo Duran [mailto:leo.du...@amd.com] > Sent: Wednesday, November 1, 2017 1:55 AM > To: edk2-devel@lists.01.org > Cc: Leo Duran <leo.du...@amd.com>; Ni, Ruiyu <ruiyu...@in

Re: [edk2] [PATCH v2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Jian, Can you add more comments to explain why changing the capabilities of GCD entry? The background is clear by checking the Bugzilla. But it would be great to know the issue by just reading the code. Thanks/Ray > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] PcAtChipsetPkg/IsaAcpiDxe: Restore PCI attributes correctly

Laszlo, Sure I will add the Bugzilla url in the commit message. Steven, Could you please check whether this patch can fix your "reconnect -r" hang? Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, November 7, 2017 7:23

Re: [edk2] [PATCH v2 2/3] ShellPkg: Fix misuses of AllocateCopyPool

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Wang, Jian J > Sent: Tuesday, November 7, 2017 1:11 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>;

Re: [edk2] [PATCH v2] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

platform enables IOMMU before and needs disable IOMMU after > ExitBootService, the IOMMU should be disabled after PCI bus driver disables > BME. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Turner <michael.tur...@microsoft.com> > Sign

Re: [edk2] [PATCH 2/3] ShellPkg: Fix misuses of AllocateCopyPool

2 comments below. -Original Message- From: Wang, Jian J Sent: Friday, November 3, 2017 12:58 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Bi, Dandan <dandan...@intel.com> Subject: [PATCH 2/3] She

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Disable BME of all devices when entering RT

Jeff, Thanks you for your comments! How are you in Guiyang? Thanks/Ray From: Fan Jeff [mailto:vanjeff_...@hotmail.com] Sent: Wednesday, November 1, 2017 10:43 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Mi

Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: fix memory override bug

I will wait for Ard's feedback. It's an ARM specific module. Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Monday, October 30, 2017 6:07 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; Heyi Guo <heyi@linaro.org>; linaro- > u...@lists.linaro.org; e

Re: [edk2] [PATCH] ShellPkg: Fix type mismatch with GCC

gt; > Another way is to propose adding StrniCmp() API into BaseLib. > > Thanks > Liming > >-Original Message- > >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > >Alcantara, Paulo > >Sent: Saturday, October 28, 2017 2:51 AM > >To: Cars

Re: [edk2] [PATCH] IntelSiliconPkg/VTdDxe: Change EBS Event TPL to CALLBACK.

I also doubt such device driver exists. Thanks/Ray > -Original Message- > From: Yao, Jiewen > Sent: Friday, October 27, 2017 9:47 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com>; Zeng, > Star <star.z...@intel.com>; edk2-devel@

Re: [edk2] [PATCH] IntelSiliconPkg/VTdDxe: Change EBS Event TPL to CALLBACK.

intel.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: RE: [edk2] [PATCH] IntelSiliconPkg/VTdDxe: Change EBS Event TPL to CALLBACK. Good Info. I think a correct

Re: [edk2] [PATCH] ShellPkg/UefiShellDebug1CommandsLib: Remove EFIAPI from Compress()

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Thursday, October 26, 2017 2:53 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.c

Re: [edk2] [PATCH v3 5/6] UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection

> Sent: Thursday, October 26, 2017 2:20 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen@intel.com>; Dong, Eric <eric.d...@intel.com>; > Laszlo Ersek <ler...@redhat.com>; Ni, Ruiyu <ruiyu...@intel.com> > Subject: RE: [edk2] [PATCH v3 5/6] UefiCpuPkg/Pi

Re: [edk2] [Patch] UefiCpuPkg/CpuFeatures: Export HOB if CPU initialized in PEI.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Dong, Eric Sent: Wednesday, October 25, 2017 3:59 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu...@intel.com>; Laszlo Ersek <ler...@redhat.com> Subject: [Patch] UefiCpuPkg/CpuFeatures: Export HOB

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

Jeff, I see. Thanks for mentioning that Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Do you mind to also give a r-b? Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Fan Jeff > Sent: Tuesday, October 24, 201

Re: [edk2] [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP initialization logic.

--- > From: Dong, Eric > Sent: Monday, October 23, 2017 3:23 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [Patch 2/2] UefiCpuPkg/MpInitLib: Enhance waiting for AP > initialization logic. > > Current logic always waiting for a s

Re: [edk2] [Patch 1/2] UefiCpuPkg/MpInitLib: Change AP Index variable name.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Monday, October 23, 2017 3:23 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [Patch 1/2] UefiCpuPkg/MpInitLib:

Re: [edk2] [patch 4/4] UefiCpuPkg/MtrrLib: Make comments align with function

Dandan, Thanks for fixing that. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Bi, Dandan Sent: Friday, October 20, 2017 9:00 AM To: edk2-devel@lists.01.org Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [patch 4/4]

Re: [edk2] [Patch] UefiCpuPkg/MpInitLib: Avoid call PcdGe* in Ap & Bsp.

With the subject change suggested by Laszlo, Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, October 19, 2017 4:08 PM > To: Dong, Eric <eric.d...@intel.com>; edk2-dev

Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color

intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; edk2- > de...@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellLib: Use a more bright > blue/green color > > And we always turn off the multiple colors. Tim > > -

Re: [edk2] [PATCH] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported

Laszlo, I agree with your status mapping. It will make the implementation more clear and easier to maintain. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, October 18, 2017 8:12 PM > To: Julien

Re: [edk2] [Patch 1/4] MdePkg: Disable VS warning 4701 & 4703 for VS2017

Liming, How many build failures are there if 4701 and 4703 are enabled for VS2017? I am asking this because we sometimes met VS2008 build failures due to 4701 and 4703 are enabled for VS2008. But the two warnings are disabled for VS2013 and later. Can we have a consistent policy for the two

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Fix MtrrDebugPrintAllMtrrsWorker to avoid hang

the setting from HW/CPU, Convert that setting to range array. Then dump the range array. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, October 17, 2017 3:56 PM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.

Re: [edk2] [PATCH] UefiCpuPkg/MtrrLib: Fix MtrrDebugPrintAllMtrrsWorker to avoid hang

Thanks Steven. All, I will check in this patch ASAP. Because it's just a bug fix in a corner of implementation and it may cause all system hang. -Original Message- From: Shi, Steven Sent: Tuesday, October 17, 2017 10:04 AM To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.

Re: [edk2] [PATCH 0/4] Update MTRR algorithm to calculate optimal settings

age- > From: Yao, Jiewen > Sent: Monday, October 16, 2017 11:03 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH 0/4] Update MTRR algorithm to calculate optimal > settings > > Thanks. > > Would you mind to share to all of

Re: [edk2] [Patch] SourceLevelDebugPkg: Update SmmDebugAgentLib to restore APIC timer

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Gao, Liming > Sent: Tuesday, October 10, 2017 6:04 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com> > Subject: [Patch] SourceLevelDebugPkg: Update SmmD

Re: [edk2] [Patch v2 0/3] Add SmmEndOfS3Resume event.

Please don't forget to change the structure name as proposed by Jiewen. Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, October 11, 2017 1:32 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <

Re: [edk2] [Patch 2/3] UefiCpuPkg/S3Resume2Pei: Send S3 resume finished event to SmmCore.

name to X64_EFI_SMM_COMMUNICATE_HEADER or IA64_EFI_SMM_COMMUNICATE_HEADER. I am neutral using X64 or IA64, but don't want to have EFI_ in the beginning. Thanks/Ray > -Original Message- > From: Dong, Eric > Sent: Wednesday, October 11, 2017 10:23 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu &

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: don't ASSERT on 'BootNext' varname

; > Cc: Zeng, Star <star.z...@intel.com>; Ard Biesheuvel > <ard.biesheu...@linaro.org>; Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric > <eric.d...@intel.com>; edk2-devel@lists.01.org; leif.lindh...@linaro.org > Subject: Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLi

Re: [edk2] [PATCH v2] TFTP : tftp fix for full volume case

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Monday, October 9, 2017 10:13 PM > To: Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>; Fu, Siyuan > <siyuan...@intel.com>; edk2-devel@lists.01.org

Re: [edk2] [PATCH] MdeModulePkg/PciHostBridgeDxe: Fixed PCI DMA Map/Umap bounce buffer

The "read"/"write" is from the Bus Master's point of view. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil > Egranov > Sent: Monday, October 9, 2017 9:16 AM > To: edk2-devel@lists.01.org > Cc: leif.lindh...@linaro.org;

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add check to void use null pointer.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric > Dong > Sent: Monday, October 9, 2017 11:18 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@

Re: [edk2] [PATCH v3] Ifconfig : Fixed False information about Media State.

t;; edk2-devel@lists.01.org; Ni, Ruiyu > <ruiyu...@intel.com> > Subject: RE: [PATCH v3] Ifconfig : Fixed False information about Media State. > > I agree with Jaben. If NetLibDetectMedia return error status, we can output as > below: > > ShellPrintHiiEx (-1, -

Re: [edk2] [Patch V2] Build spec: add description for build with binary cache

If use both flags is same as --hash. Can we just get rid of --hash and just use the existing two flags? In this way, we can hide the internal implementation of how to check modification. Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH] MdeModulePkg/PciBus: Count multiple hotplug resource paddings

degraded to MEM32 resource. > > The patch treat the resource paddings using the same logic as treating > typical/actual resources and the total resource of a bridge is set to the MAX > of > typical/actual resources and resource paddings. > > Contributed-under: TianoCore Contribut

Re: [edk2] [Patch v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Combine INIT-SIPI-SIPI.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Dong, Eric Sent: Friday, September 29, 2017 8:27 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [Patch v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm:

Re: [edk2] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> -Original Message- From: Dong, Eric Sent: Friday, September 29, 2017 8:27 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: [Patch v2 2/2] UefiCpuPkg/PiSmmCpuD

Re: [edk2] [PATCH 1/2] ShellPkg/dh: Correct typo in help

Yes I think so. Thanks/Ray > -Original Message- > From: Carsey, Jaben > Sent: Friday, September 29, 2017 2:30 AM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Subject: RE: [PATCH 1/2] ShellPkg/dh: Correct typo in help > > Ray, > >

Re: [edk2] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Refine code to avoid duplicated code.

RegisterTableCount ); 2. How about change MPRendezvousProcedure to InitializeAp? Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 5:31 PM > To: Dong, Eric <eric.d...@intel.com>; edk2-devel@lists.01.org >

Re: [edk2] [PATCH v2] ShellPkg/dh: Add the 'dh' dump support for Partition Info protocol

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Thursday, September 28, 2017 4:33 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Carsey, > Jabe

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

sday, September 28, 2017 2:13 PM > To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: RE: [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until > boot

Re: [edk2] [PATCH] MdeModulePkg/BdsDxe: Don't delete "BootNext" until booting it

This could avoid the "BootNext" set by PlatformBootManagerLib be consumed in *this* boot. If I add "*" around "this", is it more clear? Thanks/Ray > -Original Message- > From: Zeng, Star > Sent: Thursday, September 28, 2017 2:00 PM > To: Ni, Ru

Re: [edk2] [patch] ShellPkg/Dh: Refine variable naming style

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray > -Original Message- > From: Bi, Dandan > Sent: Thursday, September 28, 2017 10:45 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> >

<    1   2   3   4   5   6   7   8   9   10   >