Re: [edk2] USB question: how change to a different alternate setting of an interface?

Hi Feng, I'm still working to get my environment setup so I can see the debug messages from the USB stack. In the meantime, I made a simple test driver that looks for a USB webcam streaming interface and tries to select the first alternate. The product I'm writing a driver for isn't a webcam but

[edk2] today's build failures

Here is a Windows batch file for automating edk2 builds using different tool chains and other options. It doesn't test every valid combination and project, but its test of 416 build combinations is more thorough than what developers are doing today. https://sourceforge.net/projects/edk2developerto

Re: [edk2] [PATCH] MdePkg: Refine the comments for FileHandleLib.

Reviewed-by: Liming Gao -Original Message- From: Qiu, Shumin Sent: Wednesday, June 17, 2015 11:26 AM To: edk2-devel@lists.sourceforge.net Cc: Gao, Liming Subject: [PATCH] MdePkg: Refine the comments for FileHandleLib. Make the function comments of FileHandleLib consistent with instance

[edk2] [PATCH] MdePkg: Refine the comments for FileHandleLib.

Make the function comments of FileHandleLib consistent with instance implementation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- MdePkg/Include/Library/FileHandleLib.h | 17 -- MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.c |

Re: [edk2] [Patch] BaseTools: Fixed Build Option override bugs.

Reviewed-by: Liming Gao -Original Message- From: Yingke Liu [mailto:yingke.d@intel.com] Sent: Tuesday, June 16, 2015 4:36 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] BaseTools: Fixed Build Option override bugs. if '==' is specified, it overrides all options that

Re: [edk2] [PATCH 2/2] MdeModulePkg AcpiTableDxe: Cover EFI_ACPI_TABLE_VERSION_5_0.

Looks good. Reviewed-by: Yao, Jiewen -Original Message- From: Zeng, Star Sent: Monday, June 15, 2015 9:55 PM To: edk2-devel@lists.sourceforge.net Cc: Yao, Jiewen Subject: [PATCH 2/2] MdeModulePkg AcpiTableDxe: Cover EFI_ACPI_TABLE_VERSION_5_0. Follow PI 1.4 spec, 1. Cover EFI_ACPI_TAB

Re: [edk2] [Patch] BaseTools: Fixed Build Option override bugs.

Yes, after this patch checked in, the bug you reported should be fixed. Thanks, Dennis -Original Message- From: Andrew Fish [mailto:af...@apple.com] Sent: Wednesday, June 17, 2015 0:11 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [Patch] BaseTools: Fixed Build Option overri

Re: [edk2] Proposal of Git Repo Layout for EDKII project

Hello all, There are a lot of conflicting ideas on how we should lay out our EDK2 repo using Git. We have Submodules, Subtrees, using soft links, etc. Some of the suggestions won't work for various reasons- ex. repo isn't supported on Windows, which is very common amongst EDK2 users. What are

Re: [edk2] [PATCH] BaseTools for AArch64 GCC: Ensure that the correlation .text and .data is consistent between ELF and PE-COFF so the debugger sees global variables correctly

On 16 June 2015 at 22:32, Cohen, Eugene wrote: >> OK. so does that mean we are using a builtin linker script for >> AArch64? That sounds fragile to me ... > > Apparently we are using the builtin script. I learned that this can be > queried with the -verbose switch for ld and have attached it. I

Re: [edk2] [PATCH] BaseTools for AArch64 GCC: Ensure that the correlation .text and .data is consistent between ELF and PE-COFF so the debugger sees global variables correctly

> OK. so does that mean we are using a builtin linker script for > AArch64? That sounds fragile to me ... Apparently we are using the builtin script. I learned that this can be queried with the -verbose switch for ld and have attached it. It includes this interesting alignment mechanism: /*

Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform

On 06/16/15 20:01, Olivier Martin wrote: > Sources for the E1000 EFI driver exists > The sources are for EDK1. They can be downloaded here: > http://tianocore.sourceforge.net/wiki/EDK > > I think I had ported this driver to EDK2 in the past for fun - I did > not have the opportunity to test i

Re: [edk2] Query UEFI : PCIE Driver for Armv8 platform

Sources for the E1000 EFI driver exists The sources are for EDK1. They can be downloaded here: http://tianocore.sourceforge.net/wiki/EDK I think I had ported this driver to EDK2 in the past for fun - I did not have the opportunity to test it. I do not remember to have any difficulties to por

Re: [edk2] Proposal of Git Repo Layout for EDKII project

On 16 June 2015 at 19:39, Olivier Martin wrote: > Most EDK2 users uses MS Windows host machine & GUI tool. I am not sure 'git > subtree' that is not part of the default git tool fits with the EDK2 > community requirements. > That may be true, but the suggestion is not for every user to use git

Re: [edk2] Proposal of Git Repo Layout for EDKII project

Most EDK2 users uses MS Windows host machine & GUI tool. I am not sure 'git subtree' that is not part of the default git tool fits with the EDK2 community requirements. Having a main/unique EDK2 repository is not incompatible with the inclusion of third-party/private components in your developm

[edk2] [PATCH 1/4] OvmfPkg: PlatformPei: enable larger permanent PEI RAM

We'll soon increase the maximum guest-physical RAM size supported by OVMF. For more RAM, the DXE IPL is going to build more page tables, and for that it's going to need a bigger chunk from the permanent PEI RAM. Otherwise CreateIdentityMappingPageTables() would fail with: > DXE IPL Entry > Loadin

[edk2] [PATCH 4/4] OvmfPkg: PlatformPei: invert MTRR setup in QemuInitializeRam()

At the moment we work with a UC default MTRR type, and set three memory ranges to WB: - [0, 640 KB), - [1 MB, LowerMemorySize), - [4 GB, 4 GB + UpperMemorySize). Unfortunately, coverage for the third range can fail with a high likelihood. If the alignment of the base (ie. 4 GB) and the alignment o

[edk2] [PATCH 0/4] OvmfPkg: enable >= 64 GB guests

No functional changes in v2. I just added Tested-by tags, improved the English grammar in a comment in patch #1, and dropped the BUG language in the commit message of patch #4 (because that issue was caused by the EPT setup / phys-address-width of my laptop). Public branch:

[edk2] [PATCH 2/4] OvmfPkg: PlatformPei: create the CPU HOB with dynamic memory space width

Maoming reported that guest memory sizes equal to or larger than 64GB were not correctly handled by OVMF. Enabling the DEBUG_GCD (0x0010) bit in PcdDebugPrintErrorLevel, and starting QEMU with 64GB guest RAM size, I found the following error in the OVMF debug log: > GCD:AddMemorySpace(Base=00

[edk2] [PATCH 3/4] OvmfPkg: PlatformPei: beautify memory HOB order in QemuInitializeRam()

Build the memory HOBs in a tight block, in increasing base address order. Cc: Maoming Cc: Huangpeng (Peter) Cc: Wei Liu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek Tested-by: Maoming --- OvmfPkg/PlatformPei/MemDetect.c | 9 - 1 file changed, 4

Re: [edk2] [Patch] BaseTools: Fixed Build Option override bugs.

> On Jun 16, 2015, at 1:35 AM, Yingke Liu wrote: > > if '==' is specified, it overrides all options that specified by '='; if no > '==' is specified, all options that match current build criteria are combined. > Does this fix the bug I reported with an ‘=‘ getting lost if two of the same for

Re: [edk2] Build Tool Changes

Liming - We also edit the binary images, and we don't use a separate binary. We simply emitted a signature ahead of the generated C array. The main point is: continuing to add build tool changes without having public review before the commit causes other users of EDK2 (who may also have their

Re: [edk2] some queries in "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" implementation

Thanks Olivier! Is there some PCI NIC card or E1000 driver (PCI device driver) written on top of PCI bus driver for ARM architecture, any references? One is Intel's e1000 driver, which is proprietary and is requested by the -D E1000_ENABLE build flag( I have seen this in commit Logs) I h

Re: [edk2] [PATCH] BaseTools for AArch64 GCC: Ensure that the correlation .text and .data is consistent between ELF and PE-COFF so the debugger sees global variables correctly

On 16 June 2015 at 16:50, Cohen, Eugene wrote: >> Could you please send patches inline? Attachments are a pain to review. > > Sure, I will do that. Because I use Outlook I prefer the attachment since I > can pull it into a nice patch viewer. > I can see how that would be preferred for just view

Re: [edk2] [PATCH] CryptoPkg: add .gitignore for OpenSSL source files

On 16 June 2015 at 16:48, Long, Qin wrote: > This looks good. > > Reviewed-by: Qin Long > Committed as r17647 Thanks, Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, June 16, 2015 8:58 PM > To: edk2-devel@lists.sourceforge.net; Lon

Re: [edk2] [PATCH] CryptoPkg: add .gitignore for OpenSSL source files

On 16 June 2015 at 17:00, Laszlo Ersek wrote: > On 06/16/15 14:57, Ard Biesheuvel wrote: >> Add a .gitignore that masks the OpenSSL header files under >> Include/openssl and the OpenSSL source files under >> Library/OpensslLib/openssl-*. This prevents Git from considering >> any of these files for

Re: [edk2] [PATCH] CryptoPkg: add .gitignore for OpenSSL source files

On 06/16/15 14:57, Ard Biesheuvel wrote: > Add a .gitignore that masks the OpenSSL header files under > Include/openssl and the OpenSSL source files under > Library/OpensslLib/openssl-*. This prevents Git from considering > any of these files for addition, and prevents other clutter in > the git st

Re: [edk2] 答复: 答复: [RFC 4/4] OvmfPkg: PlatformPei: invert MTRR setup in QemuInitializeRam()

On 06/16/15 14:54, Maoming wrote: > > > -邮件原件- > 发件人: Laszlo Ersek [mailto:ler...@redhat.com] > 发送时间: 2015年6月15日 22:08 > 收件人: Maoming > 抄送: edk2-devel@lists.sourceforge.net; Huangpeng (Peter); Wei Liu; Paolo > Bonzini > 主题: Re: 答复: [edk2] [RFC 4/4] OvmfPkg: PlatformPei: invert MTRR setu

Re: [edk2] [PATCH] BaseTools for AArch64 GCC: Ensure that the correlation .text and .data is consistent between ELF and PE-COFF so the debugger sees global variables correctly

> Could you please send patches inline? Attachments are a pain to review. Sure, I will do that. Because I use Outlook I prefer the attachment since I can pull it into a nice patch viewer. > Applying your patch and doing 'git show --find-copies-harder' gives me > (tools_def.tempate omitted): U

Re: [edk2] [PATCH] CryptoPkg: add .gitignore for OpenSSL source files

This looks good. Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, June 16, 2015 8:58 PM To: edk2-devel@lists.sourceforge.net; Long, Qin Cc: ler...@redhat.com; Ard Biesheuvel Subject: [PATC

Re: [edk2] [PATCH] ArmVirtPkg: increase memory preallocations for secure build

On 16 June 2015 at 16:23, Laszlo Ersek wrote: > On 06/16/15 11:44, Ard Biesheuvel wrote: >> This is a followup to r17554 ("ArmVirtPkg: increase memory >> preallocations to reduce region count") that increases the sizes >> of the preallocated regions to account for the footprint of the >> crypto an

Re: [edk2] [PATCH] ArmVirtPkg: increase memory preallocations for secure build

On 06/16/15 11:44, Ard Biesheuvel wrote: > This is a followup to r17554 ("ArmVirtPkg: increase memory > preallocations to reduce region count") that increases the sizes > of the preallocated regions to account for the footprint of the > crypto and authentication libraries. This is only done if secu

Re: [edk2] [Patch] PcAtChipsetPkg/PcRtc: Fix a Y2K bug

On 06/16/15 04:35, Feng, Bob C wrote: > Hello Laszlo and Ray, > > I created a patch to fix the build crash. When the build tool find > there is incorrect syntax in @expression, @ValidList and @ValidRange > in DEC file, the build tool will break and report an error message. > Please review. Looks

Re: [edk2] some queries in "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" implementation

From: Leekha Shaveta [mailto:shav...@freescale.com] Sent: 16 June 2015 12:59 To: edk2-devel@lists.sourceforge.net; Olivier Martin Cc: Deepak Chauhan; Konda Ravi Subject: RE: [edk2] some queries in "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" implementation Thanks Olivier! Please find my doubts and replie

[edk2] [PATCH 0/2] Enhance the comments for MemoryAllocationLib of SMM instance

Per PI spec all allocation of SMRAM should use EfiRuntimeServicesCode or EfiRuntimeServicesData. So SMM instance use EfiRuntimeServicesCode as the default memory allocation type instead of EfiBootServicesData. This patch clarify this usage in comments. Qiu Shumin (2): MdePkg: Enhance the comm

[edk2] [PATCH 1/2] MdePkg: Enhance the comments for SmmMemoryAllocationLib instance.

Per PI spec all allocation of SMRAM should use EfiRuntimeServicesCode or EfiRuntimeServicesData. So SMM instance use EfiRuntimeServicesCode as the default memory allocation type instead of EfiBootServicesData. This patch clarify this usage in comments. Signed-off-by: Qiu Shumin --- .../SmmMem

[edk2] [PATCH 2/2] MdeModulePkg: Enhance the comments for PiSmmCoreMemoryAllocationLib instance.

Per PI spec all allocation of SMRAM should use EfiRuntimeServicesCode or EfiRuntimeServicesData. So SMM instance use EfiRuntimeServicesCode as the default memory allocation type instead of EfiBootServicesData. This patch clarify this usage in comments. Signed-off-by: Qiu Shumin --- .../Memory

[edk2] [PATCH] CryptoPkg: add .gitignore for OpenSSL source files

Add a .gitignore that masks the OpenSSL header files under Include/openssl and the OpenSSL source files under Library/OpensslLib/openssl-*. This prevents Git from considering any of these files for addition, and prevents other clutter in the git status output. Contributed-under: TianoCore Contribu

[edk2] 答复: 答复: [RFC 4/4] OvmfPkg: PlatformPei: invert MTRR setup in QemuInitializeRam()

-邮件原件- 发件人: Laszlo Ersek [mailto:ler...@redhat.com] 发送时间: 2015年6月15日 22:08 收件人: Maoming 抄送: edk2-devel@lists.sourceforge.net; Huangpeng (Peter); Wei Liu; Paolo Bonzini 主题: Re: 答复: [edk2] [RFC 4/4] OvmfPkg: PlatformPei: invert MTRR setup in QemuInitializeRam() On 06/15/15 15:25, Maoming

Re: [edk2] some queries in "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" implementation

Thanks Olivier! Please find my doubts and replies in-lined. Thanks and Regards, Shaveta From: Olivier Martin [mailto:olivier.mar...@arm.com] Sent: Tuesday, June 16, 2015 4:53 PM To: edk2-devel@lists.sourceforge.net Cc: Chauhan Deepak-B10991; Theja Ravi-B11286 Subject: Re: [edk2] some queries in

Re: [edk2] [PATCH] BaseTools for AArch64 GCC: Ensure that the correlation .text and .data is consistent between ELF and PE-COFF so the debugger sees global variables correctly

On 4 June 2015 at 21:48, Cohen, Eugene wrote: > Oops, left off the contribution agreement line, trying again > > Dear ArmPkg maintainers (and later BaseTools maintainer), > > This is a fix for debugger correlation of global variables for AArch64 built > on GCC. > > Before this change looking at g

Re: [edk2] some queries in "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" implementation

PCI bus contains three type of memory: - PCI Configuration Space - PCI I/O Space - PCI Memory Space RootBridgeIoMemWrite () writes to 'PCI Memory Space'. I would say the description matches your interpretation if you assume 'PCI controller' is the same as what you na

Re: [edk2] Filesystem support

UEFI specification says 'HD(Partition,Type,Signature,Start, Size)'. These values are specific to you partition table. gArmPlatformTokenSpaceGuid.PcdDefaultBootDevicePath is specific to the ARM BDS. It is to create a default boot entry when you start your system for a first time. It is not (neces

Re: [edk2] [PATCH] ArmVirtPkg: increase memory preallocations for secure build

Reviewed-By: Olivier Martin -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 16 June 2015 10:44 To: edk2-devel@lists.sourceforge.net; ler...@redhat.com Cc: Olivier Martin; roy.fr...@linaro.org; Ard Biesheuvel Subject: [PATCH] ArmVirtPkg: increase memory pre

[edk2] some queries in "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" implementation

Hi, I was implementing "EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL" protocol for PCI 3.0 controlller, I have few more basic queries like: (1)In function: EFI_STATUS EFIAPI RootBridgeIoMemWrite ( IN EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL*This, IN EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_WI

Re: [edk2] [Patch] BaseTools: Supported FMP capsule image.

Hi, all This BaseTool feature is to help generate UEFI FMP format capsule image. It reuses Capsule section and bases on specific capsule GUID to know this is FMP capsule image. The following is sample in FDF file for FMP capsule. It will be documented in FDF spec. If you have any comments for

Re: [edk2] Build Tool Changes

Tim: I agree that HII resource section for the same purpose. But now, most HII drivers still uses EDKII implement way to access VFR and UNI in source code. To support this usage model in the binary image, BaseTools will generate a binary file to record each offset for VFR and UNI packages in E

Re: [edk2] FV FvName in FV Ext Entry

Tim: Agree. I will wait for more feedback, then consider them more for it. I know your comment is to introduce new flag to turn on/off it, not add it in FvNameGuid feature. Right? Thanks Liming From: Tim Lewis [mailto:tim.le...@insyde.com] Sent: Tuesday, June 16, 2015 2:34 AM To: edk2-devel@li

[edk2] [PATCH] ArmVirtPkg: increase memory preallocations for secure build

This is a followup to r17554 ("ArmVirtPkg: increase memory preallocations to reduce region count") that increases the sizes of the preallocated regions to account for the footprint of the crypto and authentication libraries. This is only done if secure boot is enabled at build time, to prevent impo

[edk2] Filesystem support

Hi All, I want to boot linux and run SCT from SD card. I have seen BeagleBoard package code which is booting linux from SD. I got confused with entry: gArmPlatformTokenSpaceGuid.PcdDefaultBootDevicePath|L"VenHw(B615F1F5-5088-43CD-809C-A16E52487D00)/HD(1,MBR,0x,0x3F,0x19FC0)/zImage" fro

[edk2] [Patch] BaseTools: Fixed Build Option override bugs.

if '==' is specified, it overrides all options that specified by '='; if no '==' is specified, all options that match current build criteria are combined. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 2

Re: [edk2] [Patch]Vlv2TbltDevicePkg:Remove duplicate PR0 Lock down

It looks good. Best Regards, Tim From: Lu, ShifeiX A Sent: Tuesday, June 16, 2015 3:13 PM To: 'edk2-devel@lists.sourceforge.net' Cc: Wei, David; He, Tim; Wu, Mike Subject: [edk2][Patch]Vlv2TbltDevicePkg:Remove duplicate PR0 Lock down Remove duplicate PR0 Lock down. Contributed-under: TianoCor

[edk2] [Patch]Vlv2TbltDevicePkg:Remove duplicate PR0 Lock down

Remove duplicate PR0 Lock down. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lu, ShifeiX A mailto:shifeix.a...@intel.com>> Thanks, Shifei SPIRwPRx.patch Description: SPIRwPRx.patch

Re: [edk2] SCT build error

Thank you all for help :) I changed "C:\Program Files (x86)\Microsoft Visual Studio 12.0\Vc\bin\nmake.exe" to "C:\Program Files\Microsoft Visual Studio 12.0\Vc\bin\nmake.exe" And compilation proceeds further, still facing some issue. Working on that. Thanks Meenakshi From: Olivier Martin [ma