Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

On 07/09/15 08:45, Paolo Bonzini wrote: > > > On 08/07/2015 23:03, Laszlo Ersek wrote: >> On 07/08/15 22:36, Ryan Harkin wrote: >> >>> I have an alias in my ~/.gitconfig file: >>> >>> [alias] >>> amm=am --ignore-whitespace --ignore-space-change >>> >>> >>> Then I use "git amm" to apply patche

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

On 08/07/2015 23:03, Laszlo Ersek wrote: > On 07/08/15 22:36, Ryan Harkin wrote: > >> I have an alias in my ~/.gitconfig file: >> >> [alias] >> amm=am --ignore-whitespace --ignore-space-change >> >> >> Then I use "git amm" to apply patches and that seems to work most of the >> time. >> >> Bu

Re: [edk2] edk2 build problems

The UEFI shell is an application that can be run in a UEFI environment (either on real or emulated hardware) similar to how the Windows command prompt runs in the Windows OS. So first you need to have a UEFI environment. There are many options here. There is a UEFI environment on your computer befo

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

On 07/08/15 21:02, Roy Franz wrote: > This patchset adds a new terminal type "TtyTerm", that better handles the > typical Linux terminal (xterm/rxvt/gnome terminal/tmux/screen/etc.) These > often > treat backspace/delete differently than the existing EDK2 terminal types > expect, particularly in e

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

Many thanks, Laszlo. It's nice to see your help when I am managing to merge Roy's git tree to my local :-). Please do it. Thanks Feng -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, July 09, 2015 13:10 To: Tian, Feng; Roy Franz Cc: edk2-devel@lists.sour

Re: [edk2] [patch] MdePkg/UefiDevicePathLib:Fix link error due to missing RamDisk GUIDs

Reviewed-by: Qiu Shumin -Original Message- From: Tian, Feng Sent: Thursday, July 09, 2015 11:39 AM To: Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net; Tian, Feng Subject: [patch] MdePkg/UefiDevicePathLib:Fix link error due to missing RamDisk GUIDs UefiDevicePathLibOptionalDevicePathP

[edk2] [PATCH] SecurityPkg: Make time based AuthVariable update atomic

System may break during time based AuthVariable update, causing certdb inconsistent. 2 ways are used to ensure update atomic. 1. Delete cert in certdb after variable is deleted 2. Clean up certdb on variable initialization Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cha

Re: [edk2] edk2 build problems

> On Jul 8, 2015, at 10:25 PM, Tony wrote: > > I am very new to uefi dev and trying to understand how the environment needs > to be setup to bring up the uefi shell. > > My current environment is: > win 7 pro 64bit > vs studio express 2013 for desktop > edk2 > > The edk2 binaries are in the f

Re: [edk2] edk2 build problems

​If you want to build Shell, please update your target_conf as ACTIVE_PLATFORM = ShellPkg\ShellPkg.dsc On Wed, Jul 8, 2015 at 10:25 PM, Tony wrote: > I am very new to uefi dev and trying to understand how the environment > needs to be setup to bring up the uefi shell. > > My current e

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/09/15 04:31, Scott Duplichan wrote: > Bruce Cran [mailto:br...@cran.org.uk] wrote: > > ]Sent: Wednesday, July 08, 2015 05:12 PM > ]To: edk2-devel@lists.sourceforge.net > ]Subject: Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables > ] > ]On Wed, Jul 08, 2015 at 10:43:38PM +0200

[edk2] edk2 build problems

I am very new to uefi dev and trying to understand how the environment needs to be setup to bring up the uefi shell. My current environment is:win 7 pro 64bitvs studio express 2013 for desktopedk2 The edk2 binaries are in the f:\ folder. I have modified target_arch & toolchain to reflect my build

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

Feng, On 07/09/15 02:39, Tian, Feng wrote: > Ok, I will do it. I just checked the SVN repo and I can't see the patches yet. So please allow me to commit these patches instead -- I'm not sure if you are a regular git user otherwise, but in any case, given the extra processing needed for patches sn

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/09/15 01:42, Jordan Justen wrote: > On 2015-07-08 08:58:04, Laszlo Ersek wrote: >> On 07/08/15 17:02, Ard Biesheuvel wrote: >>> On 8 July 2015 at 16:59, Olivier Martin wrote: For ARM architectures, I only disable this flag for RELEASE build: >>> >>> OK, I hadn't noticed that. This means

[edk2] [Patch] SourceLevelDebugPkg/SecPeiDebugAgentLib: Restore CPU interrupt state

In DEBUG_AGENT_INIT_POSTMEM_SEC case, caller may disable/restore CPU interrupt to protect the stack/heap migration. SecPeiDebugAgentLib cannot always enable CPU interrupt. Otherwise system may crash during stack/heap migration. SecPeiDebugAgentLib should restore original CPU interrupt state in DEBU

[edk2] [patch] MdePkg/UefiDevicePathLib:Fix link error due to missing RamDisk GUIDs

UefiDevicePathLibOptionalDevicePathProtocol.inf needs to be updated to add RamDisk related GUIDs for passing compiler build. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- .../UefiDevicePathLibOptionalDevicePathProtocol.inf | 8 1 file

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

Bruce Cran [mailto:br...@cran.org.uk] wrote: ]Sent: Wednesday, July 08, 2015 05:12 PM ]To: edk2-devel@lists.sourceforge.net ]Subject: Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables ] ]On Wed, Jul 08, 2015 at 10:43:38PM +0200, Laszlo Ersek wrote: ] ]> I think it would make a diffe

Re: [edk2] [PATCH] SourceLevelDebugPkg: Fix PEI timer interrupt regression

Hi, Brian Yes. This is one regression. Thanks your fix. Reviewed-by: Jeff Fan There is another issue on enable CPU interrupt in DEBUG_AGENT_INIT_POSTMEM_SEC case. I will fix it soon. Thanks! Jeff -Original Message- From: Brian J. Johnson [mailto:bjohn...@sgi.com] Sent: Thursday, Ju

Re: [edk2] [PATCH v2] IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint

Hi, There are two options: 1. If the reviewers agree to keep using AllocateZeroPool() here, I can modify the patch to keep align with MdePkg. 2. If they prefer to use AllocatePool() here, then I think codes in MdePkg shall be updated. Best Regards, Hao Wu > -Original Message- > From: He

Re: [edk2] [patch] MdemodulePkg: fix the problem that data type conversion may loss data

Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Wednesday, July 08, 2015 5:30 PM To: edk2-devel@lists.sourceforge.net; Ye, Ting; Fu, Siyuan; Hai, Yue A Subject: [patch] MdemodulePkg: fix the problem that data type conversion may loss data Contributed-under: TianoCore C

Re: [edk2] [PATCH v2] IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint

Hi Hao, Shall we also change code in MdePkg for the same function to keep code style consistent? Thanks. On 07/09/2015 08:53 AM, Hao Wu wrote: > This commit will resolve issue brought by r17740. > > BufferToReturn = AllocateCopyPool(SizeRequired, String); > > The above using of AllocateCopyPool

Re: [edk2] [PATCH] OvmfPkg: Fix the build.sh shebang line to avoid depending on location of bash

The commit was synced to UDK2014.SP1 branch @ r17892. Best Regards, Hao Wu > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Thursday, July 09, 2015 4:14 AM > To: Bruce Cran; Tian, Hot; Gao, Liming > Cc: edk2-devel@lists.sourceforge.net > Subject: Re: [

[edk2] How can I get an efi version of acpidump ?

This website has acpidump tools, which I built for Linux. Supposedly efi supportis built-in. But I don't know how to get an efi version of acpidump. Does anyone know how ? Version 20130626 | The ACPI Component Architecture Project |   | |   |   |   |   |   | | Version 20130626 | The ACPI Compone

[edk2] [PATCH v2] IntelFrameworkPkg FrameworkUefiLib: Fix ASSERT in CatVSPrint

This commit will resolve issue brought by r17740. BufferToReturn = AllocateCopyPool(SizeRequired, String); The above using of AllocateCopyPool() will cause ASSERT if 'String' is NULL. Therefore, proper check for 'String' is needed. The above using of AllocateCopyPool() will read contents out of

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

Ok, I will do it. -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Thursday, July 9, 2015 8:38 AM To: Tian, Feng Cc: edk2-devel@lists.sourceforge.net; ler...@redhat.com; ard.biesheu...@linaro.org; heyi@linaro.org Subject: Re: [PATCH V4 0/5] Add TtyTerm terminal

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

On Wed, Jul 8, 2015 at 5:25 PM, Tian, Feng wrote: > Roy, > > For patch 1, 2, 3, I would sign Reviewed-by: Feng Tian > > Thanks for your contribution. Please go ahead to check them in. > I'm not a committer, so I'll need someone to commit this for me. Thanks, Roy > -Original Message- > F

Re: [edk2] [PATCH V4 0/5] Add TtyTerm terminal type

Roy, For patch 1, 2, 3, I would sign Reviewed-by: Feng Tian Thanks for your contribution. Please go ahead to check them in. -Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Thursday, July 9, 2015 3:03 AM To: edk2-devel@lists.sourceforge.net; Tian, Feng; ler...@red

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 2015-07-08 08:58:04, Laszlo Ersek wrote: > On 07/08/15 17:02, Ard Biesheuvel wrote: > > On 8 July 2015 at 16:59, Olivier Martin wrote: > >> For ARM architectures, I only disable this flag for RELEASE build: > > > > OK, I hadn't noticed that. This means my patch would be only for the > > conven

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On Wed, Jul 08, 2015 at 03:50:11PM -0700, Bill Paul wrote: > I did not do anything with the IPF platform rules. You can't build OVMF for > the Itanium architecture anyway. I tend to modify the "Option 5" rules in > tools_def.txt to specify my custom path to the cross-compiler toolchain. It's ma

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

Of all the gin joints in all the towns in all the world, Bruce Cran had to walk into mine at 14:43:23 on Wednesday 08 July 2015 and say: > On Wed, Jul 08, 2015 at 11:15:44AM -0700, Bill Paul wrote: > > Lastly, yesterday I actually spent some time updating the > > mingw-gcc-build.py to support bin

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On Wed, Jul 08, 2015 at 10:43:38PM +0200, Laszlo Ersek wrote: > I think it would make a difference if -flto *actually* worked, but from > a quick google search, I think it either doesn't work with gcc-4.8 at > all, *or* the edk2 build system would have to use FLTO-aware binutils > and linker wrapp

Re: [edk2] [PATCH 1/2] SecurityPkg: Refine the function comments.

Regarding the commit message, how about: === SecurityPkg/Pkcs7VerifyDxe: Cleanup P7CheckTrust function comments The comments for P7CheckTrust described Content and ContentSize parameters, but they don't exist. === With the updated commit message: Reviewed-by: Jordan Justen On 2015-07-07 01:

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On Wed, Jul 08, 2015 at 11:15:44AM -0700, Bill Paul wrote: > Lastly, yesterday I actually spent some time updating the mingw-gcc-build.py > to support binutils 2.25 and GCC 4.9.3, and I ran into this exact issue. I also spent a few minutes updating it today (to binutils 2.25 and gcc 5.1, though

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

> On Jul 8, 2015, at 2:21 PM, Laszlo Ersek wrote: > >>> >>> I wonder why MDEPKG_NDEBUG was then added for MSFT in the first place >>> (assuming MSVC had always been able to remove dead code), >> >> It might make MSVC catch the same errors as GCC? Not sure about that? >> >> I wonder is some h

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/08/15 22:53, Andrew Fish wrote: > >> On Jul 8, 2015, at 1:43 PM, Laszlo Ersek > > wrote: >> >>> https://svn.code.sf.net/p/edk2/code/trunk/edk2/MdePkg/Include/Library/DebugLib.h >>> >>> #if !defined(MDEPKG_NDEBUG) >>> #define ASSERT(Expression)\ >>>

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

On 07/08/15 22:36, Ryan Harkin wrote: > I have an alias in my ~/.gitconfig file: > > [alias] > amm=am --ignore-whitespace --ignore-space-change > > > Then I use "git amm" to apply patches and that seems to work most of the > time. > > But I suspect your method is doing something smarter an

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

> On Jul 8, 2015, at 1:43 PM, Laszlo Ersek wrote: > >> https://svn.code.sf.net/p/edk2/code/trunk/edk2/MdePkg/Include/Library/DebugLib.h >> >> >> >> #if !defined(MDEPKG_NDEBUG) >> #define ASSERT(Expressi

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/08/15 21:26, Andrew Fish wrote: > >> On Jul 8, 2015, at 12:02 PM, Laszlo Ersek > > wrote: >> >>> >>> It should be noted that once in a while I run into this sort of thing in >>> VxWorks as well, only it's often the other way around. We typically have >>> DEBUG()-s

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

Hi Laszlo, On 8 July 2015 at 10:46, Laszlo Ersek wrote: > On 07/08/15 04:46, Heyi Guo wrote: > > Hi Roy, > > > > I have one question; please see my comments below. > > Indeed: > > > > > On 07/08/2015 08:44 AM, Roy Franz wrote: > >> From: Laszlo Ersek > >> > >> Add a fixed pointer PCD to allow b

Re: [edk2] [PATCH] OvmfPkg: Fix the build.sh shebang line to avoid depending on location of bash

On 2015-07-08 00:09:40, Bruce Cran wrote: > On Tue, Jul 07, 2015 at 09:32:39PM -0700, Jordan Justen wrote: > > Reviewed-by: Jordan Justen > > Could it be committed to the UDK2014.SP1 branch as well as master, please? Bruce, I'm not sure of the update process for that branch, but it sure seems l

[edk2] [PATCH] SourceLevelDebugPkg: Fix PEI timer interrupt regression

Recent changes to debug timer initialization (commit 2befbc82, svn 17572) modified the Sec/Pei InitializeDebugAgent() routine to enable debug timer interrupts. This causes problems in the DEBUG_AGENT_INIT_POSTMEM_SEC case: the callers appear to assume that if they block timer interrupts before th

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

> On Jul 8, 2015, at 12:02 PM, Laszlo Ersek wrote: > >> >> It should be noted that once in a while I run into this sort of thing in >> VxWorks as well, only it's often the other way around. We typically have >> DEBUG()-style messages turned off by default, and sometimes there are debug >> me

Re: [edk2] [PATCH V4 5/5] add TTY_TERMINAL build option for ARM BDS

On 07/08/15 21:02, Roy Franz wrote: > Enable selecting the TtyTerminal type for the ARM BDS build of QEMU using > the TTY_TERMINAL define. > Convert INTEL_BDS define to check for value (!if) rather than just definition > (!ifdef) to allow setting of either value on command line. > > Contributed-un

[edk2] [PATCH V4 3/5] Accept VT220 DEL and function keys for TTY terminal type

Accept the VT220 escape code [3~ as backspace for TtyTerm terminals. This is sent by many Linux terminals by default. Also accept VT220 function keys F1-F12, and VT100 F1-F4 keys as these are commonly sent by Linux terminals. The VT220 escape codes are longer, and variable length so a new state i

[edk2] [PATCH V4 2/5] Treat ASCII 0x7F as backspace for TtyTerm terminals

Treat ASCII 0x7F as backspace, rather than delete, for TTY terminals. This better matches the default Linux terminal settings that are used when connecting to a simulated platform using xterm or a similar terminal program. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Roy

[edk2] [PATCH V4 5/5] add TTY_TERMINAL build option for ARM BDS

Enable selecting the TtyTerminal type for the ARM BDS build of QEMU using the TTY_TERMINAL define. Convert INTEL_BDS define to check for value (!if) rather than just definition (!ifdef) to allow setting of either value on command line. Contributed-under: TianoCore Contribution Agreement 1.0 Signed

[edk2] [PATCH V4 4/5] Add PCD for selecting terminal type at build time

From: Laszlo Ersek Add a fixed pointer PCD to allow build-time selection of VT100 or TTY terminal type. The default remains VT100 emulation. Add support for building the ARM QEMU platforms with the TTY terminal with the "-D TTY_TERMINAL" build option. Contributed-under: TianoCore Contribution A

[edk2] [PATCH V4 0/5] Add TtyTerm terminal type

This patchset adds a new terminal type "TtyTerm", that better handles the typical Linux terminal (xterm/rxvt/gnome terminal/tmux/screen/etc.) These often treat backspace/delete differently than the existing EDK2 terminal types expect, particularly in emulated environments where the emulated serial

[edk2] [PATCH V4 1/5] Add "TtyTerm" terminal type to TerminalDxe

This patch a adds new terminal type, TtyTerm, to TerminalDxe. This terminal type provides a place to add support for various *nix terminals that don't behave like standard VT terminals. The goal is to 'just work' with as many terminals as possible, rather than properly emulating any one specific

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/08/15 20:15, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Laszlo Ersek had to > walk into mine at 09:17:08 on Wednesday 08 July 2015 and say: >> In the above pattern, ASSERT_EFI_ERROR() is not necessarily used for >> error handling. > > You are absolutely rig

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

On Wed, Jul 8, 2015 at 2:46 AM, Laszlo Ersek wrote: > On 07/08/15 04:46, Heyi Guo wrote: >> Hi Roy, >> >> I have one question; please see my comments below. > > Indeed: > >> >> On 07/08/2015 08:44 AM, Roy Franz wrote: >>> From: Laszlo Ersek >>> >>> Add a fixed pointer PCD to allow build-time sele

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

> On Jul 8, 2015, at 11:18 AM, Ard Biesheuvel wrote: > > Indeed. But unlike ELF, PE/COFF does not allow the header to overlap > with the .text section, so using 4 KB alignment for a XIP modules > .text section always wastes 3.5 KB in the FV. > > Olivier's patch allows code to be generated that

Re: [edk2] 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file names' breaks the build

On 8 July 2015 at 17:53, Olivier Martin wrote: > That's a fair comment. I will revert the patch. Sorry for the inconvenience. > OK, thanks. -- Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: 07 July 2015 22:08 > To: edk2-devel@lists.sourcefo

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

Of all the gin joints in all the towns in all the world, Laszlo Ersek had to walk into mine at 09:17:08 on Wednesday 08 July 2015 and say: > On 07/08/15 17:28, Scott Duplichan wrote: > > Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: > > > > ]Sent: Wednesday, July 08, 2015 08:24 AM > >

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

On 8 July 2015 at 20:01, Andrew Fish wrote: > > On Jul 8, 2015, at 10:49 AM, Ard Biesheuvel > wrote: > > On 8 July 2015 at 16:57, Olivier Martin wrote: > > When EDK2 is built for the small memory model with AArch64 LLVM, > some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its > R_AA

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

> On Jul 8, 2015, at 10:49 AM, Ard Biesheuvel wrote: > > On 8 July 2015 at 16:57, Olivier Martin > wrote: >> When EDK2 is built for the small memory model with AArch64 LLVM, >> some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its >> R_AARCH64_LDST(16

Re: [edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

On 8 July 2015 at 16:57, Olivier Martin wrote: > When EDK2 is built for the small memory model with AArch64 LLVM, > some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its > R_AARCH64_LDST(16|32|64|128)_ABS_LO12_NC companions) that were not > supported before by EDK2 BaseTools are now n

Re: [edk2] [PATCH 0/2] Refine the function comments.

Hi Qui, On Tue, Jul 07, 2015 at 04:41:35PM +0800, Qiu Shumin wrote: > > Qiu Shumin (2): > SecurityPkg: Refine the function comments. > CryptoPkg: Refine the function comments. > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyNull.c| 2 +- > .../BaseCryptLibRuntimeCryptProto

Re: [edk2] How to use same UEFI Option ROM binary for devices with different device ID?

1. The PCIR data structure contain 2 byte pointer to device id table and the device id table is a list containing device ids which your ROM can support.device id is a 2 byte field that's why each entry in device id table is 2 byte wide 2 UEFI driver model, when your driver is called in "driver bin

Re: [edk2] [Patch 3/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.

On 07/08/15 17:41, Wu, Jiaxin wrote: > Hi Laszlo, > For your mentioned patch: > --[edk2] [Patch] MdeModulePkg: Update Ip4Dxe driver to support Ip4Config2 > protocol, and also add UI support in Ip4Dxe driver. > (http://thread.gmane.org/gmane.comp.bios.tianocore.devel/15823) > > That was an old v

Re: [edk2] [PATCH] MdeModulePkg/FvSimpleFileSystemDxe: Support file opening with no '.efi'

You are saying "If user enter "Shell" or "Shell.efi", it should run for both cases." But it is actually the case I am trying to solve with this patch :-) FvSimpleFileSystemOpen() was only checking if there was strict equality between the given name and the name exposed by FvSimpleFileSystemDxe (

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/08/15 17:28, Scott Duplichan wrote: > Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: > > ]Sent: Wednesday, July 08, 2015 08:24 AM > ]To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; > olivier.mar...@arm.com; leif.lindh...@linaro.org; ]jordan.l.jus...@intel.com > ]Subject:

Re: [edk2] How to use same UEFI Option ROM binary for devices with different device ID?

> On Jul 8, 2015, at 7:42 AM, Anindya Rai wrote: > > Hi > > I am developing a UEFI Option ROM. I want to use the same binary with > different devices (different device ID). When I checked the PCI data > structure, there is a field for 'device list pointer' which can be used to > give a list

Re: [edk2] [Patch] UefiCpuPkg/Library/CpuExceptionHandlerLib: Add exception type decoder

Hi Jeff, I notice that this patch has already been committed, but some comments below: On Mon, Jul 06, 2015 at 04:02:06PM +0800, Jeff Fan wrote: > Add exception type decoder to print exception name string beside print > exception type value. The exception names are from IA32 SDM. > > Contributed

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/08/15 17:02, Ard Biesheuvel wrote: > On 8 July 2015 at 16:59, Olivier Martin wrote: >> For ARM architectures, I only disable this flag for RELEASE build: >> > > OK, I hadn't noticed that. This means my patch would be only for the > convenience of the Intel engineers (and my peace of mind as

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: ]Sent: Wednesday, July 08, 2015 08:24 AM ]To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; olivier.mar...@arm.com; leif.lindh...@linaro.org; ]jordan.l.jus...@intel.com ]Subject: [edk2] [PATCH] BaseTools/GCC: allow unused but set var

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 07/08/15 15:24, Ard Biesheuvel wrote: > This fixes a recurring problem where patches that have only been > tested on MS toolchains break the build on GCC because they use > variables that are only written but never read. > > However, there is a valid pattern where this may happen as well. > For

Re: [edk2] 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default file names' breaks the build

That's a fair comment. I will revert the patch. Sorry for the inconvenience. -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: 07 July 2015 22:08 To: edk2-devel@lists.sourceforge.net; Olivier Martin Subject: 'ArmPlatformPkg/ArmVExpressDxe: Change FDT default

Re: [edk2] [PATCH] ShellPkg: Refine code to use Strn**S safe functions instead of Str**S ones in some cases.

Reviewed-by : Tapan Shah <> Make sure you merge ifconfig changes with EDKII trunk before check-in as the code is modified substantially compare to the patch file provided. -Original Message- From: Qiu, Shumin [mailto:shumin@intel.com] Sent: Tuesday, July 07, 2015 7:58 PM To: Shah, T

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

On 8 July 2015 at 16:59, Olivier Martin wrote: > For ARM architectures, I only disable this flag for RELEASE build: > OK, I hadn't noticed that. This means my patch would be only for the convenience of the Intel engineers (and my peace of mind as operator of a Jenkins job that gets broken all the

[edk2] [PATCH] BaseTools/GenFw: Added AArch64 page-relative relocations

When EDK2 is built for the small memory model with AArch64 LLVM, some page-relative relocations (R_AARCH64_ADR_PREL_PG_HI21 and its R_AARCH64_LDST(16|32|64|128)_ABS_LO12_NC companions) that were not supported before by EDK2 BaseTools are now needed. This change adds support for these relocations i

Re: [edk2] [PATCH] BaseTools/GCC: allow unused but set variables

For ARM architectures, I only disable this flag for RELEASE build: $ grep -r unused-but-set-variable Conf/tools_def.txt DEFINE GCC46_IA32_CC_FLAGS = DEF(GCC45_IA32_CC_FLAGS) -Wno-address -Wno-unused-but-set-variable DEFINE GCC46_X64_CC_FLAGS= DEF(GCC45_X64_CC_FLAGS) -Wno-add

[edk2] How to use same UEFI Option ROM binary for devices with different device ID?

Hi I am developing a UEFI Option ROM. I want to use the same binary with different devices (different device ID). When I checked the PCI data structure, there is a field for 'device list pointer' which can be used to give a list of supported device ID. I think this field cannot be used for UEFI Op

Re: [edk2] [Patch] ShellPkg: Remove Status definition in function scope

On 8 July 2015 at 15:35, Wu, Jiaxin wrote: > Hi Ard, > Please help to review and reply the patch, if so, I can submit the patch as > soon as possible. > > Thank you very much! > I just tested it and it works. So please feel free to add Reviewed-by: Ard Biesheuvel Thanks, Ard. > -Original

Re: [edk2] [Patch] ShellPkg: Remove Status definition in function scope

Hi Ard, Please help to review and reply the patch, if so, I can submit the patch as soon as possible. Thank you very much! -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Wednesday, July 8, 2015 8:19 PM To: edk2-devel@lists.sourceforge.net; Ard Biesheuvel Subject

[edk2] [PATCH] BaseTools/GCC: allow unused but set variables

This fixes a recurring problem where patches that have only been tested on MS toolchains break the build on GCC because they use variables that are only written but never read. However, there is a valid pattern where this may happen as well. For instance, Status = SomeFunc (&OutVar); ASSERT_E

Re: [edk2] I don't understand EmulatorPkg

On 07/08/15 01:17, Shubha Ramani wrote: > [...] Here's a polite request: - please stop posting HTML mail - if you are forced at gunpoint to post HTML mail, please, for the sake of all subscribers, stop posting with "24px" sized and/or "x-large" fonts. It looks extremely unprofessional and is

Re: [edk2] [PATCH v2 1/7] MdeModulePkg: Remove Ip4ConfigDxe module and related guid definition from MdeModulePkg.

Thanks all of your comments, I will review those one by one, after that, I will create version3 patch. Best Regards! Jiaxin -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Wednesday, July 8, 2015 8:13 PM To: Wu, Jiaxin Cc: edk2-devel@lists.sourceforge.net Subject:

[edk2] [Patch] ShellPkg: Remove Status definition in function scope

This patch is used fix gcc build failure issue by removing 'Status' definition in function scope that are assigned but never used afterwards. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 3 --- 1

Re: [edk2] [PATCH] MdePkg: Refine INF file for SmmMemLib.

On 07/08/15 09:53, Qiu Shumin wrote: > Add [Depex] section and update protocol usage. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qiu Shumin > CC: Liming Gao > CC: "Yao, Jiewen" > --- > MdePkg/Library/SmmMemLib/SmmMemLib.inf | 5 - > 1 file changed, 4 inser

Re: [edk2] [PATCH v2 1/7] MdeModulePkg: Remove Ip4ConfigDxe module and related guid definition from MdeModulePkg.

comments below On 07/08/15 08:24, jiaxinwu wrote: > Version2 update with a proper commit message. > > Cc: Feng Tian > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: jiaxinwu > --- > MdeModulePkg/Include/Guid/Ip4ConfigHii.h | 25 - > MdeModulePkg/Include/Gui

Re: [edk2] [PATCH v2 0/7] Remove Ip4ConfigDxe module and related guid definitions from related packages.

On 07/08/15 09:21, Wu, Jiaxin wrote: > For question1: I have really add the commit message in v2 > patches(highlight below). Did I misunderstand? You added a description to the cover letter (email 0/7), but whatever you write there will never reach the repo commit log, because the 0/7 email (the c

Re: [edk2] [patch] MdemodulePkg: fix the problem that data type conversion may loss data

On 07/08/15 11:29, Zhang Lubo wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang Lubo > --- > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Universal/Network/

Re: [edk2] OVMF for Xeon

On 07/08/15 12:27, tiger...@zhaoxin.com wrote: > Hi, Laszlo: > I have a question about OVMF package. > 1. Qemu could emulate Xeon CPU, so OVMF firmware could run with Xeon in > Qemu? Yes, why not. We have a few AsmCpuid() calls in OvmfPkg (and probably many more in modules that OvmfPkg pulls in),

Re: [edk2] [PATCH v2 5/7] ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg.

On 07/08/15 10:16, Ard Biesheuvel wrote: > On 8 July 2015 at 08:24, jiaxinwu wrote: >> Version2 update with a proper commit message. >> > > This commit message still does not explain the purpose of this change. I agree absolutely. The commit message should be as follows, in *every single* patch

Re: [edk2] [PATCH v2 4/7] ArmPlatformPkg: Remove Ip4ConfigDxe module from ArmPlatformPkg.

Same comment as Ard... At least, it would be nice to see " Ip4ConfigDxe driver is deprecated in UEFI 2.5, so we will not support original Ip4Config Protocol, which is replace by Ip4Config2 Protocol integrated in Ip4Dxe driver." -Original Message- From: jiaxinwu [mailto:jiaxin...@intel.c

Re: [edk2] [Patch 3/7] OvmfPkg: Remove Ip4ConfigDxe module from OvmfPkg.

On 07/08/15 07:18, Wu, Jiaxin wrote: > Hi Laszlo, > Thanks for your comments first. > Ip4Dxe driver update patch has been sent out and reviewed, we have > submitted to edk2 already. So, that means the packages I listed will > consume Ip4Config2 protocol integrated in Ip4Dxe driver directly. Wha

[edk2] OVMF for Xeon

Hi, Laszlo: I have a question about OVMF package. 1. Qemu could emulate Xeon CPU, so OVMF firmware could run with Xeon in Qemu? Thanks a lot! Best wishes, 本邮件仅针对指定的收件人发送并可能含有保密或专有内容。任何非指定收件人所为之查阅、转发或使用本信息是不被允许的。 如果您误收到本邮件，请立即告知发件人并删除本邮件及所有附件。谢谢！ The information transmitted in this e-mail is inten

[edk2] [PATCH] MdeModulePkg PiSmmCore: Remove a hidden assumption of SMRAM reservation

that assumes the SMRAM reserved range is only at the end of the SMRAM descriptor. // // This range has reserved area, calculate the left free size // gSmmCorePrivate->SmramRanges[Index].PhysicalSize = SmramResRegion->SmramReservedStart - gSmmCorePrivate->

Re: [edk2] [PATCH V3 4/5] Add PCD for selecting terminal type at build time

On 07/08/15 04:46, Heyi Guo wrote: > Hi Roy, > > I have one question; please see my comments below. Indeed: > > On 07/08/2015 08:44 AM, Roy Franz wrote: >> From: Laszlo Ersek >> >> Add a fixed pointer PCD to allow build-time selection of VT100 or TTY >> terminal >> type. The default remains V

[edk2] Fwd: [PATCH v4] ShellPkg: Update ping/ifconfig library.

-- Forwarded message -- From: Ard Biesheuvel Date: 8 July 2015 at 11:26 Subject: Re: [edk2] [PATCH v4] ShellPkg: Update ping/ifconfig library. To: "edk2-devel@lists.sourceforge.net" On 3 July 2015 at 05:39, jiaxinwu wrote: > Version4 include small update from reviewer's comment

[edk2] [patch] MdemodulePkg: fix the problem that data type conversion may loss data

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Support.c b/MdeModulePkg/Universal

Re: [edk2] [PATCH v4] ShellPkg: Update ping/ifconfig library.

On 3 July 2015 at 05:39, jiaxinwu wrote: > Version4 include small update from reviewer's comments: > Change and add some help messages in uni file. > Revert copyright year in UefiShellNetwork1CommandsLib.c file since there is > no code change in this file. > > This patch update ShellPkg ping/ifco

Re: [edk2] [PATCH v3 21/23] OvmfPkg: PciHostBridgeDxe: shorten search for extra root buses

On 07/08/15 02:38, Jordan Justen wrote: > On 2015-07-07 08:09:23, Laszlo Ersek wrote: >> QEMU provides an fw_cfg file called "etc/extra-pci-roots", containing a > > How long were the extra roots in qemu without the fw_cfg entry? Not at all. Please see QEMU commit 2118196bb. That patch, adding the

Re: [edk2] [Patch] Nt32Pkg: Update DSC/FDF to include drivers for HTTP boot.

Reviewed-by: Ye Ting -Original Message- From: Fu Siyuan [mailto:siyuan...@intel.com] Sent: Wednesday, July 08, 2015 5:04 PM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] Nt32Pkg: Update DSC/FDF to include drivers for HTTP boot. This patch add the HTTP boot related drive

Re: [edk2] [PATCH v3 20/23] OvmfPkg: PciHostBridgeDxe: look for all root buses

On 07/08/15 02:32, Jordan Justen wrote: > On 2015-07-07 08:09:22, Laszlo Ersek wrote: >> In this patch we assume that root bus number 0 is always there (same as >> before), and scan the rest of the extra root buses, up to and including >> 255. When an extra root bus is found, we install the PCI roo

[edk2] [Patch] Nt32Pkg: Update DSC/FDF to include drivers for HTTP boot.

This patch add the HTTP boot related drivers to NT32 platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan CC: Ruiyu Ni --- Nt32Pkg/Nt32Pkg.dsc | 6 +- Nt32Pkg/Nt32Pkg.fdf | 4 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Nt32Pkg/N

Re: [edk2] [PATCH 1/3] ArmVirtPkg: Make terminal type consistent

Hi Laszlo, Thanks for your comments. I'll send another version when Roy's patches are committed. On 07/08/2015 02:47 AM, Laszlo Ersek wrote: > comments below > > On 07/07/15 18:56, Heyi Guo wrote: >> Change default terminal type to be VT100, to make it consistent with >> default ConIn/ConOut dev

Re: [edk2] [PATCH v2 5/7] ArmVirtPkg: Remove Ip4ConfigDxe module from ArmVirtPkg.

On 8 July 2015 at 08:24, jiaxinwu wrote: > Version2 update with a proper commit message. > This commit message still does not explain the purpose of this change. > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: jiaxinwu > --- >

Re: [edk2] [PATCH] MdePkg: Refine INF file for SmmMemLib.

Looks good. -Original Message- From: Qiu, Shumin Sent: Wednesday, July 08, 2015 3:54 PM To: edk2-devel@lists.sourceforge.net Cc: Qiu, Shumin; Gao, Liming; Yao, Jiewen Subject: [edk2][PATCH] MdePkg: Refine INF file for SmmMemLib. Add [Depex] section and update protocol usage. Contributed

[edk2] [PATCH] MdePkg: Refine INF file for SmmMemLib.

Add [Depex] section and update protocol usage. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin CC: Liming Gao CC: "Yao, Jiewen" --- MdePkg/Library/SmmMemLib/SmmMemLib.inf | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MdePkg/Library/Sm

  1   2   >