On 27/10/14 01:56, Tian, Feng wrote:
> I think you have found this and are proposing this patch to make the
> SataController driver more generic.
>
> But your proposed patch makes an incorrect assumption, that is the upper
> caller must invoke IdeInit.GetChannelInfo(). So I think this patch is n
On 23/10/14 22:20, Laszlo Ersek wrote:
> Okay -- I wasn't aware that the explanation requested by Feng had
> already been provided.
It didn't. I thought the new patch explains it, but I guess not...
--
On 23/10/14 14:25, Laszlo Ersek wrote:
> I don't know the first thing about SATA, but the patch stays within the
> boundaries of that module.
When the ideinitprotocol is registered ahcimode is not initialized yet. The
ahci capability register won't be initialized at that point the channel count
wil
On 23/10/14 12:36, Laszlo Ersek wrote:
> I thought this patch was rejected by the maintainer already:
>
> http://thread.gmane.org/gmane.comp.bios.tianocore.devel/8706/focus=10290
The way I understood it, was that if there is no good explanation it will be
rejected.
I don't know if satacontroller
From: Reza Jelveh
SataController is copied to OvmfPkg for use in other packages.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/SataControllerDxe/ComponentName.c | 176
OvmfPkg/SataControllerDxe/SataController.c | 1007
From: Reza Jelveh
SataController reads host capabalities when the module is first loaded.
SataControllerStart is called before AhciMode.c resets the bus and
enables AE. If SataControllerStart would do this itself, it would break
AhciMode.
The Initialize method should only install the protocol
From: Reza Jelveh
Some Ide controllers only update ID fields such as sector information on
specific commands such as the DIAG command.
The master/slave device is therefore selected before sending the DIAG command
otherwise reading the IDE registers yields the masters ID fields.
Contributed
From: Reza Jelveh
The SataController is copied to OvmfPkg where the IdeController
resides and enabled for OvmfPkg
Because SataController needs AE to be enabled before reading Ahci
registers, GetChannelInfo is used to accomodate for initializations
after AhciMode initialization.
IdeMode of
From: Reza Jelveh
Calling GetChannelInfo allows the Controller to initialize things that depend
on previous Ahci mode initialization.
Outside of DuetPkg AE needs to be enabled before accessing AHCI registers.
AhciModeInitialization is called after the IdeControllerInitProtocol is
initialized
From: Reza Jelveh
Removed:
- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
(provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
- PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
(provides gEfiIdeControllerInitProtocolGuid)
Added:
- MdeModulePkg/Bus/Ata/AtaBusDxe
On 29/09/14 15:37, Laszlo Ersek wrote:
> On 09/29/14 15:23, Reza Jelveh wrote:
> > On 29/09/14 13:32, Laszlo Ersek wrote:
> >> What is the review / development / resubmission status of this patchset?
> >> In particular, have opinions converged on the non-OVMF pack
On 29/09/14 13:32, Laszlo Ersek wrote:
> What is the review / development / resubmission status of this patchset?
> In particular, have opinions converged on the non-OVMF packages, ie.
> MdeModulePkg, DuetPkg, and PcAtChipsetPkg?
The PcAtChipsetPkg/DuetPkg remains untouched. The copy of SataControl
On 29/09/14 13:32, Laszlo Ersek wrote:
> On 08/21/14 11:55, reza.jel...@tuhh.de wrote:
> > From: Reza Jelveh
> >
> > The SataController is moved to PcAtChipsetPkg where the IdeController
> > resides. The SataController is also enabled for OVMF.
> >
> >
On 10/09/14 09:59, Jordan Justen wrote:
> ...my question about DataHub still applies. The DataHub is deprecated,
> so I'm wondering how strongly XNU depends on it.
>
> Perhaps it would be fine if it can locate the protocol, but the
> protocol functions always fail. That is what I meant by a stub D
On 08/09/14 21:35, Jordan Justen wrote:
> I think we should add ConsoleControl directly in the library.
>
> The library is the only thing that references it, right? Other than XNU?
> > OvmfPkg: InitializeAppleSupport from BdsPlatform
>
> Could this be initialized in PlatformDxe instead?
yes, so
On 02/09/14 17:38, Laszlo Ersek wrote:
> Are you asking if this code would be acceptable in another *Pkg/
> directory, distinct from OvmfPkg/?
>
> In that case, you'd still have to comply with *that* package's
> "Contributions.txt" and "License.txt". And they all look like OvmfPkg's.
>
> (Except
On 02/09/14 16:42, Laszlo Ersek wrote:
> On 09/02/14 15:41, Reza Jelveh wrote:
> > I just noticed that my email had an empty body.
> >
> > Can anyone comment on how we could get this into the codebase?
> >
> >
> > 0011-OvmfPkg-add-a-HfsPlus-driver.
On 02/09/14 05:21, Tian, Feng wrote:
> Hi, Sava
>
> From my side, I am ok with integrating these two cases into one.
>
> Please help review and verify if the attached patch is ok for Qemu and
> Marvel’s AHCI controller.
>
Looks good from my side. Agreed with the comment issue.
On 01/09/14 15:29, A. Sava wrote:
> As we add now Ahci support, we probably should also add Ahci support to Csm
> module (IntelFrameworkModulePkg/Csm/LegacyBiosDxe), otherwise Ahci devices
> won't appear as Legacy entries.
Can you elaborate on this please? Why is this needed?
On 22/08/14 06:09, Tian, Feng wrote:
> Hi, Reza
>
> ATA spec said the Diagnostics cmd doesn't care DEV bit. Where did you meet
> such issue?
Qemu, might just be a bug. But why does ide.c first switch to slave device
read the slave status and then sends the diagnostics to the master, whereas
IdeMo
> Cc: ag...@suse.de
> Subject: [edk2] [PATCH v2 5/6] MdeModulePkg: AhciMode calls GetChannelInfo
> when enumerating
>
> From: Reza Jelveh
>
> GetChannelInfo is called to initialize the SataController when enumerating
> ports.
>
> Contributed-under: TianoCore Contr
From: Reza Jelveh
Initialize apple specific boot support in PlatformBdsPolicyBehavior
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 5 +
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h | 1
From: Reza Jelveh
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
--
The hfs module can currently be found at:
https://github.com/fishman/edk2-hfsplus
Signed-off-by: Reza Jelveh
---
OvmfPkg/OvmfPkgIa32.dsc| 7 +++
OvmfPkg/OvmfPkgIa32.fdf| 2
From: Reza Jelveh
Apple's boot.efi checks if the ConsoleControl protocol returns
EFI_SUCCESS in both GetMode and SetMode.
Apple uses a kernel extension to make parts of the DataHub protocol
available to the xnu kernel. The xnu kernel then checks for FSB
frequency and if it's not f
From: Reza Jelveh
Apple's bootloader requires the ConsoleControl protocol to be
implemented.
The gEfiConsoleControlProtocolGuid is added to the dec file for O to
consume.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/Include/Pro
From: Reza Jelveh
This patch adds apple boot support to Ovmf. It readds the ConsoleControl
protocol and adds firmware and datahub settings apple needs for
successful osx boot.
This version fixes a few typos throughout the last version and moves the
ConsoleControl protocol from EdkCompat to
On 21/08/14 23:20, Paolo Bonzini wrote:
> There is a patch in QEMU now that makes it report the PIO Setup FIS
> correctly. However QEMU will still report a D2H FIS later, even if
> there's no error. Is this incorrect?
Yeah, I saw that. In theory, for PIO Data-In it should not report a d2h fis
unl
From: Reza Jelveh
Initialize apple specific boot support in PlatformBdsPolicyBehavior
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 5 +
OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h | 1
From: Reza Jelveh
Apple's bootloader requires the ConsoleControl protocol to be
implemented. By adding the Foundation path to the package description
the ConsoleProtocol can be used in Ovmf without the need of copying it
to Include/Protocol of MdePkg like other protocols did.
From: Reza Jelveh
Apple's boot.efi checks if the ConsoleControl protocol returns
EFI_SUCCESS in both GetMode and SetMode.
Apple uses a kernel extension to make parts of the DataHub protocol
available to the xnu kernel. The xnu kernel then checks for FSB
frequency and if it's not f
From: Reza Jelveh
This patch adds apple boot support to Ovmf. It readds the ConsoleControl
protocol and adds firmware and datahub settings apple needs for
successful osx boot
Reza Jelveh (4):
EdkCompatibilityPkg: allow ConsoleControl protocol to be used
OvmfPkg: add apple boot support to
From: Reza Jelveh
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
--
The hfs module can currently be found at:
https://github.com/fishman/edk2-hfsplus
Signed-off-by: Reza Jelveh
---
OvmfPkg/OvmfPkgIa32.dsc| 7 +++
OvmfPkg/OvmfPkgIa32.fdf| 2
From: Reza Jelveh
SataController is moved to PcAtChipsetPkg for use in other packages such
as OVMF.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
DuetPkg/DuetPkg.fdf|2 +-
DuetPkg/DuetPkgIa32.dsc
From: Reza Jelveh
Some AHCI controllers such as the Marvel 9230 controllers do not send
PIO Setup FIS when the PIO data-in command is completed. Instead they
just send a D2H FIS.
To accomodate for this possibility the status code of the D2H FIS is
checked.
Contributed-under: TianoCore
From: Reza Jelveh
GetChannelInfo is called to initialize the SataController when
enumerating ports.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 16
1 file changed, 16 insertions
From: Reza Jelveh
The slave or master device must be selected before sending the
diagnostics command, otherwise reading the Ide registers yields invalid
results.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru
From: Reza Jelveh
Removed:
- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
(provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
- PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
(provides gEfiIdeControllerInitProtocolGuid)
Added:
- MdeModulePkg/Bus/Ata/AtaBusDxe
From: Reza Jelveh
The SataController is moved to PcAtChipsetPkg where the IdeController
resides. The SataController is also enabled for OVMF.
Certain controllers such as Marvel 9230 controller use a D2H FIS instead
of PIO Setup FIS to denote the end of a PIO data-in command.
Some dependency on
From: Reza Jelveh
SataController reads host capabalities when the module is first loaded.
SataControllerStart is called before AhciMode.c resets the bus and
enables AE. If SataControllerStart would do this itself, it would break
AhciMode.
The Initialize method should only install the protocol
Looks good to me, with another Ide patch it to fix slave devices I have
attached the two logs. One with Idebus and IdeController and the other with
AtaBus AtaAtapiPassthru and SataController.
On 17/08/14 01:32, Laszlo Ersek wrote:
> On 08/16/14 20:34, Reza Jelveh wrote:
> > On 16/08
This patch adds the HfsPlus driver it's licensed under the GPL so i'm curious
what the procedure here would be.
--
Slashdot TV.
Video for Nerds. Stuff that matters.
http://tv.slashdot.org/
__
On 18/08/14 00:25, Tian, Feng wrote:
> Hi, Reza
>
> I don't get your meaning about " the ChannelCount is initialized too early ".
> These drivers are UEFI driver binding drivers, which means they get
> initialized by pre-assigned order.
I fixed the IDE issue. ChannelCount too early means the fo
On 16/08/14 14:51, Laszlo Ersek wrote:
> You asked me how, in my opinion, you should test the new device paths. I
> gave you an exhaustive test plan, the way I would test for regressions
> and expected behavior. You can write a shell script with two loops, and
> watch 24 boots. (You don't need to b
On 15/08/14 12:50, Laszlo Ersek wrote:
> Sure.
>
> First, by looking at (and maybe posting) the debug log section that I
> described before.
>
> Second, by creating a virtual machine as follows:
> - ATA disk in IDE or AHCI mode, with booindex spec
> - ATA CD-ROM in IDE or AHCI mode, with bootinde
On 15/08/14 09:30, Laszlo Ersek wrote:
> ... actually, I guess the goal of this patch is to enable AHCI mode ATA
> devices while keeping IDE mode ATA devices working.
Yes, this requires the IdeMode and SataController patches that come later.
Otherwise, IdeMode would not properly enumerate ide devic
On 15/08/14 04:51, Tian, Feng wrote:
> Hi, Reza
>
> This is a reason to use IdeInit.ChannelCount rather than the constant value.
> Some platforms may only expose one ide channel to external. By this way, we
> can skip unnecessary enumeration time according to platform policy.
>
> Do you see any
On 15/08/14 04:51, Tian, Feng wrote:
> Hi, Reza
>
> This is a reason to use IdeInit.ChannelCount rather than the constant value.
> Some platforms may only expose one ide channel to external. By this way, we
> can skip unnecessary enumeration time according to platform policy.
>
> Do you see any
On 15/08/14 04:53, Tian, Feng wrote:
> Hi, Reza
>
> Do you see any impact with original code? Why we don't use
> IdeInit.GetChannelInfo() is because we can get the info by AHCI PI register.
>
I get that, the GetChannelInfo in this context serves to initialize the
SataController, which should not
From: Reza Jelveh
GetChannelInfo is called to initialize the SataController when
enumerating ports.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 16
1 file changed, 16 insertions
From: Reza Jelveh
Some AHCI controllers such as the Marvel 9230 controllers do not send
PIO Setup FIS when the PIO data-in command is completed. Instead they
just send a D2H FIS.
To accomodate for this possibility the status code of the D2H FIS is
checked.
Contributed-under: TianoCore
From: Reza Jelveh
SataController reads host capabalities when the module is first loaded.
The Initialize method should only install the protocol. All host
specific information is read when ChannelInfo is accessed.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza
From: Reza Jelveh
SataController is moved to PcAtChipsetPkg for use in other packages such
as OVMF.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
DuetPkg/DuetPkg.fdf|2 +-
DuetPkg/DuetPkgIa32.dsc
From: Reza Jelveh
Currently IdeMode depends on SataController to set ChannelCount to
enumerate IDE devices. SataController sets ChannelCount to
ICH_IDE_MAX_CHANNEL, which is 2.
IdeMode should not be dependent on SataController and just use this
constant directly.
Contributed-under: TianoCore
From: Reza Jelveh
The SataController is moved to PcAtChipsetPkg where the IdeController
resides. The SataController is also enabled for OVMF.
Certain controllers such as Marvel 9230 controller use a D2H FIS instead
of PIO Setup FIS to denote the end of a PIO data-in command.
Some dependency on
From: Reza Jelveh
Removed:
- IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
(provides gEfiDiskInfoProtocolGuid, gEfiBlockIoProtocolGuid)
- PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
(provides gEfiIdeControllerInitProtocolGuid)
Added:
- MdeModulePkg/Bus/Ata/AtaBusDxe
t this results in
duplicate code. There is only a little thing i can think of to reduce the
duplicate breaks.
>From b362cd4e50d4d9dd55eb6adb8940e94430e94bc7 Mon Sep 17 00:00:00 2001
From: Reza Jelveh
Date: Wed, 6 Aug 2014 17:47:20 +0200
Subject: [PATCH 1/3] MdeModulePkg: Check D2H register statu
On 12/08/14 23:16, A. Sava wrote:
> Hi Reza,
>
> Take note that regarding SataControllerDxe, there still remains a problem
> that effects Qemu functionality.
>
> On this query:
>
> Data32 = AhciReadReg (PciIo, R_AHCI_CAP);
>
> SataPrivateData->IdeInit.ChannelCount = (UINT8) ((Data32 & B_AHCI_CA
On 11/08/14 01:07, Tian, Feng wrote:
> Hi, Reza
>
> IMHO, it should jump out the loop at the below point if we put break
> statement inside the new if.
>
> PrdCount = *(volatile UINT32 *)
> (&(AhciRegisters->AhciCmdList[0].AhciCmdPrdbc));
> if (PrdCount == DataCount) {
>
On 10/08/14 11:29, Reza Jelveh wrote:
> Meanwhile I'll see what I can do about the PIO Setup FIS in Qemu.
Actually John Snow just contributed a patch to fix this. That leaves the
question of whether the break should be inside or outside the new if.
Is there actually any reason why a
On 10/08/14 02:53, A. Sava wrote:
> Hi Feng & Reza,
>
> In Qemu's case, it won't break out on a Setup FIS, because currently for
> PIO commands, Qemu does not put at all a PIO Setup FIS at the end, but only
> a D2H FIS. Perhaps other controllers with a similar problem also have
> similar implement
On 08/08/14 01:12, Tian, Feng wrote:
> Hi, Reza
>
> That's the problem.
>
> For PIO DATA-OUT command protocol, D2H either indicates that the transfer was
> completed or that's an error occurred.
> But for PIO DATA-IN command protocol, I don't see such sentence from SATA 2.6
> spec.
>
> If the
Currently booting from devices works by setting EFI_REMOVABLE_MEDIA_FILE_NAME
based on the architecture in MdePkg/Include/Uefi/UefiSpec.h
That information is then used in
IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c to boot from a
selected device.
OSX uses a different loader path /Syst
l@lists.sourceforge.net
> Cc: ag...@suse.de
> Subject: [edk2] [PATCH 2/2] MdeModulePkg: Check D2H register status in
> AhciPioTransfer
>
> From: Reza Jelveh
>
> Several Ahci controllers including Qemu and several ARM devices send device
> commands such as identify asyn
On 07/08/14 06:36, Zeng, Star wrote:
> I added SataControllerDxe in DuetPkg to support AHCI for Duet that has
> chipset and platform specific initialization done before the Duet boot.
> It was thought to be hardly shared and used by real hardware platforms as the
> platforms (at least all I touch
On 06/08/14 14:51, Andrew Fish wrote:
> How you write a GPL licensed FAT driver seems like a legal quagmire. Probably
> something better discussed with a lawyer. From the outside looking in it
> seems like the IP rights are enforced by charging licensing fees to devices
> that support FAT. So f
On 06/08/14 19:10, Laszlo Ersek wrote:
> Then,
>
> > @@ -567,3 +573,4 @@
> > !endif
> >
> >OvmfPkg/PlatformDxe/Platform.inf
> > + IntelFrameworkModulePkg/Universal/DataHubDxe/DataHubDxe.inf
>
> No clue what this is good for. It seems to produce
> gEfiDataHubProtocolGuid, which is consumed b
From: Reza Jelveh
Replace the IdeController with a SataController that supports both in the Ovmf
firmware.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
OvmfPkg/OvmfPkgX64.dsc | 15 +++
OvmfPkg/OvmfPkgX64.fdf | 11 +++
2 files
From: Reza Jelveh
This allows OVMF to be used with Ahci mode in Qemu.
You can try it by using the following with your qemu image:
-drive id=disk,file=mac_hdd_raw.img,if=none -device ahci,id=ahci
-device ide-drive,drive=disk,bus=ahci.0
Some sata controllers send all commands asynchronously
From: Reza Jelveh
Several Ahci controllers including Qemu and several ARM devices send
device commands such as identify asynchronously, which leads to the D2H
register being set.
AtaAtapiPassThru interprets a D2H regardless of the status code as
error therefore failing to detect and enable ahci
not technically linked but just loaded by the EFI therefore not
violating any license.
Is that correct?
Best,
Reza
--
Reza Jelveh | @rjzzleep | reza.jelveh.me
--
Infragistics Professional
Build stunning WinForms apps
On 23/06/14 11:46, Reza Jelveh wrote:
> On 23/06/14 08:30, Tian, Feng wrote:
> > Reza,
> >
> > For SerialATA Revision 3.2 golden spec, it's in section 11.8 :-).
>
do async notifications use the d2h register
On 23/06/14 08:30, Tian, Feng wrote:
> Reza,
>
> For SerialATA Revision 3.2 golden spec, it's in section 11.8 :-).
I see, thanks. I should have debugged the status and error fields of the D2H
for more details.
--
HPCC Sy
On 23/06/14 03:15, Tian, Feng wrote:
> You misunderstands this code.
>
> The pseudo code is:
> 1) Check if D2H is received;
> 2) If yes, then return ERROR;
Ok I see now what you're saying, but given that I have to pay to see sata 2.6
spec. This doesn't look like it's in the sata 3.2 specs or am I
On 23/06/14 00:26, Tian, Feng wrote:
> Hi, Reza
>
> According to SATA2.6 section 11.7 PIO data-in command protocol, the device
> will send D2H to show there is an error happened. So it should return device
> error here.
This check you're talking about happens earlier in the code:
if (!EFI
On 23/06/14 00:26, Tian, Feng wrote:
> Hi, Reza
>
> According to SATA2.6 section 11.7 PIO data-in command protocol, the device
> will send D2H to show there is an error happened. So it should return device
> error here.
Tiang,
That can't be right. First of all the check is basically saying
if
AhciPioTransfer incorrectly returns a device error when successful
>From 69105b75e17abea25c6789b55108a0601f2dd6ee Mon Sep 17 00:00:00 2001
From: Reza Jelveh
Date: Sun, 22 Jun 2014 21:40:10 +0200
Subject: [PATCH] AhciPioTransfer incorrectly returns EFI_DEVICE_ERROR on
success
Contributed-un
)) {
Status = EFI_DEVICE_ERROR;
break;
}
On 22/06/14 16:06, Reza Jelveh wrote:
> Hi there,
>
> I just replaced the ide controller in ovmf with the satacontroller from duet.
> After fiddling a bit with the fdf it works for ide devices
>
> To be specific I repla
Hi there,
I just replaced the ide controller in ovmf with the satacontroller from duet.
After fiddling a bit with the fdf it works for ide devices
To be specific I replaced
# INF IntelFrameworkModulePkg/Bus/Pci/IdeBusDxe/IdeBusDxe.inf
# INF PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeCo
On 19/06/14 14:51, Andrew Fish wrote:
> Well the code looked like this? So I assumed they did not mean iret
> .byte 0x48 # prefix to composite "retq" with next "retf"
> retf # far return
> DoIret:
> iretq
i'm not sure what you mean ...
retf is lret
On 19/06/14 13:59, Andrew Fish wrote:
>
> On Jun 19, 2014, at 11:58 AM, e...@ragequ.it wrote:
>
> > I changed the `retf` to a `ret` to get it to assemble for now.
> >
>
> That looks right. I think it should be ret.
i'm pretty certain this should be lret. Basically either the osx assembler
shoul
From: Reza Jelveh
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Reza Jelveh
---
BaseTools/Source/C/VfrCompile/VfrCompiler.cpp | 2 ++
BaseTools/Source/C/VfrCompile/VfrCompiler.h | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Source/C
On 04/04/14 10:28, Jordan Justen wrote:
> On Fri, Apr 4, 2014 at 6:07 AM, Laszlo Ersek wrote:
> > I think that Reza's fix is correct, I'd just put the
> > statement right at the top of the constructor, instead of pushing it
> >down to CVfrCompiler::OptionInitialization().
you're right i fixed this
On 04/04/14 02:14, Dong, Eric wrote:
> This error info is printed in CVfrCompiler::Compile () function. And before
> call this function, if vfrcompiler parse the code success, the status will be
> set to STATUS_PREPROCESSED, else it will be set to STATUS_DEAD. I don't think
> it's necessary to i
On 03/04/14 12:55, Andrew Fish wrote:
> Seems folks are always trying to be creative in this area …..
>
> For X64 Xcode does not support relocations. So you need to write RIP relative
> code.
>
> .asm
> REPEAT 32
> db 6ah; push #VectorNum
> db ($ - AsmIdtVectorBegin)
On 02/04/14 13:41, Reza Jelveh wrote:
> On 02/04/14 01:22, Andrew Fish wrote:
> > I’ve been meaning to add an Xcode5 target that has the different arg to the
> > template file. What OS version are you running on? I’m on OS X 10.9.2.
> i'm using 10.9.2, i have xcode 5, but
On 02/04/14 08:12, Andrew Fish wrote:
>
> On Apr 2, 2014, at 4:41 AM, Reza Jelveh wrote:
> OK then this may be fixable. Use Xcode 5 for C code and then point
> *_*_*_ASM_PATH to your binutils version of as.
>
> *_XCLANG_*_ASM_PATH = /usr/local/bin/as
yeah, that doesn
On 02/04/14 01:22, Andrew Fish wrote:
> I’ve been meaning to add an Xcode5 target that has the different arg to the
> template file. What OS version are you running on? I’m on OS X 10.9.2.
i'm using 10.9.2, i have xcode 5, but yes, I was using xcode 4.6 binutils
since i'm on gentoo prefix, and st
On 01/04/14 15:27, Andrew Fish wrote:
> Yes you need to change the argument for Xcode 5, sorry I’ve not had time to
> fix that.
another thing I just remembered. the apple as also lacks retf. I added it in
my repo
https://github.com/fishman/timebomb-gentoo-osx-overlay/blob/master/sys-devel/binuti
On 01/04/14 15:27, Andrew Fish wrote:
>
> On Apr 1, 2014, at 3:13 PM, Reza Jelveh wrote:
> Yes you need to change the argument for Xcode 5, sorry I’ve not had time to
> fix that.
it's fine, it's just a bit annoying that couldn't find a place where clang
tracks t
I've gotten pretty far with building ovmf on mavericks.
newer versions of iasl also support osx now. instead of mtriple we should also
use -target x86_64-pc-win32-macho
what i don't understand though is the undefined symbols iowrite and ioread i'm
getting.
see below for the full log. Does anyo
the default argument in vfrformpkg should be in the header.
diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
index 6dfc118..376a454 100644
--- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
+++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
@
vfrcompiler's runstatus is undefined on startup, here's a patch that fixes it.
On 01/04/14 17:35, Reza Jelveh wrote:
> using VfrCompile on a recent linux distribution such as archlinux yields
> ERROR 0003 no matter what Vfr I call it on. does anyone have any hints on how
&g
using VfrCompile on a recent linux distribution such as archlinux yields
ERROR 0003 no matter what Vfr I call it on. does anyone have any hints on how
I can debug this?
Thanks,
Reza
"VfrCompile" -l -n --string-db
/home/dude/OSXGUEST/ovmf-svn/src/tianocore-edk2-svn_build/Build/OvmfX64/REL
93 matches
Mail list logo
