[Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread andy pugh
We are seeing a number of issues reported to the forum where the fix to the PID command-deriv input is causing problems with existing configurations that net that pin to a signal that is not otherwise connected to a source. Should we consider a 2.7.16 that reverts this fix, and push the actual fix

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Jon Elson
On 03/03/2020 10:13 AM, andy pugh wrote: We are seeing a number of issues reported to the forum where the fix to the PID command-deriv input is causing problems with existing configurations that net that pin to a signal that is not otherwise connected to a source. Should we consider a 2.7.16 tha

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Rene Hopf via Emc-developers
> On 3. Mar 2020, at 17:49, Jon Elson wrote: > > On 03/03/2020 10:13 AM, andy pugh wrote: >> We are seeing a number of issues reported to the forum where the fix >> to the PID command-deriv input is causing problems with existing >> configurations that net that pin to a signal that is not othe

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread andy pugh
On Tue, 3 Mar 2020 at 16:50, Jon Elson wrote: > Does anybody have a more specific case of how it is failing? https://forum.linuxcnc.org/38-general-linuxcnc-questions/38367-2-7-15?start=0 -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mec

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Gene Heskett
On Tuesday 03 March 2020 11:13:17 andy pugh wrote: > We are seeing a number of issues reported to the forum where the fix > to the PID command-deriv input is causing problems with existing > configurations that net that pin to a signal that is not otherwise > connected to a source. > > Should we c

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Gene Heskett
On Tuesday 03 March 2020 11:54:09 andy pugh wrote: > On Tue, 3 Mar 2020 at 16:50, Jon Elson wrote: > > Does anybody have a more specific case of how it is failing? > > https://forum.linuxcnc.org/38-general-linuxcnc-questions/38367-2-7-15? >start=0 This thread is at least 2 years newer than the p

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Chris Morley
reverting seems reasonable. In the long run why don't we change it from 'magic' to a switch - like a parameter to change the behavior? Chris From: andy pugh Sent: March 3, 2020 4:13 PM To: EMC developers Subject: [Emc-developers] 2.7.15 PID Fix

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Jon Elson
On 03/03/2020 10:54 AM, andy pugh wrote: On Tue, 3 Mar 2020 at 16:50, Jon Elson wrote: Does anybody have a more specific case of how it is failing? https://forum.linuxcnc.org/38-general-linuxcnc-questions/38367-2-7-15?start=0 So, the pid command-deriv was not used in the past? Geez, that c

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Jon Elson
Looking at the 2.7 docs for the PID component, there is no mention of a pid.n.command-deriv pin. There is a commandD and a commandDD which seem to be outputs available when the debug mode is turned on. Jon ___ Emc-developers mailing list Emc-develo

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Peter C. Wallace
On Tue, 3 Mar 2020, Jon Elson wrote: Date: Tue, 03 Mar 2020 20:54:55 -0600 From: Jon Elson Reply-To: EMC developers To: EMC developers Subject: Re: [Emc-developers] 2.7.15 PID Fix On 03/03/2020 10:54 AM, andy pugh wrote: On Tue, 3 Mar 2020 at 16:50, Jon Elson wrote: Does anybody have a

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Gene Heskett
On Tuesday 03 March 2020 21:54:55 Jon Elson wrote: > On 03/03/2020 10:54 AM, andy pugh wrote: > > On Tue, 3 Mar 2020 at 16:50, Jon Elson wrote: > >> Does anybody have a more specific case of how it is failing? > > > > https://forum.linuxcnc.org/38-general-linuxcnc-questions/38367-2-7-1 > >5?star

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Gene Heskett
On Tuesday 03 March 2020 22:22:25 Peter C. Wallace wrote: > On Tue, 3 Mar 2020, Jon Elson wrote: > > Date: Tue, 03 Mar 2020 20:54:55 -0600 > > From: Jon Elson > > Reply-To: EMC developers > > To: EMC developers > > Subject: Re: [Emc-developers] 2.7.15 PID F

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-03 Thread Peter C. Wallace
On Tue, 3 Mar 2020, Gene Heskett wrote: Date: Tue, 3 Mar 2020 23:21:54 -0500 From: Gene Heskett Reply-To: EMC developers To: emc-developers@lists.sourceforge.net Subject: Re: [Emc-developers] 2.7.15 PID Fix On Tuesday 03 March 2020 22:22:25 Peter C. Wallace wrote: On Tue, 3 Mar 2020, Jon

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread Jon Elson
On 03/03/2020 09:22 PM, Peter C. Wallace wrote: No, command-deriv is only used for the FF1 feedforward calculation But, I DO use FF1 in practically all my configs, and it does seem to work. So, the problem is linking a signal to the command-deriv pin, but then NOT feeding it the correct der

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread Peter C. Wallace
On Wed, 4 Mar 2020, Jon Elson wrote: Date: Wed, 04 Mar 2020 10:44:26 -0600 From: Jon Elson Reply-To: EMC developers To: EMC developers Subject: Re: [Emc-developers] 2.7.15 PID Fix On 03/03/2020 09:22 PM, Peter C. Wallace wrote: No, command-deriv is only used for the FF1 feedforward

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread andy pugh
On Wed, 4 Mar 2020 at 16:55, Peter C. Wallace wrote: > > As for the docs, the generic 2.7 docs do NOT show any reference to > > pid.x.command-deriv > > Am I looking in the wrong place, or has it been removed? > > It was added early in 2.8 and it works the same as feedback-deriv > (value calculate

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread Peter C. Wallace
On Wed, 4 Mar 2020, andy pugh wrote: Date: Wed, 4 Mar 2020 17:20:02 + From: andy pugh Reply-To: EMC developers To: EMC developers Subject: Re: [Emc-developers] 2.7.15 PID Fix On Wed, 4 Mar 2020 at 16:55, Peter C. Wallace wrote: > As for the docs, the generic 2.7 docs do NOT show

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread andy pugh
On Wed, 4 Mar 2020 at 17:26, Peter C. Wallace wrote: > It was first added to 2.8 and them merged into 2.7 before the > 2.7.15 release AFAIK I think that they were added in 2010: https://github.com/LinuxCNC/linuxcnc/commit/44586b831e1ef5e826003190ab317cda76b6e8e3#diff-912d11dfa52738be509f63e4ff19

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread Peter C. Wallace
On Wed, 4 Mar 2020, andy pugh wrote: Date: Wed, 4 Mar 2020 17:52:09 + From: andy pugh Reply-To: EMC developers To: EMC developers Subject: Re: [Emc-developers] 2.7.15 PID Fix On Wed, 4 Mar 2020 at 17:26, Peter C. Wallace wrote: It was first added to 2.8 and them merged into 2.7

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread andy pugh
On Wed, 4 Mar 2020 at 18:07, Peter C. Wallace wrote: I meant the patch that made the command derivative behavior match the > feedback > derivative behavior (and the manual), that was quite recent. > Ah, sorry. I thought you were explaining the statement that the pins are not in the docs. ( Which

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread Jon Elson
On 03/04/2020 02:14 PM, andy pugh wrote: On Wed, 4 Mar 2020 at 18:07, Peter C. Wallace wrote: I meant the patch that made the command derivative behavior match the feedback derivative behavior (and the manual), that was quite recent. Ah, sorry. I thought you were explaining the statement tha

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-04 Thread Gene Heskett
On Wednesday 04 March 2020 12:52:09 andy pugh wrote: > On Wed, 4 Mar 2020 at 17:26, Peter C. Wallace wrote: > > It was first added to 2.8 and them merged into 2.7 before the > > 2.7.15 release AFAIK > > I think that they were added in 2010: > https://github.com/LinuxCNC/linuxcnc/commit/44586b831e

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-05 Thread andy pugh
On Thu, 5 Mar 2020 at 03:14, Gene Heskett wrote: > encoder. But from reading that, I fail to deduct a source for cmd.deriv. It's a feed-forward input, and the source would be the velocity output from the motion controller for that joint. (ie, the motion system outputs both a current position _an

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-05 Thread Peter C. Wallace
On Wed, 4 Mar 2020, Gene Heskett wrote: Date: Wed, 4 Mar 2020 22:12:47 -0500 From: Gene Heskett Reply-To: EMC developers To: emc-developers@lists.sourceforge.net Subject: Re: [Emc-developers] 2.7.15 PID Fix On Wednesday 04 March 2020 12:52:09 andy pugh wrote: On Wed, 4 Mar 2020 at 17:26

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-05 Thread Gene Heskett
On Thursday 05 March 2020 07:16:20 andy pugh wrote: > On Thu, 5 Mar 2020 at 03:14, Gene Heskett wrote: > > encoder. But from reading that, I fail to deduct a source for > > cmd.deriv. > > It's a feed-forward input, and the source would be the velocity output > from the motion controller for that

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-05 Thread Gene Heskett
On Thursday 05 March 2020 09:25:01 Peter C. Wallace wrote: > On Wed, 4 Mar 2020, Gene Heskett wrote: > > Date: Wed, 4 Mar 2020 22:12:47 -0500 > > From: Gene Heskett > > Reply-To: EMC developers > > To: emc-developers@lists.sourceforge.net > > Subject: Re

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-05 Thread Peter C. Wallace
On Thu, 5 Mar 2020, Gene Heskett wrote: Date: Thu, 5 Mar 2020 10:42:19 -0500 From: Gene Heskett Reply-To: EMC developers To: emc-developers@lists.sourceforge.net Subject: Re: [Emc-developers] 2.7.15 PID Fix On Thursday 05 March 2020 09:25:01 Peter C. Wallace wrote: On Wed, 4 Mar 2020, Gene

Re: [Emc-developers] 2.7.15 PID Fix

2020-03-05 Thread Gene Heskett
On Thursday 05 March 2020 10:54:49 Peter C. Wallace wrote: > On Thu, 5 Mar 2020, Gene Heskett wrote: > > Date: Thu, 5 Mar 2020 10:42:19 -0500 > > From: Gene Heskett > > Reply-To: EMC developers > > To: emc-developers@lists.sourceforge.net > > Subject: Re