Re: [E-devel] [Patch] elm_map rotate feature

2011-04-25 Thread David Seikel
On Mon, 25 Apr 2011 18:04:07 +0900 Carsten Haitzler (The Rasterman) wrote: > On Mon, 25 Apr 2011 17:04:10 +1000 David Seikel > said: > > > On Mon, 25 Apr 2011 16:02:42 +0900 Carsten Haitzler (The Rasterman) > > wrote: > > > > > On Mon, 25 Apr 2011 14:46:08 +0900 sangho park > > > said: > > >

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-25 Thread The Rasterman
On Mon, 25 Apr 2011 17:04:10 +1000 David Seikel said: > On Mon, 25 Apr 2011 16:02:42 +0900 Carsten Haitzler (The Rasterman) > wrote: > > > On Mon, 25 Apr 2011 14:46:08 +0900 sangho park > > said: > > > > looks ok to me. yes - 3d is nice.. but.. it's definitely more > > ambitious. for sure. fo

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-25 Thread David Seikel
On Mon, 25 Apr 2011 16:02:42 +0900 Carsten Haitzler (The Rasterman) wrote: > On Mon, 25 Apr 2011 14:46:08 +0900 sangho park > said: > > looks ok to me. yes - 3d is nice.. but.. it's definitely more > ambitious. for sure. for a full 3d map actually i might argue that > u'd need a new map widget

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-25 Thread The Rasterman
On Mon, 25 Apr 2011 14:46:08 +0900 sangho park said: looks ok to me. yes - 3d is nice.. but.. it's definitely more ambitious. for sure. for a full 3d map actually i might argue that u'd need a new map widget as it'd be a whole new internal map infra. if i were doing that i'd build something more

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-24 Thread sangho park
yes.. raster. so I changed 3d to 2d :( but I'm still eager to extend to 3d map. when I prepare to extend, I'll try again :D /** * Set the rotate degree of the map * * @param obj The map object * @param angle amount of degrees from 0.0 to 360.0 to rotate arount Z axis. * @param cx rotation's

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-24 Thread The Rasterman
On Wed, 20 Apr 2011 11:39:03 +0900 sangho park said: > hermet, > > thanks for your good suggestion. > as your suggestion, i revised APIs. > > but now center coordinates are useless, because rotated map is grid images. > so center coordinates are decided by each grid image. > > what do you thin

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-20 Thread sangho park
together for the best moment! >> -Regards, Hermet- >> >> -Original Message- >> From: "sangho park"<gouach...@gmail.com> >> To: "ChunEon Park"<her...@naver.com> >> Cc: "EFL"<enlightenment-devel@lists.sourceforge

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-20 Thread sangho park
ssage- > *From:* "sangho park" > *To:* "ChunEon Park" > *Cc:* "EFL" > *Sent:* 11-04-20(수) 11:39:03 > *Subject:* Re: Re: [E-devel] [Patch] elm_map rotate feature > hermet, > > thanks for your good suggestion. > as your suggestion, i revised

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-20 Thread sangho park
o.. i found the bug now I'm trying to fix it. after fixing that, i'll patch again. thanks~ On Tue, Apr 19, 2011 at 2:20 PM, Carsten Haitzler wrote: > On Tue, 19 Apr 2011 11:25:04 +0900 sangho park said: > > i spot a bug! (video). see the center of the screen when you zoom in and > out...

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-20 Thread Atton Jonathan
t; > Cc: "EFL"<enlightenment-devel@lists.sourceforge.net> > Sent: 11-04-20(수) 11:39:03 > Subject: Re: Re: [E-devel] [Patch] elm_map rotate feature > hermet, > thanks for your good suggestion. > as your suggestion, i revised APIs. > but now center coordinates ar

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-20 Thread ChunEon Park
ds, Hermet- -Original Message- From: "sangho park"<gouach...@gmail.com> To: "ChunEon Park"<her...@naver.com> Cc: "EFL"<enlightenment-devel@lists.sourceforge.net> Sent: 11-04-20(수) 11:39:03 Subject: Re: Re: [E-devel] [Patch] elm_map rotate feature h

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-19 Thread sangho park
hermet, thanks for your good suggestion. as your suggestion, i revised APIs. but now center coordinates are useless, because rotated map is grid images. so center coordinates are decided by each grid image. what do you think about this? /** * Set the rotate degree of the map * * @param obj T

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-19 Thread ChunEon Park
how about just rotate_set as you add elm_map_rotate_get elm_map_rotate_set(obj, center_x, center_y, center_z, degree_x, degree_y, degree_z); and I think it will be better if it returns the above arguments also. elm_map_rotate_get(const Evas_Object *obj, ¢er_x, ¢er_y, ¢er_z, °ree_x, °ree_

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-18 Thread The Rasterman
On Tue, 19 Apr 2011 11:25:04 +0900 sangho park said: i spot a bug! (video). see the center of the screen when you zoom in and out... :) > Dear all, > > I just implement map rotate feature. > it's the start of turn-by-turn navigation. :) > > because of some added APIs, I need your reviews. > >

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-18 Thread sangho park
thanks for your lightning comments~~ :) 1) I'll apply const ~ 2) the reference code is 'evas_map_util_3d_rotate'. i can't find another api which is containing rotate keyword. actually, I have a plan to support 3d map. anyway, what is your recommendation? On Tue, Apr 19, 2011 at 11:33 AM, Daniel J

Re: [E-devel] [Patch] elm_map rotate feature

2011-04-18 Thread Daniel Juyung Seo
Video looks good! It's getting better and better. Just two comments from my side. 1) >> + EAPI doubleelm_map_rotate_get(Evas_Object *obj) EINA_ARG_NONNULL(1); According to EFL coding convention, we add "const" to getter's parameter like below: EAPI doubleelm_map

[E-devel] [Patch] elm_map rotate feature

2011-04-18 Thread sangho park
Dear all, I just implement map rotate feature. it's the start of turn-by-turn navigation. :) because of some added APIs, I need your reviews. you can find demo youtube. http://www.youtube.com/watch?v=juxKrrHVU4U pls review this patch. Thanks. BR Index: elementary/src/lib/Elementary.h.in ==