Re: [E-devel] elm_label

2011-07-13 Thread Tom Hacohen
On 12/07/11 22:47, Jonas M. Gastal wrote: > Tom, > > You certainly did help, I got almost everything to work as expected. However a > few issues remain: > - the "marker" style which was mentioned in the previously existing > documentation is present in the default.edc file, but using it causes th

Re: [E-devel] elm_label

2011-07-13 Thread The Rasterman
On Wed, 13 Jul 2011 09:26:21 +0300 Tom Hacohen said: > On 13/07/11 00:36, Gustavo Sverzut Barbieri wrote: > > well, we do have the track but nobody ever checks it (/me hides from > > vtorri, the one that definitely checks!) > > > > Yeah, that's what I said, no trac-culture. :) > > We have it,

Re: [E-devel] elm_label

2011-07-12 Thread Mike Blumenkrantz
On Wed, 13 Jul 2011 09:26:21 +0300 Tom Hacohen wrote: > On 13/07/11 00:36, Gustavo Sverzut Barbieri wrote: > > well, we do have the track but nobody ever checks it (/me hides from > > vtorri, the one that definitely checks!) > > > > Yeah, that's what I said, no trac-culture. :) > > We have it,

Re: [E-devel] elm_label

2011-07-12 Thread Tom Hacohen
On 13/07/11 00:36, Gustavo Sverzut Barbieri wrote: > well, we do have the track but nobody ever checks it (/me hides from > vtorri, the one that definitely checks!) > Yeah, that's what I said, no trac-culture. :) We have it, but we don't use it. -- Tom.

Re: [E-devel] elm_label

2011-07-12 Thread Gustavo Sverzut Barbieri
On Tue, Jul 12, 2011 at 6:08 PM, Tom Hacohen wrote: > On 12/07/11 22:47, Jonas M. Gastal wrote: >> Tom, >> >> You certainly did help, I got almost everything to work as expected. However >> a >> few issues remain: >>  - the "marker" style which was mentioned in the previously existing >> document

Re: [E-devel] elm_label

2011-07-12 Thread Tom Hacohen
On 12/07/11 22:47, Jonas M. Gastal wrote: > Tom, > > You certainly did help, I got almost everything to work as expected. However > a > few issues remain: > - the "marker" style which was mentioned in the previously existing > documentation is present in the default.edc file, but using it caus

Re: [E-devel] elm_label

2011-07-12 Thread Jonas M. Gastal
On Tuesday, July 12, 2011 09:56:45 Tom Hacohen wrote: > On 12/07/11 00:14, Jonas M. Gastal wrote: > > Hey all, > > > > I've been trying to write documentation for elm_label, however there are > > a > > > > number of things that seem to not work: > > - elm_label_ellipsis_set() is only respected

Re: [E-devel] elm_label

2011-07-11 Thread Tom Hacohen
On 12/07/11 00:14, Jonas M. Gastal wrote: > Hey all, > > I've been trying to write documentation for elm_label, however there are a > number of things that seem to not work: > - elm_label_ellipsis_set() is only respected for ELM_WRAP_CHAR It also works with ELM_WRAP_WORD/NONE here... > - elm_l

Re: [E-devel] elm_label

2011-07-11 Thread Tom Hacohen
On 12/07/11 00:14, Jonas M. Gastal wrote: > Hey all, > > I've been trying to write documentation for elm_label, however there are a > number of things that seem to not work: > - elm_label_ellipsis_set() is only respected for ELM_WRAP_CHAR > - elm_label_slide_set() doesn't work(no change setting

[E-devel] elm_label

2011-07-11 Thread Jonas M. Gastal
Hey all, I've been trying to write documentation for elm_label, however there are a number of things that seem to not work: - elm_label_ellipsis_set() is only respected for ELM_WRAP_CHAR - elm_label_slide_set() doesn't work(no change setting it to true or false) - elm_object_style_set(label, "

Re: [E-devel] elm_label patch(bugfix of key_value_replace func)

2011-02-10 Thread Tom Hacohen
Dear Hyoyoung, There are some coding conventions issues in your patch, for example: for example the spaces around the + in this line: "eqchar = strchr(curlocater+key_len, '=');" Please fix those and re-send the patch. Also, if possible please also include a quick explanation on what the problem w

Re: [E-devel] elm_label patch(bugfix of key_value_replace func)

2011-01-31 Thread Tom Hacohen
Yeah yeah, I understand now. On Mon, 2011-01-31 at 18:02 +0900, Carsten Haitzler wrote: > On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen > said: > > > On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote: > > > how does this relate to your patches from 11/01/2011 with wrap mode > > > stuff

Re: [E-devel] elm_label patch(bugfix of key_value_replace func)

2011-01-31 Thread The Rasterman
On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen said: > On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote: > > how does this relate to your patches from 11/01/2011 with wrap mode stuff? i > > see some potential overlap. is the re a chance you can collect this patch > > and those from the 1

Re: [E-devel] elm_label patch(bugfix of key_value_replace func)

2011-01-31 Thread Tom Hacohen
On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote: > how does this relate to your patches from 11/01/2011 with wrap mode stuff? i > see some potential overlap. is the re a chance you can collect this patch and > those from the 11th of jan int a patch set that also implement enums? wrap mod

Re: [E-devel] elm_label patch(bugfix of key_value_replace func)

2011-01-31 Thread The Rasterman
On Thu, 13 Jan 2011 16:10:23 +0900 Hyoyoung Chang said: how does this relate to your patches from 11/01/2011 with wrap mode stuff? i see some potential overlap. is the re a chance you can collect this patch and those from the 11th of jan int a patch set that also implement enums? > Dear Elementa

Re: [E-devel] elm_label patch(bugfix and wrapmode changing)

2011-01-30 Thread The Rasterman
> edc. > > > > Thank you > > > > > -Original Message- > > > From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com] > > > Sent: Tuesday, January 11, 2011 3:52 PM > > > To: Hyoyoung Chang > > > Cc: enlightenment-dev

[E-devel] elm_label patch(bugfix of key_value_replace func)

2011-01-12 Thread Hyoyoung Chang
Dear Elementary developers. It's a bugfix patch at elm_label. Revised some char iteration and fix potential null ptr ref in strbuf_key_value_replace. Thank you. --- Hyoyoung CHANG Engineer SAMSUNG ELECTRONICS, Co., Ltd. E-mail: hyoyoung.ch...@samsung.com

Re: [E-devel] elm_label patch(bugfix and wrapmode changing)

2011-01-10 Thread Tom Hacohen
gt; > To: Hyoyoung Chang > > Cc: enlightenment-devel@lists.sourceforge.net > > Subject: Re: [E-devel] elm_label patch(bugfix and wrapmode changing) > > > > Dear Hyoyoung, > > > > I don't currently have the time to fully review the patches, but > > regarding the w

Re: [E-devel] elm_label patch(bugfix and wrapmode changing)

2011-01-10 Thread Hyoyoung Chang
ay, January 11, 2011 3:52 PM > To: Hyoyoung Chang > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] elm_label patch(bugfix and wrapmode changing) > > Dear Hyoyoung, > > I don't currently have the time to fully review the patches, but > regarding the

Re: [E-devel] elm_label patch(bugfix and wrapmode changing)

2011-01-10 Thread Tom Hacohen
Dear Hyoyoung, I don't currently have the time to fully review the patches, but regarding the wrapping: please be advised that after the release there will be a new wrap mode, "mixedwrap" which is a word-wrap that falls back to "charwrap" if a wordwrap can't be done (I assume you have seen that be

[E-devel] elm_label patch(bugfix and wrapmode changing)

2011-01-10 Thread Hyoyoung Chang
Dear Elementary developers. It's a bugfix patch and adding new functionality for wrapmode changing at elm_label. 1. bugfix strbuf_key_value_replace which is internal function 2. add wrapmode change api (wordwrap or charwrap) Thank you. --- Hyoyoung CHA

Re: [E-devel] elm_label patch(bugfix)

2011-01-05 Thread The Rasterman
On Thu, 30 Dec 2010 19:12:40 +0900 Hyoyoung Chang said: ok- in svn... but i fixed your ()'s - like: while (*replocater && *replocater != ' ' && *replocater != '>') use ()'s to group operations to make sure you dont make order-of-operation errors and you describe the grouping and order you want

[E-devel] elm_label patch(bugfix)

2010-12-30 Thread Hyoyoung Chang
Dear Elementary developers. It's a bugfix patch of elm_label. In strbuf_key_value_replace, null pointer reference can be occured Thank you. --- Hyoyoung CHANG Engineer SAMSUNG ELECTRONICS, Co., Ltd. E-mail: hyoyoung.ch...@samsung.com

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread Tom Hacohen
It's not really hard, just annoying. :) Regarding the feature: well, I don't see myself getting to it any time soon. On Mon, 2010-12-20 at 23:56 +0900, Daniel Juyung Seo wrote: > Yes. > Once this is done, we don't need to use elm_label just for the > textblock ellipsis. > Looking forward to see th

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread Daniel Juyung Seo
Yes. Once this is done, we don't need to use elm_label just for the textblock ellipsis. Looking forward to see this feature soon. Performance would be the key issue though. Thanks. Daniel Juyung Seo (SeoZ) On Mon, Dec 20, 2010 at 8:32 PM, Carsten Haitzler wrote: > On Mon, 20 Dec 2010 13:20:47 +

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread Tom Hacohen
On Mon, 2010-12-20 at 20:32 +0900, Carsten Haitzler wrote: > > but the aim here is to > add it to textblock... I generally give myself very good advice, but I very seldom followed it. I knew I shouldn't stick my nose where it doesn't belong :) -- Tom. -

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread The Rasterman
On Mon, 20 Dec 2010 13:20:47 +0200 Tom Hacohen said: > On Mon, 2010-12-20 at 20:16 +0900, Carsten Haitzler wrote: > > > Do you suggest to move ellipsis feature from elm to edje textblock? > > > > absolutely - yes!. > > edje text, not textblock, textblock doesn't support ellipsis, so please > ma

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread Tom Hacohen
On Mon, 2010-12-20 at 20:16 +0900, Carsten Haitzler wrote: > > Do you suggest to move ellipsis feature from elm to edje textblock? > > absolutely - yes!. edje text, not textblock, textblock doesn't support ellipsis, so please make sure you use type: TEXT. :)

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread The Rasterman
as...@rasterman.com] > > Sent: Monday, December 20, 2010 4:17 PM > > To: Hyoyoung Chang > > Cc: enlightenment-devel@lists.sourceforge.net > > Subject: Re: [E-devel] elm_label patch(ellipsis, sliding) > > > > On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang > >

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread Hyoyoung Chang
[mailto:ras...@rasterman.com] > Sent: Monday, December 20, 2010 4:17 PM > To: Hyoyoung Chang > Cc: enlightenment-devel@lists.sourceforge.net > Subject: Re: [E-devel] elm_label patch(ellipsis, sliding) > > On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang > > said: > > ok. here&#

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-20 Thread The Rasterman
On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang said: and now for the slide patch... 1. slide_duration should be a double - not an int. in efl we do time in floats so we can do fractions of a second nicely as well as multi-second etc. durations. this also means the edc and edje message bits ha

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-19 Thread The Rasterman
On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang said: ok. here's some feedback. 1. 0001 and 0002 are really the same patchset. so in future just send those as 1 patch. 2. it's an improvement on what was there, but the more i lok at it, the more this needs to move into edje. it's too inefficien

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-15 Thread Hyoyoung Chang
Ah, Sorry. It's filtered out. I re-attached patch files. --- Hyoyoung CHANG Engineer SAMSUNG ELECTRONICS, Co., Ltd. E-mail: hyoyoung.ch...@samsung.com --- -Original Message- From: Hyoyoung Chang [mailto:h

Re: [E-devel] elm_label patch(ellipsis, sliding)

2010-12-15 Thread Daniel Juyung Seo
Dear Hyoyoung, there's no attached files. Please modify file name to *.txt and use email client. Thanks. Daniel Juyung Seo On Wed, Dec 15, 2010 at 8:45 PM, Hyoyoung Chang wrote: > Dear Elementary developers. > > It's a elm_label patch. > My previous patch is too big to submit. > So I did split

[E-devel] elm_label patch(ellipsis, sliding)

2010-12-15 Thread Hyoyoung Chang
Dear Elementary developers. It's a elm_label patch. My previous patch is too big to submit. So I did split into patch files. (Thanks for Gastavo and Rasterman) main changes are 1. refine ellipsis algorithm - improve to cut string to fit 2. adding label text sliding feature Thank you. --

Re: [E-devel] elm_label patch

2010-12-09 Thread The Rasterman
.com] > Sent: Thursday, December 09, 2010 5:27 PM > To: enlightenment-devel@lists.sourceforge.net > Subject: [E-devel] elm_label patch > > Dear Elementary developers. > > It's a elm_label patch. > main changes are > 1. refine ellipsis algorithm > - improv

Re: [E-devel] elm_label patch

2010-12-09 Thread The Rasterman
On Thu, 9 Dec 2010 08:45:56 -0200 Gustavo Sverzut Barbieri said: > Raster, see the harm that you do by playing the bad example? :-) Get > ride of the "I'm busy excuse" and try to do simpler patches with less > changes and clear commit messages, please! says the man who has committed enough mega

Re: [E-devel] elm_label patch

2010-12-09 Thread Daniel Juyung Seo
gt;> --- >> >> -Original Message- >> From: Hyoyoung CHANG [mailto:hyoyoung.ch...@samsung.com] >> Sent: Thursday, December 09, 2010 5:27 PM >> To: enlightenment-devel@lists.sourceforge.net >> Subject: [E-devel] elm_la

Re: [E-devel] elm_label patch

2010-12-09 Thread Gustavo Sverzut Barbieri
mail: hyoyoung.ch...@samsung.com > --- > > -Original Message- > From: Hyoyoung CHANG [mailto:hyoyoung.ch...@samsung.com] > Sent: Thursday, December 09, 2010 5:27 PM > To: enlightenment-devel@lists.sourceforge.net > Subject: [E-devel] elm_label patch > > Dear Elementary deve

Re: [E-devel] elm_label patch

2010-12-09 Thread Hyoyoung Chang
ng.ch...@samsung.com] Sent: Thursday, December 09, 2010 5:27 PM To: enlightenment-devel@lists.sourceforge.net Subject: [E-devel] elm_label patch Dear Elementary developers. It's a elm_label patch. main changes are 1. refine ellipsis algorithm - improve to cut string to fit 2. adding lab

[E-devel] elm_label patch

2010-12-09 Thread Hyoyoung CHANG
Dear Elementary developers. It's a elm_label patch. main changes are 1. refine ellipsis algorithm - improve to cut string to fit 2. adding label sliding feature 3. re-indented by eflformat script Thank you. --- Hyoyoung CHANG Engineer SAMSUNG EL

Re: [E-devel] elm_label problem with specific text

2009-11-18 Thread Gustavo Sverzut Barbieri
svn it is, thanks On Wed, Nov 18, 2009 at 10:35 PM, Brian Wang wrote: > [snip] >>> OK. >>> Checking the boundaries after _advance_after_end_of_string() is more >>> expensive >>> than removing the last \0 or reducing the map_end by one. >>> >>> How could one make the fix upstream?  Keeping my own

Re: [E-devel] elm_label problem with specific text

2009-11-18 Thread Brian Wang
[snip] >> OK. >> Checking the boundaries after _advance_after_end_of_string() is more >> expensive >> than removing the last \0 or reducing the map_end by one. >> >> How could one make the fix upstream?  Keeping my own offline patches >> would be a maintenance >> nightmare. > > I'll go with the ch

Re: [E-devel] elm_label problem with specific text

2009-11-18 Thread Gustavo Sverzut Barbieri
On Wed, Nov 18, 2009 at 1:32 AM, Brian Wang wrote: > On Wed, Nov 18, 2009 at 10:51 AM, Gustavo Sverzut Barbieri > wrote: >> On Wed, Nov 18, 2009 at 12:37 AM, Brian Wang >> wrote: >>> On Sat, Nov 14, 2009 at 1:21 PM, Brian Wang >>> wrote: On Sat, Nov 14, 2009 at 1:44 AM, Gustavo Sverzut B

Re: [E-devel] elm_label problem with specific text

2009-11-17 Thread Brian Wang
On Wed, Nov 18, 2009 at 10:51 AM, Gustavo Sverzut Barbieri wrote: > On Wed, Nov 18, 2009 at 12:37 AM, Brian Wang > wrote: >> On Sat, Nov 14, 2009 at 1:21 PM, Brian Wang >> wrote: >>> On Sat, Nov 14, 2009 at 1:44 AM, Gustavo Sverzut Barbieri >>> wrote: On Fri, Nov 13, 2009 at 3:13 PM, Bri

Re: [E-devel] elm_label problem with specific text

2009-11-17 Thread Gustavo Sverzut Barbieri
On Wed, Nov 18, 2009 at 12:37 AM, Brian Wang wrote: > On Sat, Nov 14, 2009 at 1:21 PM, Brian Wang wrote: >> On Sat, Nov 14, 2009 at 1:44 AM, Gustavo Sverzut Barbieri >> wrote: >>> On Fri, Nov 13, 2009 at 3:13 PM, Brian Wang >>> wrote: On Fri, Nov 13, 2009 at 8:12 PM, Gustavo Sverzut Barbi

Re: [E-devel] elm_label problem with specific text

2009-11-17 Thread Brian Wang
On Sat, Nov 14, 2009 at 1:21 PM, Brian Wang wrote: > On Sat, Nov 14, 2009 at 1:44 AM, Gustavo Sverzut Barbieri > wrote: >> On Fri, Nov 13, 2009 at 3:13 PM, Brian Wang >> wrote: >>> On Fri, Nov 13, 2009 at 8:12 PM, Gustavo Sverzut Barbieri >>> wrote: On Fri, Nov 13, 2009 at 4:49 AM, Brian

Re: [E-devel] elm_label problem with specific text

2009-11-13 Thread Brian Wang
On Sat, Nov 14, 2009 at 1:44 AM, Gustavo Sverzut Barbieri wrote: > On Fri, Nov 13, 2009 at 3:13 PM, Brian Wang wrote: >> On Fri, Nov 13, 2009 at 8:12 PM, Gustavo Sverzut Barbieri >> wrote: >>> On Fri, Nov 13, 2009 at 4:49 AM, Brian Wang >>> wrote: [snip] > OK.  With the help of gdbser

Re: [E-devel] elm_label problem with specific text

2009-11-13 Thread Gustavo Sverzut Barbieri
On Fri, Nov 13, 2009 at 3:13 PM, Brian Wang wrote: > On Fri, Nov 13, 2009 at 8:12 PM, Gustavo Sverzut Barbieri > wrote: >> On Fri, Nov 13, 2009 at 4:49 AM, Brian Wang >> wrote: >>> [snip] OK.  With the help of gdbserver/gdb, I am able to find where it's looping. However, I don't know

Re: [E-devel] elm_label problem with specific text

2009-11-13 Thread Brian Wang
On Fri, Nov 13, 2009 at 8:12 PM, Gustavo Sverzut Barbieri wrote: > On Fri, Nov 13, 2009 at 4:49 AM, Brian Wang wrote: >> [snip] >>> OK.  With the help of gdbserver/gdb, I am able to find where it's looping. >>> However, I don't know what causes it.  Here it goes: >>> [svn r43601] >>> evas/src/lib

Re: [E-devel] elm_label problem with specific text

2009-11-13 Thread Gustavo Sverzut Barbieri
On Fri, Nov 13, 2009 at 4:49 AM, Brian Wang wrote: > [snip] >> OK.  With the help of gdbserver/gdb, I am able to find where it's looping. >> However, I don't know what causes it.  Here it goes: >> [svn r43601] >> evas/src/lib/canvas/evas_object_textblock.c:3152 > > The line number is off... I've p

Re: [E-devel] elm_label problem with specific text

2009-11-12 Thread Brian Wang
[snip] > OK.  With the help of gdbserver/gdb, I am able to find where it's looping. > However, I don't know what causes it.  Here it goes: > [svn r43601] > evas/src/lib/canvas/evas_object_textblock.c:3152 The line number is off... I've put some of my stuff in the front of the source code... My bad

Re: [E-devel] elm_label problem with specific text

2009-11-12 Thread Brian Wang
On Thu, Nov 12, 2009 at 9:36 PM, Gustavo Sverzut Barbieri wrote: > On Thu, Nov 12, 2009 at 7:59 AM, Brian Wang wrote: >> Hello all, >> >> I have some problem with elm_label, which is causing the CPU usage to >> go rocket high (from top: 97+%) and does not show anything.  The test >> program simpl

Re: [E-devel] elm_label problem with specific text

2009-11-12 Thread Gustavo Sverzut Barbieri
On Thu, Nov 12, 2009 at 7:59 AM, Brian Wang wrote: > Hello all, > > I have some problem with elm_label, which is causing the CPU usage to > go rocket high (from top: 97+%) and does not show anything.  The test > program simply freezes and does not handle 'Ctrl+c'. > > The problem, which is repeata

[E-devel] elm_label problem with specific text

2009-11-12 Thread Brian Wang
Hello all, I have some problem with elm_label, which is causing the CPU usage to go rocket high (from top: 97+%) and does not show anything. The test program simply freezes and does not handle 'Ctrl+c'. The problem, which is repeatable, occurs on my ARM board and happens with specific text. I c