Dear Hyoyoung,
There are some coding conventions issues in your patch, for example:
for example the spaces around the + in this line:
"eqchar = strchr(curlocater+key_len, '=');"
Please fix those and re-send the patch. Also, if possible please also
include a quick explanation on what the problem w
Yeah yeah, I understand now.
On Mon, 2011-01-31 at 18:02 +0900, Carsten Haitzler wrote:
> On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen
> said:
>
> > On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote:
> > > how does this relate to your patches from 11/01/2011 with wrap mode
> > > stuff
On Mon, 31 Jan 2011 10:11:52 +0200 Tom Hacohen
said:
> On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote:
> > how does this relate to your patches from 11/01/2011 with wrap mode stuff? i
> > see some potential overlap. is the re a chance you can collect this patch
> > and those from the 1
On Mon, 2011-01-31 at 16:48 +0900, Carsten Haitzler wrote:
> how does this relate to your patches from 11/01/2011 with wrap mode stuff? i
> see some potential overlap. is the re a chance you can collect this patch and
> those from the 11th of jan int a patch set that also implement enums?
wrap mod
On Thu, 13 Jan 2011 16:10:23 +0900 Hyoyoung Chang
said:
how does this relate to your patches from 11/01/2011 with wrap mode stuff? i
see some potential overlap. is the re a chance you can collect this patch and
those from the 11th of jan int a patch set that also implement enums?
> Dear Elementa
> edc.
> >
> > Thank you
> >
> > > -Original Message-
> > > From: Tom Hacohen [mailto:tom.haco...@partner.samsung.com]
> > > Sent: Tuesday, January 11, 2011 3:52 PM
> > > To: Hyoyoung Chang
> > > Cc: enlightenment-dev
Dear Elementary developers.
It's a bugfix patch at elm_label.
Revised some char iteration and fix potential null ptr ref in
strbuf_key_value_replace.
Thank you.
---
Hyoyoung CHANG
Engineer
SAMSUNG ELECTRONICS, Co., Ltd.
E-mail: hyoyoung.ch...@samsung.com
gt; > To: Hyoyoung Chang
> > Cc: enlightenment-devel@lists.sourceforge.net
> > Subject: Re: [E-devel] elm_label patch(bugfix and wrapmode changing)
> >
> > Dear Hyoyoung,
> >
> > I don't currently have the time to fully review the patches, but
> > regarding the w
ay, January 11, 2011 3:52 PM
> To: Hyoyoung Chang
> Cc: enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] elm_label patch(bugfix and wrapmode changing)
>
> Dear Hyoyoung,
>
> I don't currently have the time to fully review the patches, but
> regarding the
Dear Hyoyoung,
I don't currently have the time to fully review the patches, but
regarding the wrapping: please be advised that after the release there
will be a new wrap mode, "mixedwrap" which is a word-wrap that falls
back to "charwrap" if a wordwrap can't be done (I assume you have seen
that be
Dear Elementary developers.
It's a bugfix patch and adding new functionality for wrapmode changing at
elm_label.
1. bugfix strbuf_key_value_replace which is internal function
2. add wrapmode change api (wordwrap or charwrap)
Thank you.
---
Hyoyoung CHA
On Thu, 30 Dec 2010 19:12:40 +0900 Hyoyoung Chang
said:
ok- in svn... but i fixed your ()'s - like:
while (*replocater && *replocater != ' ' && *replocater != '>')
use ()'s to group operations to make sure you dont make order-of-operation
errors and you describe the grouping and order you want
Dear Elementary developers.
It's a bugfix patch of elm_label.
In strbuf_key_value_replace, null pointer reference can be occured
Thank you.
---
Hyoyoung CHANG
Engineer
SAMSUNG ELECTRONICS, Co., Ltd.
E-mail: hyoyoung.ch...@samsung.com
It's not really hard, just annoying. :)
Regarding the feature: well, I don't see myself getting to it any time
soon.
On Mon, 2010-12-20 at 23:56 +0900, Daniel Juyung Seo wrote:
> Yes.
> Once this is done, we don't need to use elm_label just for the
> textblock ellipsis.
> Looking forward to see th
Yes.
Once this is done, we don't need to use elm_label just for the
textblock ellipsis.
Looking forward to see this feature soon.
Performance would be the key issue though.
Thanks.
Daniel Juyung Seo (SeoZ)
On Mon, Dec 20, 2010 at 8:32 PM, Carsten Haitzler wrote:
> On Mon, 20 Dec 2010 13:20:47 +
On Mon, 2010-12-20 at 20:32 +0900, Carsten Haitzler wrote:
>
> but the aim here is to
> add it to textblock...
I generally give myself very good advice, but I very seldom followed it.
I knew I shouldn't stick my nose where it doesn't belong :)
--
Tom.
-
On Mon, 20 Dec 2010 13:20:47 +0200 Tom Hacohen
said:
> On Mon, 2010-12-20 at 20:16 +0900, Carsten Haitzler wrote:
> > > Do you suggest to move ellipsis feature from elm to edje textblock?
> >
> > absolutely - yes!.
>
> edje text, not textblock, textblock doesn't support ellipsis, so please
> ma
On Mon, 2010-12-20 at 20:16 +0900, Carsten Haitzler wrote:
> > Do you suggest to move ellipsis feature from elm to edje textblock?
>
> absolutely - yes!.
edje text, not textblock, textblock doesn't support ellipsis, so please
make sure you use type: TEXT. :)
as...@rasterman.com]
> > Sent: Monday, December 20, 2010 4:17 PM
> > To: Hyoyoung Chang
> > Cc: enlightenment-devel@lists.sourceforge.net
> > Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
> >
> > On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang
> >
[mailto:ras...@rasterman.com]
> Sent: Monday, December 20, 2010 4:17 PM
> To: Hyoyoung Chang
> Cc: enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
>
> On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang
>
> said:
>
> ok. here&#
On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang
said:
and now for the slide patch...
1. slide_duration should be a double - not an int. in efl we do time in floats
so we can do fractions of a second nicely as well as multi-second etc.
durations. this also means the edc and edje message bits ha
On Thu, 16 Dec 2010 09:46:24 +0900 Hyoyoung Chang
said:
ok. here's some feedback.
1. 0001 and 0002 are really the same patchset. so in future just send those as
1 patch.
2. it's an improvement on what was there, but the more i lok at it, the more
this needs to move into edje. it's too inefficien
Ah, Sorry. It's filtered out.
I re-attached patch files.
---
Hyoyoung CHANG
Engineer
SAMSUNG ELECTRONICS, Co., Ltd.
E-mail: hyoyoung.ch...@samsung.com
---
-Original Message-
From: Hyoyoung Chang [mailto:h
Dear Hyoyoung,
there's no attached files.
Please modify file name to *.txt
and use email client.
Thanks.
Daniel Juyung Seo
On Wed, Dec 15, 2010 at 8:45 PM, Hyoyoung Chang
wrote:
> Dear Elementary developers.
>
> It's a elm_label patch.
> My previous patch is too big to submit.
> So I did split
Dear Elementary developers.
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
main changes are
1. refine ellipsis algorithm
- improve to cut string to fit
2. adding label text sliding feature
Thank you.
--
.com]
> Sent: Thursday, December 09, 2010 5:27 PM
> To: enlightenment-devel@lists.sourceforge.net
> Subject: [E-devel] elm_label patch
>
> Dear Elementary developers.
>
> It's a elm_label patch.
> main changes are
> 1. refine ellipsis algorithm
> - improv
On Thu, 9 Dec 2010 08:45:56 -0200 Gustavo Sverzut Barbieri
said:
> Raster, see the harm that you do by playing the bad example? :-) Get
> ride of the "I'm busy excuse" and try to do simpler patches with less
> changes and clear commit messages, please!
says the man who has committed enough mega
gt;> ---
>>
>> -Original Message-
>> From: Hyoyoung CHANG [mailto:hyoyoung.ch...@samsung.com]
>> Sent: Thursday, December 09, 2010 5:27 PM
>> To: enlightenment-devel@lists.sourceforge.net
>> Subject: [E-devel] elm_la
mail: hyoyoung.ch...@samsung.com
> ---
>
> -Original Message-
> From: Hyoyoung CHANG [mailto:hyoyoung.ch...@samsung.com]
> Sent: Thursday, December 09, 2010 5:27 PM
> To: enlightenment-devel@lists.sourceforge.net
> Subject: [E-devel] elm_label patch
>
> Dear Elementary deve
ng.ch...@samsung.com]
Sent: Thursday, December 09, 2010 5:27 PM
To: enlightenment-devel@lists.sourceforge.net
Subject: [E-devel] elm_label patch
Dear Elementary developers.
It's a elm_label patch.
main changes are
1. refine ellipsis algorithm
- improve to cut string to fit
2. adding lab
Dear Elementary developers.
It's a elm_label patch.
main changes are
1. refine ellipsis algorithm
- improve to cut string to fit
2. adding label sliding feature
3. re-indented by eflformat script
Thank you.
---
Hyoyoung CHANG
Engineer
SAMSUNG EL
31 matches
Mail list logo
