> As discussed on IRC yesterday there should be consistency and there is an
> option to autofix with rubocop if the style is changed to change existing
> code with less effort.
TL;DR - Let's keep Rubocop away from rockethash thing.
What the consistency gives us? We all know there are two ways and
On 12/08/16 12:48, Eric D Helms wrote:
> Looks like named provisioners were added in 1.7 which makes me surprised
> they spin up. We'll have to add a version check or consider upgrading
> vagrant.
This doesn't seem to be fixed, I logged in today to find another load of
VMs running. Can you please
On 08/18/2016 03:16 PM, Ori Rabin wrote:
Hello,
The hash rocket syntax is still in use throughout the project.
New prs are sometimes submitted with the x: y syntax instead and then
asked to change.
As discussed on IRC yesterday there should be consistency and there is
an option to autofix with
I would say: if we want to make large-scale changes that would make
sense, let's move away
from option hashes to keywords. This would justify the large-scale
changes in my eyes,
and the non-hash rocket syntax just falls more naturally in that case.
And Rubocop
can take a rest here.
I share the lza
On 19 August 2016 at 07:26, Daniel Lobato wrote:
> I'm not sure why - but I also can reproduce this.
>
> It seems like having `foreman_templates` on your list of plugins is what's
> causing this. I don't really know why yet but I don't get the error without
> that plugin, and I get it the moment
Hello Everyone,
we're looking into deploying Windows workstations and servers with
theforeman.
Happily there's already something that supports realms (right now only
FreeIPA). Having had a look at the API I guess it should be quite
straightforward to add another provider for Active Directory u
On 08/19, Lukas Zapletal wrote:
> > As discussed on IRC yesterday there should be consistency and there is an
> > option to autofix with rubocop if the style is changed to change existing
> > code with less effort.
>
> TL;DR - Let's keep Rubocop away from rockethash thing.
>
> What the consistency
On 19/08/16 10:43, Andreas Rogge wrote:
> Hello Everyone,
>
> we're looking into deploying Windows workstations and servers with
> theforeman.
> Happily there's already something that supports realms (right now only
> FreeIPA). Having had a look at the API I guess it should be quite
> straightf
- Original Message -
> From: "Greg Sutcliffe"
> To: "Foreman"
> Sent: Friday, August 19, 2016 4:24:17 AM
> Subject: Re: [foreman-dev] Webpack merged into develop branch
>
> On 19 August 2016 at 07:26, Daniel Lobato wrote:
>
> > I'm not sure why - but I also can reproduce this.
> >
>
On 08/19/2016 11:54 AM, Daniel Lobato Garcia wrote:
On 08/19, Lukas Zapletal wrote:
As discussed on IRC yesterday there should be consistency and there is an
option to autofix with rubocop if the style is changed to change existing
code with less effort.
TL;DR - Let's keep Rubocop away from ro
I don’t care whether or not we use rubocop to enforce a particular style.
However, if we don’t use rubocop to enforce a style, we should stay away
from enforcing a hash style by commenting in PRs. Those comments would be
too trivial and distracting to me.
David
On Fri, Aug 19, 2016 at 3:03 AM, L
The PR [1] with the fix did not get merged until today and a test run with
that code in place seems to successfully delete [2] the spun up VM.
[1] https://github.com/Katello/forklift/pull/274
[2] http://ci.theforeman.org/job/systest_katello/1953/consoleFull
On Fri, Aug 19, 2016 at 3:26 AM, Domin
- Original Message -
> From: "Stephen Benjamin"
> To: foreman-dev@googlegroups.com
> Sent: Friday, August 19, 2016 7:29:21 AM
> Subject: Re: [foreman-dev] Webpack merged into develop branch
>
>
>
> - Original Message -
> > From: "Greg Sutcliffe"
> > To: "Foreman"
> > Sent: F
13 matches
Mail list logo
