Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-28 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Madeline Book wrote: > Ha! So that is how it posts duplicate messages. After I submit my > reply if I refresh the resulting page it posts the message again. > Bleh RT tries hard to be disliked... > Firefox tells me that I cannot refresh with

Re: [Freeciv-Dev] (PR#40058) mystrerror() and local encoding

2008-01-28 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40058 > After much discussion, here's the simpler version. Examining the actual mystrerror() code, it appears that there are already WIN32_NATIVE and other variants that are non-reentrant. The reentrant version should be separate (as it is on most

Re: [Freeciv-Dev] (PR#40057) strerror->mystrerror

2008-01-28 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40057 > Jason Dorje Short wrote: > mystrerror is included in support.c. Two places don't use this but > access strerror directly. This patch fixes it (for 2.1). > Yes, but gui-mui isn't used anymore, and gui-sdl has it in its local version of ico

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-28 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39620 > Marko Lindqvist wrote: > That's why I don't like GTK's generic APIs. You don't have type checking with > them. > Yeah, and I'm not a gui expert enough to catch them. Here's a slightly better version of the patch, telling the interface a po

Re: [Freeciv-Dev] (PR#39620) [Bug] gtk2: Cannot sell buildings

2008-01-28 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39620 > Marko Lindqvist wrote: > Includes some generic cleanup-style changes I made while debugging > problem. Actual fix is citydlg.c:1621. It was storing improvement > pointer instead of number. > > Original report referring to TRUNK only is old

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Jason Dorje Short wrote: > Good, except, all rulesets must be (and to my knowledge are) in utf-8. Perhaps, but that's not what the data currently said, and I'd prefer to document "reality" rather than "hope". Maybe there should be a concert

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > As our ships passed in the night, I also concur with Madeline. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40058) mystrerror() and local encoding

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40058 > Followup of PR#40028. See earlier patch and objections there. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Jason Short wrote: > Here is a quick and partial fix. I assume that strerror() is one of the > most common offending functions, so I quickly went through and converted > all mystrerror users in client/ and server/ directories to use the > ne

Re: [Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40032 > Probably should attach the patch as applied to trunk for posterity! (Also in 2.2, an update-po and vigorous line-by-line po massaging.) Index: server/citytools.c === --- server/

[Freeciv-Dev] (PR#40054) Percentages in client/helpdata.c

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40054 > Committed as part of trunk revision 14337. Committed as part of S2_2 revision 14338. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40032 > Committed as part of trunk revision 14337. Committed as part of S2_2 revision 14338. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40054) Percentages in helpdata.c

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40054 > Joan Creus wrote: > I've noticed that, in the last remodelation of helpdata.c, for trunk and 2.2, > three strings which contained "50%%" have been changed to "50%". But two of > them are still flagged as c-format, That's very odd. The othe

Re: [Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units => plrhand.c maybe_make_contact()

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40020 > Jason Short wrote: > make_contact kills the unit because of the broken treaty and bouncing > (strange in itself but whatever). Then since maybe_make_contact doesn't > use a proper iterator it breaks the loop. Attached patch should fix it >

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > I put the workaround into the doc/README -- and just (re-)discovered that's the *only* method described at: http://freeciv.wikia.com/wiki/Install-MacOSX#Localization_Support There's a different procedure at: http://freeciv.wikia.com/

[Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Jason Short wrote: # ... I thought I had written this up somewhere in the code, but I can find # nothing. Where should it be documented? Documenting the code and README.* files. Committed trunk revision 14330. Committed S2_2 revision 1433

Re: [Freeciv-Dev] (PR#40049) Losing message is not shown

2008-01-26 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40049 > Joan Creus wrote: > I have checked both trunk and 2.1, and both seem to have this behaviour. I > have even tried an old saved game (from 2.0) with the same results. Is it on > purpose? > Certainly not! Sounds like a long term bug. Send th

[Freeciv-Dev] (PR#40048) i18n: XAW wordwrap messages

2008-01-26 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40048 > Followup to PR#40043. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40047) i18n: GTK2 wordwrap messages

2008-01-26 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40047 > In PR#40043, "Christian Knoke" <[EMAIL PROTECTED]> writes: In the GTK2 client, it is an annoyance, that some lines require you horicontal scrolling in the message window (in 2.1, still in 2.2?). Of course this depends on the screen width you

Re: [Freeciv-Dev] (PR#40043) i18n: wordwrap_string() broken for UTF-8 translations

2008-01-26 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40043 > Committed S2_2 revision 14328, with update-po and hand adjustments. Committed trunk revision 14329. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid utf8 warning for LANG=fr_FR

2008-01-26 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Jason Short wrote: >> Madeline Book wrote: >>> Oh wow, it really was trivial! But certainly not obvious >>> for the likes of me :(. Once I ran the client with LANG= >>> fr_FR.UTF-8 the libc messages displayed correctly and gtk/ >>> pango was

Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages

2008-01-26 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > Christian Knoke wrote: > log messages shouldn't be translated at all. They go into a log file, the > user won't see them, usually. They go there for 2 purposes: development and > bug hunting, and scripting. For both, they are best in english.

Re: [Freeciv-Dev] (PR#10400) untranslated LOG_NORMAL messages

2008-01-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=10400 > Went through *all* the 2.2 sources. Found quite a few that are debugging messages, not "normal" user messages. New symbols LOG_TEST (same level as LOG_NORMAL) and LOG_PACKET (same level as LOG_VERBOSE). Actually results in very few new mes

Re: [Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40032 > Christian Knoke wrote: > Egor Vyscrebentsov wrote on Jan 25, 05:37 (-0800): >> On Fri, 25 Jan 2008 William Allen Simpson wrote: > >>>> ru_RU specific: >>>> Gender problem can be avoided by usage nati

Re: [Freeciv-Dev] (PR#40043) i18n: wordwrap_string() broken for UTF-8 translations

2008-01-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40043 > This removes wordwrap_string() in command line handling, adding a TRANS comment tell translators the width. It was amusing to discover that civmanual used it for html. That's silly. By definition, html always handles localized wrapping itse

Re: [Freeciv-Dev] (PR#40043) i18n: wordwrap_string() broken for UTF-8 translations

2008-01-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40043 > Egor Vyscrebentsov wrote: > Maybe I can't say what I want. Trying again: > strlen couldn't be used for receiving number of alphabetic characters > in the string. It can be used for receiving number of 7-bit signed integer. > And my point is t

Re: [Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-25 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40032 > Egor Vyscrebentsov wrote: > 1. FR: nation_ajective_plural_for_player() function. That's very unlikely. We'd end up with n**2 translations. > 2. "of the %s" will force us to enter cases problem... > "to the %s" cause to enter cases proble

Re: [Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40032 > Christian Knoke wrote: > Yes! This is essential information to be given. > After looking at the notification a bit, it seems the former message should be split (two events). But, the latter has to stay together. I shortened it drastically.

Re: [Freeciv-Dev] (PR#40043) i18n: wordwrap_string() broken for UTF-8 translations

2008-01-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40043 > Egor Vyscrebentsov wrote: > On Thu, 24 Jan 2008 William Allen Simpson wrote: >> The issue is not strlen(). It is properly used to determine the >> length of a string. The issue is that strlen() has nothing to do with >

[Freeciv-Dev] (PR#40041) BUG: server sending intelligence researching A_UNSET?

2008-01-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40041 > This is probably only fixable 2.2-only, with the new advance/techology iterators (PR#39525) able to vary the starting range, and better use of access functions to find the error. ___ Freeciv-dev

[Freeciv-Dev] (PR#40043) Re: (PR#40045) wordwrap_string(), strlen(), and multibytes encodings

2008-01-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40043 > Egor Vyscrebentsov wrote: > At least in utility/shared.c:wordwrap_string() strlen() is used to > determine number of characters in the string. This gives wrong result > on multibytes encoding. > The issue is not strlen(). It is properly use

[Freeciv-Dev] (PR#40043) i18n: wordwrap_string() broken for UTF-8 translations

2008-01-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40043 > Reported in PR#40032. Egor Vyscrebentsov <[EMAIL PROTECTED]> writes: (For ru_RU.UTF-8 part of lines cover only half of screen width - 2 bytes/character. Easiest example - '/help' [show_help_intro]. wordwrap_string() looks to me like the roo

[Freeciv-Dev] (PR#40044) i18n: split data/helptext.txt keyboard/mouse orders

2008-01-24 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40044 > Reported in PR#40032. Egor Vyscrebentsov <[EMAIL PROTECTED]> writes: PS. I'm also for splitting into several messages a keyboard/mouse orders helptext from data/helptext.txt. It will a) make it much easier for translator to see changes; b)

Re: [Freeciv-Dev] (PR#40032) server/plrhand.c civil war message plural

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40032 > This whole "narrative" is a problem. I fixed the possessive grammar last release, but the messages themselves are questionable. notify_player(pplayer, NULL, E_CIVIL_WAR, _("Your nation is thrust into civil war, "

[Freeciv-Dev] (PR#40042) BUG: ai move result and activity access functions

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40042 > Followup to PR#39792, to unravel buggy explorer code paths, and unify ACTIVITY_* processing. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40041) BUG: server sending intelligence researching A_UNSET?

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40041 > Followup to PR#40021. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40040) BUG: server sends bad tile(s), not TILE_UNKNOWN, but terrain is NULL

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40040 > Followup to PR#40011, with such truly bad savegames for testing! ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40039) ctrl+shift+i (goto related) assert

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40039 > Richard H_ wrote: > I had a worker standing on a mountain next to a river, with roads and a mine. > upon pressin ctrl+shift+i, in stead of ignoring the keycombo, the client > segfaulted. > savegame? > ... Been having a lot of crashes lat

Re: [Freeciv-Dev] (PR#40037) aifill 30 has multiple problems

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40037 > Christian Knoke wrote: > - click on AI player, RMB menu "remove player": > I had no idea there was a RMB option here Undocumented? Shouldn't that be LMB? It's a command, not "information". > | chris: 'remove "AI30"' > | /remove: Pla

Re: [Freeciv-Dev] (PR#17548) Don't hide server settings for hack/first user

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=17548 > Christian Knoke wrote: > The best approach is a GUI option that allows setting of > the game name and how often it is saved. These options in the GUI are > already there, they are just not accessible when you start a game (See > "Start n

Re: [Freeciv-Dev] (PR#40036) 2.1.2 savegame data loss on rapid saves

2008-01-23 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40036 > Martin Rubinstein wrote: > When saving, (playing standalone, all other players AI), data appears to be > lost. > Latest time government type reverted to Despotism from Monarchy You mean the government was Monarchy at the beginning of the tu

[Freeciv-Dev] (PR#40025) Happiness plurals

2008-01-22 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40025 > Committed S2_2 revision 14284. Committed trunk revision 14285. Still open awaiting win32 verification. Also hoping for better sentences for 2.2 and later. ___ Freeciv-dev mailing list Freeciv-de

Re: [Freeciv-Dev] (PR#40031) 2.1.2 M$windows title bar not visible in multiple monitor setup

2008-01-22 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40031 > Shaun Cummings wrote: > P.S. - Bonus points for the lightning fast response > You're welcome -- but it was a holiday here, and I'd devoted the day to getting 2.1.3 out the door, so I was paying particular attention __

Re: [Freeciv-Dev] (PR#40034) [Patch] Fix SDL -client compilation

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40034 > Marko Lindqvist wrote: > Will commit immediately. > Great! Anybody that can do the same for gui-win32? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-de

Re: [Freeciv-Dev] (PR#40033) sanity checking and debugging improvements

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40033 > Committed S2_1 revision 14267. Committed S2_2 revision 14268. Committed trunk revision 14269. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40033) sanity checking and debugging improvements

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40033 > Some helpful debugging improvements, and other niceties found along the way: * sanity checking with file and line * clear city and unit pointers on free() * always pair create_unit_virtual() with destroy_unit_virtual() * moved kill_dying_

Re: [Freeciv-Dev] Freeciv - Covermount authorization for Hype!, a portuguese videogames magazine

2008-01-21 Thread William Allen Simpson
Egor Vyscrebentsov wrote: > Good day! > > On Wed, 16 Jan 2008 Jorge Vieira wrote: > >> Cheers. >> >> My name is Jorge Vieira and i'm editor in chief of Hype!, a Portuguese >> videogames magazine. >> >> The magazine has an print run of 30.000 copies, 22.000 of them including 1 >> covermount DVD wi

Re: [Freeciv-Dev] (PR#40011) client crash with bad tile(s)

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40011 > Committed S2_1 revision 14262. Committed S2_2 revision 14263. Committed trunk revision 14264. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40011) client crash with bad tile(s)

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40011 > OK, these two savegames crash in several different ways, but I've got both running (not crashing) now. Even though the server tells us the tile is not "unknown", it still isn't sending valid terrain or sometimes special data. For those that

[Freeciv-Dev] (PR#40011) client crash with bad borders, city, and tile owners

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40011 > Merged with previous report. I'm thinking that my initial approach to the solution is wrong. While better server checking in 2.2 should catch many problems, the clients SHOULD NOT be this fragile. No matter how badly the server behaves,

Re: [Freeciv-Dev] (PR#40030) Segfault while drawing map

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40030 > 2.2 has more error checking, and here's what it found: 1: Failed sanitycheck.c:231 (cityturn.c:215) in Bellingshausen[2](58,83): tile_owner(pcity->tile) == NULL || tile_owner(pcity->tile) == pplayer 1: Failed sanitycheck.c:231 (cityturn.c:2

[Freeciv-Dev] (PR#40030) Segfault while drawing map

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40030 > Thank you for the savegame. This sounds like the known problem with borders that we hope will be solved in 2.2. I'll use it to test. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mai

Re: [Freeciv-Dev] (PR#40028) gtk/pango invalid utf8 warning for LANG=fr_FR

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Madeline Book wrote: > Oh wow, it really was trivial! But certainly not obvious > for the likes of me :(. Once I ran the client with LANG= > fr_FR.UTF-8 the libc messages displayed correctly and gtk/ > pango was very happy. > Nor to me. Lea

Re: [Freeciv-Dev] (PR#40031) 2.1.2 M$windows title bar not visible in multiple monitor setup

2008-01-21 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40031 > Shaun Cummings wrote: > Freeciv 2.1.2 Stable Release (from pre-built Windows binary download) > Which one? win32? gtk2? sdl? > Windows Vista Ultimate, fully patched as of 1/20/08 > > AMD Athlon64 3500+ > > 2GB System RAM > > Nvidia G

Re: [Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units => plrhand.c maybe_make_contact()

2008-01-20 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40020 > After 12 hours of staring at this problem, and debugging both S2_1 and S2_2, I've guessed that there is some unit somewhere that is killed, but not unlinked from its tile. Another unit is meeting it. In 2.1, all goes well until the make_con

Re: [Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units => plrhand.c maybe_make_contact()

2008-01-20 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40020 > For posterity, several more hours of solid debugging, and I've determined the unit itself has lost its name. A dead unit wasn't taken off the tile? temporary logging: 2: maybe_make_contact() unit And a dead city wasn't taken off the tile o

Re: [Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units => plrhand.c maybe_make_contact()

2008-01-20 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40020 > Thank you for the helpful savegame! Here's where it currently dies in S2_1: 0: nation_of_player() has NULL nation 0: Detected fatal error in nation.c line 259: 0: bad nation This is a crash trying to display a logging message -- nation_of_

Re: [Freeciv-Dev] (PR#40028) 2.1 gtk/pango invalid utf8 warning for LANG=fr_FR

2008-01-20 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Madeline Book wrote: > I can reproduce the garbled text and gtk warnings with the released > 2.1.1 and branch S2_1. As other occurences of "special" characters > (e.g. accented vowels) in translated messages don't show up as "?", > I am led t

Re: [Freeciv-Dev] (PR#40028) 2.2 gtk/pango invalid utf8 warning for LANG=fr_FR

2008-01-19 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Madeline Book wrote: > Some translated strings show "garbage" characters when the client (branch > S2_2) runs under LANG=fr_FR. S2_2 does not have currently maintained translations. That begins next week. Please check again after the 2.1 p

Re: [Freeciv-Dev] (PR#40021) view intelligence failed assertion (tech not in range)

2008-01-19 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40021 > This does not fix the underlying problem. But clients should not crash with bad server data. Check this datum as it is passed in from the network. Only xaw checked its data for A_UNSET! This updates that check, and fixes gtk2 (and hopeful

Re: [Freeciv-Dev] (PR#40021) client assert on view intelligence

2008-01-19 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40021 > S2_1: tech.c:63: failed assertion `tech == A_FUTURE || (tech >= 0 && tech < game.control.num_tech_types)' S2_2: tech.c:119: failed assertion `tech == A_FUTURE || (tech >= 0 && tech < game.control.num_tech_types)'

[Freeciv-Dev] (PR#28092) server found_new_tech => notify_team crash

2008-01-19 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=28092 > Both reports were for 64-bit Linux flavors. So anybody using such a machine can tell us whether this is fixed? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/free

[Freeciv-Dev] (PR#28092) server found_new_tech => notify_team crash

2008-01-19 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=28092 > Merged 2 with same trace, spanning 2.1b1, b2, b3. Thanks to reporters! But has anybody seen this since? I'd have thought that this would be fairly frequent Without confirmation, I'll close this one.

Re: [Freeciv-Dev] (PR#40025) Happiness plurals

2008-01-19 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40025 > Joan Creus wrote: > Sorry. You are right that the previous sentence also needs to be > "pluralized", but I don't get why they have to be moved to a separate > line. They were already in separate strings, so they could be pluralized > indepe

Re: [Freeciv-Dev] (PR#40026) Updated Finnish translation for 2.1 (and 2.2/trunk)

2008-01-18 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40026 > As you wish. But I'll note that an awful lot of recent 2.1 strings are now in the #~ section: #~ msgid "%d content before penalty." #~ msgid_plural "%d content before penalty." Maybe they'll be fixed by another update-po before 2.1.3 relea

Re: [Freeciv-Dev] (PR#39792) explore server assert

2008-01-18 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39792 > Unfortunately, it appears that the activity and explore code has so many problems that it's not practical to completely fix at this time. One of the most egregious problems is that folks didn't always use access functions for setting activit

Re: [Freeciv-Dev] (PR#40025) Happiness plurals

2008-01-18 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40025 > Joan Creus wrote: > In #: client/gui-gtk-2.0/happiness.c:252 client/gui-win32/happiness.c:204 > > the sentence is: > > %d additional unhappy citizens. > > %d is 1 in the default ruleset, so it would be good to have an option here. > Thank

Re: [Freeciv-Dev] (PR#40023) Feature Request: add more switches to slow_down_timeline

2008-01-17 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40023 > Egor Vyscrebentsov wrote: > Any opinions about http://bugs.freeciv.org/Ticket/Display.html?id=1871 ? > I'm more in favor of http://bugs.freeciv.org/Ticket/Display.html?id=39413 I think Ulrik had some good ideas. But there was an executive

Re: [Freeciv-Dev] (PR#39870) unithand, unittools, citytools routines misnamed handle_* and real_*

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39870 > Committed trunk revision 14242. Committed S2_2 revision 14243. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39954) aitoggle savegames - cannot Meet with nations any longer

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39954 > Jason, two releases ago you wrote: > This is a significant bug though that should be a priority for the next > 2.1 release. > We're awaiting your patch? ___ Freeciv-dev mailing list Freeciv-dev@

[Freeciv-Dev] (PR#39791) 2.1.0-RC1 random crashes while running on Mandrake

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39791 > There were other reported problems with the Mandrake libraries (PR#39990). Are you still having this problem in 2.1.2? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listin

[Freeciv-Dev] (PR#39788) translations not displaying

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39788 > Are you still experiencing this problem? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40023) Feature Request: add more switches to slow_down_timeline

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40023 > Good idea. Although import of civ2 games is planned, it may not make it into 2.2, but should be in 2.3. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv

[Freeciv-Dev] (PR#40019) Feature Request: adjustable road movement multiplier

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40019 > Good idea. Although import of civ2 games is planned, it may not make it into 2.2, but should be in 2.3. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv

[Freeciv-Dev] (PR#40005) 2.1.2 Strange autosettler behavior

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40005 > There are many different auto commands, which one did you use? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units => plrhand.c maybe_make_contact()

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40020 > Thank you for the savegame. I'll try to reproduce. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39870) unithand, unittools, citytools routines misnamed handle_* and real_*

2008-01-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39870 > Meant to do this months ago. Found some in unittools and citytools, too. Added some error logging for actual handle_* routines. Never trust network data! Index: server/citytools.c ==

Re: [Freeciv-Dev] (PR#40007) Crash when upgrading unit using Japanese language

2008-01-15 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40007 > Jason Short wrote: > That means that the GTK library is using japanese correctly, but freeciv > is still using the untranslated strings. I have trouble with this > myself and aside from making sure you have gettext installed and linked > (us

Re: [Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-15 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40016 > Jason Short wrote: > This is the same as 39991 which explains the cause. And had you actually read the ticket, you'd have seen the link. It's not exactly the same, but they are related. ___ Fre

Re: [Freeciv-Dev] (PR#39792) explore server assert

2008-01-15 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39792 > Jason Short wrote: > I'd really like a savegame from which this can be reproduced. > What's wrong with the two existing savegames they've already provided? Perhaps you didn't actually read the report(s) Next time, please re-read the wh

Re: [Freeciv-Dev] (PR#40018) [Patch] Security fix: Add " ' " to illegal characters

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40018 > Agree with Madeline. Unfortunately, he's already committed the patch, even though he knew it was not the "proper fix" Could you post a patch that undoes his, calling the mysql api properly? ___

[Freeciv-Dev] (PR#39792) explore server assert

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39792 > OK, I've merged the tickets, they are failing in the same place. An assert is supposed to be added by developers to detect impossible conditions. In this case, it looks like a piece of debugging accidentally left in -- it wasn't in the or

Re: [Freeciv-Dev] (PR#40010) 2.1.2 SDL assert - message pane

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40010 > Christian Renz wrote: > sorry for replying by e-mail instead of using the bug tracker, but I > can't log in as guest (and I don't have an account) > We want you to reply by email. That's how you send us nice attachments ___

Re: [Freeciv-Dev] (PR#40011) bad borders, city, and tile owners

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40011 > Thank you for the bad savegame! This is the worst I've ever seen. It will help in debugging our future code Sadly, the 2.1 border generation code is very buggy, and has a tendency to crash whenever cities change hands out of sight. Fo

[Freeciv-Dev] (PR#40017) 2.1.2 SDL races_dialog_ok_callback crash

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40017 > Thanks for the report. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40016 > Thank you, that helps narrow down a previously reported problem. However, I'm not personally able to reproduce. I'll try staring at the code to see whether anything leaps to mind ___ Freeci

[Freeciv-Dev] (PR#40010) 2.1.2 SDL assert - message pane

2008-01-14 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40010 > Thank you, that helps narrow down a previously reported problem. However, I'm not personally able to reproduce. I'll try staring at the code to see whether anything leaps to mind ___ Freeci

Re: [Freeciv-Dev] (PR#40007) Crash when upgrading unit using Japanese language

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40007 > Was finally able to get some labels showing in Japanese (mostly _Quit, _Cancel, but hardly any other buttons) -- the upgrade dialog showed English, and it didn't crash I started it with LANG=JA ./civ What am I doing wrong? Could it be

[Freeciv-Dev] (PR#40015) Tracking 2.1.3 release

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40015 > Time to give a heads up to translators, and do general testing. Should be ready in a week? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40014) helpdata.c implicit declaration of strlcpy()

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40014 > Committed trunk revision 14234. Committed S2_2 revision 14235. Committed S2_1 revision 14236. Index: client/helpdata.c === --- client/helpdata.c (revision 14233) +++ client/he

[Freeciv-Dev] (PR#40013) helpdata.c more checking buffer sizes

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40013 > Committed trunk revision 14231. Committed S2_2 revision 14232. Committed S2_1 as part of revision 14233, with update-po to fix TRANS comments. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https

Re: [Freeciv-Dev] (PR#40013) helpdata.c more checking buffer sizes

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40013 > Madeline Book wrote: > ... would it > not seem terribly inefficient to have to find the end of the string > on every single call to a cat/CAT* function? Briefly, no. 1) I'm not the original designer of this code, I'm just fixing crashing b

[Freeciv-Dev] (PR#40014) helpdata.c implicit declaration of strlcpy()

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40014 > Sorry, force of habit, I momentarily forgot that not all systems have strlcpy(), despite its presence on *BSD (and MacOS) machines for 10+ years. This was the only one extant. Correcting to our local mystrlcpy(). === Date: Sun, 13 Jan 2008

[Freeciv-Dev] (PR#40012) 2.2-test assert in helpdata.c

2008-01-13 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40012 > Errors from PR#39831, due to my incomplete implementation of buffer concatenation length checking. === Date: Sat, 12 Jan 2008 17:52:27 +0100 From: Joan Creus <[EMAIL PROTECTED]> ... The message is "Assertion `len_destIndex: client/gui

[Freeciv-Dev] (PR#39792) 2.1.0 worker explore server assert

2008-01-12 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39792 > unithand.c:635: failed assertion `punit->activity == ACTIVITY_EXPLORE' ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40009) 2.1.2 second autoexplore server assert

2008-01-12 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40009 > Do you have a savegame? I'd like to compare with PR#39792. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40006) ja.po: Placeholder strings like %d for gold amount isn't replaced

2008-01-12 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40006 > Agro Rachmatullah wrote: > In talks about Japanese character encoding, the terms "half-width" and > "full-width" DOES exist. See http://en.wikipedia.org/wiki/Fullwidth > Sorry, that's not about encoding, that's about display of glyphs in fix

Re: [Freeciv-Dev] (PR#40008) Server sends message using inappropriate language

2008-01-11 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40008 > Agro Rachmatullah wrote: > However, the server sends Japanese message to all players (e.g., turn > X starts)! Which means it will irritate people that can't understand > Japanese. I also reported this problem in PR#39979, fixing the login m

Re: [Freeciv-Dev] (PR#40007) Crash when upgrading unit using Japanese language

2008-01-11 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40007 > Sounds like a fuzzy string translation that doesn't have the correct number of c-format parameters, causing a memory access for a non-existent pointer. I've already reported the general problem in PR#39970, and there are other reported speci

Re: [Freeciv-Dev] (PR#40006) jp.po: Placeholder strings like %d for gold amount isn't replaced

2008-01-11 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=40006 > Agro Rachmatullah wrote: > I can recall some other strings for which %d is still intact. Using > the English language, this problem doesn't occur. Probably because the > translation string uses fullwidth "%d" instead of its halfwidth > (ASCII

<    1   2   3   4   5   6   7   8   9   10   >